Re: [PATCH net-next] qed*: Utilize FW 8.33.11.0

Hi Michal, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Michal-Kalderon/qed-Utilize-FW-8-33-11-0/20180327-070630 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig

[RFC PATCH] qed*: qed_cm_init_pf() can be static

Fixes: cda33d25b808 ("qed*: Utilize FW 8.33.11.0") Signed-off-by: Fengguang Wu --- qed_cxt.c |2 +- qed_dcbx.c |2 +- qed_dev.c | 12 ++-- qed_init_fw_funcs.c |2 +- qed_iscsi.c |4 ++-- qed_iwarp.c |

Re: [PATCH] scsi: libsas: add transport class for ATA devices

On 2018/3/26 22:38, Dan Williams wrote: On Mon, Mar 26, 2018 at 2:27 AM, Jason Yan wrote: Now ata devices attached with sas controller do not have transport class, so that we can not see any information of these ata devices in /sys/class/ata_port(or ata_link or

Re: [PATCH] scsi: Replace sdev_printk with printk_deferred to avoid

On Thu, 2018-03-08 at 16:50 +0800, Wen Yang wrote: > This patch replacing the sdev_printk with async printk_deferred can > avoid task blocking because of the slow serial and unstable disks in > such senario. Although I'm not enthusiast about this approach, I haven't been able to come up with a

Re: [PATCH v2 6/6] scsi_io_completion convert BUGs to WARNs

On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -1048,13 +1048,20 @@ void scsi_io_completion(struct scsi_cmnd *cmd, > unsigned int good_bytes) > scsi_req(req->next_rq)->resid_len =

Re: [PATCH v2 5/6] scsi_io_completion hints on fastpatch

On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > - /* > - * Kill remainder if no retrys. > - */ > - if (blk_stat && scsi_noretry_cmd(cmd)) { > + /* Kill remainder if no retrys */ Since you are modifying this comment please also fix the spelling in that comment

Re: [PATCH v2 4/6] scsi_io_completion_action helper added

On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > + /* sense not about current command is termed: deferred */ Do we really need comments that explain the SCSI specs? If such a comment is added I think it should be added above the definition of scsi_sense_is_deferred() together with

Re: [PATCH v2 3/6] scsi_io_completion_nz_result function added

On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > Break out several interwined paths when cmd->result is non zero and ^^ intertwined? > place them in scsi_io_completion_nz_result helper function. The logic > is not changed. > [ ... ] > A

Re: [PATCH v2 2/6] scsi_io_completion rename variables

On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > - blk_status_t error = BLK_STS_OK; > + blk_status_t blk_stat = BLK_STS_OK; /* u8: BLK_STS_OK is only 0 */ Hello Doug, This newly added comment looks really confusing to me. Can it be left out? Thanks, Bart.

Re: [PATCH v2 1/6] scsi_io_completion comment on end_request return

On Sun, 2018-03-18 at 21:58 +0100, Douglas Gilbert wrote: > scsi_end_request() is called multiple times from scsi_io_completion() > which branches on its bool returned value. Add comment before the static > definition of scsi_end_request() about the meaning of that return. Reviewed-by: Bart Van

Re: [PATCH] scsi: don't look for NULL devices handlers by name

On Fri, 2018-03-23 at 14:37 +0100, Johannes Thumshirn wrote: > Currently scsi_dh_lookup() doesn't check for NULL as a device > name. This combined with nvme over dm-mapth results in the following > messages emitted by device-mapper: > > device-mapper: multipath: Could not failover device 259:67:

Re: [PATCH] scsi: remove reference to scsi_show_extd_sense()

On Sat, 2018-03-24 at 09:30 -0400, John Pittman wrote: > In commit 2104551969e8 ("scsi: use per-cpu buffer for formatting > sense"), function scsi_show_extd_sense() was removed, switching > use over to scsi_format_extd_sense(). Remove last reference to > scsi_show_extd_sense() in

Re: [PATCH v3] scsi: ufs: add trace event for ufs upiu

On Sun, 2018-03-25 at 10:08 +0300, Ohad Sharabi wrote: > Add UFS Protocol Information Units(upiu) trace events for ufs driver, > used to trace various ufs transaction types- command, task-management > and device management. > The trace-point format is generic and can be easily adapted to trace >

Re: [PATCH net-next] qed*: Utilize FW 8.33.11.0

On Mon, Mar 26, 2018 at 08:02:12PM +0300, Michal Kalderon wrote: > This FW contains several fixes and features > > RDMA Features > - SRQ support > - XRC support > - Memory window support > - RDMA low latency queue support > - RDMA bonding support > > RDMA bug fixes > - RDMA remote invalidate

[Bug 198689] Setro has no effect for SCSI device

https://bugzilla.kernel.org/show_bug.cgi?id=198689 --- Comment #1 from John Pittman (jpitt...@redhat.com) --- Issue fixed by: 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading partition") https://marc.info/?l=linux-scsi=151991330722943=2 -- You are receiving this mail because: You

[Bug 198081] scsi sg

https://bugzilla.kernel.org/show_bug.cgi?id=198081 --- Comment #4 from Cristian Crinteanu (crinteanu.crist...@gmail.com) --- will try that - to see what patch(es) introduced in 4.4.89 (see above) cause that fault. wil be back.. -- You are receiving this mail because: You are the assignee for

[PATCH v3 41/41] cxlflash: Handle spurious interrupts

The following Oops can occur when there is heavy I/O traffic and the host is reset by a tool such as sg_reset. [c000200fff3fbc90] c0081690117c process_cmd_doneq+0x104/0x500 [cxlflash] (unreliable) [c000200fff3fbd80] c00816901648

[PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

The following Oops can occur if an internal command sent to the AFU does not complete within the timeout: [c00ff101b810] c00816020d94 term_mc+0xfc/0x1b0 [cxlflash] [c00ff101b8a0] c00816020fb0 term_afu+0x168/0x280 [cxlflash] [c00ff101b930] c008160232ec

[PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

The following Oops can be encountered if a device removal or system shutdown is initiated while an EEH recovery is in process: [c00ff2f479c0] c00815256f18 cxlflash_pci_slot_reset+0xa0/0x100 [cxlflash] [c00ff2f47a30] c0080dae22e0

[PATCH v3 37/41] cxlflash: Support AFU reset

The cxlflash core driver resets the AFU when the master contexts are created in the initialization or recovery paths. Today, the OCXL provider service to perform this operation is pending implementation. To avoid a crash due to a missing fop, log an error once and return success to continue with

[PATCH v3 38/41] cxlflash: Enable OCXL operations

This commit enables the OCXL operations for the OCXL devices. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/main.c | 9 +++-- drivers/scsi/cxlflash/main.h | 1 + 2 files changed, 8 insertions(+), 2

[PATCH v3 32/41] cxlflash: Setup LISNs for user contexts

The SISLite specification has been updated for OCXL to support communicating data to generate AFU interrupts to the AFU. This includes a new capability bit that is advertised for OCXL AFUs and new registers to hold the object handle and translation PASID of each interrupt. For Power, the object

[PATCH v3 34/41] cxlflash: Update synchronous interrupt status bits

The SISLite specification has been updated to define new synchronous interrupt status bits. These bits are set by the AFU when a given PASID or EA is bad and a synchronous interrupt is triggered. The SISLite header file is updated to support these new bits. Note that there are also some

[PATCH v3 36/41] cxlflash: Register for translation errors

While enabling a context on the link, a predefined callback can be registered with the OCXL provider services to be notified on translation errors. These errors can in turn be passed back to the user on a read operation. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 35/41] cxlflash: Introduce OCXL context state machine

In order to protect the OCXL hardware contexts from getting clobbered, a simple state machine is added to indicate when a context is in open, close or start state. The expected states are validated throughout the code to prevent illegal operations on a context. A mutex is added to protect writes

[PATCH v3 33/41] cxlflash: Setup LISNs for master contexts

Similar to user contexts, master contexts also require that the per-context LISN registers be programmed for certain AFUs. The mapped trigger page is obtained from underlying transport and registered with AFU for each master context. Signed-off-by: Uma Krishnan

[PATCH v3 31/41] cxlflash: Introduce object handle fop

OCXL requires that AFUs use an opaque object handle to represent an AFU interrupt. The specification does not provide a common means to communicate the object handle to the AFU - each AFU must define this within the AFU specification. To support this model, the object handle must be passed back to

[PATCH v3 30/41] cxlflash: Support file descriptor mapping

The cxlflash core fop API requires a way to invoke the fault and release handlers of underlying transports using their native file-based APIs. This provides the core with the ability to insert selectively itself into the processing stream of these operations for cleanup. Implement these two fops

[PATCH v3 28/41] cxlflash: Support adapter context reading

The cxlflash userspace API requires that users be able to read the adapter context for any pending events or interrupts from the AFU. Support reading various events by implementing the AFU read fop to copy out event data. Signed-off-by: Uma Krishnan Acked-by: Matthew

[PATCH v3 29/41] cxlflash: Support adapter context mmap and release

The cxlflash userspace API requires that users be able to mmap and release the adapter context. Support mapping by implementing the AFU mmap fop to map the context MMIO space and install the corresponding page table entry upon page fault. Similarly, implement the AFU release fop to terminate and

[PATCH v3 26/41] cxlflash: Support starting user contexts

User contexts request interrupts and are started using the "start work" interface. Populate the start_work() fop to allocate and map interrupts before starting the user context. As part of starting the context, update the user process identification logic to properly derive the data required by

[PATCH v3 25/41] cxlflash: Support AFU interrupt mapping and registration

Add support to map and unmap the irq space and manage irq registrations with the kernel for each allocated AFU interrupt. Also support mapping the physical trigger page to obtain an effective address that will be provided to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan

[PATCH v3 27/41] cxlflash: Support adapter context polling

The cxlflash userspace API requires that users be able to poll the adapter context for any pending events or interrupts from the AFU. Support polling on various events by implementing the AFU poll fop using a waitqueue. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 21/41] cxlflash: Setup function OCXL link

After reading and modifying the function configuration, setup the OCXL link using the OCXL provider services. The link is released when the adapter is unconfigured. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic

[PATCH v3 22/41] cxlflash: Setup OCXL transaction layer

The first function of the link needs to configure the transaction layer between the host and device. This is accomplished by a call to the OCXL provider services. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 24/41] cxlflash: Support AFU interrupt management

Add support to allocate and free AFU interrupts using the OCXL provider services. The trigger page returned upon successful allocation will be mapped and exposed to the cxlflash core in a future commit. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 23/41] cxlflash: Support process element lifecycle

As part of the context lifecycle, the associated process element within the Shared Process Area (SPA) of the link must be updated. Each process is defined by various parameters (pid, tid, PASID mm) that are stored in the SPA upon starting a context and invalidated when a context is stopped. Use

[PATCH v3 18/41] cxlflash: Support process specific mappings

Once the context is started, the assigned MMIO space can be mapped and unmapped. Provide means to map and unmap the context MMIO space. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 24

[PATCH v3 20/41] cxlflash: Support reading adapter VPD data

Use the PCI VPD services to support reading the VPD data of the underlying adapter. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v3 19/41] cxlflash: Support AFU state toggling

The AFU should be enabled following a successful configuration and disabled near the end of the cleanup path. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs Reviewed-by: Frederic Barrat ---

[PATCH v3 17/41] cxlflash: Support starting an adapter context

Once the adapter context is created, it needs to be started by assigning the MMIO space for the context and by enabling the process element in the link. This commit adds the skeleton for starting the context and assigns the context specific MMIO space. Master contexts have access to the global

[PATCH v3 16/41] cxlflash: MMIO map the AFU

When the AFU is configured, the global and per process MMIO regions are presented by the configuration space. Save these regions and map the global MMIO region that is used to access all of the control and provisioning data in the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 14/41] cxlflash: Support adapter context discovery

Provide means to obtain the process element of an adapter context as well as locate an adapter context by file. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 26 ++ 1

[PATCH v3 15/41] cxlflash: Support image reload policy modification

On a PERST, the AFU image can be reloaded or left intact. Provide means to set this image reload policy. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- drivers/scsi/cxlflash/ocxl_hw.c | 13 +

[PATCH v3 13/41] cxlflash: Support adapter file descriptors for OCXL

Allocate a file descriptor for an adapter context when requested. In order to allocate inodes for the file descriptors, a pseudo filesystem is created and used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs ---

[PATCH v3 12/41] cxlflash: Use IDR to manage adapter contexts

A range of PASIDs are used as identifiers for the adapter contexts. These contexts may be destroyed and created randomly. Use an IDR to keep track of contexts that are in use and assign a unique identifier to new ones. Signed-off-by: Uma Krishnan Acked-by: Matthew R.

[PATCH v3 11/41] cxlflash: Adapter context support for OCXL

Add support to create and release the adapter contexts for OCXL and provide means to specify certain contexts as a master. The existing cxlflash core has a design requirement that each host will have a single host context available by default. To satisfy this requirement, one host adapter context

[PATCH v3 10/41] cxlflash: Setup AFU PASID

Per the OCXL specification, the maximum PASID supported by the AFU is indicated by a field within the configuration space. Similar to acTags, implementations can choose to use any sub-range of PASID within their assigned range. For cxlflash, the entire range is used. Signed-off-by: Uma Krishnan

[PATCH v3 09/41] cxlflash: Setup AFU acTag range

The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. As cxlflash devices are expected to only support a single AFU per function, the entire range that was assigned to the function is also assigned to the AFU. Signed-off-by: Uma Krishnan

[PATCH v3 08/41] cxlflash: Read host AFU configuration

The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 06/41] cxlflash: Read host function configuration

Per the OCXL specification, the underlying host can have multiple AFUs per function with each function supporting its own configuration. The host function configuration is read on the initialization path to evaluate the number of functions present and identify the features and configuration of the

[PATCH v3 07/41] cxlflash: Setup function acTag range

The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. The platform-specific acTag range for the link is obtained using the OCXL provider services and then assigned to the host function based on implementation. Signed-off-by: Uma Krishnan

[PATCH v3 03/41] cxlflash: Add argument identifier names

Checkpatch throws a warning when the argument identifier names are not included in the function definitions. To avoid these warnings, argument identifiers are added in the existing function definitions. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 04/41] cxlflash: Introduce OCXL backend

Add initial infrastructure to support a new cxlflash transport, OCXL. Claim a dependency on OCXL and add a new file, ocxl_hw.c, which will host the backend routines that are specific to OCXL. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

[PATCH v3 05/41] cxlflash: Hardware AFU for OCXL

When an adapter is initialized, transport specific configuration and MMIO mapping details need to be saved. For CXL, this data is managed by the underlying kernel module. To maintain a separation between the cxlflash core and underlying transports, introduce a new structure to store data specific

[PATCH v3 02/41] cxlflash: Avoid clobbering context control register value

From: "Matthew R. Ochs" The SISLite specification originally defined the context control register with a single field of bits to represent the LISN and also stipulated that the register reset value be 0. The cxlflash driver took advantage of this when programming the

[PATCH v3 01/41] cxlflash: Preserve number of interrupts for master contexts

The number of interrupts requested for user contexts are stored in the context specific structures and utilized to manage the interrupts. For the master contexts, this number is only used once and therefore not saved. To prepare for future commits where the number of interrupts will be required

[PATCH v3 00/41] cxlflash: OCXL transport support and miscellaneous fixes

This patch series adds OCXL support to the cxlflash driver. With this support, new devices using the OCXL transport will be supported by the cxlflash driver along with the existing CXL devices. An effort is made to keep this transport specific function independent of the existing core driver that

Re: [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

On Fri, 23 Mar 2018 17:55:54 + Bart Van Assche wrote: > Comments are not verified at runtime and hence can become outdated if the code > is modified. assert_spin_locked() and lockdep_assert_held() assertions however > are verified at runtime with the proper kernel

[Bug 198081] scsi sg

https://bugzilla.kernel.org/show_bug.cgi?id=198081 Bart Van Assche (bvanass...@acm.org) changed: What|Removed |Added CC||bvanass...@acm.org

Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks

On Fri, 23 Mar 2018 18:17:36 +0100 "bige...@linutronix.de" wrote: > There are a few functions which check for if the lock is held > (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()). > >From looking at the code, each function is static, the caller is

Re: Multi-Actuator SAS HDD First Look

On Fri, 23 Mar 2018 08:57:12 -0600 Tim Walker wrote: > Seagate announced their split actuator SAS drive, which will probably > require some kernel changes for full support. It's targeted at cloud > provider JBODs and RAID. > > Here are some of the drive's architectural

Re: [PATCH] scsi: libsas: add transport class for ATA devices

On Mon, Mar 26, 2018 at 2:27 AM, Jason Yan wrote: > Now ata devices attached with sas controller do not have transport > class, so that we can not see any information of these ata devices in > /sys/class/ata_port(or ata_link or ata_device). > > Add transport class for the ata

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Fri, Mar 23, 2018 at 04:55:13PM +0100, Sebastian Andrzej Siewior escreveu: > Arnaldo, please do "[PATCH RT]" while sending patches. Then the bots > don't complain if it applies but does not compile on !RT kernel (or so > I've been told). Ok, I'll try to remember that for future patches. -

Re: [PATCH] scsi: libsas: add transport class for ATA devices

On Mon, Mar 26, 2018 at 05:27:41PM +0800, Jason Yan wrote: > Now ata devices attached with sas controller do not have transport > class, so that we can not see any information of these ata devices in > /sys/class/ata_port(or ata_link or ata_device). > > Add transport class for the ata devices

[PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

The Windows Server 2016 iSCSI target doesn't work with the Linux kernel initiator since the kernel started sending larger requests by default, nor does it implement the block limits VPD page. Apply the sector limit workaround for these targets. Signed-off-by: Ross Lagerwall

答复: 答复: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

Hi, Arnd I'll ask our soc colleagues for help and give a detailed and accurate explanation aosp. Thanks! -邮件原件- 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann 发送时间: 2018年3月26日 18:42 收件人: liwei (CM) 抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin

Re: [PATCH] scsi: don't look for NULL devices handlers by name

On Fri, 23 Mar 2018 14:37:05 +0100 Johannes Thumshirn wrote: > Currently scsi_dh_lookup() doesn't check for NULL as a device > name. This combined with nvme over dm-mapth results in the following > messages emitted by device-mapper: > > device-mapper: multipath: Could not

Re: 答复: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Mon, Mar 26, 2018 at 12:26 PM, liwei (CM) wrote: > 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann > > 主题: Re: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs > > On Fri, Mar 23, 2018 at 3:22 AM, liwei (CM)

答复: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

Hi, Arnd -邮件原件- 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann 发送时间: 2018年3月26日 17:14 收件人: liwei (CM) 抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Kevin Hilman; Gregory

[PATCH] scsi: libsas: add transport class for ATA devices

Now ata devices attached with sas controller do not have transport class, so that we can not see any information of these ata devices in /sys/class/ata_port(or ata_link or ata_device). Add transport class for the ata devices attached with sas controller. The /sys/class directory will show the

Re: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Fri, Mar 23, 2018 at 3:22 AM, liwei (CM) wrote: >> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt >> b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt >> new file mode 100644 >> index ..0d21b57496cf >> --- /dev/null >> +++

Ask some questions about removing SCSI devices

Hi all, Sorry to bother you. Is there any safe way to delete SCSI devices? Thanks~ Best regards, Chongyun