Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-02 Thread Sreekanth Reddy
On Mon, Apr 2, 2018 at 8:55 PM, Bart Van Assche wrote: > On Mon, 2018-04-02 at 11:53 +0530, Sreekanth Reddy wrote: >> On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig >> wrote: >> > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: >> > >

Re: Multi-Actuator SAS HDD First Look

2018-04-02 Thread Tim Walker
On Mon, Apr 2, 2018 at 10:29 AM, Douglas Gilbert wrote: > On 2018-04-02 11:34 AM, Tim Walker wrote: >> >> On Sat, Mar 31, 2018 at 10:52 AM, Douglas Gilbert >> wrote: >>> >>> On 2018-03-30 04:01 PM, Bart Van Assche wrote: On Fri,

Re: Multi-Actuator SAS HDD First Look

2018-04-02 Thread Douglas Gilbert
On 2018-04-02 11:34 AM, Tim Walker wrote: On Sat, Mar 31, 2018 at 10:52 AM, Douglas Gilbert wrote: On 2018-03-30 04:01 PM, Bart Van Assche wrote: On Fri, 2018-03-30 at 12:36 -0600, Tim Walker wrote: Yes I will be there to discuss the multi-LUN approach. I wanted to

Re: Multi-Actuator SAS HDD First Look

2018-04-02 Thread Tim Walker
On Sat, Mar 31, 2018 at 10:52 AM, Douglas Gilbert wrote: > On 2018-03-30 04:01 PM, Bart Van Assche wrote: >> >> On Fri, 2018-03-30 at 12:36 -0600, Tim Walker wrote: >>> >>> Yes I will be there to discuss the multi-LUN approach. I wanted to get >>> these interface details

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-02 Thread Bart Van Assche
On Mon, 2018-04-02 at 11:53 +0530, Sreekanth Reddy wrote: > On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig wrote: > > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: > > > Check scsi tracker for NULL before accessing it. > > > And in some places there are

Re: [PATCH 00/15] mpt3sas: Enhancements and Defect fixes.

2018-04-02 Thread Bart Van Assche
On Mon, 2018-04-02 at 20:09 +0530, Chaitra Basappa wrote: > Below set of patches were prepared against Martin's 4.17/scsi-queue. Also > today I tried applying patches to Martin's 4.17/scsi-queue and patches got > applied smoothly, didn't observe any issue. > Please share the observed errors/hunks

RE: [PATCH 00/15] mpt3sas: Enhancements and Defect fixes.

2018-04-02 Thread Chaitra Basappa
Bart, Below set of patches were prepared against Martin's 4.17/scsi-queue. Also today I tried applying patches to Martin's 4.17/scsi-queue and patches got applied smoothly, didn't observe any issue. Please share the observed errors/hunks failed messages. Below is the link of the repo used by me:

Re: [PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq

2018-04-02 Thread Bart Van Assche
On Mon, 2018-04-02 at 11:37 +0200, Johannes Thumshirn wrote: > Coverity reports that we're assigning shost->use_blk_mq twice. This > looks like the result of a bad merge of commit 2f31115e940c ("scsi: > core: introduce force_blk_mq") > > Signed-off-by: Johannes Thumshirn >

[PATCH] tcmu: allow userspace to reset netlink

2018-04-02 Thread xiubli
From: Xiubo Li This patch adds 1 tcmu attr to reset and complete all the blocked netlink waiting threads. It's used when the userspace daemon like tcmu-runner has crashed or forced to shutdown just before the netlink requests be replied to the kernel, then the netlink

Regarding SCSI SANITIZE command support

2018-04-02 Thread Mahesh Rajashekhara
Hello, I am RAID HBA driver engineer here at Microsemi. We are working on linux driver development for Microsemi SAS/SATA RAID HBA controllers. As per our understanding, while a drive is processing the SANITIZE command: - The drive should still be exposed to the OS. - The drive will fail all

Re: [PATCH v1] scsi: ufs: add 2 lane support

2018-04-02 Thread Vivek Gautam
Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash

[PATCH] scsi: hosts: remove redundant assingment of shost->use_blk_mq

2018-04-02 Thread Johannes Thumshirn
Coverity reports that we're assigning shost->use_blk_mq twice. This looks like the result of a bad merge of commit 2f31115e940c ("scsi: core: introduce force_blk_mq") Signed-off-by: Johannes Thumshirn --- drivers/scsi/hosts.c | 1 - 1 file changed, 1 deletion(-) diff --git

RE: [PATCH 11/15] mpt3sas: Report Firmware Package Version from HBA Driver.

2018-04-02 Thread Chaitra Basappa
Bart, Agreed and patches will be posted with below changes. Thanks, Chaitra -Original Message- From: Bart Van Assche [mailto:bart.vanass...@wdc.com] Sent: Friday, March 30, 2018 10:05 PM To: chaitra.basa...@broadcom.com; linux-scsi@vger.kernel.org Cc: sathya.prak...@broadcom.com;

RE: [PATCH 06/15] mpt3sas: Enhanced handling of Sense Buffer.

2018-04-02 Thread Chaitra Basappa
Bart, Agreed with below changes, we will be posting the patches soon. -Original Message- From: Bart Van Assche [mailto:bart.vanass...@wdc.com] Sent: Friday, March 30, 2018 9:46 PM To: chaitra.basa...@broadcom.com; linux-scsi@vger.kernel.org Cc: sathya.prak...@broadcom.com;

Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-02 Thread Sreekanth Reddy
On Fri, Mar 30, 2018 at 5:29 PM, Christoph Hellwig wrote: > On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: >> Check scsi tracker for NULL before accessing it. >> And in some places there are possibilities for getting valid st >> but still other fields are not

Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk

2018-04-02 Thread Jason Yan
On 2018/4/2 13:29, Sergey Senozhatsky wrote: On (04/02/18 13:14), wen.yan...@zte.com.cn wrote: > It's true that this print for the same device is useless. But it's > useful for different devices. Is it possible to limit the print only > for the same device? In our scene,

Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk

2018-04-02 Thread Jason Yan
On 2018/4/2 13:14, wen.yan...@zte.com.cn wrote: Hello, > It's true that this print for the same device is useless. But it's > useful for different devices. Is it possible to limit the print only > for the same device? In our scene, it's just for the same device (q->queuedata), Thanks.