Re: [PATCH v1] scsi: ufs: add 2 lane support

On 2018-04-02 18:00, Vivek Gautam wrote: Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan

[PATCH v9] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

From: Michael Schmitz New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for

Re: [PATCH v8] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Geert, On Wed, Apr 11, 2018 at 8:56 PM, Geert Uytterhoeven wrote: > Hi Michael, > > On Wed, Apr 11, 2018 at 10:36 AM, Michael Schmitz > wrote: >> From: Michael Schmitz >> >> New combined SCSI driver for all ESP based Zorro

Re: 4.15.14 crash with iscsi target and dvd

Wakko Warner wrote: > Ming Lei wrote: > > Sure, thanks for your sharing. > > > > Wakko, could you test the following patch and see if there is any > > difference? > > > > -- > > diff --git a/drivers/target/target_core_pscsi.c > > b/drivers/target/target_core_pscsi.c > > index

Re: usercopy whitelist woe in scsi_sense_cache

On Wed, Apr 11, 2018 at 3:47 PM, Kees Cook wrote: > On Tue, Apr 10, 2018 at 8:13 PM, Kees Cook wrote: >> I'll see about booting with my own kernels, etc, and try to narrow this >> down. :) > > If I boot kernels I've built, I no longer hit the bug in

Re: [PATCH] Waiting for scsi_host_template release

On "what was the actual error": it is deref of an invalid address, not NULL. Attaching crash dump analysis for the reference. On module reference count: good point. I decided against it at first, but I can reconsider. "modprobe -r qla2xxx" will fail if there is an extra reference to the module,

Re: usercopy whitelist woe in scsi_sense_cache

On Tue, Apr 10, 2018 at 8:13 PM, Kees Cook wrote: > I'll see about booting with my own kernels, etc, and try to narrow this down. > :) If I boot kernels I've built, I no longer hit the bug in this VM (though I'll keep trying). What compiler are you using? -Kees -- Kees

Re: [PATCH v3 0/3] Report all request failures again to user space

On Wed, 2018-04-11 at 17:45 -0400, Douglas Gilbert wrote: > It is a good bet that some sg based apps in the wild will be using the > old (shifted+masked) SCSI status defines. The basis of the sg_v3 interface > is 'struct sg_io_hdr' and it has two SCSI status fields: 'status' and > 'masked_status'.

Re: [PATCH v3 0/3] Report all request failures again to user space

On 2018-04-11 12:25 PM, Johannes Thumshirn wrote: On Wed, Apr 11, 2018 at 12:20:49PM -0400, Martin K. Petersen wrote: Johannes, While we're at it, anyone still in love with the non SAM_ status bytes? If not they'll be gone afterwards as well. /me is up for some spring cleaning. Just be

Re: [PATCH] Waiting for scsi_host_template release

On Wed, 2018-04-11 at 12:22 -0700, Anatoliy Glagolev wrote: > Hannes, James, thanks a lot for taking a look! > > On the problem the patch is solving: it is in the "Description" part > of my initial e-mail. If you agree that a Scsi_Host may be around > after a driver has unloaded, the problem

Re: [PATCH] Waiting for scsi_host_template release

Hannes, James, thanks a lot for taking a look! On the problem the patch is solving: it is in the "Description" part of my initial e-mail. If you agree that a Scsi_Host may be around after a driver has unloaded, the problem applies to any driver creating a new Scsi_Host. I fixed it in qla2xxx to

Re: sr: get/drop reference to device in revalidate and check_events

On Wed 11-04-18 10:23:30, Jens Axboe wrote: > We can't just use scsi_cd() to get the scsi_cd structure, we have > to grab a live reference to the device. For both callbacks, we're > not inside an open where we already hold a reference to the device. > > This fixes device removal/addition under

Re: sr: get/drop reference to device in revalidate and check_events

On 04/11/2018 09:23 AM, Jens Axboe wrote: > We can't just use scsi_cd() to get the scsi_cd structure, we have > to grab a live reference to the device. For both callbacks, we're > not inside an open where we already hold a reference to the device. > > This fixes device removal/addition under

Re: [PATCH v3 0/3] Report all request failures again to user space

On Wed, Apr 11, 2018 at 12:20:49PM -0400, Martin K. Petersen wrote: > > Johannes, > > > While we're at it, anyone still in love with the non SAM_ status > > bytes? If not they'll be gone afterwards as well. > > > > /me is up for some spring cleaning. > > Just be careful not to break any sg/bsg

sr: get/drop reference to device in revalidate and check_events

We can't just use scsi_cd() to get the scsi_cd structure, we have to grab a live reference to the device. For both callbacks, we're not inside an open where we already hold a reference to the device. This fixes device removal/addition under concurrent device access, which otherwise could result

Re: [PATCH v3 0/3] Report all request failures again to user space

Johannes, > While we're at it, anyone still in love with the non SAM_ status > bytes? If not they'll be gone afterwards as well. > > /me is up for some spring cleaning. Just be careful not to break any sg/bsg apps that rely on them. -- Martin K. Petersen Oracle Linux Engineering

Re: Hotplug

On 4/11/18 10:14 AM, Jan Kara wrote: > Hello, > > On Wed 11-04-18 08:11:13, Jens Axboe wrote: >> On 4/11/18 7:58 AM, Jan Kara wrote: >>> On Tue 10-04-18 11:17:46, Jens Axboe wrote: Been running some tests and I keep running into issues with hotplug. This looks similar to what Bart

Re: Hotplug

Hello, On Wed 11-04-18 08:11:13, Jens Axboe wrote: > On 4/11/18 7:58 AM, Jan Kara wrote: > > On Tue 10-04-18 11:17:46, Jens Axboe wrote: > >> Been running some tests and I keep running into issues with hotplug. > >> This looks similar to what Bart posted the other day, but it looks > >> more

Re: [PATCH v3 0/3] Report all request failures again to user space

On Wed, Apr 11, 2018 at 12:05:18PM -0400, Martin K. Petersen wrote: > > Johannes, > > > Well it's defined in "drivers/scsi/scsi_typedefs.h" and only used by > > some (old) drivers inside drivers/scsi so it can't be a UAPI => we're > > not breaking any existing user-space with it. > > I'm all

Re: [PATCH v3 0/3] Report all request failures again to user space

Johannes, > Well it's defined in "drivers/scsi/scsi_typedefs.h" and only used by > some (old) drivers inside drivers/scsi so it can't be a UAPI => we're > not breaking any existing user-space with it. I'm all for nuking it. > Anyways that's still WIP but I plan to have it done before LSF/MM so

Re: [PATCH v3 0/3] Report all request failures again to user space

On Tue, Apr 10, 2018 at 02:53:40PM +, Bart Van Assche wrote: > I'm in favor of the removal. But maybe there is something I'm overlooking > and that means that the typedef should not be removed? Well it's defined in "drivers/scsi/scsi_typedefs.h" and only used by some (old) drivers inside

Re: [PATCH] Waiting for scsi_host_template release

On Wed, 2018-04-11 at 16:11 +0200, Hannes Reinecke wrote: > On Mon, 9 Apr 2018 23:23:51 -0700 > Anatoliy Glagolev wrote: > > > Description: > > SCSI mid-layer may hold references to Scsi_Host structs when > > the owning module has already unloaded. Scsi_Host release path > >

Re: [PATCH] Waiting for scsi_host_template release

On Mon, 9 Apr 2018 23:23:51 -0700 Anatoliy Glagolev wrote: > Description: > SCSI mid-layer may hold references to Scsi_Host structs when > the owning module has already unloaded. Scsi_Host release path > touches scsi_host_template struct that is usually allocated > in the

Re: Hotplug

On 4/11/18 7:58 AM, Jan Kara wrote: > Hi, > > On Tue 10-04-18 11:17:46, Jens Axboe wrote: >> Been running some tests and I keep running into issues with hotplug. >> This looks similar to what Bart posted the other day, but it looks >> more deeply rooted than just having to protect the queue in >>

Re: Hotplug

On 4/11/18 8:06 AM, Bart Van Assche wrote: > On Wed, 2018-04-11 at 15:58 +0200, Jan Kara wrote: >> I'm not really sure where this is crashing and 'Code' line is incomplete to >> tell me. > > Hello Jan, > > The following patch should fix this crash: >

Re: Hotplug

On Wed, 2018-04-11 at 15:58 +0200, Jan Kara wrote: > I'm not really sure where this is crashing and 'Code' line is incomplete to > tell me. Hello Jan, The following patch should fix this crash: https://www.mail-archive.com/linux-block@vger.kernel.org/msg20209.html. Thanks, Bart.

Re: Hotplug

Hi, On Tue 10-04-18 11:17:46, Jens Axboe wrote: > Been running some tests and I keep running into issues with hotplug. > This looks similar to what Bart posted the other day, but it looks > more deeply rooted than just having to protect the queue in > generic_make_request_checks(). The test run

Re: [PATCH v8] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Michael, On Wed, Apr 11, 2018 at 10:36 AM, Michael Schmitz wrote: > From: Michael Schmitz > > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. Thanks a lot! > --- /dev/null > +++ b/drivers/scsi/zorro_esp.c > +static

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On 04/11/2018 10:55 AM, Michael Schmitz wrote: Would be nice but this has been chugging along for over four years in my queue so I'm sure it can wait a few more weeks :-) But the driver works very well now, so it was worth the wait ;-). -- .''`. John Paul Adrian Glaubitz : :' : Debian

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Geert, Christoph, Am 11.04.2018 um 20:30 schrieb Geert Uytterhoeven: > Hi Christoph, > > On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig > wrote: >> On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: That would be cool. Would that still be in

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Geert, Am 11.04.2018 um 18:51 schrieb Geert Uytterhoeven: > Hi Michael, > > On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz > wrote: Short of a complete rewrite of the Zorro driver support code to be closer to what PCI does, I don' see what can be done

[PATCH v8] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

From: Michael Schmitz New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Christoph, On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig wrote: > On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: >> > That would be cool. Would that still be in time for the 4.17 merge? >> >> Nope, as new drivers need to be in linux-next before

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote: > > That would be cool. Would that still be in time for the 4.17 merge? > > Nope, as new drivers need to be in linux-next before the merge window opens. I always throught that entirely new drivers were an exception to that.

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Adrian, On Wed, Apr 11, 2018 at 9:59 AM, John Paul Adrian Glaubitz wrote: > On 04/11/2018 08:51 AM, Geert Uytterhoeven wrote: >> I don't have a preference. If you think it makes the driver easier to >> read, >> go for it. > > That would be cool. Would that still

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On 04/11/2018 08:51 AM, Geert Uytterhoeven wrote: I don't have a preference. If you think it makes the driver easier to read, go for it. That would be cool. Would that still be in time for the 4.17 merge? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer -

[PATCH][next] scsi: fnic: fix spelling mistake in fnic stats "Abord" -> "Abort"

From: Colin Ian King Trivial fix to spelling mistake in fnic stats message text Signed-off-by: Colin Ian King --- drivers/scsi/fnic/fnic_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] scsi_debug: IMMED related delay adjustments

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Hi Michael, On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz wrote: > On Tue, Apr 10, 2018 at 8:18 PM, Geert Uytterhoeven > wrote: >> On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz >> wrote: >>> On Mon, Apr 9, 2018 at 7:50