> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Wednesday, April 18, 2018 10:43 PM
> To: volker.schwick...@godaddy.com
> Cc: linux-scsi@vger.kernel.org; Kashyap Desai; Sumit Saxena
> Subject: Re: MegaCli fails to communicate with Raid-Controller
>
On Wed, 18 Apr 2018 17:01:15 +0200
Johannes Thumshirn wrote:
> Introduce clear_scsi_result() and convert drivers over to use the new
> function.
>
[ .. ]
Why not use 'set_scsi_result' here?
Basically everywhere the usage pattern is
clear_scsi_result()
set_host_byte()
so they can be collapsed
On Thu, 19 Apr 2018 09:46:30 +1000 (AEST)
Finn Thain wrote:
> On Wed, 18 Apr 2018, Johannes Thumshirn wrote:
>
> > --- a/drivers/scsi/dc395x.c
> > +++ b/drivers/scsi/dc395x.c
> > @@ -3473,7 +3473,7 @@ static void srb_done(struct AdapterCtlBlk
> > *acb, struct DeviceCtlBlk *dcb,
> > /*if( sr
> Subject: Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE
> devices
>
>
> Long,
>
> > Can you take a look at the following patch?
>
> >> > + max_sub_channels =
> >> > +(num_cpus - 1) / storvsc_vcpus_per_sub_channel;
>
> What happens if num_cpus = 1?
If num_c
Hi Martin,
thank you so much!
Ben - please drop the Amiga SCSI patch for Debian testing from kernel
version 4.18!
Cheers,
Michael
Am 19.04.2018 um 16:01 schrieb Martin K. Petersen:
>
> Michael,
>
>> Anything else needed for linux-scsi?
>
> Applied to 4.18/scsi-queue. Thanks!
>
Souptick,
> Use new return type vm_fault_t for fault handler in struct
> vm_operations_struct.
Applied to 4.18/scsi-queue. Thank you.
--
Martin K. Petersen Oracle Linux Engineering
Lee,
> The target database root directory, dbroot, has defaulted to
> /var/target for a while, but its main client, targetcli-fb, has been
> moving it to /etc/target for quite some time. With the plethora of
> target drivers now appearing, it has become more difficult to
> initialize this attribu
Ming,
> When the current page can't be added to bio, one new bio should be
> created for adding this page again, instead of ignoring this page.
>
> This patch fixes kernel crash with iscsi target and dvd, as reported
> by Wakko.
I queued this up in 4.17/scsi-fixes.
--
Martin K. Petersen O
This patch uses a cleaner method to convey the presence of the IMMED
cdb bit back to the generic delay code in the scsi_debug driver. The
previous method used a temporary mask over the SCSI result value
(a 32 bit integer soon to be restructured) that was not visible
outside this driver. It has stil
Christoph,
> The default already is to never bounce, so the call is a no-op.
Applied to 4.18/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> The default already is to never bounce, so the call is a no-op.
Applied to 4.18/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Souptick,
> Use new return type vm_fault_t for fault handler in struct
> vm_operations_struct.
Applied to 4.18/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
> Chaitra P B (14):
> mpt3sas: Bug fix for big endian systems.
> mpt3sas: Pre-allocate RDPQ Array at driver boot time.
> mpt3sas: Lockless access for chain buffers.
> mpt3sas: Optimize I/O memory consumption in driver.
> mpt3sas: Enhanced handling of Sense Buffer.
> mpt3sas: Added supp
Sara,
> Summary: scsi sd driver is not emitting a CHANGE uevent for online
> disk resizes using VMware’s vsphere.
For the SCSI layer to emit an event on capacity change, the storage
device must generate a UNIT ATTENTION with ASC 0x2a and ASCQ 0x9. Very
few devices to that.
When you do a rescan
Colin,
> Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and
> MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN
Applied to 4.18/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> This patch series, when combined with the block layer patch that
> prevents that the report and reset zone ioctls are executed while a
> queue is frozen, prevents that these ioctls fail sporadically with
> -EIO. Since this race is relatively easy to trigger with the SMR
> support for fio
Michael,
> Anything else needed for linux-scsi?
Applied to 4.18/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Wed, 2018-04-18 at 23:27 -0400, Martin K. Petersen wrote:
> Christoph,
>
> > Btw, seems like someone needs to volunteer for putting together a pull
> > request with target fixes for Linus - I haven't heard from Nic for a
> > while, and we've got quite a few fixes out on the list.
>
> Still hap
Long,
> Can you take a look at the following patch?
>> > + max_sub_channels =
>> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel;
What happens if num_cpus = 1?
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Btw, seems like someone needs to volunteer for putting together a pull
> request with target fixes for Linus - I haven't heard from Nic for a
> while, and we've got quite a few fixes out on the list.
Still happy to take things through SCSI if Nic doesn't materialize.
--
Martin K.
Mahesh,
> During the drive sanitization, when the sd driver issues TEST UNIT
> READY (TUR), drive reports Sense Key: NOT_READY, ASC: 0x4 and ASCQ:
> 0x1b.
Applied to 4.17/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
On Wed, 18 Apr 2018, Johannes Thumshirn wrote:
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index d670cfe4d0e7..a0b79899bce3 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -548,7 +548,8 @@ static int NCR5380_queue_command(struct Scsi_Host
> *instance
On Wed, 18 Apr 2018, Johannes Thumshirn wrote:
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -3473,7 +3473,7 @@ static void srb_done(struct AdapterCtlBlk *acb, struct
> DeviceCtlBlk *dcb,
>
> /*if( srb->cmd->cmnd[0] == INQUIRY && */
> /* (host_byte(cmd->result) =
Hi Martin
Can you take a look at the following patch?
Long
> > -Original Message-
> > From: linux-kernel-ow...@vger.kernel.org
> > On Behalf Of Long Li
> > Sent: Thursday, March 22, 2018 2:47 PM
> > To: KY Srinivasan ; Haiyang Zhang
> > ; Stephen Hemminger
> ;
> > James E . J . Bottom
On Wed, Apr 18, 2018 at 1:12 AM, Martin Wilck wrote:
>
> No, it doesn't (gcc 7.3.0). -> https://paste.opensuse.org/27471594
> It doesn't even warn on an expression like this:
>
> #define SIZE (1<<10)
> static int foo[ilog2(SIZE)];
Ok, I think this is the "random gcc versions act differently"
Hello -
This is an issue I've encountered while trying to detect disk resizing
with utilities listening to udev. Let me know if there's a better place
for me to post this.
Summary: scsi sd driver is not emitting a CHANGE uevent for online disk
resizes using VMware’s vsphere.
Configuration:
Sent out a new patch with "bsg referencing bus driver module" in subj.
On Wed, Apr 11, 2018 at 4:37 PM, Anatoliy Glagolev wrote:
> On "what was the actual error": it is deref of an invalid address, not
> NULL. Attaching crash dump analysis for the reference.
>
> On module reference count: good po
On 2018-04-18 11:01 AM, Johannes Thumshirn wrote:
Hey all,
here's a early preview of my SCSI results rework so we can eventually
discuss things next week at LSF/MM (it still has compiler errors on
aic7xxx and scsi_debug).
The motivation behing this is that some drivers have failed to set the
sc
https://bugzilla.kernel.org/show_bug.cgi?id=199435
--- Comment #4 from Don (don.br...@microsemi.com) ---
Your stack trace does not show and hpsa driver components, but I do see the
reset issued but not completing.
I'm hoping that the attached patch helps diagnose the issue a little better.
--
Y
https://bugzilla.kernel.org/show_bug.cgi?id=199435
--- Comment #3 from Don (don.br...@microsemi.com) ---
Created attachment 275437
--> https://bugzilla.kernel.org/attachment.cgi?id=275437&action=edit
Patch to use local work-queue insead of system work-queue
If the driver initiates a re-scan fro
Volker,
> after our latest kernel-update from 4.6. to 4.14.14 we are having
> trouble getting data out of our LSI-raid-controllers using the
> megacli-binary.
>
> For every execution of the megacli-binary a line shows up in the kern.log
>
> ###
> [547216.425556] megaraid_sas :03:00.0: Failed
On Wed, Apr 18, 2018 at 10:20 AM, Bart Van Assche
wrote:
> On Wed, 2018-04-18 at 05:16 -0600, Tim Walker wrote:
>> It would be good if we could set up an informal meeting time and
>> location at LSFMM to discuss these dual actuator topics. so far you,
>> Doug, Hannes, and Christoph have expressed
On Wed, 2018-04-18 at 05:16 -0600, Tim Walker wrote:
> It would be good if we could set up an informal meeting time and
> location at LSFMM to discuss these dual actuator topics. so far you,
> Doug, Hannes, and Christoph have expressed the most interest, plus
> Damien. Can we set an hour aside one
On Wed, 2018-04-18 at 17:01 +0200, Johannes Thumshirn wrote:
> here's a early preview of my SCSI results rework so we can eventually
> discuss things next week at LSF/MM (it still has compiler errors on
> aic7xxx and scsi_debug).
>
> The motivation behing this is that some drivers have failed to s
@@
struct scsi_cmnd *c;
expression E1;
@@
(
-c->result |= E1;
+set_status_byte(c, E1);
|
-c->result |= (E1);
+set_status_byte(c, E1);
)
Signed-off-by: Johannes Thumshirn
---
drivers/ata/libata-scsi.c| 20
drivers/infiniband/ulp/srp/ib_srp.c | 2 +-
driver
Introduce set_scsi_result() for setting the bytes of the scsi_cmnd's result
filed and flip over all users that set at least two bytes to using it.
The conversion has been done using the following coccinelle spatch:
@@
struct scsi_cmnd *c;
expression E1, E2, E3, E4;
@@
(
- c->result = E1 << 24 |
Introduce struct scsi_result.
Signed-off-by: Johannes Thumshirn
Suggested-by: Bart Van Assche
---
block/bsg-lib.c | 8 --
block/bsg.c | 8 --
block/scsi_ioctl.c | 12
drivers/ata/
Add enum for message byte codes and adopt set_msg_byte()'s
signature.
Signed-off-by: Johannes Thumshirn
Suggested-by: Bart Van Assche
---
include/scsi/scsi.h | 79 +---
include/scsi/scsi_cmnd.h | 3 +-
2 files changed, 44 insertions(+), 38 delet
Signed-off-by: Johannes Thumshirn
---
drivers/ata/libata-scsi.c | 2 +-
drivers/scsi/3w-9xxx.c| 2 +-
drivers/scsi/3w-.c| 6 --
drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++--
drivers/scsi/dc395x.c | 4 ++--
drivers/scsi/dpt
Add enum for host byte codes and adopt set_host_byte()'s and host_byte()'s
signature.
Signed-off-by: Johannes Thumshirn
Suggested-by: Bart Van Assche
---
drivers/scsi/dc395x.c | 3 +--
drivers/scsi/megaraid.c | 6 --
drivers/scsi/scsi_error.c | 2 ++
include/scsi/scsi.h | 55
This will make subsequent refactoring easier to handle.
@rem_Scsi_Cmnd@
@@
- typedef struct scsi_cmnd Scsi_Cmnd;
@fix_Scsi_Cmnd@
typedef Scsi_Cmnd;
@@
-Scsi_Cmnd
+struct scsi_cmnd
@fix_sizeof_Scsi_Cmnd@
@@
-sizeof(Scsi_Cmnd)
+sizeof(struct scsi_cmnd)
Note: this patch is nowhere checkpatch cl
@@
struct scsi_cmnd *c;
expression E1, E2;
@@
(
- c->result = E1 << 24 | E2;
+ c->result = 0;
+ set_driver_byte(c, E1);
+ c->result |= E2;
|
- c->result |= E1 << 24 | E2;
+ set_driver_byte(c, E1);
+ c->result |= E2;
|
- c->result = E1 << 24;
+ c->result = 0;
+ set_driver_byte(c, E1);
|
- c->result
Hey all,
here's a early preview of my SCSI results rework so we can eventually
discuss things next week at LSF/MM (it still has compiler errors on
aic7xxx and scsi_debug).
The motivation behing this is that some drivers have failed to set the
scsi_cmnd::result bytes correctly in the past and this
@@
struct scsi_cmnd *c;
expression E1, E2;
@@
(
- c->result = E1 << 8 | E2;
+ c->result = 0;
+ set_msg_byte(c, E1);
+ c->result |= E2;
|
- c->result |= E1 << 8 | E2;
+ set_msg_byte(c, E1);
+ c->result |= E2;
|
- c->result = E1 << 8;
+ c->result = 0;
+ set_msg_byte(c, E1);
|
- c->result |= E1 << 8;
Use the host_byte() accessor for getting the SCSI host byte.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/aic7xxx/aic79xx_osm.h | 2 +-
drivers/scsi/aic7xxx/aic7xxx_osm.h | 2 +-
drivers/scsi/dc395x.c | 2 +-
drivers/scsi/imm.c | 4 ++--
drivers/scsi/ppa.c
Add enum for driver byte codes and adopt set_driver_byte()'s
signature.
Signed-off-by: Johannes Thumshirn
Suggested-by: Bart Van Assche
---
include/scsi/scsi.h | 33 -
include/scsi/scsi_cmnd.h | 3 ++-
2 files changed, 22 insertions(+), 14 deletions(-)
dif
https://bugzilla.kernel.org/show_bug.cgi?id=199435
--- Comment #2 from Anthony Hausman (anthonyhaussm...@gmail.com) ---
I don't have any "Controller lockup detected" message in the Syslog
unfortunately.
On the ilo IML log, the last message was about the cache module:
CAUTION: POST Messages - POST
On 4/18/18 3:08 AM, Paolo Valente wrote:
>
>
>> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha
>> scritto:
>>
>> On 4/17/18 3:48 PM, Jens Axboe wrote:
>>> On 4/17/18 3:47 PM, Kees Cook wrote:
On Tue, Apr 17, 2018 at 2:39 PM, Jens Axboe wrote:
> On 4/17/18 3:25 PM, Kees Cook wrot
https://bugzilla.kernel.org/show_bug.cgi?id=199435
Don (don.br...@microsemi.com) changed:
What|Removed |Added
CC||don.br...@microsemi.com
-
Hello,
Open bug in launchpad.net
https://bugs.launchpad.net/bugs/1765043
dmesg:
[ 4228.290628] sr 6:0:0:0: [sr0] tag#0 FAILED Result: hostbyte=DID_OK
driverbyte=DRIVER_SENSE
[ 4228.290638] sr 6:0:0:0: [sr0] tag#0 Sense Key : Illegal Request [current]
[ 4228.290645] sr 6:0:0:0: [sr0] tag#0 Add. S
From: Colin Ian King
Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and
MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN
Signed-off-by: Colin Ian King
---
drivers/message/fusion/lsi/mpi_cnfg.h | 4 ++--
drivers/message/fusion/mptfc.c| 2 +-
2 files changed, 3 ins
On Sun, Apr 15, 2018 at 10:31 PM, Bart Van Assche
wrote:
> On Sun, 2018-04-15 at 19:35 -0600, Tim Walker wrote:
>> I also believe the dual-actuator, or any significant HDD parallelism,
>> would map well onto an NVMe target, or NVMe-oF behind nvmet. Maybe a
>> lightweight virtual NVMe controller th
Hi all,
after our latest kernel-update from 4.6. to 4.14.14 we are having trouble
getting data out of our LSI-raid-controllers using the megacli-binary.
For every execution of the megacli-binary a line shows up in the kern.log
###
[547216.425556] megaraid_sas :03:00.0: Failed to alloc kerne
> Il giorno 18 apr 2018, alle ore 00:57, Jens Axboe ha
> scritto:
>
> On 4/17/18 3:48 PM, Jens Axboe wrote:
>> On 4/17/18 3:47 PM, Kees Cook wrote:
>>> On Tue, Apr 17, 2018 at 2:39 PM, Jens Axboe wrote:
On 4/17/18 3:25 PM, Kees Cook wrote:
> On Tue, Apr 17, 2018 at 1:46 PM, Kees Cook
> Il giorno 17 apr 2018, alle ore 23:42, Kees Cook ha
> scritto:
>
> Some elevators may not correctly check rq->rq_flags & RQF_ELVPRIV, and
> may attempt to read rq->elv fields. When requests got reused, this
> caused BFQ to think it already had a bfqq (rq->elv.priv[1]) allocated.
Hi Kees,
wh
On Wed, Apr 18, 2018 at 10:12:54AM +0200, Martin Wilck wrote:
> On Tue, 2018-04-17 at 17:07 -0700, Linus Torvalds wrote:
> > On Tue, Apr 17, 2018 at 4:35 PM, Martin Wilck
> > wrote:
> > > Sparse emits errors about ilog2() in array indices because of the
> > > use of
> > > __ilog2_32() and __ilog2_
https://bugzilla.kernel.org/show_bug.cgi?id=199435
Bug ID: 199435
Summary: HPSA + P420i resetting logical Direct-Access never
complete
Product: IO/Storage
Version: 2.5
Kernel Version: 4.11.0-14-generic
Hardware: All
On Tue, 2018-04-17 at 17:07 -0700, Linus Torvalds wrote:
> On Tue, Apr 17, 2018 at 4:35 PM, Martin Wilck
> wrote:
> > Sparse emits errors about ilog2() in array indices because of the
> > use of
> > __ilog2_32() and __ilog2_64(),
>
> If sparse warns about it, then presumably gcc with -Wvla warns
58 matches
Mail list logo
