Re: [RESEND V2 1/6] tcmu: add new netlink events helpers

Mike, > Thanks. Patchset looks ok to me. > > Acked-by: Mike Christie Applied this to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] target/file: add support of direct and async I/O

Bryant, > Can you review this patch and pull it into scsi since Nicholas has > been out for awhile? > > I have tested this patch and really like the performance enhancements > as a result of it. No problem queuing it up if I get an ACK from Christoph or Mike. -- Martin K. Petersen Oracle

Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

Hello Ching, > 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT. > 2. Add slave_configure callback function to set device command timeout value. > 3. Update driver version to v1.40.00.06-20180504. I am not so keen on arcmsr overriding the timeout set by the admin or

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

Wenwen, > In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by > 'driver_command', which is 'driver_command.buffer_length'.

Re: [PATCH 1/2] scsi: mpt3sas: remove obsolete path "drivers/scsi/mpt2sas/" from MAINTAINERS

Tomohiro, > drivers/scsi/mpt2sas/ no longer exists after > c84b06a48c ("mpt3sas: Single driver module which supports both > SAS 2.0 & SAS 3.0 HBAs") merged/removed it. Applied patches 1 + 2 to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid: silence a static checker bug

Dan, > If we had more than 32 megaraid cards then it would cause memory > corruption. That's not likely, of course, but it's handy to enforce it > and make the static checker happy. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][V2] scsi: lpfc: fix spelling mistakes: "mabilbox" and "maibox"

Colin, > Trivial fix to spelling mistakes in lpfc_printf_log log message > > "mabilbox" -> "mailbox" > "maibox" -> "mailbox" Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptsas: fix spelling mistake: "matchs" -> "matches"

Colin, > Trivial fix to spelling mistake in warning message Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

Andrei, Applied to 4.18/scsi-queue. thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptfusion: fix spelling mistake: "initators" -> "initiators"

Colin, > Trivial fix to spelling mistake in text string Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 06/10] lpfc: Check if SCSI scanning is complete, before allowing I/O commands

James, Not a fan of these: > +static int > +lpfc_is_scan_cmd(uint8_t opcode) > +{ > + switch (opcode & 0x1f) { > + case LPFC_INQUIRY_CMD_CODE: > + case LPFC_LOG_SELECT_CMD_CODE: > + case LPFC_LOG_SENSE_CMD_CODE: Especially since they are masked off twice: > +#define

Re: [PATCH 00/10] lpfc updates for 12.0.0.3

James, > This patch contains lpfc bug fixes and a few message updates and > cleanups. Applied to 4.18/scsi-queue except for patch #6. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/11] hisi_sas: some misc patches

John, > This patchset introduces some misc changes for the > driver. These include: > - fixes for potential problems related to SCSI EH > and device removal races > - fix protection info size for all hw versions > - some SoC bug workarounds > - minor optimisations > - other more minor things

Re: [PATCH 00/21] qedf: Update driver to 8.33.16.20.

Chad, > Please add these patches to your tree for the next kernel merge window > at your convenience. Applied to 4.18/scsi-queue with the zeroday tweak rolled in. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/12] qla2xxx: Updates for driver

Himanshu, > Please apply this to 4.18 scsi-misc branch at your earliest > convenience. Applied patches 2 through 12 to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 00/14] mpt3sas: Enhancements and Defect fixes.

Sreekanth, > Any update on this patch set. I applied it to 4.18/scsi-queue earlier today. -- Martin K. Petersen Oracle Linux Engineering

RE: [PATCH v3 00/14] mpt3sas: Enhancements and Defect fixes.

Hi, Any update on this patch set. Thanks, Sreekanth -Original Message- From: Chaitra P B [mailto:chaitra.basa...@broadcom.com] Sent: Tuesday, April 24, 2018 2:58 PM To: linux-scsi@vger.kernel.org Cc: sathya.prak...@broadcom.com; sreekanth.re...@broadcom.com;

Re: [PATCH] zfcp: fix infinite iteration on ERP ready list

Steffen, > zfcp_erp_adapter_reopen() schedules blocking of all of the adapter's > rports via zfcp_scsi_schedule_rports_block() and enqueues a reopen > adapter ERP action via zfcp_erp_action_enqueue(). Both are separately > processed asynchronously and concurrently. Applied to 4.17/scsi-fixes.

Re: [PATCH v2 2/2] scsi: ufs: Use freq table with devfreq

Hi, On 2018년 05월 05일 07:44, Bjorn Andersson wrote: > devfreq requires that the client operates on actual frequencies, not > only 0 and UMAX_INT and as such UFS brok with the introduction of > f1d981eaecf8 ("PM / devfreq: Use the available min/max frequency"). > > This patch registers the

Re: [PATCH v2 1/2] scsi: ufs: Extract devfreq registration

Hi, On 2018년 05월 05일 07:44, Bjorn Andersson wrote: > Failing to register with devfreq leaves hba->devfreq assigned, which > causes the error path to dereference the ERR_PTR(). Rather than bolting > on more conditionals, move the call of devm_devfreq_add_device() into > it's own function and only

Re: [PATCH v2] scsi: 3w-xxxx: fix a missing-check bug

On Mon, May 7, 2018 at 5:54 PM, Wenwen Wang wrote: > In tw_chrdev_ioctl(), the length of the data buffer is firstly copied from > the userspace pointer 'argp' and saved to the kernel object > 'data_buffer_length'. Then a security check is performed on it to make sure > that the

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

On Mon, May 7, 2018 at 5:46 PM, Wenwen Wang wrote: > In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by >

[PATCH v2] scsi: 3w-xxxx: fix a missing-check bug

In tw_chrdev_ioctl(), the length of the data buffer is firstly copied from the userspace pointer 'argp' and saved to the kernel object 'data_buffer_length'. Then a security check is performed on it to make sure that the length is not more than 'TW_MAX_IOCTL_SECTORS * 512'. Otherwise, an error code

[PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the userspace pointer 'argp' and saved to the kernel object 'driver_command'. Then a security check is performed on the data buffer size indicated by 'driver_command', which is 'driver_command.buffer_length'. If the security

Re: [PATCH] scsi: 3w-xxxx: fix a missing-check bug

On Sat, May 5, 2018 at 10:48 PM, Wenwen Wang wrote: > In tw_chrdev_ioctl(), the length of the data buffer is firstly copied from > the userspace pointer 'argp' and saved to the kernel object > 'data_buffer_length'. Then a security check is performed on it to make sure > that the

Re: [PATCH] scsi: 3w-9xxx: fix a missing-check bug

On Sat, May 5, 2018 at 8:43 PM, Wenwen Wang wrote: > In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by >

Re: [PATCH] scsi: 3ware: fix a missing-check bug

On Sat, May 5, 2018 at 10:50 PM, Wenwen Wang wrote: > In twl_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by

Re: [PATCH v2] target/file: add support of direct and async I/O

Hi Martin, Can you review this patch and pull it into scsi since Nicholas has been out for awhile? I have tested this patch and really like the performance enhancements as a result of it. Thanks, Bryant On 4/19/18 1:29 PM, Andrei Vagin wrote: > Hello Nicholas, > > What do you think about

[PATCH-next v2] scsi: libsas: dynamically allocate and free ata host

Now the ata host for libsas is embedded in domain_device, and the ->kref member is not initialized. Afer we add ata transport class, ata_host_get() will be called when adding transport ATA port and a warning will be triggered as below: refcount_t: increment on 0; use-after-free. WARNING: CPU: 2

Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host

://github.com/0day-ci/linux/commits/linux-kernel-owner-vger-kernel-org/scsi-libsas-dynamically-allocate-and-free-ata-host/20180507-105656 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-federa-25 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce

[PATCH 3/3] scsi: arcmsr: Update driver version to v1.40.00.06-20180504

>From Ching Huang Update driver version to v1.40.00.06-20180504 Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 62eeef5..eb39623 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++

[PATCH 2/3] scsi: arcmsr: Add slave_configure callback function to set device command timeout value

>From Ching Huang Add slave_configure callback function to set device command timeout value Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index f6ddaec..79a4487 100755 ---

[PATCH 1/3] scsi: arcmsr: Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT

>From Ching Huang Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 2e51ccc..62eeef5 100755 ---

[PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

>From Ching Huang This patch series are against to mkp's 4.18/scsi-queue. 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT. 2. Add slave_configure callback function to set device command timeout value. 3. Update driver version to