[PATCH] scsi_lib: sanitize++ in progress

2018-05-18 Thread Douglas Gilbert
A patch titled: "scsi: sd: improved drive sanitize error handling" by Mahesh Rajashekhara on 20180417 has been accepted into the kernel. It may not be sufficient, especially if the SCSI SANITIZE command is sent via the bsg or sg pass-throughs, since they don't use the sd driver. Add "Sanitize in p

Re: [PATCH] scsi: sg: fix a missing-check bug

2018-05-18 Thread Wenwen Wang
On Mon, May 7, 2018 at 12:13 AM, Douglas Gilbert wrote: > On 2018-05-05 11:21 PM, Wenwen Wang wrote: >> >> In sg_write(), the opcode of the command is firstly copied from the >> userspace pointer 'buf' and saved to the kernel variable 'opcode', using >> the __get_user() function. The size of the c

[PATCH] aic94xx: don't return zero on failure paths in aic94xx_init()

2018-05-18 Thread Alexey Khoroshilov
If sas_domain_attach_transport() fails in aic94xx_init(), it breaks off initialization, deallocates all resources, but returns zero. The patch adds -ENOMEM as return value in this case. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Peter Melnichenko Signed-off-by

Re: [PATCH v4] target: transport should handle st FM/EOM/ILI reads

2018-05-18 Thread Martin K. Petersen
Lee, > When a tape drive is exported via LIO using the pscsi module, a read > that requests more bytes per block than the tape can supply returns an > empty buffer. This is because the pscsi pass-through target module > sees the "ILI" illegal length bit set and thinks there is no reason to > retu

Re: [PATCH] scsi: snic: fix a couple of spelling mistakes: "COMPLETE"

2018-05-18 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistakes/typos: > "SNIC_IOREQ_ABTS_COMPELTE" -> "SNIC_IOREQ_ABTS_COMPLETE" > "SNIC_IOREQ_LR_COMPELTE" -> "SNIC_IOREQ_LR_COMPLETE" > "SNIC_IOREQ_CMD_COMPELTE" -> "SNIC_IOREQ_CMD_COMPLETE" Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle L

Re: [PATCH] scsi: qlogicpti: Fix an error handling path in 'qpti_sbus_probe()'

2018-05-18 Thread Martin K. Petersen
Christophe, > The 'free_irq()' call is not at the right place in the error handling > path. The changed order has been introduced in commit 3d4253d9afab > ("[SCSI] qlogicpti: Convert to new SBUS device framework.") Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux En

Re: [PATCH v2 00/10] ufshcd optimizations and fixes

2018-05-18 Thread Martin K. Petersen
Asutosh, > This patch set has a bunch of optimizations for UFS HCI. Applied patches 4-8 and 10 to 4.18/scsi-queue. Patches 1-3 were dropped on request and patch 9 needs review. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 04:23:18PM +0200, Alexander Potapenko wrote: > This shall help avoid copying uninitialized memory to the userspace > when calling ioctl(fd, SG_IO) with an empty command. Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-18 Thread Martin K. Petersen
Kees, >> On the quest to remove all VLAs from the kernel[1] this moves the sg_list >> variable off the stack, as already done for other allocated buffers in >> adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). > > Friendly ping! How does this look for v4.18? Applied to 4

Re: [PATCH v3 0/3] Fix UFS and devfreq interaction

2018-05-18 Thread Martin K. Petersen
Bjorn, > With the introduction of f1d981eaecf8 ("PM / devfreq: Use the > available min/max frequency") the UFS host controller driver (UFSHCD) > stopped probing for platforms that supports frequency scaling, > e.g. all modern Qualcomm platforms. Applied to 4.18/scsi-queue. Thank you! -- Martin

Re: [PATCH 1/1] scsi: storvsc: Avoid allocating memory for temp cpumasks

2018-05-18 Thread Martin K. Petersen
Michael, > Current code allocates 240 Kbytes (in typical configs) for each > synthetic SCSI controller to use as temp cpumask variables. Recode to > avoid needing the temp cpumask variables and remove the memory > allocation. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Orac

Re: [PATCH 00/25] zfcp: updates for v4.18

2018-05-18 Thread Martin K. Petersen
Steffen, > this is the zfcp patch set for the v4.18 merge window. The patches > apply to Martin's 4.18/scsi-queue. Applied to 4.18/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/7] Miscellaneous patches and bug fixes

2018-05-18 Thread Martin K. Petersen
Uma, > This patch series adds few improvements to the cxlflash driver and it > also contains couple of bug fixes. Applied to 4.18/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/6] hisi_sas: improve DQ locking

2018-05-18 Thread Martin K. Petersen
John, > This patchset introduces some patches to much improve DQ lockout for > sending commands to the HW. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: dpt_i2o: Remove VLA usage

2018-05-18 Thread Kees Cook
On Wed, May 2, 2018 at 3:21 PM, Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1] this moves the sg_list > variable off the stack, as already done for other allocated buffers in > adpt_i2o_passthru(). Additionally consolidates the error path for kfree(). > > [1] > https://lkml

Re: [PATCH 15/25] workqueue,zfcp: set description for port work items with their WWPN as context

2018-05-18 Thread Tejun Heo
On Thu, May 17, 2018 at 07:14:57PM +0200, Steffen Maier wrote: > As a prerequisite, complement commit 3d1cb2059d93 ("workqueue: include > workqueue info when printing debug dump of a worker task") to be usable > with kernel modules by exporting the symbol set_worker_desc(). > Current built-in user

Re: [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci

2018-05-18 Thread Martin K. Petersen
Alim, > These patches are part of a larger patch series [1] which attempts > upstreaming EXYNOS UFS driver support. There was not much activities > after v5 of that series. In between I saw there were other teams in > Samsung tried upstreaming the same, but that has not really gone > anywhere. I

Re: [PATCH] scsi: ufs: ufshcd: Remove VLA usage

2018-05-18 Thread Martin K. Petersen
Kees, > On the quest to remove all VLAs from the kernel[1] this moves buffers > off the stack. In the second instance, this collapses two separately > allocated buffers into a single buffer, since they are used > consecutively, which saves 256 bytes (QUERY_DESC_MAX_SIZE + 1) of > stack space. Ap

Re: [PATCH] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-05-18 Thread Martin K. Petersen
Alexander, > This shall help avoid copying uninitialized memory to the userspace > when calling ioctl(fd, SG_IO) with an empty command. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-05-18 Thread Alexander Potapenko
This shall help avoid copying uninitialized memory to the userspace when calling ioctl(fd, SG_IO) with an empty command. Reported-by: syzbot+7d26fc1eea198488d...@syzkaller.appspotmail.com Cc: sta...@vger.kernel.org Signed-off-by: Alexander Potapenko Acked-by: Douglas Gilbert Reviewed-by: Johanne

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-18 Thread John Garry
On 04/05/2018 15:50, Sebastian Andrzej Siewior wrote: Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock management duties from lldds") the sas_ata_qc_issue() function unlocks the ata_port.lock and disables interrupts before doing so. That lock is always taken with disabled interrupt

Re: [Drbd-dev] [PATCH 28/42] drbd: switch to proc_create_single

2018-05-18 Thread Lars Ellenberg
On Wed, May 16, 2018 at 11:43:32AM +0200, Christoph Hellwig wrote: > And stop messing with try_module_get on THIS_MODULE, which doesn't make > any sense here. The idea was to increase module count on /proc/drbd access. If someone holds /proc/drbd open, previously rmmod would "succeed" in starting

[Bug 199703] HPSA blocking boot on HP smart Array P400

2018-05-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199703 --- Comment #6 from Roberto M. (roby_program...@fastwebnet.it) --- Sorry I mean kernel 4.14.1 not 4.13.1 -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH] Bsg referencing parent device

2018-05-18 Thread Christoph Hellwig
The idea looks pretty reasonable, but once that is done we can get rid of the ->release callback entirely and just handle it in the callers. Something like the untested patch below: diff --git a/block/bsg-lib.c b/block/bsg-lib.c index fc2e5ff2c4b9..9419def8c017 100644 --- a/block/bsg-lib.c +++ b/b

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 10:43:46AM +0200, Paul Bolle wrote: > > iif->ctr.release_appl = gigaset_release_appl; > > iif->ctr.send_message = gigaset_send_message; > > - iif->ctr.procinfo = gigaset_procinfo; > > Is this intentional? You didn't touch the procinfo method in the other IS

Re: [PATCH 38/42] isdn: replace ->proc_fops with ->proc_show

2018-05-18 Thread Paul Bolle
Hi Christoph, (I don't think the patches of this series ever hit the ISDN related addresses still found in MAINTAINERS. And now I might be a bit late.) Christoph Hellwig schreef op wo 16-05-2018 om 11:43 [+0200]: > diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c > index cc