RE: [PATCH RFC 0/3] Add ufs provisioning support in driver

2018-05-30 Thread sayali
Hi Alex, Thanks for your comments. Yes, I will check the feasibility of using existing sysfs infrastructure and making it writable for configuring provisioning data. Will update my patches accordingly. Thanks, Sayali -Original Message- From: Alex Lemberg [mailto:alex.lemb...@wdc.com]

Re: [RESEND] TCMUser: add read length support

2018-05-30 Thread Bodo Stroesser
On 05/26/18 19:14, kbuild test robot wrote: Hi Bodo, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] Sorry for

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread John Garry
On 30/05/2018 15:28, Sebastian Andrzej Siewior wrote: On 2018-05-30 15:08:37 [+0100], John Garry wrote: On 30/05/2018 14:45, Sebastian Andrzej Siewior wrote: excellent. So no more objections from your side or is this a complaint I didn't fully decode? I think the original code is not great

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread Sebastian Andrzej Siewior
On 2018-05-30 15:08:37 [+0100], John Garry wrote: > On 30/05/2018 14:45, Sebastian Andrzej Siewior wrote: > > excellent. So no more objections from your side or is this a complaint I > > didn't fully decode? > > I think the original code is not great since we're dropping the lock but >

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread John Garry
On 30/05/2018 14:45, Sebastian Andrzej Siewior wrote: On 2018-05-30 14:37:50 [+0100], John Garry wrote: On 30/05/2018 12:22, Sebastian Andrzej Siewior wrote: Yes, there are the same on vanilla and not on RT. However my point is that the code does this instead: local_irq_save();

[Bug 199887] Fibre login failure on older adapters

2018-05-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199887 Jur van der Burg (j...@avtware.com) changed: What|Removed |Added Regression|No |Yes -- You are

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread Sebastian Andrzej Siewior
On 2018-05-30 14:37:50 [+0100], John Garry wrote: > On 30/05/2018 12:22, Sebastian Andrzej Siewior wrote: > > Yes, there are the same on vanilla and not on RT. However my point is > > that the code does this instead: > > local_irq_save(); > > spin_unlock(); > > Ah, I just noticed that

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread John Garry
On 30/05/2018 12:22, Sebastian Andrzej Siewior wrote: On 2018-05-30 12:16:23 [+0100], John Garry wrote: On 30/05/2018 11:16, Sebastian Andrzej Siewior wrote: On 2018-05-30 10:34:12 [+0100], John Garry wrote: Sorry, but personally I don't see much value in this change. I think it's better for

[Bug 199887] New: Fibre login failure on older adapters

2018-05-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199887 Bug ID: 199887 Summary: Fibre login failure on older adapters Product: SCSI Drivers Version: 2.5 Kernel Version: 4.14.44 Hardware: x86-64 OS: Linux Tree:

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread Sebastian Andrzej Siewior
On 2018-05-30 12:16:23 [+0100], John Garry wrote: > On 30/05/2018 11:16, Sebastian Andrzej Siewior wrote: > > On 2018-05-30 10:34:12 [+0100], John Garry wrote: > > > Sorry, but personally I don't see much value in this change. I think it's > > > better for safety to be consistent in how we lock &

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread John Garry
On 30/05/2018 11:16, Sebastian Andrzej Siewior wrote: On 2018-05-30 10:34:12 [+0100], John Garry wrote: Sorry, but personally I don't see much value in this change. I think it's better for safety to be consistent in how we lock & unlock the spinlock, i.e. use irqsave variant (or similar). The

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread Sebastian Andrzej Siewior
On 2018-05-30 10:34:12 [+0100], John Garry wrote: > Sorry, but personally I don't see much value in this change. I think it's > better for safety to be consistent in how we lock & unlock the spinlock, > i.e. use irqsave variant (or similar). The lock should do irqsave() and unlock irqrestore().

Re: [PATCH 1/2] libsas: remove irq save in sas_ata_qc_issue()

2018-05-30 Thread John Garry
On 23/05/2018 10:24, Sebastian Andrzej Siewior wrote: On 2018-05-23 09:46:30 [+0100], John Garry wrote: On 22/05/2018 18:31, Sebastian Andrzej Siewior wrote: On 2018-05-18 14:31:27 [+0100], John Garry wrote: On 04/05/2018 15:50, Sebastian Andrzej Siewior wrote: Since commit 312d3e56119a

Re: [PATCH] aacraid: remove bogus GFP_DMA32 specifies

2018-05-30 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH] aacraid: remove bogus GFP_DMA32 specifies

2018-05-30 Thread Christoph Hellwig
For one GFP_DMA32 does not actually work with kmalloc, as we only have GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32. Second the memory is mapped using the proper DMA API anyway, which would include proper bounce buffering if needed by the device. Signed-off-by: Christoph Hellwig ---