[PATCH] scsi: let __scsi_remove_device do the blk_put_queue in one place

2018-06-20 Thread anthoine . bourgeois
From: Anthoine Bourgeois The function scsi_device_dev_release_usercontext calls blk_put_queue with request_queue then set request_queue to NULL. If the function scsi_device_dev_release_usercontext is racy then the next call to blk_put_queue will trigger the NULL pointer dereference below. As the

[bug report] csiostor:T5 Firmware fix and cleanup.

2018-06-20 Thread Dan Carpenter
Hello Praveen Madhavan, The patch 216ce69c7ff5: "csiostor:T5 Firmware fix and cleanup." from Jan 27, 2015, leads to the following static checker warning: drivers/scsi/csiostor/csio_hw.c:2006 csio_hw_use_fwconfig() warn: was negative '-ENOENT' intended? drivers/scsi/csiost

Re: Grant

2018-06-20 Thread Maratovich M. Fridman
-- I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation: http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-l

Re: [PATCH RFC] sr: mark the device as changed when burning a CD

2018-06-20 Thread Maurizio Lombardi
Hi Jens, Dne 23.5.2018 v 16:42 Jens Axboe napsal(a): > On 5/23/18 3:19 AM, Maurizio Lombardi wrote: >> >> >> Dne 22.5.2018 v 16:47 Jens Axboe napsal(a): >>> It's been many years, but back in the day the program writing the cd >>> would eject the disc once done. This of course forces a reload of >>

Re: [PATCH] scsi: let __scsi_remove_device do the blk_put_queue in one place

2018-06-20 Thread Bart Van Assche
On Wed, 2018-06-20 at 11:57 +0200, anthoine.bourge...@gmail.com wrote: > The function scsi_device_dev_release_usercontext calls blk_put_queue > with request_queue then set request_queue to NULL. If the function > scsi_device_dev_release_usercontext is racy then the next call to > blk_put_queue will

[Bug 199887] Fibre login failure on older adapters

2018-06-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199887 --- Comment #1 from Jur van der Burg (j...@avtware.com) --- I have some more info. First of all, the problem started with kernel V4.11, most likely this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=726b85

Re: [PATCH RFC] sr: mark the device as changed when burning a CD

2018-06-20 Thread Jens Axboe
On 6/20/18 5:52 AM, Maurizio Lombardi wrote: > Hi Jens, > > Dne 23.5.2018 v 16:42 Jens Axboe napsal(a): >> On 5/23/18 3:19 AM, Maurizio Lombardi wrote: >>> >>> >>> Dne 22.5.2018 v 16:47 Jens Axboe napsal(a): It's been many years, but back in the day the program writing the cd would eject

Re: [PATCH] scsi: let __scsi_remove_device do the blk_put_queue in one place

2018-06-20 Thread Anthoine Bourgeois
On Wed, Jun 20, 2018 at 01:50:38PM +, Bart Van Assche wrote: On Wed, 2018-06-20 at 11:57 +0200, anthoine.bourge...@gmail.com wrote: The function scsi_device_dev_release_usercontext calls blk_put_queue with request_queue then set request_queue to NULL. If the function scsi_device_dev_release_

Re: [PATCH] scsi: let __scsi_remove_device do the blk_put_queue in one place

2018-06-20 Thread Bart Van Assche
On Wed, 2018-06-20 at 18:58 +0200, Anthoine Bourgeois wrote: > On Wed, Jun 20, 2018 at 01:50:38PM +, Bart Van Assche wrote: > > On Wed, 2018-06-20 at 11:57 +0200, anthoine.bourge...@gmail.com wrote: > > > The function scsi_device_dev_release_usercontext calls blk_put_queue > > > with request_qu

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-20 Thread Bart Van Assche
On Wed, 2018-06-20 at 09:18 +0530, Chaitra Basappa wrote: > We have tried with calling scsi_internal_device_block_nowait() API before > doing IOC reset (i.e. host reset) and called > scsi_internal_device_unblock_nowait() after performing IOC reset. > We have tested this code change with various tes