[PATCH 3/8] lpfc: Fix list corruption on the completion queue.

2018-07-31 Thread James Smart
Enabling list_debug showed the drivers txcmplq was suffering list corruption. The systems will eventually crash because the iocb free list gets crossed linked with the prings txcmplq. Most systems will run for a while after the corruption, but will eventually crash when a scsi eh reset occurs and

[PATCH 7/8] lpfc: Remove lpfc_enable_pbde as module parameter

2018-07-31 Thread James Smart
Enablement of the PBDE optimization brought out some incompatible behaviors under error scenarios. Best to disable and remove the PBDE optimization. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- 1 file changed, 2 insertions(+), 10

[PATCH 8/8] lpfc: update driver version to 12.0.0.6

2018-07-31 Thread James Smart
Update the driver version to 12.0.0.6 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index

[PATCH 2/8] lpfc: Fix sysfs Speed value on CNA ports

2018-07-31 Thread James Smart
CNA ports were showing speed as "unknown" even if the link is up. Add speed decoding for FCOE-based adapters Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH 6/8] lpfc: Correct LCB ACCept payload

2018-07-31 Thread James Smart
After memory allocation for the LCB response frame, the memory wasn't zero initialized, and not all fields are set. Thus garbage shows up in the payload. Fix by zeroing the memory at allocation. Also properly set the Capability field based on duration support. Signed-off-by: Dick Kennedy

[PATCH 0/8] lpfc updates for 12.0.0.6

2018-07-31 Thread James Smart
This patch contains lpfc bug fixes The patches were cut against the Martin's 4.19/scsi-queue tree James Smart (8): lpfc: Fix ELS abort on SLI-3 adapters lpfc: Fix sysfs Speed value on CNA ports lpfc: Fix list corruption on the completion queue. lpfc: Fix driver crash when re-registering

[PATCH 1/8] lpfc: Fix ELS abort on SLI-3 adapters

2018-07-31 Thread James Smart
For ABORT_XRI_CN command, firmware identifies XRI to abort by IOTAG and RPI combination. For ELS aborts, driver specifies IOTAG correctly but RPI is not specified. Fix by setting RPI in WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 3 +++

[PATCH 5/8] lpfc: Limit tracking of tgt queue depth in fast path

2018-07-31 Thread James Smart
Performance is effected when target queue depth is tracked. An atomic counter is incremented on the submission path which competes with it being decremented on the completion path. In addition multiple CPUs can simultaniously be manipulating this counter for the same ndlp. Reduce the overhead by

[PATCH 4/8] lpfc: Fix driver crash when re-registering NVME rports.

2018-07-31 Thread James Smart
During remote port loss fault testing, the driver crashed with the following trace: general protection fault: [#1] SMP RIP: ... lpfc_nvme_register_port+0x250/0x480 [lpfc] Call Trace: lpfc_nlp_state_cleanup+0x1b3/0x7a0 [lpfc] lpfc_nlp_set_state+0xa6/0x1d0 [lpfc]

[PATCH] scsi: csiostor: remove automatic irq affinity assignment

2018-07-31 Thread Varun Prakash
If number of interrupt vectors are more than num_online_cpus() then pci_alloc_irq_vectors_affinity() assigns cpumask based on num_possible_cpus() to the remaining vectors because of this interrupt does not generate for these vectors. This patch fixes this issue by using pci_alloc_irq_vectors()

Re: FCOE vn2vn memory leaks in 4.14

2018-07-31 Thread ard
Hi, On Tue, Jul 31, 2018 at 10:38:06AM +0200, Johannes Thumshirn wrote: > So I've fixed one use-after-free and one memory leak, but the one you > reported is still on the TODO list. Wow, thanks... > Long story short, I can reproduce it here and I'm working on it. > > Thanks for your patience,

Re: FCOE vn2vn memory leaks in 4.14

2018-07-31 Thread Johannes Thumshirn
On Fri, Jul 27, 2018 at 12:49:55AM +0200, ard wrote: > Actually already got there from my arm dump, but they are different in > backtrace. > Anyway: > root@antec:~# grep -c fc_rport_create kmemleak.txt > 44 > So 44 * 512 bytes leaked in that path. And an extra thing: "it was leaked in" > libfc