On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote:
> However, in previous discussion, it is strongly objected to use
> per-driver/device .use_blk_mq switch, so not sure if this way can
> be accepted.
I don't like the per-driver switch as module_parameter at all and
we should never do that.
On Mon, Sep 17, 2018 at 07:08:55PM +0300, Avri Altman wrote:
> Do that for the currently supported UPIUs:
> query, nop out, and task management.
>
> We do not support UPIU of type scsi command yet, while
> we are using the job's request and reply pointers to hold
> the payload. We will look into
> + lrbp->command_type = hba->ufs_version == UFSHCI_VERSION_10 ||
> + hba->ufs_version == UFSHCI_VERSION_11 ?
> + UTP_CMD_TYPE_DEV_MANAGE :
> + UTP_CMD_TYPE_UFS_STORAGE;
I think a good old if/self or even a switch state
This looks generally fine to me (module comments from Bart).
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Sep 19, 2018 at 11:32:01AM +0800, Jason Yan wrote:
> We are using lldd_port_deformed so we'd better check if lldd_port_deformed
> is NULL.
>
> After this, we can remove hisi_sas_port_deformed() because it is just a
> stub to avoid a NULL dereference caused by the wrong check.
>
The wordi
Looks good,
Reviewed-by: Christoph Hellwig
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Bart Van Assche
> Sent: Wednesday, September 19, 2018 12:41 AM
> To: Avri Altman ; Christoph Hellwig ;
> Johannes Thumshirn ; Hannes Reinecke
> ; James E.J. Bottomley ; Martin K.
> Petersen ; linux-scsi@vger.ker
Bart,
> On Sep 15, 2018, at 9:57 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> @@ -686,7 +686,7 @@ static void qla_nvmet_send_resp_ctio(struct qla_qpair
>> *qpair,
>> ctio->u.nvme_status_mode1.transfer_len =
>>
On Wed, Sep 19, 2018 at 07:14:45AM -0400, James Bottomley wrote:
> A couple of small but important fixes, one affecting big endian and the
> other fixing a BUG_ON in scatterlist processing.
>
> The patch is available here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
A couple of small but important fixes, one affecting big endian and the
other fixing a BUG_ON in scatterlist processing.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Dan Carpenter (1):
scsi: qla2xxx: Fix an end
On 19/09/2018 04:32, Jason Yan wrote:
When the lldd is processing the complete sas task in interrupt and set
the task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to
be triggered at the same time. And smp_task_timedout() will complete the
task wheter the SAS_TASK_STATE_DONE is set o
On 19/09/2018 03:49, Jason Yan wrote:
On 2018/9/17 17:47, John Garry wrote:
On 12/09/2018 09:29, Jason Yan wrote:
When the lldd is processing the complete sas task in interrupt and set
the task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to
be triggered at the same time. And sm
On Wed, Sep 19, 2018 at 11:52:21AM +0800, jianchao.wang wrote:
> Hi Ming
>
> On 09/18/2018 08:15 PM, Ming Lei wrote:
> > The adminq request can be quisced in the scsi_device level, just as normal
> > IO
> > request, because the scsi_device instance is same with normal IO.
>
> Yes, the scsi_queue
18 matches
Mail list logo
