Re: [PATCHv6 0/3] Deprecate DAC960 driver

2018-10-17 Thread Hannes Reinecke
On 10/18/18 3:14 AM, Martin K. Petersen wrote: Hannes, as we're trying to get rid of the remaining request_fn drivers here's a patchset to move the DAC960 driver to the SCSI stack. As per request from hch I've split up the driver into two new SCSI drivers called 'myrb' and 'myrs'. Applied t

Re: [PATCH v2 2/7] drivers/base: Verify struct device locking requirements at runtime

2018-10-17 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 04:40:01PM -0700, Bart Van Assche wrote: > Make sure that a complaint appears in the kernel log if the driver core > locking assumptions are violated. > > Cc: Lee Duncan > Cc: Hannes Reinecke > Cc: Luis Chamberlain > Cc: Johannes Thumshirn > Cc: Christoph Hellwig > Cc:

Re: [PATCH v2 1/7] drivers/base: Fix a race condition in the device probing code

2018-10-17 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 04:40:00PM -0700, Bart Van Assche wrote: > This patch avoids that complaints similar to the following appear in the > system log: > > sysfs: cannot create duplicate filename > '/devices/pseudo_0/adapter0/host3/target3:0:0/3:0:0:133/driver' > > Cc: Lee Duncan > Cc: Hannes

Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-17 Thread Greg KH
On Wed, Oct 17, 2018 at 05:54:56PM -0700, Dan Williams wrote: > On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche wrote: > > > > Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS > > mode, scan devices concurrently. This helps when the wall clock time for > > a single probe is

[PATCH -next] scsi: hisi_sas: Fix missing unlock on error in hisi_sas_phy_read32()

2018-10-17 Thread Wei Yongjun
Add the missing unlock before return from function hisi_sas_phy_read32() in the error handling case. Fixes: 784b46b7cba0 ("scsi: hisi_sas: Use block layer tag instead for IPTT") Signed-off-by: Wei Yongjun --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

Re: [PATCH] scsi: ips: fix missing break in switch

2018-10-17 Thread Finn Thain
On Wed, 17 Oct 2018, Martin K. Petersen wrote: > > >> See the case statements above for another fast exit scenario. > >> > > > > But that's an error path. > > Look further down. Several other SCSI commands are completed as NOPs the > same way. > That's true, but it doesn't indicate a bug to

Re: [PATCH] fnic_scsi: replace gross legacy tag hack with blk-mq hack

2018-10-17 Thread Martin K. Petersen
Jens, > Would be nice to fix up the SCSI midlayer instead, but this will > do for now. Applied to 4.20/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: switch most scsi drivers to the generic DMA API v2

2018-10-17 Thread Martin K. Petersen
Christoph, > A lot of SCSI drivers still use the legacy PCI DMA API. While a few > of them have various oddities that should be deal with separately, > most of them can be very trivially converted over. Applied to 4.20/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: dma-related cleanups for dc95x

2018-10-17 Thread Martin K. Petersen
Christoph, > A few bits found when auditing DMA API use. The first list cleanup > isn't directly related, but I had to to do this first to fully > understand the code.. Applied to 4.20/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/6] mac_esp, zorro_esp, esp_scsi: Various improvements

2018-10-17 Thread Martin K. Petersen
Finn, > This series has fixes and cleanup for mac_esp, zorro_esp and the core > esp_scsi driver. > > These improvements include elimination of duplicated code temporarily > introduced for zorro_esp. Had to hand-apply patch #5. Otherwise OK. Applied to 4.20/scsi-queue. Thank you! -- Martin K.

Re: [PATCHv6 0/3] Deprecate DAC960 driver

2018-10-17 Thread Martin K. Petersen
Hannes, > as we're trying to get rid of the remaining request_fn drivers here's > a patchset to move the DAC960 driver to the SCSI stack. As per > request from hch I've split up the driver into two new SCSI drivers > called 'myrb' and 'myrs'. Applied to 4.20/scsi-queue since Jens already dropp

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

2018-10-17 Thread Martin K. Petersen
YueHaibing, > drivers/scsi/advansys.c: In function 'adv_isr_callback': > drivers/scsi/advansys.c:5952:6: warning: > variable 'srb_tag' set but not used [-Wunused-but-set-variable] > > It never used since introduction in > commit 9c17c62aedb0 ("advansys: use shared host tag map for command looku

Re: [PATCH] scsi: ips: fix missing break in switch

2018-10-17 Thread Martin K. Petersen
Finn, >> See the case statements above for another fast exit scenario. >> > > But that's an error path. Look further down. Several other SCSI commands are completed as NOPs the same way. Also, I don't see how the case statement for TUR/INQUIRY would do anything meaningful in terms of preparin

Re: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

2018-10-17 Thread Martin K. Petersen
Laurence, Patch completely mangled by your mailer, please use git send-email for submissions. I applied the change by hand. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-17 Thread Dan Williams
On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche wrote: > > Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS > mode, scan devices concurrently. This helps when the wall clock time for > a single probe is significantly above the CPU time needed for a single > probe, e.g. when

Re: [PATCH] scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd()

2018-10-17 Thread Martin K. Petersen
Bryant, > There is currently a bug with the driver where there is never a call > to target_sess_cmd_list_set_waiting(), it only called > target_wait_for_sess_cmd(), which basically means that the > sess_wait_list would always be empty. > > Thus, list_empty(&sess->sess_wait_list) = true, (eg: no

Re: [PATCH RESEND] scsi: qla2xxx: I/Os timing out on surprise removal of

2018-10-17 Thread Martin K. Petersen
Himanshu, > When doing a surprise removal of an adapter, some in flight I/Os can get > stuck and take a while to complete (they actually timeout and are > retried). We are not handling an early error exit from > qla2xxx_eh_abort properly. > > Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver un

Re: [PATCH] scsi: ufs: Schedule clk gating work on correct queue

2018-10-17 Thread Martin K. Petersen
Evan, > With commit 10e5e37581fc ("scsi: ufs: Add clock ungating to a separate > workqueue"), clock gating work was moved to a separate work queue with > WQ_MEM_RECLAIM set, since clock gating could occur from a memory > reclaim context. Unfortunately, clk_gating.gate_work was left queued > via

[PATCH v2 4/7] drivers/base, __device_release_driver(): Do not wait for asynchronous probing

2018-10-17 Thread Bart Van Assche
Since __device_release_driver() is called with the device lock held and since the same device lock is obtained by the functions that perform asynchronous probing (driver_attach_async() and __device_attach_async_helper()), asynchronous probing is already serialized against __device_release_driver().

[PATCH v2 5/7] sd: Avoid that hibernation triggers a kernel warning

2018-10-17 Thread Bart Van Assche
Although the power management code never calls the system-wide and runtime suspend callbacks concurrently, runtime power state changes can happen while the system is being suspended or resumed. See also the dpm_suspend() and dpm_resume() calls in hibernation_snapshot(). Make sure the sd driver supp

[PATCH v2 6/7] sd: Rely on the driver core for asynchronous probing

2018-10-17 Thread Bart Van Assche
As explained during the LSF/MM session about increasing SCSI disk probing concurrency, the problems with the current probing approach are as follows: - The driver core is unaware of asynchronous SCSI LUN probing. wait_for_device_probe() waits for all asynchronous probes except asynchronous SCSI

[PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-17 Thread Bart Van Assche
Instead of probing devices sequentially in the PROBE_PREFER_ASYNCHRONOUS mode, scan devices concurrently. This helps when the wall clock time for a single probe is significantly above the CPU time needed for a single probe, e.g. when scanning SCSI LUNs over a storage network. Cc: Lee Duncan Cc: H

[PATCH v2 7/7] sd: Inline sd_probe_part2()

2018-10-17 Thread Bart Van Assche
This patch does not change any functionality. Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis Chamberlain Cc: Johannes Thumshirn Cc: Christoph Hellwig Cc: Greg Kroah-Hartman Signed-off-by: Bart Van Assche --- drivers/scsi/sd.c | 101 -- 1 file change

[PATCH v2 2/7] drivers/base: Verify struct device locking requirements at runtime

2018-10-17 Thread Bart Van Assche
Make sure that a complaint appears in the kernel log if the driver core locking assumptions are violated. Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis Chamberlain Cc: Johannes Thumshirn Cc: Christoph Hellwig Cc: Greg Kroah-Hartman Signed-off-by: Bart Van Assche --- drivers/base/dd.c | 1

[PATCH v2 1/7] drivers/base: Fix a race condition in the device probing code

2018-10-17 Thread Bart Van Assche
This patch avoids that complaints similar to the following appear in the system log: sysfs: cannot create duplicate filename '/devices/pseudo_0/adapter0/host3/target3:0:0/3:0:0:133/driver' Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis Chamberlain Cc: Johannes Thumshirn Cc: Christoph Hellwig C

[PATCH v2 0/7] Increase SCSI disk probing concurrency

2018-10-17 Thread Bart Van Assche
Hello Martin, During the 2018 edition of LSF/MM there was a session about increasing SCSI disk probing concurrency. This patch series implements what has been proposed during that session, namely: - Make sure that the driver core is aware of asynchronous SCSI LUN probing. - Avoid unnecessary seria

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

2018-10-17 Thread Finn Thain
On Wed, 17 Oct 2018, Christoph Hellwig wrote: > > Please leave the possibly unused exports as-is. > I take that to mean "leave the conditional export as-is". Hence, I think v3 (posted on the 16th) should address all of the concerns raised by reviewers... --

Re: [PATCH] scsi/sd: Avoid that hibernation triggers a kernel warning

2018-10-17 Thread Bart Van Assche
On Wed, 2018-10-17 at 13:27 -0700, Bart Van Assche wrote: > Although the power management code never calls the system-wide and runtime > suspend callbacks concurrently, runtime power state changes can happen > while the system is being suspended or resumed. See also the dpm_suspend() > and dpm_resu

Re: [PATCHv5 0/3] Deprecate DAC960 driver

2018-10-17 Thread Martin K. Petersen
Jens, > Martin, are you taking the two new drivers? Then I'll queue up the > old driver removal. Yep! -- Martin K. Petersen Oracle Linux Engineering

Re: SCSI qla2xxx: tcm_qla2xxx target server code regession

2018-10-17 Thread Laurence Oberman
On Mon, 2018-10-15 at 08:51 -0400, Laurence Oberman wrote: > On Sat, 2018-10-13 at 10:42 -0400, Laurence Oberman wrote: > > On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote: > > > On 10/12/18 1:36 PM, Laurence Oberman wrote: > > >  > While I have for the longest time used 4.5 as a base for

[PATCH] scsi/sd: Avoid that hibernation triggers a kernel warning

2018-10-17 Thread Bart Van Assche
Although the power management code never calls the system-wide and runtime suspend callbacks concurrently, runtime power state changes can happen while the system is being suspended or resumed. See also the dpm_suspend() and dpm_resume() calls in hibernation_snapshot(). Make sure the sd driver supp

Re: [PATCH] scsi: ufs: Schedule clk gating work on correct queue

2018-10-17 Thread Stephen Boyd
Quoting Evan Green (2018-10-05 10:27:32) > With commit 10e5e37581fc ("scsi: ufs: Add clock ungating to a separate > workqueue"), clock gating work was moved to a > separate work queue with WQ_MEM_RECLAIM set, since clock > gating could occur from a memory reclaim context. Unfortunately, > clk_gatin

Re: [PATCH] scsi: ufs: Schedule clk gating work on correct queue

2018-10-17 Thread Doug Anderson
Hi, On Fri, Oct 5, 2018 at 10:28 AM Evan Green wrote: > > With commit 10e5e37581fc ("scsi: ufs: Add clock ungating to a separate > workqueue"), clock gating work was moved to a > separate work queue with WQ_MEM_RECLAIM set, since clock > gating could occur from a memory reclaim context. Unfortuna

Re: [PATCH] bsg: convert to use blk-mq

2018-10-17 Thread Jens Axboe
On 10/17/18 12:08 PM, Douglas Gilbert wrote: > On 2018-10-17 11:55 a.m., Benjamin Block wrote: >> On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote: >>> Requires a few changes to the FC transport class as well. >>> >>> Cc: Johannes Thumshirn >>> Cc: Benjamin Block >>> Cc: linux-scsi@vger

RE: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-10-17 Thread Dave.Carroll
> > Am 17.10.18 um 10:14 schrieb Christoph Hellwig: > > On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG > wrote: > >> Hi David, > >> > >> can you give as any hint? We're running aroud 120 Adaptec Controllers > >> and i don't want to replace them all... > > > > 4.15 had a fai

Re: [PATCH] bsg: convert to use blk-mq

2018-10-17 Thread Douglas Gilbert
On 2018-10-17 11:55 a.m., Benjamin Block wrote: On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote: Requires a few changes to the FC transport class as well. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c

Re: [PATCH] scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd()

2018-10-17 Thread Mike Christie
On 10/16/2018 12:34 PM, Ly, Bryant wrote: > From: "Bryant G. Ly" > > There is currently a bug with the driver where there is never a > call to target_sess_cmd_list_set_waiting(), it only called > target_wait_for_sess_cmd(), which basically means that the > sess_wait_list would always be empty. >

For your photos 25

2018-10-17 Thread Jenny
We provide photoshop services to some of the companies from around the world. Some online stores use our services for retouching portraits, jewelry, apparels, furnitures etc. Here are the details of what we provide: Clipping path Deep etching Image masking Portrait retouching Jewelry retouching

For your photos 20

2018-10-17 Thread Jenny
We provide photoshop services to some of the companies from around the world. Some online stores use our services for retouching portraits, jewelry, apparels, furnitures etc. Here are the details of what we provide: Clipping path for photos Deep etching for photos Image masking for photos Port

Re: [PATCH] bsg: convert to use blk-mq

2018-10-17 Thread Jens Axboe
On 10/17/18 9:55 AM, Benjamin Block wrote: > On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote: >> Requires a few changes to the FC transport class as well. >> >> Cc: Johannes Thumshirn >> Cc: Benjamin Block >> Cc: linux-scsi@vger.kernel.org >> Signed-off-by: Jens Axboe >> --- >> block

Re: [PATCH] bsg: convert to use blk-mq

2018-10-17 Thread Benjamin Block
On Tue, Oct 16, 2018 at 08:43:01AM -0600, Jens Axboe wrote: > Requires a few changes to the FC transport class as well. > > Cc: Johannes Thumshirn > Cc: Benjamin Block > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Jens Axboe > --- > block/bsg-lib.c | 102 +-

[RFC PATCH 2/3] target: remove unused session PDU-format-errors metric

2018-10-17 Thread David Disseldorp
Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_stat.c | 14 +- include/target/iscsi/iscsi_target_stat.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_stat.c b/drivers/target/iscsi/iscsi_target_stat.c i

[RFC PATCH 3/3] target: remove cumulative session errors metric

2018-10-17 Thread David Disseldorp
The cumulative session errors metric matches cxn_timeout_errors, so drop the duplicate. Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_stat.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_stat.c b/drivers/target/isc

[RFC PATCH 1/3] target: remove unused session digest-errors metric

2018-10-17 Thread David Disseldorp
Signed-off-by: David Disseldorp --- drivers/target/iscsi/iscsi_target_stat.c | 14 +- include/target/iscsi/iscsi_target_stat.h | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_stat.c b/drivers/target/iscsi/iscsi_target_stat.c i

[RFC PATCH 0/3] target: remove some unused stats

2018-10-17 Thread David Disseldorp
This patchset removes a couple of unused error stat counters and a redundant cumulative counter. I've tagged this patchset RFC, as it may be considered a kernel<->user (configfs) API change. Cheers, David --- drivers/target/iscsi/iscsi_target_stat.c | 40

Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Doug Ledford
On Wed, 2018-10-17 at 11:30 -0400, Doug Ledford wrote: > On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote: > > On 10/17/18 12:20 AM, Hannes Reinecke wrote: > > > The WARN_ON() is pointless as the rport is placed in > > > SDEV_TRANSPORT_OFFLINE > > > at that time, so no new commands can be

Re: [PATCHv6 0/3] Deprecate DAC960 driver

2018-10-17 Thread Jens Axboe
On 10/17/18 9:25 AM, Hannes Reinecke wrote: > Hi all, > > as we're trying to get rid of the remaining request_fn drivers here's > a patchset to move the DAC960 driver to the SCSI stack. > As per request from hch I've split up the driver into two new SCSI > drivers called 'myrb' and 'myrs'. > > Th

Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Doug Ledford
On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote: > On 10/17/18 12:20 AM, Hannes Reinecke wrote: > > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > > at that time, so no new commands can be submitted via srp_queuecommand() > > > > Signed-off-by: Hannes Reinec

[PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

2018-10-17 Thread Hannes Reinecke
This patch adds support for the Mylex DAC960 RAID controller, supporting the older, block-based interface only. The driver is a re-implementation of the original DAC960 driver. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- MAINTAINERS |6 + drivers/scsi/Kconfig

[PATCHv6 0/3] Deprecate DAC960 driver

2018-10-17 Thread Hannes Reinecke
Hi all, as we're trying to get rid of the remaining request_fn drivers here's a patchset to move the DAC960 driver to the SCSI stack. As per request from hch I've split up the driver into two new SCSI drivers called 'myrb' and 'myrs'. The 'myrb' driver only supports the earlier (V1) firmware inte

[PATCH 2/3] myrs: Add Mylex RAID controller (SCSI interface)

2018-10-17 Thread Hannes Reinecke
This patch adds support for the Mylex DAC960 RAID controller, supporting the newer, SCSI-based interface. The driver is a re-implementation of the original DAC960 driver. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- MAINTAINERS |1 + drivers/scsi/Kconfig |

Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-17 Thread Paul Menzel
Dear Greg, On 10/15/18 15:21, Greg Kroah-Hartman wrote: > On Mon, Oct 15, 2018 at 02:17:11PM +0200, Paul Menzel wrote: >> On 10/01/18 17:59, Paul Menzel wrote: >> >>> On 10/01/18 14:43, Paul Menzel wrote: >>> On 10/01/18 14:35, Christoph Hellwig wrote: > On Mon, Oct 01, 2018 at 02:33:07

Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Bart Van Assche
On 10/17/18 12:20 AM, Hannes Reinecke wrote: The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- driver

Re: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

2018-10-17 Thread Ewan Milne
- Original Message - From: "Laurence Oberman" To: "linux-scsi" Cc: "Hannes Reinecke" , "Ewan Milne" , "Bart Van Assche" , "James Bottomley" Sent: Tuesday, October 16, 2018 4:39:16 PM Subject: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message This message floods the

Re: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

2018-10-17 Thread Dupuis, Chad
On Tue, 16 Oct 2018, 4:39pm, Laurence Oberman wrote: > External Email > > This message floods the log when enabling mask 0x7 for > /proc/sys/dev/scsi/logging_level > kernel: scsi_block_when_processing_errors: rtn: 1 > Its not needed and makes tracing just scsi_eh* messages way too v

Re: [PATCHv5 0/3] Deprecate DAC960 driver

2018-10-17 Thread Jens Axboe
On 10/12/18 1:15 AM, Hannes Reinecke wrote: > Hi all, > > as we're trying to get rid of the remaining request_fn drivers here's > a patchset to move the DAC960 driver to the SCSI stack. > As per request from hch I've split up the driver into two new SCSI > drivers called 'myrb' and 'myrs'. > > Th

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

2018-10-17 Thread Johannes Thumshirn
On 17/10/18 15:00, Matthew Wilcox wrote: > On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote: >> On 17/10/18 14:34, YueHaibing wrote: >>> - srb_tag = le32_to_cpu(scsiqp->srb_tag); >>> scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag); >> >> Shouldn't this be: >> s

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

2018-10-17 Thread Matthew Wilcox
On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote: > On 17/10/18 14:34, YueHaibing wrote: > > - srb_tag = le32_to_cpu(scsiqp->srb_tag); > > scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag); > > Shouldn't this be: > scp = scsi_host_find_tag(boardp->shost, >

Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

2018-10-17 Thread Johannes Thumshirn
On 17/10/18 14:34, YueHaibing wrote: > drivers/scsi/advansys.c: In function 'adv_isr_callback': > drivers/scsi/advansys.c:5952:6: warning: > variable 'srb_tag' set but not used [-Wunused-but-set-variable] > > It never used since introduction in > commit 9c17c62aedb0 ("advansys: use shared host ta

[PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback

2018-10-17 Thread YueHaibing
drivers/scsi/advansys.c: In function 'adv_isr_callback': drivers/scsi/advansys.c:5952:6: warning: variable 'srb_tag' set but not used [-Wunused-but-set-variable] It never used since introduction in commit 9c17c62aedb0 ("advansys: use shared host tag map for command lookup") Signed-off-by: YueHai

Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback

2018-10-17 Thread YueHaibing
On 2018/10/17 9:34, Martin K. Petersen wrote: > > Hi Yue Haibing, > >> srb_tag = le32_to_cpu(scsiqp->srb_tag); >> -scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag); >> +scp = scsi_host_find_tag(boardp->shost, srb_tag); > > Maybe I'm missing something, but I don't see where

my subject

2018-10-17 Thread test
I am Peter Wong director of operations, Hong Kong and Shanghai Banking Corporation Limited Hong Kong. I have a very confidential business proposition involving transfer of $18.350.000.00 that will be of great benefit for both of us. Reply for more details as regards this transaction Best Regards P

Re: [PATCH 2/8] powerpc: remove CONFIG_PCI_QSPAN

2018-10-17 Thread Benjamin Herrenschmidt
On Wed, 2018-10-17 at 10:01 +0200, Christoph Hellwig wrote: > This option isn't actually used anywhere. Oh my, that's ancient. Probably didn't make the cut from arch/ppc to arch/powerpc > Signed-off-by: Christoph Hellwig Acked-by: Benjamin Herrenschmidt > --- > arch/powerpc/Kconfig | 9 -

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-10-17 Thread Stefan Priebe - Profihost AG
Am 17.10.18 um 10:14 schrieb Christoph Hellwig: > On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG wrote: >> Hi David, >> >> can you give as any hint? We're running aroud 120 Adaptec Controllers >> and i don't want to replace them all... > > 4.15 had a fair amount of aacrai

RE: [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-10-17 Thread Avri Altman
Hello Bean, > >Usage: > >1) To read current configuration descriptor with index X > > (where index X can be 0/1/2/3) : > > cat /config//ufs_config_desc_X > > > >2) To write configuration descriptor with index X : > > echo > /config//ufs_config_desc_X > > > > > I tested on my platform and go

Re: [v5 2/4] mpt3sas: Fix Sync cache command failure during driver unload

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu wrote: > > This is to fix Sync cache and start stop command > failures with DID_NO_CONNECT during driver unload. > > 1) Release drives first from SML, then remove internally > in driver. > 2) And allow sync cache and Start stop commands to firmware,

Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v2

2018-10-17 Thread Geert Uytterhoeven
Hi Christoph, On Wed, Oct 17, 2018 at 10:03 AM Christoph Hellwig wrote: > currently every architecture that wants to provide on of the common > periphal busses needs to add some boilerplate code and include the > right Kconfig files. This series instead just selects the presence > (when needed)

Re: [v5 3/4] mpt3sas:Fix driver modifying persistent data.

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu wrote: > > * If EEDPTagMode field in manufacturing page11 is set, > unset it. This is needed to fix a hardware bug > in SAS3/SAS2 cards, So, skipping EEDPTagMode changes > in Manufacturing page11 for SAS35 controllers. > > * Fix driver modifying NVRAM

Re: [v5 1/4] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 11:17 AM Andy Shevchenko wrote: > > On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu > wrote: > > > > No functional changes. This section of code > > "wait for IOC to be operational" is used in many places > > across the driver, and hence moved this code in to > > a funct

Re: [PATCH 8/8] kconfig: remove CONFIG_MCA leftovers

2018-10-17 Thread Christoph Hellwig
On Tue, Oct 16, 2018 at 02:20:23PM +0900, Masahiro Yamada wrote: > On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > > > Signed-off-by: Christoph Hellwig > > --- > > > Can you use "powerpc:" or something > for the subject line? > > I'd like to see "kconfig:" only for patches > that

Re: [v5 1/4] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu wrote: > > No functional changes. This section of code > "wait for IOC to be operational" is used in many places > across the driver, and hence moved this code in to > a function "mpt3sas_wait_for_ioc_to_operational()" > + ioc_state = mpt3sa

Re: aacraid: latest driver results in Host adapter abort request. / Outstanding commands on (0,0,0,0):

2018-10-17 Thread Christoph Hellwig
On Tue, Oct 16, 2018 at 07:33:53PM +0200, Stefan Priebe - Profihost AG wrote: > Hi David, > > can you give as any hint? We're running aroud 120 Adaptec Controllers > and i don't want to replace them all... 4.15 had a fair amount of aacraid changes. You can't bisect them by any chance?

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

2018-10-17 Thread Christoph Hellwig
On Tue, Oct 16, 2018 at 04:39:07PM +1100, Finn Thain wrote: > > Perhaps I've misunderstood your concern here. Is it a problem that > esp_scsi.ko may or may not export the function, depending on .config? > > For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y && > !CONFIG_SCSI_

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

2018-10-17 Thread Christoph Hellwig
On Tue, Oct 16, 2018 at 10:52:26AM +1100, Finn Thain wrote: > True enough. We agree that this #ifdef is undesirable. And yet when I > tried it, I found an unexpected readability benefit to your suggestion: > > #ifdef CONFIG_SCSI_ESP_PIO > u8 __iomem *fifo_reg; > int

[PATCH 3/8] powerpc: PCI_MSI needs PCI

2018-10-17 Thread Christoph Hellwig
Various powerpc boards select the PCI_MSI config option without selecting PCI, resulting in potentially not compilable configurations if the by default enabled PCI option is disabled. Explicitly select PCI to ensure we always have valid configs. Signed-off-by: Christoph Hellwig Acked-by: Thomas

[PATCH 5/8] pcmcia: allow PCMCIA support independent of the architecture

2018-10-17 Thread Christoph Hellwig
There is nothing architecture specific in the PCMCIA core, so allow building it everywhere. The actual host controllers will depend on ISA, PCI or a specific SOC. Signed-off-by: Christoph Hellwig Acked-by: Dominik Brodowski Acked-by: Thomas Gleixner --- arch/alpha/Kconfig | 2 -- arch/arm

[PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-17 Thread Christoph Hellwig
There is no good reason to duplicate the PCI menu in every architecture. Instead provide a selectable HAS_PCI symbol that indicates availability of PCI support and the handle the rest in drivers/pci. Note that for powerpc we now select HAVE_PCI globally instead of the convoluted mess of conditiona

[PATCH 1/8] aha152x: rename the PCMCIA define

2018-10-17 Thread Christoph Hellwig
We plan to enable building the PCMCIA core and drivers, and the non-prefixed PCMCIA name clashes with some arch headers. Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- drivers/scsi/aha152x.c | 14 +++--- drivers/scsi/pcmcia/aha152x_core.c | 2 +- 2 files cha

[PATCH 6/8] rapidio: consolidate RAPIDIO config entry in drivers/rapidio

2018-10-17 Thread Christoph Hellwig
There is no good reason to duplicate the RAPIDIO menu in various architectures. Instead provide a selectable HAS_RAPIDIO symbol that indicates native availability of RAPIDIO support and the handle the rest in drivers/pci. This also means we now provide support for PCI(e) to Rapidio bridges for ev

[PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

2018-10-17 Thread Christoph Hellwig
Let architectures opt into EISA support by selecting HAS_EISA and handle everything else in drivers/eisa. Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- arch/alpha/Kconfig | 10 +++--- arch/arm/Kconfig | 16 +--- arch/mips/Kconfig | 31 +---

[PATCH 8/8] kconfig: remove CONFIG_MCA leftovers

2018-10-17 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig Acked-by: Thomas Gleixner --- arch/powerpc/Kconfig | 4 drivers/scsi/Kconfig | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index f2001fff14d1..f3ec13765639 100644 --- a/arch/powerpc/Kco

[PATCH 2/8] powerpc: remove CONFIG_PCI_QSPAN

2018-10-17 Thread Christoph Hellwig
This option isn't actually used anywhere. Signed-off-by: Christoph Hellwig --- arch/powerpc/Kconfig | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a80669209155..e8c8970248bc 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfi

move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/ v2

2018-10-17 Thread Christoph Hellwig
Hi all, currently every architecture that wants to provide on of the common periphal busses needs to add some boilerplate code and include the right Kconfig files. This series instead just selects the presence (when needed) and then handles everything in the bus-specific Kconfig file under drive

RE: [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-10-17 Thread Bean Huo (beanhuo)
Hi, Sayali >Subject: [EXT] [PATCH V15 2/2] scsi: ufs: Add configfs support for UFS >provisioning > >This patch adds configfs support to provision UFS device at runtime. This >feature can be primarily useful in factory or assembly line as some devices >may be required to be configured multiple time

[PATCH v3] scsi: tcmu: avoid cmd/qfull timers updated whenever a new cmd comes

2018-10-17 Thread xiubli
From: Xiubo Li Currently there has one cmd timeout timer and one qfull timer for each udev, and whenever there has any new coming cmd it will update the cmd timer or qfull timer. And for some corner case the timers are always working only for the ringbuffer's and full queue's newest cmd. That's t

Re: [PATCH 2/3] myrs: Add Mylex RAID controller (SCSI interface)

2018-10-17 Thread Christoph Hellwig
On Fri, Oct 12, 2018 at 09:15:47AM +0200, Hannes Reinecke wrote: > This patch adds support for the Mylex DAC960 RAID controller, > supporting the newer, SCSI-based interface. > The driver is a re-implementation of the original DAC960 driver. > > Signed-off-by: Hannes Reinecke > --- > MAINTAINERS

Re: [PATCH 3/3] drivers/block: Remove DAC960 driver

2018-10-17 Thread Christoph Hellwig
On Fri, Oct 12, 2018 at 09:15:48AM +0200, Hannes Reinecke wrote: > The DAC960 driver has been obsoleted by the myrb/myrs drivers, > so it can be dropped. Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/3] myrb: Add Mylex RAID controller (block interface)

2018-10-17 Thread Christoph Hellwig
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 99d366cb0e9f..1efbd175411a 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -922,10 +922,12 @@ > #define PCI_DEVICE_ID_PICOPOWER_PT86C523BBP 0x8002 > > #define PCI_VENDOR_ID_MYLEX 0x106

Re: [PATCH v4 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks

2018-10-17 Thread Christoph Hellwig
> @@ -687,12 +688,8 @@ int sd_zbc_read_zones(struct scsi_disk *sdkp, unsigned > char *buf) >* Check zone size: only devices with a constant zone size (except >* an eventual last runt zone) that is a power of 2 are supported. >*/ > - zone_blocks = sd_zbc_check_zones(sdkp

[PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Hannes Reinecke
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 fil

Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Christoph Hellwig
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c > index e52b9d3c0bd6..c777b36ba62a 100644 > --- a/drivers/nvme/host/fc.c > +++ b/drivers/nvme/host/fc.c > @@ -483,6 +483,8 @@ nvme_fc_signal_discovery_scan(struct nvme_fc_lport *lport, > char hostaddr[FCNVME_TRADDR_LENGTH];/*

[PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Hannes Reinecke
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- driv