Re: [PATCH 0/7] qla2xxx patches for kernel v4.20

2018-10-23 Thread Martin K. Petersen
Bart, > This is a series with mostly trivial patches for the qla2xxx > driver. These patches address warnings reported by gcc and by the > smatch and sparse static analyzers. Please consider these patches for > kernel v4.20. Applied to 4.20/scsi-queue. Thanks! -- Martin K. Petersen

Re: [PATCH 2/8] sg: introduce sg_log macro

2018-10-23 Thread Martin K. Petersen
Hi Doug, > I'll follow what the scsi mid-level and the other ULDs do. IOW, no > change. The debug messages they produce are quite helpful (to me, I > use them a lot, and Tony B. has asked for more precision) and > well-tuned to the SCSI subsystem (e.g. telling us what sdp represents > in useful

[PATCH 09/12] lpfc: Correct loss of fc4 type on remote port address change

2018-10-23 Thread James Smart
An address change for a remote port cause PRLI for the wrong protocol to be sent. The node copy done in the discovery code skipped copying the fc4 protocols supported as well. Fix the copy logic for the address change. Beefed up log messages in this area as well. Signed-off-by: Dick Kennedy

[PATCH 04/12] lpfc: Reset link or adapter instead of doing infinite nameserver PLOGI retry

2018-10-23 Thread James Smart
Currently, PLOGI failures are infinitely delayed/retried. There have been some fabric situations where the PLOGI's were to the nameserver and it stopped responding. The retries would never clear up. A better resolution in this situation is to retry a couple of times, then drop the link and

[PATCH 00/12] lpfc updates for 12.0.0.8

2018-10-23 Thread James Smart
This patch contains lpfc bug fixes and 2 enhancements. The patches were cut against Martin's 4.20/scsi-queue tree James Smart (12): lpfc: Correct speeds on SFP swap lpfc: Fix lpfc_sli4_read_config return value check lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event lpfc:

[PATCH 07/12] lpfc: Correct LCB RJT handling

2018-10-23 Thread James Smart
When LCB's are rejected, if beaconing was already in progress, the Reason Code Explanation was not being set. Should have been set to command in progress. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 12/12] lpfc: update driver version to 12.0.0.8

2018-10-23 Thread James Smart
Update the driver version to 12.0.0.8 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index

[PATCH 08/12] lpfc: Fix odd recovery in duplicate FLOGIs in point-to-point

2018-10-23 Thread James Smart
Testing a point-to-point topology and a case of re-FLOGI without intervening link bouncing, showed an odd interaction with firmware and a resulting scenario where the driver no longer probed after accepting the new FLOGI. Work around the firmware issue by issuing a link bounce if a FLOGI is

[PATCH 10/12] lpfc: Implement GID_PT on Nameserver query to support faster failover

2018-10-23 Thread James Smart
The switches seem to respond faster to GID_PT vs GID_FT NameServer queries. Add support for GID_PT to be used over GID_FT to enable faster storage failover detection. Includes addition of new module parameter to select between GID_PT and GID_FT (GID_FT is default). Signed-off-by: Dick Kennedy

[PATCH 01/12] lpfc: Correct speeds on SFP swap

2018-10-23 Thread James Smart
Supported speeds is not updated when SFP is removed or replaced Supported speed is obtained from lmt field in READ_CONFIG mailbox response. Driver updates supported speeds only once from PCI probe path. After that it is never updated. So, supported speeds remains the same till reboot or driver

[PATCH 03/12] lpfc: Fix LOGO/PLOGI handling when triggerd by ABTS Timeout event

2018-10-23 Thread James Smart
After a LOGO in response to an ABTS timeout, a PLOGI wasn't issued to re-establish the login. A nlp_type check in the LOGO completion handler failed to restart discovery for NVME targets. Revised the nlp_type check for NVME as well as SCSI. While reviewing the LOGO handling a few other issues

[PATCH 06/12] lpfc: fcoe: Fix link down issue after 1000+ link bounces

2018-10-23 Thread James Smart
On FCoE adapters, when running link bounce test in a loop, initiator failed to login with switch switch and required driver reload to recover. Switch reached a point where all subsequent FLOGIs would be LS_RJT'd. Further testing showed the condition to be related to not performing FCF discovery

[PATCH 11/12] lpfc: add Trunking support

2018-10-23 Thread James Smart
Add trunking support to the driver. Trunking is found on more recent asics. In general, trunking appears as a single "port" to the driver and overall behavior doesn't differ. Link speed is reported as an aggregate value, while link speed control is done on a per-physical link basis with all links

[PATCH 02/12] lpfc: Fix lpfc_sli4_read_config return value check

2018-10-23 Thread James Smart
An error is an error - but not to the existing return value check. Revise check to handle any failure, not just EIO. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 05/12] lpfc: Correct errors accessing fw log

2018-10-23 Thread James Smart
This patch corrects two issues: - An oops would occur if reading based on a non-zero offset. Offset calculation was incorrect. - Updates to ras config (logging level) were ignored if change was made while fw logging was enabled. Revise to dynamically update. Signed-off-by: Dick Kennedy

Re: [PATCH] bsg: convert to use blk-mq

2018-10-23 Thread Jens Axboe
On 10/23/18 11:40 AM, Benjamin Block wrote: > On Mon, Oct 22, 2018 at 06:38:36AM -0600, Jens Axboe wrote: >> On 10/22/18 4:03 AM, Benjamin Block wrote: >>> On Fri, Oct 19, 2018 at 09:50:53AM -0600, Jens Axboe wrote: >>> >>> Ok so, that gets past the stage where we initialize the queues. Simple >>>

[PATCH RESEND] Timeouts occur on QLogic adapter surprise removal

2018-10-23 Thread Bill Kuzeja
When doing a surprise removal of an adapter, some in flight I/Os can get stuck and take a while to complete (they actually timeout and are retried). We are not handling an early error exit from qla2xxx_eh_abort properly. Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down

RE: [PATCH RESEND] scsi: qla2xxx: I/Os timing out on surprise removal of

2018-10-23 Thread Kuzeja, William
This is still a bug in 4.20/scsi-queue. I am sending a new patch that applies cleanly to 4.20/scsi-queue as it stands now. I have tested it successfully. Regards -Bill -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Friday, October 19, 2018

Re: [PATCH] bsg: convert to use blk-mq

2018-10-23 Thread Benjamin Block
On Mon, Oct 22, 2018 at 06:38:36AM -0600, Jens Axboe wrote: > On 10/22/18 4:03 AM, Benjamin Block wrote: > > On Fri, Oct 19, 2018 at 09:50:53AM -0600, Jens Axboe wrote: > > > > Ok so, that gets past the stage where we initialize the queues. Simple > > SCSI-I/O also seems to work, that is for