No functional changes. This section of code "wait for IOC to be
operational" is used in many places across the driver. Factor
this code out into a new mpt3sas_wait_for_ioc().
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 73 +++
drivers/scs
Currently driver is modifying both current & NVRAM/persistent data
in Manufacturing page11. Driver should change only current copy of
Manufacturing page11. It should not modify the persistent data.
So removed the section of code where driver is modifying
the persistent data of Manufacturing page11
V7 Change Set:
Split some patches into multiple small patches
as suggested by Bjorn Helgaas
v6 Change Set:
Incorporated changes as suggested by Andy.
In Patch 1 converted while loop to do while in
function mpt3sas_wait_for_ioc_to_operational().
And in patch 3 removed parentheses.
V5 Change Set:
V
Modify driver version to 27.100.00.00
(which is equivalent to PH8 OOB driver)
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
i
Added new #define variable IOC_OPERATIONAL_WAIT_COUNT and
it replaces hard coded value '10' in all the places where driver is
waiting for the IOC to become operational.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
drivers/scsi/mpt3sas/mpt3sas_base.h |
If EEDPTagMode field in manufacturing page11 is set then
unset it. This is needed to fix a hardware bug only
in SAS3/SAS2 cards. So, skipping EEDPTagMode changes
in Manufacturing page11 for SAS 3.5 controllers.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file
Call sas_remove_host() before removing the target devices in the
driver's .remove() callback function(i.e. during driver unload time).
So that driver can provide a way to allow SYNC CACHE, START STOP unit
commands etc. (which are issued from SML) to the target drives during
driver unload time.
Onc
This is to fix SYNC CACHE and START STOP command
failures with DID_NO_CONNECT during driver unload.
In driver's IO submission patch (i.e. in driver's .queuecommand())
driver won't allow any SCSI commands to the IOC when ioc->remove_host
flag is set and hence SYNC CACHE commands which are issued to
No functional change. Doing code refactor of function
mpt3sas_wait_for_ioc() for better readability.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c
On Wed, 31 Oct 2018, Zengtao (B) wrote:
> Hi:
>
> >-Original Message-
> >From: Alan Stern [mailto:st...@rowland.harvard.edu]
> >Sent: Tuesday, October 30, 2018 10:08 PM
> >To: Zengtao (B)
> >Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com;
> >gre...@linuxfoundation.org; linux-scs
On Fri, Oct 19, 2018 at 9:10 PM Christoph Hellwig wrote:
>
> We plan to enable building the PCMCIA core and drivers, and the
> non-prefixed PCMCIA name clashes with some arch headers.
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Thomas Gleixner
> ---
Applied to linux-kbuild.
> drivers
On Fri, Oct 19, 2018 at 9:10 PM Christoph Hellwig wrote:
>
> This option isn't actually used anywhere.
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Benjamin Herrenschmidt
> ---
Applied to linux-kbuild.
> arch/powerpc/Kconfig | 9 -
> 1 file changed, 9 deletions(-)
>
> diff --g
On Fri, Oct 19, 2018 at 9:12 PM Christoph Hellwig wrote:
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Thomas Gleixner
> ---
Applied to linux-kbuild.
> arch/powerpc/Kconfig | 4
> drivers/scsi/Kconfig | 6 +++---
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/ar
On Sat, Oct 20, 2018 at 12:10 AM Josh Triplett wrote:
>
> On Fri, Oct 19, 2018 at 02:09:48PM +0200, Christoph Hellwig wrote:
> > Various powerpc boards select the PCI_MSI config option without selecting
> > PCI, resulting in potentially not compilable configurations if the by
> > default enabled P
On 30/10/18 09:45, Christoph Hellwig wrote:
> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
>> LGTM, for both:
>
> I also have this one on top as requested by Martin. The core block
> bidi support is unfortunately also used by bsg-lib, although it is
> not anywhere near as invasive.
On 10/30/18 1:45 AM, Christoph Hellwig wrote:
> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
>> LGTM, for both:
>
> I also have this one on top as requested by Martin. The core block
> bidi support is unfortunately also used by bsg-lib, although it is
> not anywhere near as invasiv
Hi Christoph,
On Fri, Oct 19, 2018 at 9:58 PM Masahiro Yamada
wrote:
>
> On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux
> wrote:
>
> > > index a68b34183107..b185794549be 100644
> > > --- a/arch/arm/mach-pxa/Kconfig
> > > +++ b/arch/arm/mach-pxa/Kconfig
> > > @@ -125,7 +125,7 @@ config
On 27/10/18 11:20, Christoph Hellwig wrote:
> The only real user of the T10 OSD protocol, the pNFS object layout
> driver never went to the point of having shipping products, and we
> removed it 1.5 years ago. Exofs is just a simple example without
> real life users.
>
> The code has been mostly
On Wed, 2018-10-31 at 18:34 +0200, Boaz Harrosh wrote:
> On 27/10/18 11:20, Christoph Hellwig wrote:
> > The only real user of the T10 OSD protocol, the pNFS object layout
> > driver never went to the point of having shipping products, and we
> > removed it 1.5 years ago. Exofs is just a simple ex
On 31/10/18 19:29, Bart Van Assche wrote:
> On Wed, 2018-10-31 at 18:34 +0200, Boaz Harrosh wrote:
>> On 27/10/18 11:20, Christoph Hellwig wrote:
>>> The only real user of the T10 OSD protocol, the pNFS object layout
>>> driver never went to the point of having shipping products, and we
>>> removed
Straight forward conversion, there's room for improvement.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
drivers/memstick/core/mspro_block.c | 121 +++-
1 file changed, 66 insertions(+), 55 deletions(-)
diff --git a/drivers/memstick/core/mspro_block.c
b/dr
We don't do anything with it, that's just the legacy path.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 3f91c6e5b17a..4c82dc44d4d8 100644
--- a/block/blk-mq.c
+++ b/block/b
This patch series converts the remaining drivers to blk-mq. SCSI
supports both paths, this removes the legacy IO path from SCSI. At the
end, legacy IO code and schedulers are killed off.
I'm not aware of any issues with this series.
This patch series is on top of current -git. It can also be boun
ide-disk and ide-cd tested as working just fine, ide-tape and
ide-floppy haven't. But the latter don't require changes, so they
should work without issue.
Add helper function to insert a request from a work queue, since we
cannot invoke the blk-mq request insertion from IRQ context.
Cc: David Mil
Straight forward conversion, room for optimization in how everything
is punted to a work queue. Also looks plenty racy all over the map,
with the state changes. I fixed a bunch of them up while doing the
conversion, but there are surely more.
Cc: Maxim Levitsky
Reviewed-by: Hannes Reinecke
Signe
Convert from the old request_fn style driver to blk-mq.
Cc: David Miller
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
drivers/block/sunvdc.c | 149 +++--
1 file changed, 98 insertions(+), 51 deletions(-)
diff --git a/drivers/block/sunvdc.c b/d
Nobody is using the legacy path for blk_lld_busy() anymore, remove
it.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-core.c | 2 --
block/blk-settings.c | 6 --
include/linux/blkdev.h | 3 ---
3 files changed, 11 deletions(-)
diff --git a/block/blk-core.c b/b
Since e443343e509a we haven't had a request_fn attached to
this driver, hence any code inside an if (q->request_fn) is
unreachable.
Fixes: e443343e509a ("s390/dasd: blk-mq conversion")
[sth: Keep and fix the dasd_info->chanq_len counter.]
Reviewed-by: Hannes Reinecke
Reviewed-by: Jan Hoeppner
Si
Cc: linux-scsi@vger.kernel.org
Acked-by: Himanshu Madhani
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
Documentation/scsi/scsi-parameters.txt | 5 -
drivers/scsi/Kconfig | 12 -
drivers/scsi/cxlflash/main.c | 6 -
drivers/scsi/hosts.c
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4c82dc44d4d8..a58d2d953876 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -177,8 +177,6 @@ void blk_freeze_queue(struct reques
This will ease in the conversion to blk-mq, where we can't set
a timeout handler after queue init.
Cc: Johannes Thumshirn
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke
Tested-by: Benjamin Block
Signed-off-by: Jens Axboe
---
block/bsg-lib.c | 3 ++-
drivers/sc
Requires a few changes to the FC transport class as well.
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
Tested-by: Benjamin Block
Signed-off-by: Jens Axboe
---
block/bsg-lib.c | 123 +++
drivers/scsi/sc
All drivers do unregister + cleanup, provide a helper for that.
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
Reviewed-by: Christoph Hellwig
Tested-by: Benjamin Block
Signed-off-by: Jens Axboe
---
block/bsg-lib.c | 9 +
It's now unused.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-softirq.c| 20
include/linux/blkdev.h | 1 -
2 files changed, 21 deletions(-)
diff --git a/block/blk-softirq.c b/block/blk-softirq.c
index e47a2f751884..8ca0f6caf174 100644
--- a/blo
Everything is blk-mq at this point, so it doesn't make any sense
to have this option available as it does nothing.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/Kconfig | 6 --
block/blk-wbt.c | 3 +--
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/block/
Get rid of the special bsg job fn and timeout handler, move them
into a private bsg_set instead.
Mostly from Christoph, with fixes for error handling and cleanups.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/bsg-lib.c | 43 ++---
It'll always be false at this point, just remove it.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-merge.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 7fedc0391610..3561dcce2260
We'll hook into this from blk_lld_busy(), allowing blk-mq to also
return whether or not a given queue currently has requests in
progress.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-core.c | 2 ++
include/linux/blk-mq.h | 6 ++
2 files changed, 8 insertions(+)
With the legacy path gone, all we do is funnel it through the
mq_ops->complete() operation.
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 17 -
block/blk-settings.c | 6 --
block/blk-softirq.c| 4 ++--
include/linux/blk-mq.h | 3 ++-
include/linux/blkdev.h |
This is dead code, any queue reaching this part has mq_ops
attached.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-merge.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 3561dcce2260..0128284bded4 100644
--- a/block/blk-m
No point in hiding what this does, just open code it in the
one spot where we are still using it.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-mq.c | 2 +-
include/linux/blkdev.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-mq.c
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-flush.c | 154 +-
block/blk.h | 4 +-
2 files changed, 31 insertions(+), 127 deletions(-)
diff --git a/block/blk-flush.c b/block/blk-flush.c
index 8b44b86779da..9baa9a119447
The only user of legacy timing now is BSG, which is invoked
from the mq timeout handler. Kill the legacy code, and rename
the q->rq_timed_out_fn to q->bsg_job_timeout_fn.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-core.c | 1 -
block/blk-settings.c | 7 ---
b
It's now unused, kill it.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
Documentation/block/biodoc.txt | 88
block/Makefile | 2 +-
block/blk-core.c | 6 -
block/blk-mq-debugfs.c | 2 -
block/blk-mq-tag.c | 6 +-
b
Now there's no difference between blk_put_request() and
__blk_put_request() anymore, get rid of the underscore version and
convert the few callers.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-core.c | 9 -
block/blk-merge.c | 2
Only the SCSI legacy path provides a way to check if target is
currently busy, provide the same for the MQ path.
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
drivers/scsi/scsi_lib.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/sc
This removes a bunch of core and elevator related code. On the core
front, we remove anything related to queue running, draining,
initialization, plugging, and congestions. We also kill anything
related to request allocation, merging, retrieval, and completion.
Remove any checking for single queue
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-core.c | 8
block/blk.h | 1 -
2 files changed, 9 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 0678ec4b1169..951e8cf082e1 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -57,11 +57,
We only support mq devices now.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-cgroup.c | 8
1 file changed, 8 deletions(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 992da5592c6e..5f10d755ec52 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgrou
It's now dead code, nobody uses it.
Reviewed-by: Hannes Reinecke
Signed-off-by: Jens Axboe
---
block/blk-cgroup.c | 47
block/blk-core.c | 75 --
block/blk-mq.c | 4 --
block/blk.h| 3 --
include/linux/
On 2018-10-31 4:57 p.m., Boaz Harrosh wrote:
On 30/10/18 09:45, Christoph Hellwig wrote:
On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
LGTM, for both:
I also have this one on top as requested by Martin. The core block
bidi support is unfortunately also used by bsg-lib, although
On Wed, 31 Oct 2018, Boaz Harrosh wrote:
> > [...] All changes made by other kernel developers than you are the
> > result of tree-wide refactoring, compiler warning fixes, fixes for
> > issues detected by static source code analyzers or spelling fixes.
> > Hence my question: how big is the use
On 31/10/18 23:10, Douglas Gilbert wrote:
> On 2018-10-31 4:57 p.m., Boaz Harrosh wrote:
>> On 30/10/18 09:45, Christoph Hellwig wrote:
>>> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote:
LGTM, for both:
>>>
>>> I also have this one on top as requested by Martin. The core block
>>
On 27/10/18 16:28, Martin K. Petersen wrote:
>
> Bart,
>
>> Removing kernel drivers that are not used helps to reduce the workload
>> of a maintainer and hence is a rational action. Additionally, if
>> anyone would ever complain about removal of a kernel driver, it can be
>> brought back by rever
On 26/10/18 20:54, Nick Desaulniers wrote:
<>
>
> It's hard to say without knowing the original intent of the code.
>>From the variable's identifier and fact that it's global, I *assume*
> that we want only 1 struct osd_obj_id which is the root, hence the
> identifier `osd_root_object`. It has 4
On 26/10/18 00:31, Nathan Chancellor wrote:
> On Tue, Oct 02, 2018 at 04:06:31PM -0700, Bart Van Assche wrote:
<>
>
> Hi Bart,
>
> I'm sorry if I didn't follow the conclusion of this conversation properly
> but this is the below diff you were initially looking for, correct?
>
> If so, Boaz and N
On Thu, Nov 01, 2018 at 03:39:54AM +0200, Boaz Harrosh wrote:
> On 26/10/18 00:31, Nathan Chancellor wrote:
> > On Tue, Oct 02, 2018 at 04:06:31PM -0700, Bart Van Assche wrote:
> <>
> >
> > Hi Bart,
> >
> > I'm sorry if I didn't follow the conclusion of this conversation properly
> > but this is
On Wed, Oct 31, 2018 at 11:58:52AM -0600, Jens Axboe wrote:
> This patch series converts the remaining drivers to blk-mq. SCSI
> supports both paths, this removes the legacy IO path from SCSI. At the
> end, legacy IO code and schedulers are killed off.
>
> I'm not aware of any issues with this ser
Replaced dma_pool_alloc + memset with dma_pool_zalloc
Signed-off-by: Brajeswar Ghosh
Signed-off-by: Souptick Joarder
---
drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/aic94xx/aic94xx_hwi.c
b/drivers/scsi/aic94xx/aic94xx_hw
On Thu, Nov 01, 2018 at 01:05:26AM +0900, Masahiro Yamada wrote:
> > How about letting CONFIG_ARM to select HAVE_PCI ?
> >
>
>
> I applied 1/9, 3/9, 4/9, 5/9.
> (I think 2/9 should be squashed to 9/9)
>
> As Russell pointed out, we need to avoid
> the unmet dependency.
Yes, I think the HAVE_PCI
As part of VMWare performance regression testing for Linux Kernel upstream
releases, when comparing the Linux Kernel 4.19 RC4 to Linux Kernel 4.18GA, we
are able to notice both latency improvements of up to 60% and CPU cost
regressions of up to 23% in our storage tests. Details can be found in t
https://bugzilla.kernel.org/show_bug.cgi?id=201583
Bug ID: 201583
Summary: 4.19.0 mpt3sas generates I/O Error while spinning up
drives
Product: SCSI Drivers
Version: 2.5
Kernel Version: 4.19.0
Hardware: All
From: Anil Gurumurthy
This patch Adds following code in the driver to
support FC-NVMe Target
- Updated ql2xenablenvme to allow FC-NVMe Target operation
- Added Link Service Request handling for NVMe Target
- Added passthru IOCB for LS4 request
- Added CTIO for sending response to FW
- Added FC4
From: Anil Gurumurthy
This patch provides link service pass through feature handling
in the driver. This feature is implemented mainly by the firmware
and the same implementation is handled in the driver via an
IOCB interface.
Signed-off-by: Anil Gurumurthy
Signed-off-by: Giridhar Malavali
Sig
From: Anil Gurumurthy
This patch adds SysFS node for NVMe Target configuration
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 33 +
drivers/scsi/qla2xxx/qla_gs.c | 2 +-
drivers/scsi/qla2xxx/qla_init.c |
Hi Martin,
This series adds support for FC-NVMe Target.
Patch #1 adds infrastructure to support FC-NVMeT Link Service processing.
Patch #2 adds addes new qla_nvmet.[ch] files for FC-NVMe Target support.
Patch #3 has bulk of changes to add hooks into common code infrastucture and
adds
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 12bafff71a1a..0d58aa629c08 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
From: Anil Gurumurthy
This patch adds files to enable NVMe Target Support
Signed-off-by: Anil Gurumurthy
Signed-off-by: Giridhar Malavali
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvmet.c | 795 +++
drivers/s
--
Schönen Tag.
Wir hoffen, Sie gut zu treffen.
Benötigen Sie einen dringenden Kredit für ein Geschäft oder ein Projekt?
Wir bieten Kredite zu 1,5% und wir können Ihre Transaktion innerhalb von
3 bis 5 Arbeitstagen abschließen.
Wenn Sie ernsthaft an einem Kredit interessiert sind, empfehlen
If "interface" is NULL then we can't release it and trying to will only
lead to an Oops.
Fixes: aea71a024914 ("[SCSI] bnx2fc: Introduce interface structure for each
vlan interface")
Signed-off-by: Dan Carpenter
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
70 matches
Mail list logo
