John,
> Hynix ufs has deviations on hi36xx platform which will result in ufs
> bursts transfer failures.
Applied to 4.20/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Janek,
>> Rob reviewed the dt binding patch but has it been merged or should I
>> take both patches through SCSI?
Applied to 4.21/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> Thanks for reviewing both of these. Since the series is hard to break
> apart, are you fine with me carrying this for 4.21 in the block tree?
> I can stage it very soon, which would make it trivial for you to base
> the 4.21 SCSI branch on it to avoid conflicting changes.
Sure, that's f
Sreekanth,
>> Display below warning message only up on detection of
>> Configurable secure type controllers.
Actually, same question as for Shivasharan: Why a warning?
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a warning message when a Configurable secure type controller is
> encountered.
> + dev_warn(&pdev->dev, "Adapter is in configurable secure
> mode\n");
Why warn and not info?
--
Martin K. Peterse
Bill,
> When doing a surprise removal of an adapter, some in flight I/Os can get
> stuck and take a while to complete (they actually timeout and are
> retried). We are not handling an early error exit from
> qla2xxx_eh_abort properly.
Applied to 4.20/scsi-fixes, thank you.
--
Martin K. Pet
Steffen,
> There are too many unresolved issues with DIX outside of zfcp such as
> wrong protection data on writesame/discard (over device-mapper)
We don't configure protected transfers for anything but read and write
commands. There is currently no protection information generated for
WRITE SA
Sreekanth,
> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
Applied to 4.21/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
On Fri, Oct 19, 2018 at 02:09:49PM +0200, Christoph Hellwig wrote:
> There is no good reason to duplicate the PCI menu in every architecture.
> Instead provide a selectable HAVE_PCI symbol that indicates availability
> of PCI support and the handle the rest in drivers/pci.
>
> Note that for powerp
Thanks James. Please let us know.
-- Giri
On 11/8/18, 9:18 AM, "linux-scsi-ow...@vger.kernel.org on behalf of James
Smart"
wrote:
External Email
Madhani,
I'll be looking through it over the weekend.
-- james
On 11/8/2018 8:58 AM, Madhani, Himanshu
Madhani,
I'll be looking through it over the weekend.
-- james
On 11/8/2018 8:58 AM, Madhani, Himanshu wrote:
Hi James,
Any more review comments?
On Oct 31, 2018, at 9:40 AM, Himanshu Madhani
wrote:
Hi Martin,
This series adds support for FC-NVMe Target.
Patch #1 adds infrastructure t
From: Wei Li
Hynix ufs has deviations on hi36xx platform which will result in
ufs bursts transfer failures.
To fix the problem, the Hynix device must set the register
VS_DebugSaveConfigTime to 0x10, which will set time reference
for SaveConfigTime is 250 ns. The time reference for SaveConfigTime
Hi James,
Any more review comments?
> On Oct 31, 2018, at 9:40 AM, Himanshu Madhani
> wrote:
>
> Hi Martin,
>
> This series adds support for FC-NVMe Target.
>
> Patch #1 adds infrastructure to support FC-NVMeT Link Service processing.
> Patch #2 adds addes new qla_nvmet.[ch] files for FC-
On 2018-10-25 10:49 a.m., Martin Wilck wrote:
By scanning for LUN 0 only, we may encounter a device that the
kernel won't add (e.g. peripheral device type 31) and which may
thus never appear in sysfs for us to use for REPORT LUNS. That
causes LUN additions for such devices to be missed by
"rescan
Also clarify namespace prefix for the timeout used for FSF requests
on behalf of SCSI error recovery: It is zfcp_fsf_ not zfcp_scsi_.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 6 --
drivers/s390/scsi/zfcp_fsf.c | 9 +++--
2 files changed
James, Martin,
this is the zfcp patch set for the v4.21 merge window.
The patches apply to Martin's 4.21/scsi-queue
and to James' misc branch.
Patch 1 is a small feature to select DIF only without DIX.
Patches 2-23 are cleanups including resolving new build warnings.
Fedor Loshakov (1):
zfcp:
v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements")
extended this mask by one nibble with the introduction of
ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x0080 for ACT
(access control table).
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfc
On Thu, 2018-10-25 at 10:49 +0200, Martin Wilck wrote:
> By scanning for LUN 0 only, we may encounter a device that the
> kernel won't add (e.g. peripheral device type 31) and which may
> thus never appear in sysfs for us to use for REPORT LUNS. That
> causes LUN additions for such devices to be mi
Improve whatever the following simple invocation reported:
$ ./scripts/kernel-doc -none drivers/s390/scsi/*.h
While at it, improve some related kdoc,
including struct zfcp_fsf_ct_els in zfcp_fsf.h.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.h |
zfcp: : LUN 0x0 on port 0x5005076. ...
zfcp: : LUN 0x1 on port 0x5005076. ...
should be
zfcp: : LUN 0x on port 0x5005076. ...
zfcp: : LUN 0x0001 on port 0x5005076.
is already in use by CSS., MIF Image ID .
This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix
missing REC trigger trace for all objects in ERP_FAILED") but would now
suppress helpful -Wswitch compiler warnings when building with W=1 such as
the following forced example:
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_
This was introduced with v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup
code in zfcp_erp.c") but would now suppress helpful -Wswitch compiler
warnings when building with W=1 such as the following forced example:
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_setup_act':
drivers/s390/scsi/
While at it also improve some copy&paste kdoc mistakes.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_dbf.c | 13 -
drivers/s390/scsi/zfcp_erp.c | 6 +++---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/s390/scsi/zfcp_fsf.c | 14 +--
Use the already defined enum for this purpose to get at least some build
checking (even though an enum is type equivalent to an int in C).
v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in zfcp_erp.c")
introduced the enum which was cpp defines previously.
Since struct zfcp_erp_action type
For some reason the already existing substring "fall through" in the
comment is not sufficient for GCC to silence -Wimplicit-fallthrough.
CC [M] drivers/s390/scsi/zfcp_erp.o
drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_lun_strategy':
drivers/s390/scsi/zfcp_erp.c:1065:6: warning: this sta
zfcp_erp_thread_setup() update complements v2.6.32 commit 347c6a965dc1
("[SCSI] zfcp: Use kthread API for zfcp erp thread").
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_erp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390
With that instead of just "int" it becomes clear which functions return
this type and which ones also accept it as argument they just pass through
in some cases or modify in other cases.
v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in zfcp_erp.c")
introduced the enum which was cpp define
v2.6.30 commit 5ffd51a5e495 ("[SCSI] zfcp: replace current ERP logging
with a more convenient version") changed trace record distinguishing from a
numerical ID to a 7 character string called "trace tag". While starting to
use function arguments with different type and semantics, it did not change
t
&zfcp_erp_action.action ==> &zfcp_erp_action.type
While at it, make use of the already defined enum for this purpose
to get at least some build checking (even though an enum is type equivalent
to an int in C). v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code
in zfcp_erp.c") introduced the e
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 31b3e2bb3b42..572debf2f528 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390
While struct zfcp_adapter contains a pointer to zfcp_reqlist,
the pointer field does not need to know the structure or even a prototype.
The prototype was introduced with v2.6.34 commit b6bd2fb92a7b ("[SCSI]
zfcp: Move FSF request tracking code to new file").
Signed-off-by: Steffen Maier
Reviewe
Status read buffers (SRBs, unsolicited notifications) never use a QTCB
[zfcp_fsf_req_create()]. zfcp_fsf_req_send() already uses this to
distinguish SRBs from other FSF request types. We can re-use this method
in zfcp_fsf_req_complete(). Introduce a helper function to make the check
for req->qtcb l
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_fsf.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
di
There is no point for double bookkeeping especially just for tracing.
The trace can take it from the QTCB which always exists for non-SRB
responses traced with zfcp_dbf_hba_fsf_res().
As a side effect, this removes an alignment hole and reduces the
size of struct zfcp_fsf_req, and thus of each pen
Since commit 663e0890e31c ("[SCSI] zfcp: remove access control tables
interface") these helper functions are only used for auto port scan in
zfcp_fc.c. Also change them to the corresponding namespace prefix.
This is a small cleanup for the miscellaneous catchall compile unit
zfcp_aux.c.
Signed-of
Have structures just before the structures that use them
(without disrupting sequences of using structures such as
zfcp_unit and zfcp_scsi_dev):
- zfcp_adapter_mempool embedded in zfcp_adapter,
- zfcp_latenc... embedded in zfcp_scsi_dev.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
In contrast to struct fsf_qual_latency_info, the ones here are not FSF
but software defined zfcp-internal.
Signed-off-by: Steffen Maier
Reviewed-by: Benjamin Block
---
drivers/s390/scsi/zfcp_def.h | 14 +++---
drivers/s390/scsi/zfcp_fsf.c | 4 ++--
2 files changed, 9 insertions(+), 9 d
From: zhong jiang
mempool_destroy has taken null pointer check into account. so remove the
redundant check.
Signed-off-by: zhong jiang
Acked-by: Benjamin Block
[ma...@linux.ibm.com: depends on v4.3 4e3ca3e033d1 ("mm/mempool: allow NULL
`pool' pointer in mempool_destroy()")]
Signed-off-by: Ste
From: Fedor Loshakov
There are too many unresolved issues with DIX outside of zfcp
such as wrong protection data on writesame/discard (over device-mapper)
or due to unstable page writes.
This can cause I/O stalls or endless loops or even kernel panics,
or I/O errors due to erroneously failed logi
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/qedi/qedi_main.c: In function 'qedi_queue_cqe':
drivers/scsi/qedi/qedi_main.c:1105:21: warning:
variable 'conn' set but not used [-Wunused-but-set-variable]
It never used since introduction in commit
ace7f46ba5fd ("scsi: qedi: Add QLogi
Display below warning message only up on detection of
Configurable secure type controllers.
"HBA is in Configurable Secure mode"
Signed-off-by: Sreekanth Reddy
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mpt3sa
41 matches
Mail list logo
