On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> Unused now.
>
> Signed-off-by: Christoph Hellwig
> ---
> include/linux/blkdev.h | 10 --
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 9b1f470cc784..55597948868b 10
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> Remove the last use of the old BLKPREP_* values, which get converted
> to BLK_STS_* later anyway.
Reviewed-by: Bart Van Assche
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> Replace the old BLKRREP_* values with the BLK_STS_ ones that they are
> converted to later anyway.
Just noticed a typo: I think BLKRREP_ should be changed into BLKPREP_.
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> Replace the old BLKRREP_* values with the BLK_STS_ ones that they are
> converted to later anyway.
Reviewed-by: Bart Van Assche
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> There is no need to call scsi_mq_free_sgtables until we have actually
> allocated sgtables.
Reviewed-by: Bart Van Assche
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> This just moves the prep_to_mq calls up in preparation of further removal
> of BLKPREP_* usage.
Reviewed-by: Bart Van Assche
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> The return value is just used as a binary yes/no decicsion, so switch
> it to a bool instead of the old BLKPREP_* values returned as an int.
Reviewed-by: Bart Van Assche
On Fri, 2018-11-09 at 14:42 +0100, Christoph Hellwig wrote:
> Return a blk_status_t directly, and make the code a little more compact
> by handling the fast path in the caller.
Reviewed-by: Bart Van Assche
On 2018-11-09 7:18 p.m., Bean Huo (beanhuo) wrote:
This patch is to convert inputted string to the integer when
read data from stdin. While entering data, the data between bytes
can be separated by space, or by ',' or by '.'.
Could you send me this patch against sg_write_buffer.c as found
in th
Hi,
Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y
enabled report kobject lifetime issues when booting an image in qemu
using virtio-scsi-pci.
Bisect points to two different commits, depending on the kernel
configuration.
1st configuration: defconfig plus:
CONFIG_VIRTIO_BLK=
On Friday 09 November 2018 16:45:54 Christoph Hellwig wrote:
> aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
> also isn't portable enough. Convert it to the proper DMA mapping API.
>
> Thanks to Ondrej Zary for testing and finding and fixing a crucial
> bug.
>
> Signed-
This patch is to convert inputted string to the integer when
read data from stdin. While entering data, the data between bytes
can be separated by space, or by ',' or by '.'.
Signed-off-by: Bean Huo
---
src/sg_write_buffer.c | 31 +++
1 file changed, 31 insertions(+)
This patch adds support for MegaRAID Aero controller PCI IDs.
Throw a message when a Configurable secure type controller is
encountered.
Signed-off-by: Shivasharan S
---
Changes in v2:
Change dev_warn to dev_info.
drivers/scsi/megaraid/megaraid_sas.h | 4
drivers/scsi/megaraid/megara
On Fri, Nov 9, 2018 at 7:43 AM Martin K. Petersen
wrote:
> Shivasharan,
>
> > This patch adds support for MegaRAID Aero controller PCI IDs.
> > Throw a warning message when a Configurable secure type controller is
> > encountered.
>
> > + dev_warn(&pdev->dev, "Adapter is in configurabl
On Fri, Oct 19, 2018 at 09:42:28AM +1100, Finn Thain wrote:
> On Thu, 18 Oct 2018, Christoph Hellwig wrote:
>
> > Switch from the legacy PCI DMA API to the generic DMA API. Also switch
> > to dma_map_single from pci_map_page in one case where this makes the code
> > simpler.
> >
> > Signed-off-b
Assalamu alaikum,
I came across your e-mail contact prior a private search while in need
of a
trusted person. My name is Mrs. Aisha Gaddafi, a single Mother and a
Widow
with three Children. I am the only biological Daughter of late Libyan
President (Late Colonel Muammar Gaddafi)I have a busine
> >
> > -buf = gdth_ioctl_alloc(ha, GDTH_SCRATCH, FALSE, &paddr);
> > if (!buf)
> > goto stop_output;
>
> I think this !buf test is redundant.
Thanks,
fixed.
> > + switch (gen.command.OpCode) {
> > + case GDT_IOCTL:
> > + gen.command.u.ioctl.p_param = paddr;
> > + break;
> > + case CACHESERVICE:
> > + gdth_ioc_cacheservice(ha, &gen, paddr);
> > + break;
> > + case SCSIRAWSERVICE:
> > + gdth_ioc_s
Add the SCB onto the scsi command allocation and use dma streaming
mappings for it only when in use. This avoid possibly calling
dma_alloc_coherent under a lock or even in irq context, while also
making the code simpler.
Thanks to Ondrej Zary for testing and various bug fixes.
Signed-off-by: Chr
The wd719x driver currently uses a mix of the legacy PCI DMA and
the generic DMA APIs. Switch it over to the generic DMA API entirely.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/wd719x.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git
So warn on that case instead of trying to free them, which would be fatal
in case we actuall had active ones.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/wd719x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 97
Various dma relates cleanups
Changes since v1:
- include important fixes from Ondrej
On 11/9/18 6:42 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> this series gets rid of the old BLKPREP_* values from the legacy block
> layer in favor of always using a blk_status_t (or a bool in one case).
Series looks good to me, tested the IDE bits too. I'm assuming we'll
take this through the bl
aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
also isn't portable enough. Convert it to the proper DMA mapping API.
Thanks to Ondrej Zary for testing and finding and fixing a crucial
bug.
Signed-off-by: Christoph Hellwig
Tested-by: Ondrej Zary
---
drivers/scsi/aha154
This patchset adds 2 forms of interrupt aggregation support to the
driver:
- Interrupt converge: Interrupts from all completion queues can be
reported through completion queue #0 interrupt only.
- Interrupt coalesce: Ability to set timeout period at which we report
From: Xiang Chen
If INT_COAL_EN is enabled, config time and count of interrupt coalescing.
Then if CQ collects count of CQ entries in time, it will report the
interrupt. Or if CQ doesn't collect enough CQ entries in time, it Will
report the interrupt at timeout.
As all the registers are not supp
From: Xiang Chen
If CQ_INT_CONVERGE_EN is enabled, the interrupts of all the 16 CQ queues
will be reported by CQ0.
So we need to change the process of CQ tasklet for this situation.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 29 ++
From: Xiang Chen
Currently all the three HBA (v1/v2/v3 HW) share the same host attribute.
To support each HBA having separate attributes in future, create per-HBA
attributes.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 -
drivers/scsi/hi
From: Xiang Chen
Currently the time of SAS SSP connection is 1ms, which means the link
connection will fail if no IO response after this period.
For some disks handling large IO (such as 512k), 1ms is not enough, so
change it to 5ms.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
dr
From: Xiang Chen
In function hisi_sas_task_prep(), we check asd_sas_port, but in function
hisi_sas_task_exec(), we already refer to asd_sas_port by using function
dev_to_hisi_hba() implicitly. So to avoid this possible invalid
dereference, relocate the check to function hisi_sas_task_prep().
Sig
So long and thanks for all the fish,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Gra
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Look good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nü
Unused now.
Signed-off-by: Christoph Hellwig
---
include/linux/blkdev.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 9b1f470cc784..55597948868b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -778,16 +778
Remove the last use of the old BLKPREP_* values, which get converted
to BLK_STS_* later anyway.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/device_handler/scsi_dh_alua.c | 21 +++--
drivers/scsi/device_handler/scsi_dh_emc.c | 8
drivers/scsi/device_handler/scsi
Replace the old BLKRREP_* values with the BLK_STS_ ones that they are
converted to later anyway.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c| 45 ++--
drivers/scsi/sd.c | 85 +-
drivers/scsi/sd.h | 6 +--
Hi Jens,
this series gets rid of the old BLKPREP_* values from the legacy block
layer in favor of always using a blk_status_t (or a bool in one case).
This just moves the prep_to_mq calls up in preparation of further removal
of BLKPREP_* usage.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c | 45 ++---
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/dri
The return value is just used as a binary yes/no decicsion, so switch
it to a bool instead of the old BLKPREP_* values returned as an int.
Also clean up a few related comments.
Signed-off-by: Christoph Hellwig
---
drivers/ide/ide-cd.c | 22 +++---
drivers/ide/ide-disk.c | 8 +
Return a blk_status_t directly, and make the code a little more compact
by handling the fast path in the caller.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c | 102 +++-
1 file changed, 48 insertions(+), 54 deletions(-)
diff --git a/drivers/sc
There is no need to call scsi_mq_free_sgtables until we have actually
allocated sgtables.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index e665c
On 11/8/18 7:28 PM, Martin K. Petersen wrote:
>
> Jens,
>
>> Thanks for reviewing both of these. Since the series is hard to break
>> apart, are you fine with me carrying this for 4.21 in the block tree?
>> I can stage it very soon, which would make it trivial for you to base
>> the 4.21 SCSI bra
John,
> I am building your 4.21 queue today, and it seems to be broken from
> this patch:
>
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/b3874a425510d1164fd3428ab99273c07d210d82
>
> You seemed to miss adding the c-file:
> make[3]: *** No rule to make target `drivers/scsi
On 09/11/2018 02:28, Martin K. Petersen wrote:
Janek,
Rob reviewed the dt binding patch but has it been merged or should I
take both patches through SCSI?
Applied to 4.21/scsi-queue. Thank you!
Hi Martin,
I am building your 4.21 queue today, and it seems to be broken from this
patch:
Hi Martin,
On 11/09/2018 03:07 AM, Martin K. Petersen wrote:
There are too many unresolved issues with DIX outside of zfcp such as
wrong protection data on writesame/discard (over device-mapper)
We don't configure protected transfers for anything but read and write
commands. There is currently
Display below warning message only up on detection of
Configurable secure type controllers.
"HBA is in Configurable Secure mode"
v2 change set:
Replaced dev_warn() with dev_info() function while
displaying above message.
Signed-off-by: Sreekanth Reddy
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c |
48 matches
Mail list logo
