[PATCH AUTOSEL 4.19 05/73] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-12-12 Thread Sasha Levin
From: Cathy Avery [ Upstream commit 02f425f811cefcc4d325d7a72272651e622dc97e ] Currently pvscsi_remove calls free_irq more than once as pvscsi_release_resources and __pvscsi_shutdown both call pvscsi_shutdown_intr. This results in a 'Trying to free already-free IRQ' warning and stack trace. To s

[PATCH AUTOSEL 4.19 04/73] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-12-12 Thread Sasha Levin
From: Fred Herard [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ] This commit addresses NULL pointer dereference in iscsi_eh_session_reset. Reference should not be made to session->leadconn when session->state is set to ISCSI_STATE_TERMINATE. Signed-off-by: Fred Herard Reviewed-by

[PATCH AUTOSEL 4.14 04/41] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-12-12 Thread Sasha Levin
From: Cathy Avery [ Upstream commit 02f425f811cefcc4d325d7a72272651e622dc97e ] Currently pvscsi_remove calls free_irq more than once as pvscsi_release_resources and __pvscsi_shutdown both call pvscsi_shutdown_intr. This results in a 'Trying to free already-free IRQ' warning and stack trace. To s

[PATCH AUTOSEL 4.9 03/34] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-12-12 Thread Sasha Levin
From: Cathy Avery [ Upstream commit 02f425f811cefcc4d325d7a72272651e622dc97e ] Currently pvscsi_remove calls free_irq more than once as pvscsi_release_resources and __pvscsi_shutdown both call pvscsi_shutdown_intr. This results in a 'Trying to free already-free IRQ' warning and stack trace. To s

[PATCH AUTOSEL 4.9 02/34] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-12-12 Thread Sasha Levin
From: Fred Herard [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ] This commit addresses NULL pointer dereference in iscsi_eh_session_reset. Reference should not be made to session->leadconn when session->state is set to ISCSI_STATE_TERMINATE. Signed-off-by: Fred Herard Reviewed-by

[PATCH AUTOSEL 4.4 03/23] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-12-12 Thread Sasha Levin
From: Cathy Avery [ Upstream commit 02f425f811cefcc4d325d7a72272651e622dc97e ] Currently pvscsi_remove calls free_irq more than once as pvscsi_release_resources and __pvscsi_shutdown both call pvscsi_shutdown_intr. This results in a 'Trying to free already-free IRQ' warning and stack trace. To s

[PATCH AUTOSEL 4.4 02/23] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-12-12 Thread Sasha Levin
From: Fred Herard [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ] This commit addresses NULL pointer dereference in iscsi_eh_session_reset. Reference should not be made to session->leadconn when session->state is set to ISCSI_STATE_TERMINATE. Signed-off-by: Fred Herard Reviewed-by

[PATCH AUTOSEL 3.18 01/16] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-12-12 Thread Sasha Levin
From: Fred Herard [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ] This commit addresses NULL pointer dereference in iscsi_eh_session_reset. Reference should not be made to session->leadconn when session->state is set to ISCSI_STATE_TERMINATE. Signed-off-by: Fred Herard Reviewed-by

[PATCH AUTOSEL 3.18 02/16] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload

2018-12-12 Thread Sasha Levin
From: Cathy Avery [ Upstream commit 02f425f811cefcc4d325d7a72272651e622dc97e ] Currently pvscsi_remove calls free_irq more than once as pvscsi_release_resources and __pvscsi_shutdown both call pvscsi_shutdown_intr. This results in a 'Trying to free already-free IRQ' warning and stack trace. To s

[PATCH AUTOSEL 4.14 03/41] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-12-12 Thread Sasha Levin
From: Fred Herard [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ] This commit addresses NULL pointer dereference in iscsi_eh_session_reset. Reference should not be made to session->leadconn when session->state is set to ISCSI_STATE_TERMINATE. Signed-off-by: Fred Herard Reviewed-by

Re: [PATCH -next] scsi: ufs: Fix platform_no_drv_owner.cocci warnings

2018-12-12 Thread Martin K. Petersen
YueHaibing, > Remove .owner field if calls are used which set it automatically > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/4] mpt3sas: Fix hardware bug in aero controllers.

2018-12-12 Thread Martin K. Petersen
Suganath, > Sometimes aero controllers appears to be returning bad data (0) for > doorbell register read and if retries are performed immediately after > the bad read, they return good data. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 0/5] hisi_sas: DIF support

2018-12-12 Thread Martin K. Petersen
John, > This patchset introduces support to the driver for DIF/DIX. Applied 1-3 to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw

2018-12-12 Thread Martin K. Petersen
John, > +static void fill_prot_v3_hw(struct scsi_cmnd *scsi_cmnd, > + struct hisi_sas_protect_iu_v3_hw *prot) > +{ > + u8 prot_type = scsi_get_prot_type(scsi_cmnd); > + u8 prot_op = scsi_get_prot_op(scsi_cmnd); > + unsigned int interval = scsi_prot_interval(sc

Re: [PATCH 0/4] qla2xxx: Enable NPIV support for FC-NVMe capable ports

2018-12-12 Thread Martin K. Petersen
Himanshu, > This series adds support for NPIV on FC-NVMe enabled ports. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] scsi: aacraid: change wait_sem to a completion

2018-12-12 Thread Martin K. Petersen
Arnd, > The wait_sem member is used like a completion, so we should use the > respective API. The behavior is unchanged. Applied to 4.21/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH repost] lpfc: Enable Management features for IF_TYPE=6

2018-12-12 Thread Martin K. Petersen
James, > Addition of support for if_type=6 missed several checks for interface > type, resulting in the failure of several key management features such > as firmware dump and loopback testing. > > Correct the checks on the if_type so that both SLI4 IF_TYPE's 2 and 6 > are supported. Applied to

Re: [PATCH 09/15] lpfc: ls_rjt erroneus FLOGIs

2018-12-12 Thread Martin K. Petersen
James, > Can you please revert this patch from 4.21/scsi-queue ? scsi: lpfc: > ls_rjt erroneus FLOGIs commit 287aba2592870fa5b76134b28173b77f1f7a4492 > > We killed the bad firmware and this mod is no longer necessary. Done. I would have like to have a clean history but it's a bit late in the c

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Martin K. Petersen
Jens, > When boxes are run near (or to) OOM, we have a problem with the > discard page allocation in sd. If we fail allocating the special page, > we return busy, and it'll get retried. But since ordering is honored > for dispatch requests, we can keep retrying this same IO and > failing. Behind

Re: [PATCH 09/15] lpfc: ls_rjt erroneus FLOGIs

2018-12-12 Thread James Smart
Martin, Can you please revert this patch from 4.21/scsi-queue ? scsi: lpfc: ls_rjt erroneus FLOGIs commit287aba2592870fa5b76134b28173b77f1f7a4492 We killed the bad firmware and this mod is no longer necessary. -- james On 11/29/2018 4:09 PM, James Smart wrote: In some link initialization

It may be a suprise reading from me now.

2018-12-12 Thread emmanuel kodjo
Hello good day! I am attorney Barr.Emmanuel Kodjovi Okumayi, personal lawyer to my late client a foreign construction engineer who was a resident here in Lome Togo.My client died with his family while on holiday in Phuket, Thailand on December 2004, in an Asia earthquake disaster (tsunami) I decid

Re: [PATCH repost] lpfc: Enable Management features for IF_TYPE=6

2018-12-12 Thread Ewan D. Milne
On Mon, 2018-12-10 at 19:37 -0800, James Smart wrote: > Addition of support for if_type=6 missed several checks for interface > type, resulting in the failure of several key management features > such as firmware dump and loopback testing. > > Correct the checks on the if_type so that both SLI4 IF

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Jens Axboe
On 12/12/18 8:33 AM, Jens Axboe wrote: > On 12/12/18 8:32 AM, Christoph Hellwig wrote: >> On Wed, Dec 12, 2018 at 08:22:37AM -0700, Jens Axboe wrote: >>> That one is a little worse, since we only need a full page if we >>> use all 256 segments. I don't want to make the fast case of >>> 16 bytes sin

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Jens Axboe
On 12/12/18 8:32 AM, Christoph Hellwig wrote: > On Wed, Dec 12, 2018 at 08:22:37AM -0700, Jens Axboe wrote: >> That one is a little worse, since we only need a full page if we >> use all 256 segments. I don't want to make the fast case of >> 16 bytes single segment allocs get a full page, so we hav

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Christoph Hellwig
On Wed, Dec 12, 2018 at 08:22:37AM -0700, Jens Axboe wrote: > That one is a little worse, since we only need a full page if we > use all 256 segments. I don't want to make the fast case of > 16 bytes single segment allocs get a full page, so we have to > track if we used kmalloc() or mempool_alloc(

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Jens Axboe
On 12/12/18 7:35 AM, Jens Axboe wrote: > On 12/12/18 7:21 AM, Christoph Hellwig wrote: >> Looks good: >> >> Reviewed-by: Christoph Hellwig >> >> Note that NVMe will need the same treatment. > > Indeed, I'll prep one for that too. That one is a little worse, since we only need a full page if we u

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Jens Axboe
On 12/12/18 7:21 AM, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > Note that NVMe will need the same treatment. Indeed, I'll prep one for that too. -- Jens Axboe

Re: [PATCH] sd: use mempool for discard special page

2018-12-12 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig Note that NVMe will need the same treatment.

[PATCH] sd: use mempool for discard special page

2018-12-12 Thread Jens Axboe
When boxes are run near (or to) OOM, we have a problem with the discard page allocation in sd. If we fail allocating the special page, we return busy, and it'll get retried. But since ordering is honored for dispatch requests, we can keep retrying this same IO and failing. Behind that IO could be r