On 01/11/2017 10:15 AM, Hanjun Guo wrote:
> On 2017/1/11 9:50, Aaron Lu wrote:
>> On 01/10/2017 07:44 PM, John Garry wrote:
>>> On 10/01/2017 08:14, Hanjun Guo wrote:
>>>> From: Hanjun Guo <hanjun@linaro.org>
>>>>
>>>> commi
i_unregister_acpi_bus_type(),
>> but forgot to remove them in the head file, do it now.
>>
>> Signed-off-by: Hanjun Guo <hanjun@linaro.org>
Reviewed-by: Aaron Lu <aaron...@intel.com>
Just out of curiosity, did you find this by some tool? If so, can you
please let me k
On 12/04/2014 09:22 AM, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks
depending on CONFIG_PM_RUNTIME may now be changed to
On 01/09/2014 05:21 AM, Alan Stern wrote:
On Wed, 8 Jan 2014, Phillip Susi wrote:
You issue a REQUEST SENSE command and that returns status indicating
whether the drive is stopped, or in standby. See my patches. One of
I never saw your patches. Where were they posted?
If you issue the
On 01/07/2014 10:50 PM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/7/2014 2:49 AM, Aaron Lu wrote:
We can modify the device's system resume callback. To better
illustrate the idea, I just made two patches to do this and I did
some quick tests and didn't find
On 01/08/2014 09:16 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 01/07/2014 08:03 PM, Aaron Lu wrote:
You mean you want to leave the disk runtime suspended after a
system resume and in the meantime make sure the disk is indeed not
spun up?
Yep
On 01/08/2014 10:19 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 01/07/2014 09:11 PM, Aaron Lu wrote:
I thought that feature is used to control if a disk should be spun
up once powered from the host side.
That *is* what it sounds like, only ATA disks either
On 01/08/2014 01:24 PM, Phillip Susi wrote:
On 01/07/2014 09:36 PM, Aaron Lu wrote:
Oh, of course, my stupid :-) Then I suddenly think my patches can
kind of work - let's say we have done the hdparm setting thing
before suspend and the disk will be spun up in standby mode next
time
on RUNTIME_PM, while Todd's implementation
doesn't.
that this is not the case, and only requests with the type set to
REQ_TYPE_PM_RESUME are dispatched during suspend/resume. The
following patch fixes the hang, but I'm not sure why it is needed or
if it is generally appropriate:
Adding Aaron Lu
On 01/06/2014 10:40 PM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 1/6/2014 4:15 AM, Aaron Lu wrote:
My guess why it doesn't work for you is that, when you call
blk_pre_runtime_suspend in sd_resume_work, there are requests left
in the queue so that call
On 11/05/2013 10:37 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
I can not figure out what is waking up disks on resume from suspend.
I thought it was sd.c, and setting manage_start_stop = 0 should stop
that. It does stop the message printed saying it is being
On 11/06/2013 05:32 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/5/2013 4:05 AM, Aaron Lu wrote:
Are you using an ATA drive? Last time I checked, the spin up
actually happened while the ata port is resumed(when it will be
reset): https://lkml.org/lkml/2013/2
+linux-ide
On 11/05/2013 08:52 AM, Phillip Susi wrote:
The ATA SLEEP mode saves some more power than SUSPEND, and
has basically the same recovery time, so use it instead.
I suppose this is mainly for runtime PM? Since for system
suspend/hibernation, the disk and its controller will be powered
+linux-ide
On 11/05/2013 08:53 AM, Phillip Susi wrote:
When a disk is in SLEEP mode it can not respond to commands,
including the CHECK POWER command. Instead of waking up the
sleeping disk, fake the reply to the CHECK POWER command to
indicate the disk is in standby mode. This prevents
On 11/05/2013 10:39 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 11/04/2013 09:23 PM, Aaron Lu wrote:
I suppose this is mainly for runtime PM? Since for system
suspend/hibernation, the disk and its controller will be powered
off anyway.
Yes, or the second
, if the autosuspend delay is set longer than the polling
interval then the device will never suspend.
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
v2: scsi_dev_type_suspend/resume should be covered by CONFIG_PM_SLEEP,
suggested by Alan Stern.
v3: Modify
On 10/09/2013 04:32 PM, sthu...@codeaurora.org wrote:
Hi Aaron,
I found a race condition with the block layer runtime PM due to which
the q-nr_pending is decremented to less than zero (0x_ (-1))
and hence the blk pre-runtime suspend always returns -EBUSY.
The issue is easily
On 10/10/2013 09:40 AM, Phillip Susi wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
I have been trying out the new block layer runtime pm, and run into a
problem: udisks keeps waking up the disk. Every 10 minutes it tries
to poll the SMART status of the drive, but it does first
initiated there will all be counted.
Signed-off-by: Aaron Lu aaron...@intel.com
Reported-and-tested-by: Sujit Reddy Thumma sthu...@codeaurora.org
Cc: sta...@vger.kernel.org
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
, if the autosuspend delay is set longer than the polling
interval then the device will never suspend.
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
v2: scsi_dev_type_suspend/resume should be covered by CONFIG_PM_SLEEP,
suggested by Alan Stern.
v3: Modify
On 09/06/2013 11:00 PM, James Bottomley wrote:
On Fri, 2013-09-06 at 10:01 +0800, Aaron Lu wrote:
Migrate SCSI Optical Disk Drive(ODD)
I'm not very keen on this description because it's not quite accurate.
sr stands for SCSI ROM. You could say optical SCSI ROM perhaps, but
Magneto Optical
On 09/06/2013 11:56 PM, Alan Stern wrote:
On Fri, 6 Sep 2013, James Bottomley wrote:
layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
simplified as all SCSI devices that implement runtime PM are now request
based.
OK, let's now try for a descriptive changelog. All
On 09/05/2013 10:25 PM, Alan Stern wrote:
On Thu, 5 Sep 2013, Aaron Lu wrote:
Migrate SCSI Optical Disk Drive(ODD) driver sr to make use of block
layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
simplified as all SCSI devices that implement runtime PM are now request
happen, the autosuspend_delay can not be set to more than 2
seconds or the polling interval has to be increased.
Signed-off-by: Aaron Lu aaron...@intel.com
---
v2: scsi_dev_type_suspend/resume should be covered by CONFIG_PM_SLEEP,
suggested by Alan Stern.
Make sure to use the util-linux utility
Migrate SCSI Optical Disk Drive(ODD) driver sr to make use of block
layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is
simplified as all SCSI devices that implement runtime PM are now request
based.
Signed-off-by: Aaron Lu aaron...@intel.com
---
Note that due to ODD
On 08/23/2013 03:02 PM, Dirk Griesbach wrote:
Hello Aaron,
On Do, Aug 22, 2013 at 03:15:16 +0800, Aaron Lu wrote:
Hi Drik,
Can you please test the two patches regarding your ATA bay? Thanks.
No problems with the bay. I applied the patches on top of 3.11-rc6.
Thanks a lot for the test
On 08/15/2013 11:19 AM, Tejun Heo wrote:
Hello, Aaron.
On Thu, Aug 15, 2013 at 09:33:28AM +0800, Aaron Lu wrote:
This has been quiet for some time, may I know your opinion on this?
Ooh, I like it. I was waiting for proper patch series w/o RFC tag and
hopefully some test results
On 08/23/2013 02:36 AM, Tejun Heo wrote:
Hello, Aaron.
On Thu, Aug 22, 2013 at 03:15:16PM +0800, Aaron Lu wrote:
The patch series has two patches and the first has been taken, shall I
send the 2nd one again without the RFC tag in the patch subject? There
should be no other changes
On 07/25/2013 10:52 PM, Tejun Heo wrote:
On Thu, Jul 25, 2013 at 01:47:03PM +0800, Aaron Lu wrote:
Binding ACPI handle to SCSI device has several drawbacks, namely:
1 During ATA device initialization time, ACPI handle will be needed
while SCSI devices are not created yet. So each time ACPI
Commit 7381fe737 libata-acpi: remove redundent code for power resource
handling removed ata_acpi_(un)bind but left their prototypes in libata.h,
so remove them.
Signed-off-by: Aaron Lu aaron...@intel.com
---
drivers/ata/libata.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/ata
, but all ACPI handling
are done in ATA with ATA transport devices.
Tested on an Intel platform, ZPODD and runtime power off of a SATA disk
works OK. More testing by other people is needed/appreciated.
Aaron Lu (2):
ata: acpi: remove dead code for ata_acpi_(un)bind
ata: acpi: rework the ata acpi bind
is no longer
needed.
Signed-off-by: Aaron Lu aaron...@intel.com
---
drivers/ata/libata-acpi.c | 278 -
drivers/ata/libata-core.c | 5 -
drivers/ata/libata-scsi.c | 13 +-
drivers/ata/libata-transport.c | 2 +
drivers/ata/libata-zpodd.c
On 07/02/2013 03:11 PM, Kishore Babu Lukka wrote:
Adding Asha also.
-Original Message-
From: Mahesh Rajashekhara
Sent: Monday, July 01, 2013 11:41 AM
To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
Cc: Tony Ruiz; Achim Leubner; Mahesh Rajashekhara; Kishore Babu Lukka
pm_runtime_autosuspend() in blk_post_runtime_resume().
Hi Sujit,
Thanks for testing out block layer runtime PM!
As for the problem here, it is already fixed by:
commit c60855cdb976c632b3bf8922eeab8a0e78edfc04
Author: Aaron Lu aaron...@intel.com
Date: Fri May 17 15:47:20 2013 +0800
blkpm
in case people there think it should be solved in another way.
Here is the patch.
From d4202374d620bf72953a0b59f108521f94cefbd6 Mon Sep 17 00:00:00 2001
From: Aaron Lu aaron...@intel.com
Date: Thu, 6 Jun 2013 16:28:37 +0800
Subject: [PATCH] eject: unlock door before issuing CDROMEJECT command
If user
On 03/23/2013 12:23 PM, Jens Axboe wrote:
On Sat, Mar 23 2013, Aaron Lu wrote:
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
, then only PM request is allowed
to go.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/scsi/scsi_lib.c| 9 -
drivers/scsi/sd.c | 9 +
include/scsi/scsi_device.h | 16
3 files changed, 21 insertions(+), 13
-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
include/linux/blk_types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index cdf1119..fcc1ce2 100644
--- a/include/linux/blk_types.h
+++ b/include/linux
to RPM_SUSPENDED.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
block/blk-core.c | 144
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
, then only PM request is allowed
to go.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/scsi/scsi_lib.c| 9 -
drivers/scsi/sd.c | 9 +
include/linux/blk_types.h | 2 ++
include/scsi/scsi_device.h | 16
On 03/12/2013 08:10 PM, James Bottomley wrote:
On Tue, 2013-03-12 at 10:53 +0800, Aaron Lu wrote:
Hi James and Alan,
On 03/11/2013 11:00 PM, Alan Stern wrote:
On Mon, 11 Mar 2013, James Bottomley wrote:
Oh, that seems to be the suspend order isn't careful enough.
__device_suspend() waits
On 2013-03-11 16:49, James Bottomley wrote:
On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote:
Hi all,
I've seen some reports on STANDBY IMMEDIATE failed on NVIDIA MCP5x
controllers when system goes to suspend(this command is sent by scsi sd
driver on system suspend as a SCSI STOP command
Hi James and Alan,
On 03/11/2013 11:00 PM, Alan Stern wrote:
On Mon, 11 Mar 2013, James Bottomley wrote:
Oh, that seems to be the suspend order isn't careful enough.
__device_suspend() waits for its children, but the host disk are too far
separated in the device tree. If the immediate
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
to RPM_SUSPENDED.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
block/blk-core.c | 144
, then only PM request is allowed
to go.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/scsi/scsi_lib.c| 9 -
drivers/scsi/sd.c | 9 +
include/linux/blk_types.h | 2 ++
include/scsi/scsi_device.h | 16
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
On Wed, Feb 20, 2013 at 10:43:50AM -0500, Alan Stern wrote:
On Wed, 20 Feb 2013, Aaron Lu wrote:
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
, then only PM request is allowed
to go.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 39
-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
drivers/scsi/scsi_lib.c| 9 -
drivers/scsi/sd.c | 9 +
include/linux/blk_types.h | 2 ++
include/scsi/scsi_device.h | 16
4 files changed, 23 insertions(+), 13
to RPM_SUSPENDED.
The idea and API is designed by Alan Stern and described here:
http://marc.info/?l=linux-scsim=133727953625963w=2
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 144
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
Hi Alan,
On Tue, Feb 05, 2013 at 04:03:15PM +0800, Aaron Lu wrote:
From: Lin Ming ming.m@intel.com
When a request is added:
If device is suspended or is suspending and the request is not a
PM request, resume the device.
When the last request finishes:
Call
On Wed, Feb 06, 2013 at 10:51:19AM -0500, Alan Stern wrote:
On Wed, 6 Feb 2013, Aaron Lu wrote:
The if (err == -EAGAIN) test and the call to pm_schedule_suspend seem
to have been dropped since v8 of this series. It looks like they ought
to be moved into sdev_runtime_suspend.
I
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
to RPM_SUSPENDED.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 144 +
include/linux/blkdev.h | 27 ++
2 files changed, 171 insertions(+)
diff --git a/block/blk-core.c b/block/blk
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
, then only PM request is allowed
to go.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 39 +++
block/elevator.c | 26 ++
2 files changed, 65 insertions(+)
diff --git
-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
drivers/scsi/scsi_lib.c| 9 -
drivers/scsi/sd.c | 9 +
include/linux/blk_types.h | 2 ++
include/scsi/scsi_device.h | 16
4 files changed, 23 insertions(+), 13
On 02/06/2013 12:51 AM, Alan Stern wrote:
On Tue, 5 Feb 2013, Aaron Lu wrote:
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path
On 02/03/2013 02:23 PM, Aaron Lu wrote:
No, the modification is actually for disk.
With v8 of block layer runtime PM, it is no longer the case runtime
suspend is the same as system suspend for hard disk that utilize block
layer runtime PM: we quiesce the device and run its suspend callback
think it's that before we can send the command to spin up the disk, we
need to wait for the ata host controller to come up. As Aaron Lu
pointed out, it takes seconds for the ata port to resume. On the hand,
I just did some more recording, the result is:
host controller takes 1ms or less to resume
On 02/01/2013 11:28 PM, Alan Stern wrote:
On Fri, 1 Feb 2013, Aaron Lu wrote:
Hi Derek,
On 12/21/2012 12:35 PM, Derek Basehore wrote:
We no longer wait for the disk to spin up in sd_resume. It now enters the
request to spinup the disk into the elevator and returns.
A function
On 02/02/2013 11:09 PM, Alan Stern wrote:
On Sat, 2 Feb 2013, Aaron Lu wrote:
An alternative way of possibly solving this problem from PM's point of
view might be:
1 Set both ata port and scsi device's runtime status to RPM_SUSPENDED
in their system suspend callback;
By the way, what
In August 2010, Jens and Alan discussed about Runtime PM and the block
layer. http://marc.info/?t=12825910841r=1w=2
And then Alan has given a detailed implementation guide:
http://marc.info/?l=linux-scsim=133727953625963w=2
To test:
# ls -l /sys/block/sda
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open/release path and check_events path.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron
, then only PM request is allowed
to go.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 39 +++
block/elevator.c | 26 ++
2 files changed, 65 insertions(+)
diff --git
-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 143 +
include/linux/blkdev.h | 27 ++
2 files changed, 170 insertions(+)
diff --git a/block/blk-core.c b/block/blk-core.c
index 66d3168
On Wed, Jan 30, 2013 at 10:54:53AM -0500, Alan Stern wrote:
On Wed, 30 Jan 2013, Aaron Lu wrote:
From: Lin Ming ming.m@intel.com
Add runtime pm helper functions:
void blk_pm_runtime_init(struct request_queue *q, struct device *dev)
- Initialization function for drivers
On Wed, Jan 30, 2013 at 10:38:26AM -0500, Alan Stern wrote:
On Wed, 30 Jan 2013, Aaron Lu wrote:
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume for devices that take advantage of it.
Remove scsi_autopm_* from sd open
On Fri, Jan 18, 2013 at 04:25:10PM -0500, Alan Stern wrote:
On Wed, 16 Jan 2013, Aaron Lu wrote:
From: Lin Ming ming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume.
Remove scsi_autopm_* from sd open/release path and check_events path
On Sat, Jan 19, 2013 at 01:11:45PM -0500, Alan Stern wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
Considering ODD's use case, I was thinking of moving the
blk_pm_runtime_init call to sd.c, as sr will not use request based auto
suspend. Probably right before we decrease usage count
On Fri, Jan 25, 2013 at 03:37:28PM -0500, Jeff Garzik wrote:
On 01/23/2013 02:09 AM, Aaron Lu wrote:
This patch adds runtime pm support for sr.
It did this by increasing the runtime usage_count of the device when
its block device is accessed. And decreasing the runtime usage_count
On Mon, Jan 21, 2013 at 03:42:55PM -0500, Jeff Garzik wrote:
On 01/15/2013 04:21 AM, Aaron Lu wrote:
For ODDs, the upper layer will poll for media change every few
seconds, which will make it enter and leave suspend state very
often. And as each suspend will also cause a hard/soft reset
is transparent to the end user.
Aaron Lu (3):
scsi: sr: support runtime pm
libata: scsi: no poll when ODD is powered off
scsi: remove can_power_off flag from scsi_device
drivers/ata/libata-zpodd.c | 7 +++
drivers/scsi/scsi_lib.c| 14 ++
drivers/scsi/sr.c | 46
know if the ODD is being used or not.
The idea is discussed here:
http://thread.gmane.org/gmane.linux.acpi.devel/55243/focus=52703
and the restriction to check media inside is discussed here:
http://thread.gmane.org/gmane.linux.ide/53665/focus=58836
Signed-off-by: Aaron Lu aaron...@intel.com
Acked
, while values above 0
means media poll is not needed and should better be skipped. So we can
increase its value when we are to power off the ODD in ATA layer and
decrease its value when the ODD is powered on, effectively silence the
media events poll.
Signed-off-by: Aaron Lu aaron...@intel.com
remove it.
Signed-off-by: Aaron Lu aaron...@intel.com
---
include/scsi/scsi_device.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index bb1371b..a7f9cba 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -157,7
On Sat, Jan 19, 2013 at 01:46:15PM -0500, Alan Stern wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
What happens if you're not running a desktop graphical environment, so
gvfs doesn't mount the disc? Basically, I'm worried that the drive may
remain suspended after sr_open() returns
On Mon, Jan 21, 2013 at 02:31:50PM +1100, Julian Calaby wrote:
Hi Alan,
On Sun, Jan 20, 2013 at 5:46 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
closed. Do we want to drop support for that kind of behavior?
I don't think we should drop
Hi Julian,
On Mon, Jan 21, 2013 at 07:55:20PM +1100, Julian Calaby wrote:
Hi Aaron,
On Mon, Jan 21, 2013 at 7:14 PM, Aaron Lu aaron...@intel.com wrote:
On Mon, Jan 21, 2013 at 02:31:50PM +1100, Julian Calaby wrote:
Hi Alan,
On Sun, Jan 20, 2013 at 5:46 AM, Alan Stern st
On 01/21/2013 05:16 PM, Jeff Garzik wrote:
On 01/15/2013 04:20 AM, Aaron Lu wrote:
The ODD can be enabled for ZPODD if the following three conditions are
satisfied:
1 The ODD supports device attention;
2 The platform can runtime power off the ODD through ACPI;
3 The ODD is either slot type
On Sat, Jan 19, 2013 at 01:46:15PM -0500, Alan Stern wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
I don't think we should drop such support.
And the safest way to avoid such break is we refine the suspend
condition for ODD, and using what ZPODD defined condition isn't that
bad to me
On 01/19/2013 05:25 AM, Alan Stern wrote:
On Wed, 16 Jan 2013, Aaron Lu wrote:
From: Lin Mingming.m@intel.com
Uses block layer runtime pm helper functions in
scsi_runtime_suspend/resume.
Remove scsi_autopm_* from sd open/release path and check_events path.
And remove the quiesce call
On 01/20/2013 02:46 AM, Alan Stern wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
Then we indeed have a problem. But I didn't find any such app in
Fedora's repo or by searching the internet.
http://rpm.pbone.net/index.php3/stat/4/idpl/2392183/dir/redhat_5.x/com/cdp-0.33-10.i386.rpm.html
Now
On Mon, Jan 21, 2013 at 03:56:43PM +0100, Oliver Neukum wrote:
On Monday 21 January 2013 17:11:04 Aaron Lu wrote:
It is not easy for the OS to tell if the drive is being used or not
sometimes
Alan has reminded me it is possible for an app to open the block device
file(/dev/sr0), issue
On Mon, Jan 21, 2013 at 11:59:06AM -0500, Alan Stern wrote:
On Mon, 21 Jan 2013, Aaron Lu wrote:
On Sat, Jan 19, 2013 at 01:46:15PM -0500, Alan Stern wrote:
On Sat, 19 Jan 2013, Aaron Lu wrote:
I don't think we should drop such support.
And the safest way to avoid such break is we
On 01/18/2013 11:24 PM, Alan Stern wrote:
On Fri, 18 Jan 2013, Aaron Lu wrote:
Aaron, have you checked whether this patch works okay when you play a
track on an audio-only CD on the computer? The block interface looks
okay but I'm not sure about the cdrom_device interface.
Just verified
On Thu, Jan 17, 2013 at 10:11:31AM -0500, Alan Stern wrote:
On Thu, 17 Jan 2013, Aaron Lu wrote:
@@ -515,6 +516,27 @@ void elv_bio_merged(struct request_queue *q,
struct request *rq,
e-type-ops.elevator_bio_merged_fn(q, rq, bio);
}
+#ifdef
On 01/18/2013 11:26 PM, Alan Stern wrote:
On Fri, 18 Jan 2013, Aaron Lu wrote:
Either you have to make sure the q-nr_pending is always correct, even
when runtime PM isn't being used, or else the caller has to make sure
that no I/O takes place before blk_pm_runtime_init is called.
I think we
On Wed, Jan 16, 2013 at 11:31:31AM -0500, Alan Stern wrote:
On Wed, 16 Jan 2013, James Bottomley wrote:
On Tue, 2013-01-15 at 17:20 +0800, Aaron Lu wrote:
This patch adds runtime pm support for sr.
It did this by increasing the runtime usage_count of the device when:
- its block
, then only PM request is allowed
to go.
Signed-off-by: Lin Ming ming.m@intel.com
Signed-off-by: Aaron Lu aaron...@intel.com
---
block/blk-core.c | 39 +++
block/elevator.c | 26 ++
2 files changed, 65 insertions(+)
diff --git
1 - 100 of 373 matches
Mail list logo
