[LSF/MM TOPIC][LSF/MM ATTEND] blk-mq and I/O scheduling

2016-02-26 Thread Andreas Herrmann
Hi, I'd like to participate in LSF/MM and would like to present/discuss ideas for introducing I/O scheduling support to blk-mq. Motiviation for this is to be able use scsi-mq even on systems that have slow (spinning) devices attached to the SCSI stack. I think the presentation/discussion should

Re: [RFC PATCH v2] blk-mq: Introduce per sw queue time-slice

2016-02-10 Thread Andreas Herrmann
On Wed, Feb 10, 2016 at 08:47:15PM +0100, Markus Trippelsdorf wrote: > On 2016.02.10 at 20:34 +0100, Andreas Herrmann wrote: > > On Tue, Feb 09, 2016 at 06:41:56PM +0100, Markus Trippelsdorf wrote: > > > > Recently Johannes sent a patch to enable scsi-mq per driver, see > &

Re: [RFC PATCH v2] blk-mq: Introduce per sw queue time-slice

2016-02-10 Thread Andreas Herrmann
On Tue, Feb 09, 2016 at 06:41:56PM +0100, Markus Trippelsdorf wrote: > On 2016.02.09 at 18:12 +0100, Andreas Herrmann wrote: > > [CC-ing linux-block and linux-scsi and adding some comments] > > > > On Mon, Feb 01, 2016 at 11:43:40PM +0100, Andreas Herrmann wrote: > &

Re: [RFC PATCH v2] blk-mq: Introduce per sw queue time-slice

2016-02-09 Thread Andreas Herrmann
[CC-ing linux-block and linux-scsi and adding some comments] On Mon, Feb 01, 2016 at 11:43:40PM +0100, Andreas Herrmann wrote: > This introduces a new blk_mq hw attribute time_slice_us which allows > to specify a time slice in usecs. > > Default value is 0 and implies no modificati

Re: Documents for SCSI mid layer

2007-04-05 Thread Andreas Herrmann
On Fri, Apr 06, 2007 at 03:30:52AM +0200, mahesh wrote: > Where can I find documents for Linux SCSI mid layer How about Documentation/scsi/scsi_mid_low_api.txt Documentation/scsi/scsi_eh.txt and Documentation/scsi in general as a start? Regards, Andreas -- AMD Saxony, Dresden, Germany O

Re: [PATCH] zfcp: Invalid locking order

2007-02-08 Thread Andreas Herrmann
On Thu, Feb 08, 2007 at 03:40:03PM +0100, Heiko Carstens wrote: > On Wed, Feb 07, 2007 at 05:06:43PM +0100, Andreas Herrmann wrote: > > On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote: > > > From: Swen Schillig <[EMAIL PROTECTED]> > > > > >

Re: [PATCH] zfcp: Invalid locking order

2007-02-07 Thread Andreas Herrmann
On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote: > From: Swen Schillig <[EMAIL PROTECTED]> > > Invalid locking order. Kernel hangs after trying to take two locks > which are dependend on each other. Introducing temporary variable > to free requests. Free lock after requests are copie

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
On Sat, Sep 03, 2005 at 14:53:00, Christoph Hellwig wrote: > Please don't do this. We have proper midlayer handling (plus FC > transport > class wrappers) to handle that case without introducing a big mess in > the > driver. Please take a look at fc_remote_port_{block,unblock} Thanks for t

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
James, I wished I would have put patch 1/7 at the end of the patch series ;-( Because if patch 1 is not applied the other patches won't apply without rejects. I am on vacation for 1 week and I am not able to recreate the patches before 12th of September. Do you see any problems to bring the new

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-04 Thread Andreas Herrmann
On Sat, 2005-09-03 13:45:01, James Bottomley wrote: > But that's not what the patch does. It short circuits the error > handler > globally, not just in the cable pulled case. > For any error induced timeout, you're going to follow this logic. In > particular, if the device itself actua

Re: [PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Andreas Herrmann
On 03.09.2005 14:56 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > zfcp: introduce eh_timed_out handler > > > > This handler is required to avoid offlined SCSI devices in a multipath > > setup if scsi commands time out on cable pulls lasting longer than 30 > > seconds. > hmm why i

[PATCH 7/7] zfcp: provide support for NPIV

2005-09-03 Thread Andreas Herrmann
eature. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> zfcp_dbf.c | 11 + zfcp_def.h | 13 +- zfcp_erp.c | 95 +- zfcp_ext.h |3 zfcp_fsf.c | 330 +--

[PATCH 5/7] zfcp: shorten eh_bus_reset and eh_host_reset handlers

2005-09-03 Thread Andreas Herrmann
zfcp: shorten eh_bus_reset and eh_host_reset handlers Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -Nup linux-2.6.13/drivers/s390/scsi-orig/zfcp_scsi.c linux-2.6.13/drivers/s390/scsi/zfcp_scsi.c --- linux-2.6.13/drivers/s390/scsi-orig/zfcp_scsi.c 2005-09-03 12:21:58.000

[PATCH 4/7] zfcp: remove function zfcp_fsf_req_wait_and_cleanup

2005-09-03 Thread Andreas Herrmann
zfcp: remove function zfcp_fsf_req_wait_and_cleanup Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> zfcp_ext.h |1 - zfcp_fsf.c | 46 -- zfcp_scsi.c | 21 + 3 files changed, 9 insertions(+), 59 deletions(-) dif

[PATCH 3/7] zfcp: remove union zfcp_req_data, use unit refcount for FCP commands

2005-09-03 Thread Andreas Herrmann
before all fsf_requests of that unit are completely processed.) Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> zfcp_aux.c |8 +--- zfcp_def.h | 69 +--- zfcp_fsf.c | 101 +--- zfcp_

[PATCH 2/7] zfcp: fix race conditions when accessing erp_action lists

2005-09-03 Thread Andreas Herrmann
zfcp: fix race conditions when accessing erp_action lists o always use locking when changing erp_action lists, o avoid escalation to ERP_ACTION_REOPEN_PORT_FORCED if erp_action is still in use for ERP_ACTION_REOPEN_PORT Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -Nup

[PATCH 1/7] zfcp: introduce eh_timed_out handler

2005-09-03 Thread Andreas Herrmann
zfcp: introduce eh_timed_out handler This handler is required to avoid offlined SCSI devices in a multipath setup if scsi commands time out on cable pulls lasting longer than 30 seconds. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -Nup linux-2.6.13/drivers/s390/scs

[PATCH 0/7] zfcp: update to driver version 4.5.0

2005-09-03 Thread Andreas Herrmann
Hi, Following a series of 7 patches (based on 2.6.13) to update the zfcp device driver. Patches contain bugfixes, some cleanups and new features. Overall diffstat of all patches is: Makefile |2 zfcp_aux.c | 188 - zfcp_dbf.c | 999 +

Re: correct deregistration from scsi_transport_fc

2005-08-29 Thread Andreas Herrmann
On 29.08.2005 13:03 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > Won't work for all zSeries FC host adapters because they are > > virtualized and you can have several virtual adapters using the same > > WWPN/WWNN. Using LUN masking and zoning it is not possible to > > configure the SA

Re: correct deregistration from scsi_transport_fc

2005-08-29 Thread Andreas Herrmann
On 29.08.2005 10:48 Christoph Hellwig <[EMAIL PROTECTED]> worte: > Never use scsi_add_device with the fc_transport code. fc_remote_port_add > will do a proper lun scan if the added rport is a scsi target. Won't work for all zSeries FC host adapters because they are virtualized and you can ha

correct deregistration from scsi_transport_fc

2005-08-29 Thread Andreas Herrmann
Hi, What is the correct sequence to register and deregister host/rport/scsi_devices at the scsi stack? ZFCP's sequence is like follows: scsi_add_host fc_remote_port_add (if port succesfully configured/opened in/by zfcp) scsi_add_device (if unit successfully configured/opened in/by zfcp) If a zf

Re: [PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-29 Thread Andreas Herrmann
On 27.08.2005 19:38 James Bottomley <[EMAIL PROTECTED]> wrote: > > this patch fixes a severe problem with 2.6.13-rc7. > > > > Due to recent SCSI changes it is not possible to add any > > LUNs to the zfcp device driver anymore. With registration > > of remote ports this is fixed. > >

[PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-27 Thread Andreas Herrmann
then please integrate it in 2.6.13.1 Thanks a lot. Regards, Andreas Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diffstat: zfcp_aux.c | 29 +++-- zfcp_ccw.c | 10 ++ zfcp_def.h |2 +- zfcp_erp.c | 25 ++--- zfcp

Re: [PATCH] remove name length check in a workqueue

2005-08-11 Thread Andreas Herrmann
Simon Derr <[EMAIL PROTECTED]> wrote: > It is sufficient to have a few HBAs and to insmod/rmmod the driver a few > times. > Since the host_no is choosen with a mere counter increment > in scsi_host_alloc(): > shost->host_no = scsi_host_next_hn++; /* XXX(hch): still rac

Re: [dm-devel] Re: fastfail operation and retries

2005-04-21 Thread Andreas Herrmann
Lars Marowsky-Bree <[EMAIL PROTECTED]> 21.04.2005 21:54 > On 2005-04-21T09:42:05, Patrick Mansfield <[EMAIL PROTECTED]> wrote: > > On Tue, Apr 19, 2005 at 07:19:53PM +0200, Andreas Herrmann wrote: > > > > We need a patch like Mike

[PATCH] zfcp: fix compile error

2005-04-21 Thread Andreas Herrmann
rc3) will fix the problem. Sorry, for any inconvenience. Regards, Andreas zfcp: fix compile error Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -bBrauN linux-2.6.x/drivers/s390/scsi-orig/zfcp_aux.c linux-2.6.x/drivers/s390/scsi/zfcp_aux.c --- linux-2.6.x/drivers/s390/scsi-orig/zfcp_a

Re: fastfail operation and retries

2005-04-20 Thread Andreas Herrmann
??? <[EMAIL PROTECTED]> wrote: 20.04.2005 03:17 > what multipath are you using? Software, or hardware, > or both? We are using udm with evms (Linux on zSeries). Hardware setup is: - switched fabric FC-SAN, - 4 paths to each FC-LUN on the ESS 800 All 4 paths are "failing fast" du

fastfail operation and retries

2005-04-19 Thread Andreas Herrmann
Hi, I have question(s) regarding the fastfail operation of the SCSI stack. Performing multipath-tests with an IBM ESS I encountered problems. During certain operations on an ESS (quiesce/resume and such) requests on all paths fail temporarily with an data underrun (resid is set in the FCP-respons

evaluation of scsi_cmnd->resid

2005-04-12 Thread Andreas Herrmann
Hi, Am I right in the assumption that scsi_cmnd->resid is just of use for requests initiated by sg? How does the SCSI-stack handle normal (non-sg) requests for SCSI disks for which a scsi_cmnd->resid is set? AFAIK, resid is ignored by sd. So, such requests are returned to the block layer althoug

Re: Proper handling of data underrun

2005-04-08 Thread Andreas Herrmann
Douglas Gilbert <[EMAIL PROTECTED]> wrote: > underflow- LLD should place (DID_ERROR << 16) in 'result' if > actual number of bytes transferred is less than this > figure. Not many LLDs implement this check and some > that do just

Proper handling of data underrun

2005-04-08 Thread Andreas Herrmann
Hi, Documentation/scsi/scsi_mid_low_api.txt says: resid- an LLD should set this signed integer to the ... underflow- LLD should place (DID_ERROR << 16) in 'result' if ... ZFCP is setting resid and DID_ERROR if an underrun is indicated in the FCP-response. In som

[PATCH] zfcp: add point-2-point support

2005-04-06 Thread Andreas Herrmann
Hi, This patch mainly introduces support for point-2-point topology. Regards, Andreas From: Heiko Carstens <[EMAIL PROTECTED]> From: Maxim Shchetynin <[EMAIL PROTECTED]> From: Andreas Herrmann <[EMAIL PROTECTED]> zfcp changes: - add support for point-2-point topology - c

[PATCH] zfcp: convert to compat_ioctl

2005-04-06 Thread Andreas Herrmann
Hi, Patch converts zfcp to use compat_ioctl. Thanks to Cristoph who reminded me to adapt zfcp. Regards, Andreas zfcp changes: convert zfcp to compat_ioctl Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> = zfcp_aux.c 1.19 vs edited = --- 1.19/drivers/s390/scsi/zfcp_aux.c