[PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

Signed-off-by: Andrei Vagin --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index aadfeaac3898..b63440fec18e 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b

Re: [PATCH v2] target/file: add support of direct and async I/O

Hello Nicholas, What do you think about this patch? Thanks, Andrei On Wed, Mar 21, 2018 at 11:55:02PM -0700, Andrei Vagin wrote: > There are two advantages: > * Direct I/O allows to avoid the write-back cache, so it reduces > affects to other processes in the system. > * Async I

Re: [PATCH v2] target/file: add support of direct and async I/O

On Thu, Mar 22, 2018 at 10:34:34AM -0700, Christoph Hellwig wrote: > > > > DIF (PI) emulation doesn't work when a target uses async I/O, because > > DIF metadata is saved in a separate file, and it is another non-trivial > > task how to synchronize writing in two files, so that a following read >

[PATCH v2] target/file: add support of direct and async I/O

y: Bryant G. Ly Signed-off-by: Andrei Vagin --- drivers/target/target_core_file.c | 137 ++ drivers/target/target_core_file.h | 1 + 2 files changed, 124 insertions(+), 14 deletions(-) diff --git a/drivers/target/target_core_file.c b/drivers/target/target_co

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

On Wed, Mar 21, 2018 at 11:47:02AM -0700, Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 11:16:09AM -0700, Andrei Vagin wrote: > > If we look at lo_rw_aio, we can find that bvec can be allocated or got > > from bio. I think the problem with the second case. > > > >

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

On Wed, Mar 21, 2018 at 12:23:40AM -0700, Christoph Hellwig wrote: > > I'm afraid this patch doesn't work, because we are not always allocate bvec, > > sometimes we get it from bio. In this case, we have to call > > blk_mq_complete_request after read_iter/write_iter. > > The issue there is that we

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

On Tue, Mar 20, 2018 at 01:47:01AM -0700, Christoph Hellwig wrote: > On Tue, Mar 20, 2018 at 12:54:58AM -0700, Andrei Vagin wrote: > > commit 92d773324b7edbd36bf0c28c1e0157763aeccc92 > > Author: Shaohua Li > > Date: Fri Sep 1 11:15:17 2017 -0700 > > > >

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

On Fri, Mar 16, 2018 at 12:50:27AM -0700, Christoph Hellwig wrote: > > DIF (PI) emulation doesn't work when a target uses async I/O, because > > DIF metadata is saved in a separate file, and it is another non-trivial > > task how to synchronize writing in two files, so that a following read > > ope

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

Hi Christoph, Thank you for the review. All comments look reasonable. I will fix and set a final version soon. Pls, answer on one inline question. On Fri, Mar 16, 2018 at 12:50:27AM -0700, Christoph Hellwig wrote: > > DIF (PI) emulation doesn't work when a target uses async I/O, because > > DIF

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

On Thu, Mar 15, 2018 at 09:26:57AM -0500, Bryant G. Ly wrote: > On 3/8/18 6:42 PM, Andrei Vagin wrote: > > > Direct I/O allows to not affect the write-back cache, this is > > expected when a non-buffered mode is used. > > > > Async I/O allows to handle a few comm

[PATCH] [RFC] target/file: add support of direct and async I/O

ng in two files, so that a following read operation always returns a consisten metadata for a specified block. Cc: "Nicholas A. Bellinger" Signed-off-by: Andrei Vagin --- drivers/target/target_core_file.c | 124 -- drivers/target/target_core_file.h |

[PATCH] target: don't call an unmap callback if a range length is zero

let) returns EINVAL, if len is zero. It means that file_operations->fallocate() isn't obligated to handle zero ranges too. Signed-off-by: Andrei Vagin --- drivers/target/target_core_sbc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/target/target_c