[PATCH 2/6] qla2xxx: Honor NVRAM port-down-retry-count settings.

2007-05-07 Thread Andrew Vasquez
Hardcoding the qlport_down_retry module-parameter effectively disallowed any user-defined NVRAM setting to go into effect. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi

[PATCH 3/6] qla2xxx: Attempt to stop firmware only if it had been previously executed.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 3e296ab..6ad1588 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b

[PATCH 4/6] qla2xxx: Correct pci_set_msi() usage semantics.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 6ad1588..db998d8 100644

[PATCH 6/6] qla2xxx: Update version number to 8.01.07-k7.

2007-05-07 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index dc85495..c375a4e 100644 --- a/drivers/scsi/qla2xxx

[PATCH 5/6] qla2xxx: Add MSI support.

2007-05-07 Thread Andrew Vasquez
Supported ISP types include ISP2422 and revision-2 type ISP2432 chips. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx

Re: qla_wxyz pci_set_mwi question

2007-05-03 Thread Andrew Vasquez
On Thu, 12 Apr 2007, Matthew Wilcox wrote: On Thu, Apr 12, 2007 at 12:37:13PM -0700, Andrew Vasquez wrote: On Thu, 12 Apr 2007, Matthew Wilcox wrote: Why should it fail? If there's a platform which can't support a cacheline size that the qla2xyz card can handle, it should be able

Re: Question regarding firmware

2007-04-24 Thread Andrew Vasquez
/Kconfig;h=8c865b9e02b579f2d5bfc64a706fec3ea4063433;hb=HEAD for details on where to retrieve and place the firmware images on your local systems. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Major qla2xxx regression on sparc64

2007-04-19 Thread Andrew Vasquez
based on other archs I can test with embedded ISPs. Thanks again for the SPARC tips. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread Andrew Vasquez
On Wed, 18 Apr 2007, Christoph Hellwig wrote: I don't think a module option is a good idea at this point. The problem is you broke some so far perfectly working setups, which is not okay. The only first step can be printing a really big warning. After this has been in for a while (at lest

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
that you're proposing implies that there's some 'random' bit-space within the IEEE NAA with which one can safely encode without stomping on any valid OUI. From 9ee6de3bbaa03390b83226e7bb84c49566a583b3 Mon Sep 17 00:00:00 2001 From: Andrew Vasquez [EMAIL PROTECTED] Date: Wed, 11 Apr 2007 16:02:06 -0700 Subject

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, Andrew Vasquez wrote: On Mon, 16 Apr 2007, David Miller wrote: They DON'T CARE, they want their systems to work and if you don't give them that you're not being a good driver maintainer. Let's push aside attitudes and unrealistic statistics, could we perhaps

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 14:10:49 -0700 Ok, how about the following patch based on the one you posted which adds the codes to retrieve the WWPN/WWNN from firmware on SPARC, and also adds the module-parameter

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 15:25:17 -0700 Fine, I'll agree that wacking-users (and I'll wager the outliers) with a 2x4 was a bit extreme, And that, right there, is basically the end of the conversation. You

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:28:51 -0700 Sorry, but let's be realistic, this type of warning would have *NEVER* been addressed if we kept the status quo Wrong. I watch the logs all the time and would have

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread Andrew Vasquez
On Mon, 16 Apr 2007, David Miller wrote: From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:47:05 -0700 Dave, according to your earlier emails, the qla2xxx driver worked 'fine' in driver versions before commit 7aef45ac92f49e76d990b51b7ecd714b9a608be1. If that were

Re: qla_wxyz pci_set_mwi question

2007-04-12 Thread Andrew Vasquez
On Wed, 11 Apr 2007, Randy Dunlap wrote: Both scsi/qla2xxx/qla_init.c and scsi/qla4xxx/ql4_init.c use pci_set_mwi() like this: mwi = 0; if (pci_set_mwi(ha-pdev)) mwi = PCI_COMMAND_INVALIDATE; and then go on to set the PCI_COMMAND word based on that value.

Re: qla_wxyz pci_set_mwi question

2007-04-12 Thread Andrew Vasquez
On Thu, 12 Apr 2007, Matthew Wilcox wrote: On Thu, Apr 12, 2007 at 10:20:38AM -0700, Andrew Vasquez wrote: No, the current logic doesn't make much sense at all, initialization should not continue if MWI is not set... I'll queue-up something like the patch below for our next batch

Re: [PATCH] [qla2xxx] Remove duplicate pci_disable_device() call

2007-03-28 Thread Andrew Vasquez
(). This patch removes the unnecessary call. Signed-off-by: Bernhard Walle [EMAIL PROTECTED] Acked-by: Andrew Vasquez [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH] correct SCSI_WAIT_SCAN selection for non-modular SCSI_SCAN_ASYNC builds.

2007-03-20 Thread Andrew Vasquez
Commit 840c2835a1c867281d27158378a9d34f593a7664 ([SCSI] make scsi_wait_scan always modular) broke configurations where SCSI_SCAN_ASYNC is selected for non-modular builds. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index f3bc0f4

Re: [PATCH] correct SCSI_WAIT_SCAN selection for non-modular SCSI_SCAN_ASYNC builds.

2007-03-20 Thread Andrew Vasquez
On Tue, 20 Mar 2007, James Bottomley wrote: On Tue, 2007-03-20 at 12:19 -0700, Andrew Vasquez wrote: SCSI_SCAN_ASYNC was compiled non-modularly before merging the latest scsi-misc-2.6.git tree. After the merge, and a rebuild of the kernel, was getting 'unknown symbol' failures during link

Re: [PATCH] correct SCSI_WAIT_SCAN selection for non-modular SCSI_SCAN_ASYNC builds.

2007-03-20 Thread Andrew Vasquez
config is MODULES not MODULE. Can you try this: Ahh, that makes sense. Your patch fixes the mis-compilation. Thanks, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 0/6] qla2xxx: fixes for 2.6.21 [8.01.07-k6].

2007-03-12 Thread Andrew Vasquez
to be dynamic. - Update version number to 8.01.07-k6. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/6] qla2xxx: fix RSCN handling on big-endian systems

2007-03-12 Thread Andrew Vasquez
PROTECTED] Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index 05f4f2a..e8948b6 100644 --- a/drivers/scsi/qla2xxx

[PATCH 2/6] qla2xxx: Add scan_[start|finish]() callbacks for ISP24xx HBAs.

2007-03-12 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 68f5d24..f67ef38 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers

[PATCH 3/6] qla2xxx: Add cond_resched() calls during HBA flash manipulation.

2007-03-12 Thread Andrew Vasquez
We're observing soft lockups during HBA FLASH retrieval and update. Add cond_resched() each time around the tight-loops during flash read()s/write()s. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_sup.c |5 + 1 files changed, 5 insertions(+), 0 deletions

[PATCH 4/6] qla2xxx: Drop acquisition of hardware_lock during flash manipulations.

2007-03-12 Thread Andrew Vasquez
There's no need given, I/O has been quiesced, RISC interrupts have been disabled, and finally the RISC has been paused. Flash manipulation on ISP21xx, ISP22xx, and ISP23xx parts requires the RISC to go through a full reset to recover. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers

[PATCH 6/6] qla2xxx: Update version number to 8.01.07-k6.

2007-03-12 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 61347ae..dc85495 100644 --- a/drivers/scsi/qla2xxx

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-27 Thread Andrew Vasquez
On Tue, 27 Feb 2007, Andre Noll wrote: On 10:26, Andrew Vasquez wrote: You are loading some stale firmware that's left over on the card -- I'm not even sure what 4.00.70 is, as the latest release firmware is 4.00.27. That's the firmware which came with the card. Anyway, I just upgraded

Re: qla2xxx BUG: workqueue leaked lock or atomic

2007-02-26 Thread Andrew Vasquez
] [80462414] qla24xx_intr_handler+0x1d4/0x2b0 [ 75.780131] [8025e950] handle_IRQ_event+0x20/0x60 Hmm Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-02-02 Thread Andrew Vasquez
On Thu, 01 Feb 2007, Andrew Morton wrote: On Mon, 22 Jan 2007 10:35:10 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: Basically what is happening from the FC side is the initiator executes a simple dt test: dt of=/dev/raw/raw1 procs=8 oncerr=abort bs=16k disable=stats limit=2m

Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-02-02 Thread Andrew Vasquez
On Fri, 02 Feb 2007, Randy Dunlap wrote: On Fri, 2 Feb 2007 16:25:41 -0800 Andrew Morton wrote: On Fri, 2 Feb 2007 12:56:30 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: dt of=/dev/raw/raw1 procs=8 oncerr=abort bs=16k disable=stats limit=2m passes=100 pattern=iot

[PATCH 0/14] qla2xxx: driver update.

2007-01-29 Thread Andrew Vasquez
This patchset updates the qla2xxx driver to 8.01.07-k5. drivers/scsi/qla2xxx/qla_attr.c| 68 +++- drivers/scsi/qla2xxx/qla_def.h | 38 - drivers/scsi/qla2xxx/qla_gbl.h |6 + drivers/scsi/qla2xxx/qla_init.c| 218 ++

[PATCH 1/14] qla2xxx: Correct sector-erase issues while writing flash.

2007-01-29 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_sup.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_sup.c b/drivers/scsi/qla2xxx/qla_sup.c index 15390ad..7bbe751 100644 --- a/drivers/scsi/qla2xxx/qla_sup.c +++ b

[PATCH 3/14] qla2xxx: Handle IRQ-0 assignments by the system.

2007-01-29 Thread Andrew Vasquez
No restriction should be placed on the IRQ number assigned to a given ISP. Original code incorrectly assumed a non-zero IRQ number assignment by the system. In these circumstances the proper freeing of the IRQ (via free_irq()) would not take place. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

[PATCH 5/14] qla2xxx: Perform implicit LOGO during fabric logout request.

2007-01-29 Thread Andrew Vasquez
From: Lalit Chandivade [EMAIL PROTECTED] Similarly to previous LOGO requests on non-24xx hardware, perform an implicit-LOGO as to avoid the potential 2 * R_A_TOV delay which can result during an explicit-LOGO request. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx

[PATCH 7/14] qla2xxx: Refactor set-HBA-model/description code.

2007-01-29 Thread Andrew Vasquez
Limit assignments via qla2x00_model_name[] array to HBA subsystem vendor IDs equal to QLogic. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 83 +- 1 files changed, 37 insertions(+), 46 deletions(-) diff --git

[PATCH 8/14] qla2xxx: Check loop-state before reading host statistics.

2007-01-29 Thread Andrew Vasquez
Non-ISP24xx cards must have a loop-id in order to query host statistics. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi

[PATCH 10/14] qla2xxx: Enable queue-full throttling when UNDERRUN detected.

2007-01-29 Thread Andrew Vasquez
As ISP24xx firmware can return a CS_DATA_UNDERRUN completion status when the storage has returned a SAM_STAT_TASK_SET_FULL scsi-status. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_isr.c | 16 1 files changed, 16 insertions(+), 0 deletions

[PATCH 13/14] qla2xxx: Remove unnecessary spinlock primitive - mbx_reg_lock.

2007-01-29 Thread Andrew Vasquez
From: Seokmann Ju [EMAIL PROTECTED] Since, mailbox commands are executed in a synchronous manner, there is no need to have a separate spinlock primitive to protect data/register access shared by callers. Signed-off-by: Seokmann Ju [EMAIL PROTECTED] Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

[PATCH 2/14] qla2xxx: Add MSI-X support.

2007-01-29 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h | 24 + drivers/scsi/qla2xxx/qla_gbl.h |3 + drivers/scsi/qla2xxx/qla_init.c |2 + drivers/scsi/qla2xxx/qla_isr.c | 215 +++ drivers/scsi/qla2xxx/qla_os.c

[PATCH 12/14] qla2xxx: Fixup printk() with proper new-line character.

2007-01-29 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 6c790dd..98c01cd 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b

[PATCH 4/14] qla2xxx: Export OptionROM boot-codes version information.

2007-01-29 Thread Andrew Vasquez
This includes BIOS, EFI, FCODE and firmware versions. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c | 49 ++ drivers/scsi/qla2xxx/qla_def.h | 11 ++ drivers/scsi/qla2xxx/qla_gbl.h |3 + drivers/scsi/qla2xxx/qla_init.c |4 + drivers/scsi

[PATCH 9/14] qla2xxx: Fail initialization when inconsistent NVRAM detected.

2007-01-29 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 125 -- 1 files changed, 14 insertions(+), 111 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index f4c63ad..6c790dd 100644

[PATCH 6/14] qla2xxx: Set correct cabling state during initialization.

2007-01-29 Thread Andrew Vasquez
-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index cef24f3..5c9ce61 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi

[PATCH 11/14] qla2xxx: Allow NVRAM updates to immediately go into affect.

2007-01-29 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 834c404..8081b63 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b

[BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-01-22 Thread Andrew Vasquez
is the .config used. Thanks, Andrew Vasquez # # Automatically generated make config: don't edit # Linux kernel version: 2.6.19 # Fri Jan 19 16:53:19 2007 # CONFIG_X86_64=y CONFIG_64BIT=y CONFIG_X86=y CONFIG_ZONE_DMA32=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y

Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Andrew Vasquez
On Tue, 09 Jan 2007, Matthew Wilcox wrote: On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding starget_for_each_device() calls. As Matthew W. pointed out, starget_for_each_device() can be called under a spinlock being

[PATCH 1/9] qla2xxx: Don't log trace-control async-events.

2006-12-13 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_mbx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 4cde76c..afe7310 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b

[PATCH 6/9] qla2xxx: Correct reset handling logic.

2006-12-13 Thread Andrew Vasquez
- honor ISP24XX NVRAM settings for lip-reset, full-login-lip, and device-reset. - correct LIP_FULL_LOGIN mailbox command issuance. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c |8 +++-- drivers/scsi/qla2xxx/qla_mbx.c | 10 +++--- drivers/scsi

[PATCH 3/9] qla2xxx: Use proper prep_ms_iocb() function during GFPN_ID.

2006-12-13 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index f8bd33e..220ec41 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers

[PATCH 0/9] qla2xxx: fixes for 2.6.20 [8.01.07-k4].

2006-12-13 Thread Andrew Vasquez
. - Update version number to 8.01.07-k4. Regards, Andrew Vasquez QLogic Corporation - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 9/9] qla2xxx: Update version number to 8.01.07-k4.

2006-12-13 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 1fa0bce..459e0d6 100644 --- a/drivers/scsi/qla2xxx

[PATCH 5/9] qla2xxx: Correct IOCB queueing mechanism for ISP54XX HBAs.

2006-12-13 Thread Andrew Vasquez
Original code would incorrectly use non-24xx code-paths. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index d03523d

[PATCH 2/9] qla2xxx: Correct endianess issue while interrogating MS status.

2006-12-13 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 97fbc62..f8bd33e 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b

Re: [PATCH] qla2xyz: use NULL instead of 0

2006-11-27 Thread Andrew Vasquez
On Mon, 27 Nov 2006, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Use NULL instead of 0 for pointers (sparse warning): drivers/scsi/qla2xxx/qla_attr.c:393:4: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Acked-by: Andrew Vasquez

Re: [-mm patch] make qla2x00_reg_remote_port() static

2006-11-27 Thread Andrew Vasquez
] Acked-by: Andrew Vasquez [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/8] qla4xxx: new driver -- request for review.

2005-09-06 Thread Andrew Vasquez
(unused structures and functions) All patches can be found at the following URL: ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.03b15-k/ Comments and criticisms welcomed. Regards, Andrew Vasquez QLogic Corporation -- Andrew Vasquez - To unsubscribe from this list: send

[PATCH 5/8] qla4xxx: ISR routines

2005-09-06 Thread Andrew Vasquez
ISP4xxx driver ISR routines. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_isr.c | 905 1 files changed, 905 insertions(+), 0 deletions(-) create mode 100644 drivers/scsi/qla4xxx/ql4_isr.c

[PATCH 8/8] qla4xxx: Settings

2005-09-06 Thread Andrew Vasquez
ISP4xxx driver settings. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_settings.h | 67 ++ drivers/scsi/qla4xxx/ql4_version.h | 68 +++ 2 files changed, 135 insertions(+), 0 deletions(-) create

[PATCH 6/8] qla4xxx: Mailbox routines

2005-09-06 Thread Andrew Vasquez
ISP4xxx driver Mailbox routines. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_mbx.c | 1132 1 files changed, 1132 insertions(+), 0 deletions(-) create mode 100644 drivers/scsi/qla4xxx/ql4_mbx.c

Re: [PATCH 0/8] qla4xxx: new driver -- request for review.

2005-09-06 Thread Andrew Vasquez
On Tue, 06 Sep 2005, Andrew Vasquez wrote: Here's a first-pass run for submission-review of the qla4xxx driver for QLogic's ISP4010 and ISP4022 products. The patchset breaks-down as follows: o Driver definitions o initialisation routines o OS integration files o iSNS routines o ISR

Re: Possible bug in qla2xxx rev. 8.00.02

2005-08-31 Thread Andrew Vasquez
On Mon, 29 Aug 2005, Frank Borich wrote: I have a controller with a firmware bug that mishandles underrun situations for inquiry commands. It correctly sets the FCP_RESID_UNDER flag however it miscalculates the FCP_RESID count. The 7.05.00 Qlogic driver for 2.4.x kernels thinks frame(s)

[PATCH 1/3] Generalize WWN to u64 interger conversions.

2005-08-31 Thread Andrew Vasquez
. Generalize the conversions with a transport helper function which performs consistent shifting of WWN bytes. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h --- a/include/scsi/scsi_transport_fc.h +++ b/include/scsi

[PATCH 2/3] qla2xxx: use wwn_to_u64() transport helper

2005-08-31 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -360,16 +360,16 @@ qla2x00_get_starget_node_name(struct scs struct Scsi_Host

[PATCH 3/3] lpfc: use wwn_to_u64() transport helper

2005-08-31 Thread Andrew Vasquez
Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -965,21 +965,21 @@ static void lpfc_get_host_fabric_name (struct Scsi_Host *shost

Re: fc remote port timeout with qla2xxx driver

2005-08-31 Thread Andrew Vasquez
On Wed, 31 Aug 2005, Rudolph Pereira wrote: Aug 31 15:55:16 baku kernel: scsi(0): Sending Login IOCB (a0005000) to [81/0b1132]. Aug 31 15:55:16 baku kernel: scsi(0): Process IODesc -- processing a0005000. Aug 31 15:55:16 baku kernel: scsi(0): Login IOCB -- status=0 mb1=0

Re: [PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling.

2005-08-29 Thread Andrew Vasquez
On Fri, 26 Aug 2005, James Bottomley wrote: On Fri, 2005-08-26 at 19:08 -0700, Andrew Vasquez wrote: WRT_REG_DWORD(reg-ctrl_status, CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES); - RD_REG_DWORD(reg-ctrl_status

Re: regression w/ qla2300 - oopses..

2005-08-26 Thread Andrew Vasquez
On Fri, 26 Aug 2005, James Bottomley wrote: On Fri, 2005-08-26 at 14:52 -0700, Andrew Morton wrote: Is there not some nasty little hack we can do to make the crash go away in the interim? Well, it's nasty. The problem is that klist_next() refers to the previous element to get the next

[PATCH 0/16] qla2xxx: update qla2xxx driver to 8.01.00.

2005-08-26 Thread Andrew Vasquez
://ftp.qlogic.com/outgoing/linux/patches/8.x/8.01.00k/ Regards, Andrew Vasquez QLogic Corporation -- Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/16] qla2xxx: Export class-of-service (COS) information.

2005-08-26 Thread Andrew Vasquez
Export class-of-service (COS) information. Export COS information for the fc_host and fc_remote_port objects added by the driver. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |4 drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx

[PATCH 1/16] qla2xxx: Use dma_get_required_mask() in determining the 'ideal' DMA mask.

2005-08-26 Thread Andrew Vasquez
, as the ISP24xx uses command-type 7 IOCBs which use 64bit DSDs. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c | 33 ++--- 1 files changed, 10 insertions(+), 23 deletions(-) 2978995966996a021e5ac86dbccf917846553754 diff --git a/drivers/scsi

[PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling.

2005-08-26 Thread Andrew Vasquez
Correct ISP24xx soft-reset handling. A driver must wait 100us before attempting an MMIO operation to the RISC after a soft-reset has been initiated. A similar delay was needed with earlier ISPs. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.c | 10

[PATCH 6/16] qla2xxx: Simplify redundant target/device reset logic.

2005-08-26 Thread Andrew Vasquez
Simplify redundant target/device reset logic. Remove redundant qla2x00_target_reset() function in favour of the equivalent qla2x00_device_reset(). Update callers of old function. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gbl.h |3 -- drivers/scsi/qla2xxx

[PATCH 4/16] qla2xxx: Add FDMI support.

2005-08-26 Thread Andrew Vasquez
Add FDMI support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.h |7 drivers/scsi/qla2xxx/qla_def.h | 151 ++ drivers/scsi/qla2xxx/qla_gbl.h |4 drivers/scsi/qla2xxx/qla_gs.c | 564 +++ drivers/scsi

[PATCH 7/16] qla2xxx: Correct LED scheme definition.

2005-08-26 Thread Andrew Vasquez
Correct LED scheme definition. Original implementation used an overloaded bit in the EFI parameters. The correct bit is BIT_4 of the special_options section of NVRAM. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |4 ++-- drivers/scsi/qla2xxx

[PATCH 8/16] qla2xxx: Remove RISC pause/release barriers during flash manipulation.

2005-08-26 Thread Andrew Vasquez
Remove RISC pause/release barriers during flash manipulation. Remove unnecessary RISC pause/release barriers during ISP24xx flash manipulation. The ISP24xx can arbitrate flash access requests during RISC executions. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx

[PATCH 9/16] qla2xxx: Remove redundant call to pci_unmap_sg().

2005-08-26 Thread Andrew Vasquez
Remove redundant call to pci_unmap_sg(). In a corner-case failure where the request-q does not contain enough entries for a given request, pci_unmap_sg() would be called twice. Remove direct call and let the failure-path logic handle the unmapping. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

[PATCH 11/16] qla2xxx: Add host attributes.

2005-08-26 Thread Andrew Vasquez
. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c | 132 +++ drivers/scsi/qla2xxx/qla_gbl.h |2 + drivers/scsi/qla2xxx/qla_os.c |2 + 3 files changed, 136 insertions(+), 0 deletions

[PATCH 10/16] qla2xxx: Add change_queue_depth/type() API support.

2005-08-26 Thread Andrew Vasquez
Add change_queue_depth/type() API support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) c61d82773aa6675dd6e8553f5aee97a743948689 diff --git a/drivers/scsi/qla2xxx

[PATCH 13/16] qla2xxx: Remove bad call to fc_remove_host() during probe failure.

2005-08-26 Thread Andrew Vasquez
/qla_os.c @@ -1586,8 +1586,6 @@ int qla2x00_probe_one(struct pci_dev *pd return 0; probe_failed: - fc_remove_host(ha-host); - qla2x00_free_device(ha); scsi_host_put(host); -- Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi

[PATCH 14/16] qla2xxx: Replace schedule_timeout().

2005-08-26 Thread Andrew Vasquez
] Signed-off-by: Domen Puncer [EMAIL PROTECTED] Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) e7a48fd7d795d483405f7b30990e3745a2668288 diff --git a/drivers/scsi/qla2xxx/qla_os.c

[PATCH 15/16] qla2xxx: Stop firmware execution at unintialization time.

2005-08-26 Thread Andrew Vasquez
Stop firmware execution at unintialization time. On ISP24xx parts, stop execution of firmware during ISP tear-down. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_gbl.h |3 +++ drivers/scsi/qla2xxx/qla_mbx.c | 30

[PATCH 16/16] qla2xxx: Update version number to 8.01.00-k.

2005-08-26 Thread Andrew Vasquez
Update version number to 8.01.00-k. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_version.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) 9fdabc46aa84637af6518661786d624da60830c5 diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi

Re: qla2xxx: does not respond to SCSI_IOCTL_PROBE_HOST

2005-08-24 Thread Andrew Vasquez
On Wed, 24 Aug 2005, Drew Winstel wrote: Here's the situation. I am running a QLogic QLA2200 (32-bit mode; lspci output follows), and when I issue an ioctl() to call SCSI_IOCTL_PROBE_HOST to /dev/sg0 (example code follows as well), the ioctl() returns 0, as if to imply that there is no host

Re: calling scsi_adjust_queue_depth() during I/O...

2005-08-05 Thread Andrew Vasquez
On Fri, 05 Aug 2005, Tejun Heo wrote: Oops, forget about the previous mail. Above patch make it into the tree and it's the source of the problem. My git HEAD was pointing at the latest update but I haven't updated my cache, so I was looking at the old source tree. My apologies for

Re: Fix up qla2xxx configuration bogosity

2005-07-28 Thread Andrew Vasquez
On Thu, 28 Jul 2005, James Bottomley wrote: On Wed, 2005-07-27 at 22:10 -0700, Andrew Vasquez wrote: Would you also apply the attached patch which adds the appropriate FW_LOADER pre-requisite and a separate entry for ISP24xx support. That's what I see reading the code; however, it looks

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-27 Thread Andrew Vasquez
On Wed, 27 Jul 2005, Rajat Jain wrote: On 7/27/05, Andrew Vasquez [EMAIL PROTECTED] wrote: A similar problem was noted with RHEL4, it seems the modules.pcimap and pci.ids file were correct, but the pcitable file contained entries for all ql[ae]23xx based HBAs to load qla2300.ko

Re: Incorrect driver getting loaded for Qlogic FC-HBA

2005-07-26 Thread Andrew Vasquez
distro are you using? If you are using RHEL, and are still having problems, I'd suggest you file a report with Redhat. Regards, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile

2005-07-15 Thread Andrew Vasquez
, but this is so horribly wrong. Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig --- a/drivers/scsi

Re: [PATCH 0/17] qla2xxx: Add ISP24xx support.

2005-07-08 Thread Andrew Vasquez
James, Here's three small patches which fix-up several issues found since my original patchset. Should apply cleanly to a scsi-misc-2.6 tree with the previous patch set applied. Thanks, Andrew Vasquez - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

[PATCH] qla2xxx: Add firmware version number to qla24xx_fw_version_str().

2005-07-08 Thread Andrew Vasquez
Add firmware version number to qla24xx_fw_version_str(). Original code was accidently trimmed during port. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_os.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) 21fad7fa5cb535355f128fc0459a2de79f1975be

[PATCH] qla2xxx: Cleanup FC remote port registration.

2005-07-08 Thread Andrew Vasquez
/PRLI bits). This allows for a more cleaner rport-dd_data management as can be seen with the simplified qla2xxx_slave_alloc() function. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_init.c | 17 ++--- drivers/scsi/qla2xxx/qla_os.c | 16

[PATCH] qla2xxx: Consolidate ISP24xx chip reset logic.

2005-07-08 Thread Andrew Vasquez
Consolidate ISP24xx chip reset logic. Consolidate near-duplicate RISC reset logic from qla24xx_reset_chip() and qla24xx_chip_diag(). Also, after initiating a soft-reset, insure the firmware has completed all NVRAM accesses before continuing. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED

[PATCH 0/17] qla2xxx: Add ISP24xx support.

2005-07-06 Thread Andrew Vasquez
://ftp.qlogic.com/outgoing/linux/patches/8.x/8.01.00b5k/ Hopefully this patch-set addresses the issues voiced against the earlier 4gb submission. Regards, Andrew Vasquez QLogic Corporation commit cb2ccfbc4f91e62e69d2f84992a45a557c02230d Author: Andrew Vasquez [EMAIL PROTECTED] Date: Wed Jul 6 09:25:46

[PATCH 14/17] qla2xxx: Firmware updates.

2005-07-06 Thread Andrew Vasquez
Firmware updates. Resync with latest 21xx firmware -- 1.19.25. Resync with latest 22xx firmware -- 2.02.08. Resync with latest 23xx/63xx firmware -- 3.03.15. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] This patch is too large for an inline patch, please download the bzip'd patch

[PATCH 15/17] qla2xxx: Update copyright banner.

2005-07-06 Thread Andrew Vasquez
Update copyright banner. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/ql2100.c |2 +- drivers/scsi/qla2xxx/ql2200.c |2 +- drivers/scsi/qla2xxx/ql2300.c |2 +- drivers/scsi/qla2xxx/ql2322.c |2 +- drivers/scsi/qla2xxx/ql6312.c

[PATCH 16/17] qla2xxx: Correct maximum supported lun and target-id definitions.

2005-07-06 Thread Andrew Vasquez
Correct maximum supported lun and target-id definitions. The driver uses command-IOCBs which support a maximum lun value of 0x -- correct #define to reflect the change. Also, remove superfluous MAX_TARGET definition. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx

[PATCH 8/17] qla2xxx: Add ISP24xx IOCB manipulation routines.

2005-07-06 Thread Andrew Vasquez
Add ISP24xx IOCB manipulation routines. Add appropriate glue-code for ISP24xx support while manipulting IOCB packets. Add an ISP24xx specific 'start_scsi' routine due to command-type-7 layout changes. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_gbl.h|1

[PATCH 13/17] qla2xxx: Code scrubbing.

2005-07-06 Thread Andrew Vasquez
Code scrubbing. - Remove trailing whitespace from driver files. - Remove unused #defines and inlines. - Standardize on C comments (// - /* */) Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_dbg.c | 130 ++- drivers/scsi

[PATCH 1/17] qla2xxx: Factor-out ISP specific functions to method-based call tables.

2005-07-06 Thread Andrew Vasquez
Factor-out ISP specific functions to method-based call tables. In anticipation of ISP24xx/ISP25xx support, factor-out ISP specific functions into a method-based call table. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |5 - drivers/scsi/qla2xxx

<    1   2   3   >