Patches adds Praveen Madhavan as maintainer for the csiostor driver
and cleans up dead code in the csiostor driver.
Applies on e56f698bd072 ('blk-mq: set default timeout as 30 seconds')
at hare/scsi-devel master
Anish Bhatt (2):
scsi : Add maintainer for csiostor driver
csiosto
Code guarded by __CSIO_DEBUG__ was dead code, fix via
csio_dbg now direcly calling dev_dbg, so output can be controlled
by changing kernel log level.
This dead code also enabled many BUG_ON() calls, use the preferred
WARN_ON() for any debug-only asserts instead.
Signed-off-by: Anish Bhatt
Add Praveen Madhavan as maintainer for Chelsio FCoE
driver (csiostor)
Signed-off-by: Anish Bhatt
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2d3d55c..88cfbaf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2641,6 +2641,13 @@ M
> -Original Message-
> From: Nicholas Krause [mailto:xerofo...@gmail.com]
> Sent: Thursday, September 3, 2015 10:44 AM
> To: jbottom...@odin.com
> Cc: h...@suse.de; micha...@cs.wisc.edu; da...@davemloft.net; Anish
> Bhatt; Hariprasad S; linux-scsi@vger.kernel
> -Original Message-
> From: Nicholas Krause [mailto:xerofo...@gmail.com]
> Sent: Thursday, September 3, 2015 10:09 AM
> To: jbottom...@odin.com
> Cc: h...@suse.de; micha...@cs.wisc.edu; da...@davemloft.net; Anish
> Bhatt; Hariprasad S; linux-scsi@vger.kernel
> -Original Message-
> From: Praveen Madhavan
> Sent: Friday, September 4, 2015 6:12 AM
> To: Anish Bhatt; Nicholas Krause; jbottom...@odin.com
> Cc: h...@suse.de; micha...@cs.wisc.edu; da...@davemloft.net;
> Hariprasad S; linux-scsi@vger.kernel.org; linux-ker.
> -Original Message-
> From: Nicholas Krause [mailto:xerofo...@gmail.com]
> Sent: Wednesday, September 2, 2015 10:36 AM
> To: jbottom...@odin.com
> Cc: h...@suse.de; micha...@cs.wisc.edu; da...@davemloft.net; Anish
> Bhatt; Hariprasad S; linux-scsi@vger.kernel
Acked-by: Anish Bhatt --
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Hariprasad Shenai
This patch cleanups all other macros/register define related to
CPL messages that are defined in t4_msg.h and the affected files
Signed-off-by: Anish Bhatt
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/cm.c | 20 +--
drivers
From: Hariprasad Shenai
This patch cleanups all macros/register define related to connection management
CPL messages that are defined in t4_msg.h and the affected files
Signed-off-by: Anish Bhatt
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/cm.c | 78
This patch series cleans up all register defines/MACROS defined in t4_msg.h and
affected files as part of the continuing cleanup effort
The patches series is created against 'net-next' tree and includes patches
to the cxgb4, cxgb4vf, iw_cxgb4, cxgb4i and csiostor drivers.
We have included all t
> This series does not apply cleanly at all to net-next, it gets many
> rejects.
Hey Dave, this patchset was mostly bugfixes and hence meant for net where it
applies cleanly. not net-next. We can rebase to net-next and send if you're
still
willing to take it before net-next closes.
-Anish--
To u
.
Signed-off-by: Anish Bhatt
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 ++
drivers/scsi/cxgbi/libcxgbi.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 3e0a0d3..f48f40ce 100644
--- a/drivers
) & csiostor
Signed-off-by: Anish Bhatt
---
drivers/infiniband/hw/cxgb4/cm.c| 104 ++--
drivers/infiniband/hw/cxgb4/mem.c | 20 ++--
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 +-
drivers/net/ethernet/chelsio/cxgb4/l2t.c| 2 +-
dri
Connection retries were not being cleaned up correctly if they failed as a
result of link down. Applies on top of drivers-for-3.18.
v2 : Previous patch casued a build failure and was backed out. Fixed and
verified with this patch.
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Christoph, this fixes the build failure from the previous patch. Sorry about
that. Please apply to drivers-for-3.18 as well.
-Anish
Signed-off-by: Anish Bhatt
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i
First patch adds missing maintainers for cxgb3i/cxgb4i.
Second is a bugfix
Please apply on drivers-for-3.18
Anish Bhatt (2):
cxgbi : Add Maintainer for cxgb3i/cxgb4i
cxgb4i : Send abort_rpl correctly
MAINTAINERS| 14 ++
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
Signed-off-by: Anish Bhatt
---
MAINTAINERS | 14 ++
1 file changed, 14 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 82d4ad2..254cb28 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2742,6 +2742,13 @@ W: http://www.chelsio.com
S: Supported
F: drivers/net
Connection retries were not being cleaned up correctly if they failed as a
result of link down. Applies on top of drivers-for-3.18
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 15 +--
drivers/scsi/cxgbi/libcxgbi.c | 18
> On 10/16/2014 05:59 PM, Anish Bhatt wrote:
> > libcxgbi was always returning an ipv4 address for
> > ISCSI_HOST_PARAM_IPADDRESS, return appropriate address based on
> > address family
> >
> > Signed-off-by: Anish Bhatt
> > Signed-off-by: Karen Xie
>
>> Anything that is an urgent and/or very small fix should just be against
>> Linus' current tree and will go into the drivers branch for that tree.
>
>> Anything bigger and/or less urgent should be sent against the drivers
>> branch for the next release.
> Linux 3.17 has been released. The curr
Aah, thanks for the clarification. I have made mistakenly made this patch
against drivers-for-3.18 then, but it applies cleanly to drivers-for-3.17 as
well, please apply this to drivers-for-3.17.
-Anish
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mess
I actually wanted to get some clarification on how the branches on scsi-queue
work. The core/drivers separation is easy enough, but the current branches
are confusing. If say I am submitting a bug fix for the next 3.17 release, what
branch should I be basing my changes on ? Is there a preferred
libcxgbi was always returning an ipv4 address for ISCSI_HOST_PARAM_IPADDRESS,
return appropriate address based on address family
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
---
drivers/scsi/cxgbi/libcxgbi.c | 42 +-
drivers/scsi/cxgbi/libcxgbi.h
Please do not apply this patch. This got fixed in the net tree as part of a
larger changeset, at the following commit :
587ddfe2d212 (cxgb4i : Remove duplicated CLIP handling code)
-Anish--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@
cxgb4 already handles CLIP updates from a previous changeset for iw_cxgb4,
there is no need to have this functionality in cxgb4i. Remove duplicated code
Signed-off-by: Anish Bhatt
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 7 ++
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 133
cxgb4 ipv6 does not guard against ipv6 being disabled, or the standard
ipv6 module vs inbuilt tri-state issue. This was fixed for cxgb4i & iw_cxgb4
but missed for cxgb4.
Signed-off-by: Anish Bhatt
---
drivers/net/ethernet/chelsio/Kconfig| 2 +-
drivers/net/ethernet/chelsio/c
There is an extra call to dst_neigh_lookup() leftover in cxgb4i that can cause
an unreleased refcnt issue. Remove extraneous call.
Signed-off-by: Anish Bhatt
Fixes : 759a0cc5a3e1b ('cxgb4i: Add ipv6 code to driver, call into libcxgbi
ipv6 api')
---
drivers/scsi/cxgbi/cxgb4i/cx
, make subject more concise as
recommended by Dave Miller.
Anish Bhatt (4):
cxgb4i : Remove duplicated CLIP handling code
cxgb4 : Fix build failure in cxgb4 when ipv6 is disabled/not in-built
cxgb4i : Fix -Wunused-function warning
cxgb4i: Remove duplicate call to dst_neigh_lookup()
drivers
A bunch of ipv6 related code is left on by default. While this causes no
compilation issues, there is no need to have this enabled by default. Guard
with an ipv6 check, which also takes care of a -Wunused-function warning.
Signed-off-by: Anish Bhatt
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 8
We should have been calling netdev_master_upper_dev_get_rcu() instead of
netdev_master_upper_dev_get() all along since this is called with an
rcu_read_lock()
Please queue up for the next set of fixes for 3.17 as well.
-Anish
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Fixes
d for 3.17, and I assumed the
bugfixes would automatically be picked for the next rc. If James doesn't pick
this up, I'll send it to stable when appropriate.
-Anish
From: Christoph Hellwig [h...@infradead.org]
Sent: Wednesday, October 01, 2014 12:4
Little late, but I was hoping this would be pushed as part of fixes to 3.17.
Is it too late for that ?
-Anish
From: Christoph Hellwig [h...@infradead.org]
Sent: Monday, September 22, 2014 7:45 AM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; jbottom
Pinging for visibility
-Anish
From: Anish Bhatt [an...@chelsio.com]
Sent: Monday, September 15, 2014 5:44 PM
To: linux-scsi@vger.kernel.org
Cc: jbottom...@parallels.com; h...@infradead.org; Karen Xie; Manoj Malviya;
Anish Bhatt
Subject: [PATCH scsi] cxgb4i
From: Randy Dunlap [rdun...@infradead.org]
Sent: Monday, September 15, 2014 8:17 PM
To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David Miller
Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com;
jim.ep
> From : Randy Dunlap [rdun...@infradead.org]
> Sent: Monday, September 15, 2014 5:20 PM
> To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David
> Miller
> Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com;
> jim.ep...@gmail.com
&
cxgbi_inet6addr_handler() can be called in interrupt context, so use rcu
protected list while finding netdev
Applies on top of core-for-3.18
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Fixes: fc8d0590d914 ("libcxgbi: Add ipv6 api to driver")
Fixes: 759a0cc5a3e1 ("cxgb4i
Required for avoiding recursive dependencies in the Kconfig, brought out
by fixing randconfig error for bnx2i/bnx2fc in the patch that follows.
As suggested by Randy Dunlap
Signed-off-by: Anish Bhatt
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
will only 'm' or 'n' when ipv6 is
compiled as a module.
Fixes: c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Signed-off-by: Anish Bhatt
---
drivers/scsi/bnx2fc/Kconfig | 1 +
drivers/scsi/bnx2i/Kconfig | 1 +
2 files changed, 2 insertions(+)
dif
error.
Entire thread can be followed here : https://lkml.org/lkml/2014/9/9/500
-Anish
Fixes: c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
Anish Bhatt (2):
scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting
NET
bnx2i/bnx2fc : fix randconfig e
Thanks for the heads up, will wait for those. Please cc me/Manoj on the patches
-Anish
From: Martin K. Petersen [martin.peter...@oracle.com]
Sent: Thursday, August 21, 2014 2:47 PM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; h...@infradead.org; jbottom
We tested against a Sanblaze target.
-Anish
From: Sagi Grimberg [sa...@dev.mellanox.co.il]
Sent: Thursday, August 14, 2014 2:25 AM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; h...@infradead.org; jbottom...@parallels.com;
micha...@cs.wisc.edu; Karen
Adding Casey who's actually incharge of this code and missing from the CC list
-Anish
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
branches, but not in master. Do the patches need to be
rebased onto drivers-for-3.17 then ?
-Anish
____
From: Anish Bhatt
Sent: Wednesday, August 06, 2014 7:35 PM
To: Mike Christie
Cc: linux-scsi@vger.kernel.org; h...@infradead.org; jbottom...@parallels.com;
This patch was made over scsi-devel/master, I'll rebase it to Christoph's tree
-Anish
From: Mike Christie [micha...@cs.wisc.edu]
Sent: Wednesday, August 06, 2014 7:25 PM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; h...@infradead.or
The following patch adds T10 DIF support to libiscsi. I didn't see any merge
window messages on linux-scsi, I hope I'm not sending this out of sync.
-Anish
Anish Bhatt (1):
libiscsi : Add T10 Data Integrity Feature support
drivers/scsi/libiscsi.c | 61 +++--
dr
Signed-off-by: Anish Bhatt
Signed-off by: Manoj Malvia
Signed-off by: Karen Xie
---
drivers/scsi/libiscsi.c | 61 +++--
drivers/scsi/libiscsi_tcp.c | 296
include/scsi/libiscsi.h | 6 +
include/scsi/libiscsi_tcp.h | 22
4 files
Christoph,
Sure, we can wait for some time, not a problem. No urgent fixes are
required
-Anish
From: Christoph Hellwig [h...@infradead.org]
Sent: Friday, August 01, 2014 6:39 AM
To: Anish Bhatt
Cc: linux-scsi@vger.kernel.org; h...@infradead.org
Christoph/James/Mike
Is there a timeline for pulling in the cxgb4i changes from net-next,
or a specific way to ask for it ? We have more changes in queue for cxgb4i &
libiscsi, and I would rather have the cxgb4i up to date in the scsi tree
before we do that to avoid any potentil issues in t
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
---
drivers/scsi/cxgbi/libcxgbi.c | 237 ++
drivers/scsi/cxgbi/libcxgbi.h | 21 +++-
2 files changed, 237 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/cxgbi
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication
Signed-off-by: Anish Bhatt
Acked-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 1 -
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a
with actual ipv6 code in libcxgbi/cxgb4i.
Submitting to net-next as changes were needed in cxgb4/iw_cxgb4, and submitting
to scsi separately would break compilation, cc-ing scsi & rdma.
-Anish
v2 : Cleanup macro that prints ip addresses by using %pIS in patch 3
Anish Bhatt (4):
cxgb4/iw_cxg
Signed-off-by: Anish Bhatt
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 ++
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 4
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 2 ++
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 353 +
1 file changed, 314 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
b/drivers/scsi/cxgbi/cxgb4i
ee.
-Anish
From: Christoph Hellwig [h...@infradead.org]
Sent: Wednesday, July 16, 2014 1:08 AM
To: Anish Bhatt
Cc: net...@vger.kernel.org; linux-r...@vger.kernel.org;
linux-scsi@vger.kernel.org; da...@davemloft.net; rol...@purestorage.com;
h...@infradead.org; micha...@cs.wisc.edu; jbottom...@par
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 353 +
1 file changed, 314 insertions(+), 39 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
b/drivers/scsi/cxgbi/cxgb4i
Signed-off-by: Anish Bhatt
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 ++
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 4
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 2 ++
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication
Signed-off-by: Anish Bhatt
Acked-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 1 -
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a
with actual ipv6 code in libcxgbi/cxgb4i.
Submitting to net-next as changes were needed in cxgb4/iw_cxgb4, and submitting
to scsi separately would break compilation, cc-ing scsi & rdma.
Anish Bhatt (4):
cxgb4/iw_cxgb4: Move common defines to cxgb4
cxgb4: Export symbols required by cxgb4i
Signed-off-by: Anish Bhatt
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
---
drivers/scsi/cxgbi/libcxgbi.c | 237 ++
drivers/scsi/cxgbi/libcxgbi.h | 37 ++-
2 files changed, 253 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/cxgbi
60 matches
Mail list logo