[PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

2013-10-28 Thread Asias He
vqs are freed in virtscsi_freeze but the hotcpu_notifier is not unregistered. We will have a use-after-free usage when the notifier callback is called after virtscsi_freeze. Signed-off-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 15 ++- 1 file changed, 14

Re: [PATCH] vhost/scsi: Fix incorrect usage of get_user_pages_fast write parameter

2013-10-27 Thread Asias He
- WRITE payload case. This bug would manifest itself as random process segmentation faults on KVM host after repeated vhost starts + stops and/or with lots of vhost endpoints + LUNs. Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Asias He

[PATCH] virtio-scsi: Fix virtqueue affinity setup

2013-07-31 Thread Asias He
] __virtscsi_set_affinity+0x6f/0x120 RSP 88007bfe5a38 CR2: 0020 ---[ end trace 99679331a3775f48 ]--- CC: sta...@vger.kernel.org Signed-off-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b

Re: [PATCH 9/9] vhost/scsi: Convert to se_cmd-cmd_kref TARGET_SCF_ACK_KREF usage

2013-06-26 Thread Asias He
: Christoph Hellwig h...@lst.de Cc: Roland Dreier rol...@kernel.org Cc: Kent Overstreet koverstr...@google.com Cc: Asias He as...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Or Gerlitz ogerl...@mellanox.com Cc: Moussa Ba mouss...@micron.com Signed-off-by: Nicholas Bellinger n...@linux

Re: [PATCH 5/9] virtio-scsi: Implement TMF timeout

2013-06-12 Thread Asias He
Reinecke h...@suse.de Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 1efd219..abfc684 100644 --- a/drivers/scsi/virtio_scsi.c +++ b

Re: [PATCH 4/9] virtio_scsi: Enable new EH timeout handler

2013-06-12 Thread Asias He
On Mon, Jun 10, 2013 at 09:40:53AM +0200, Hannes Reinecke wrote: Signed-off-by: Hannes Reinecke h...@suse.de Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

2013-05-03 Thread Asias He
On Fri, May 03, 2013 at 09:57:20AM +0300, Or Gerlitz wrote: On Thu, May 2, 2013 at 10:31 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: We used RAMDISK_MCP backend which was patched to act as NULL device, so we can test the raw iSER wire performance. Btw, I'll be including a

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-06 Thread Asias He
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote: On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: On 03/28/2013 10:22 AM, Wanlong Gao wrote: On 03/23/2013 07:28 PM, Wanlong Gao wrote: This series implements virtio-scsi queue steering, which gives performance

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Asias He
-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 13d7672..0ad9017 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi

Re: [PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Asias He
as a parameter because everything should now happen dynamically. Cc: James Bottomley james.bottom...@hansenpartnership.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-19 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote: From: Paolo Bonzini pbonz...@redhat.com virtio_scsi_target_state is now empty, but we will find new uses for it in the next few patches. However, dropping the sglist lets us turn the array-of-pointers into a simple array, which

Re: [PATCH V4 0/5] virtio-scsi multiqueue

2013-03-19 Thread Asias He
Wanlong Gao (1): virtio-scsi: reset virtqueue affinity when doing cpu hotplug drivers/scsi/virtio_scsi.c | 364 - 1 file changed, 291 insertions(+), 73 deletions(-) -- 1.8.2.rc2 Patch 2-5 Reviewed-by: Asias He as...@redhat.com -- Asias

Re: [PATCH] target/file: Add WRITE_SAME w/ UNMAP=0 emulation support

2013-02-19 Thread Asias He
with 512, 1k, 2k, and 4k block_sizes. Cc: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Asias He as...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/target/target_core_file.c | 115

Re: [PATCH] target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status

2013-01-29 Thread Asias He
On 01/30/2013 02:57 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch allows IBLOCK to check block hints in request_queue-flush_flags when reporting current backend device WriteCacheEnabled status to a remote SCSI initiator port. This is done via a

Re: [PATCH 6/8] V2 ipr: Implement block iopoll

2013-01-11 Thread Asias He
Hello Wen Xiong, On Sat, Jan 12, 2013 at 7:43 AM, wenxi...@linux.vnet.ibm.com wrote: This patch implements blk iopoll in ipr driver for performance improvement. Can you provide the performance numbers with/without the io polling? It would be interesting to know. Signed-off-by: Wen Xiong

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Asias He
+++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asias He