vqs are freed in virtscsi_freeze but the hotcpu_notifier is not
unregistered. We will have a use-after-free usage when the notifier
callback is called after virtscsi_freeze.
Signed-off-by: Asias He
---
drivers/scsi/virtio_scsi.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion
irtio-scsi DMA_TO_DEVICE -> WRITE payload case.
>
> This bug would manifest itself as random process segmentation faults on
> KVM host after repeated vhost starts + stops and/or with lots of vhost
> endpoints + LUNs.
>
> Cc: Stefan Hajnoczi
> Cc: Michael S. Tsirkin
gt; 8b 47 20 48 8b 80 d0 01 00 00 48 8b 40 50 48 85 c0 74 07 be
RIP [] __virtscsi_set_affinity+0x6f/0x120
RSP
CR2: 0020
---[ end trace 99679331a3775f48 ]---
CC: sta...@vger.kernel.org
Signed-off-by: Asias He
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file changed, 1 insertion(+)
gt;cmd_kref put occurs.
>
> Cc: Christoph Hellwig
> Cc: Roland Dreier
> Cc: Kent Overstreet
> Cc: Asias He
> Cc: Michael S. Tsirkin
> Cc: Or Gerlitz
> Cc: Moussa Ba
> Signed-off-by: Nicholas Bellinger
Acked-by: Asias He
> ---
> drivers/vhost/scsi.c |
se_cmd is still active from TCM's perspective
> when transport_generic_free_cmd() is called.
>
> Cc: Christoph Hellwig
> Cc: Roland Dreier
> Cc: Kent Overstreet
> Cc: Asias He
> Cc: Michael S. Tsirkin
> Cc: Or Gerlitz
> Cc: Moussa Ba
> Signed-off-by: Nicholas B
On Mon, Jun 10, 2013 at 09:40:53AM +0200, Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke
Reviewed-by: Asias He
> ---
> drivers/scsi/virtio_scsi.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi
gned-off-by: Hannes Reinecke
Reviewed-by: Asias He
> ---
> drivers/scsi/virtio_scsi.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index 1efd219..abfc684 100644
> --- a/drivers/scsi
On Fri, May 03, 2013 at 09:57:20AM +0300, Or Gerlitz wrote:
> On Thu, May 2, 2013 at 10:31 PM, Nicholas A. Bellinger
> wrote:
>
> >> We used RAMDISK_MCP backend which was patched to act as NULL device, so
> >> we can test the raw iSER wire performance.
>
> > Btw, I'll be including a similar patc
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote:
> On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote:
> > On 03/28/2013 10:22 AM, Wanlong Gao wrote:
> > > On 03/23/2013 07:28 PM, Wanlong Gao wrote:
> > >> This series implements virtio-scsi queue steering, which gives
> > >> perfo
nd no need to pass in the maximum target size as a parameter because
> everything should now happen dynamically.
>
> Cc: James Bottomley
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Wanlong Gao
Reviewed-by:
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote:
> Add hot cpu notifier to reset the request virtqueue affinity
> when doing cpu hotplug.
>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Paolo Bonzini
> Signed-off-by: Wanlong Gao
> Reviewed-by: Asias He
--
> 1 file changed, 291 insertions(+), 73 deletions(-)
>
> --
> 1.8.2.rc2
>
Patch 2-5
Reviewed-by: Asias He
--
Asias
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote:
> From: Paolo Bonzini
>
> virtio_scsi_target_state is now empty, but we will find new uses
> for it in the next few patches. However, dropping the sglist lets
> us turn the array-of-pointers into a simple array, which simplifies
> the
On Fri, Mar 8, 2013 at 9:45 AM, Nicholas A. Bellinger
wrote:
> From: Nicholas Bellinger
>
> This patch converts struct iscsi_cmd memory allocation + free to use
> ->iscsit_alloc_cmd() + ->iscsit_free_cmd() iscsit_transport API caller,
> and export iscsit_allocate_cmd() + iscsit_free_cmd() symbols
e_same_len to the operational default at setup ->
> fd_configure_device() time.
>
> Tested with 512, 1k, 2k, and 4k block_sizes.
>
> Cc: Martin K. Petersen
> Cc: Christoph Hellwig
> Cc: Asias He
> Signed-off-by: Nicholas Bellinger
> ---
> drivers/target/target
On 01/30/2013 02:57 PM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> This patch allows IBLOCK to check block hints in request_queue->flush_flags
> when reporting current backend device WriteCacheEnabled status to a remote
> SCSI initiator port.
>
> This is done via a se_subsystem_
Hello Wen Xiong,
On Sat, Jan 12, 2013 at 7:43 AM, wrote:
> This patch implements blk iopoll in ipr driver for performance improvement.
Can you provide the performance numbers with/without the io polling?
It would be interesting to know.
> Signed-off-by: Wen Xiong
> ---
> drivers/scsi/ipr.c |
er.kernel.org
> drivers/scsi/virtio_scsi.c | 43 +++
> 1 file changed, 23 insertions(+), 20 deletions(-)
>
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to ma
On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote:
On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote:
Hi folks,
[I am resending to fix the broken thread in the previous one.]
This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk
device accelerator. Compared to
19 matches
Mail list logo
