RE: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

2008-02-05 Thread Ballabio_Dario
Good to know that somebody still uses the Ultrastor 14f board :). Yes, this typo was introduced by somebody doing massive editing to all scsi drivers long ago. Cheers, --db -Original Message- From: Roel Kluin [mailto:[EMAIL PROTECTED] Sent: Monday, February 04, 2008 11:37 PM To: Ba

[PATCH] EATA and u14-34f driver update for lk-2.4.4

2001-05-01 Thread Ballabio_Dario
Here enclosed release 6.05 of the EATA ISA/EISA/PCI and Ultrastor 14F/34F SCSI drivers. This patch applies to lk-2.4.4. * * 1 May 2001 Rev. 6.05 for linux 2.4.4 *+ Clean up all pci related routines. *+ Fix data transfer direction for opcode SEND_CUE_SHEET (0x5d) *

RE: [PATCH] consolidating data direction tables

2001-02-13 Thread Ballabio_Dario
I support the idea of the 2 bit. The EATA protocol requires to specify either DATA_IN or DATA_OUT or DATA_NONE. The data_out table by itself is not enough. -db -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Tuesday, February 13, 2001 10:42 AM To: Oliver Ne

RE: scsi_unjam_host and scsi_try to abort_command

2001-02-10 Thread Ballabio_Dario
> >> and then issue a spin_lock again. Your UP system is likely to be very little >> or >> not responsive at all during the above process, but this is an unavoidable >> price to >> be paid in the last attempt to avoid a full system crash. Pls. note that in >Well the driver isnt allowed to hold i

RE: scsi_unjam_host and scsi_try to abort_command

2001-02-10 Thread Ballabio_Dario
When scsi_unjam_host is called, your system is likely to be in serious trouble, just very close to become totally unusable. At this a point the low level driver reset routine need to be able to do its best effort in order to clean up the situation without being bothered by any ongoing activity. T

pci_enable_device fix for the EATA driver.

2001-02-08 Thread Ballabio_Dario
This patch applies to lk 2.4.1. It upgrades EATA scsi driver to rev. 6.04. The only difference from 6.03 is to call pci_enable_device before pci_resource_start. Cheers, -db begin 644 eata_6.04.diff M9&EF9B`M"]D"TR M+C0N,2]D"P@861D"5X+EQN(BP*("`@("`@("`@("`@("!D"!I;B!UPHK("`@("`@PH@("`@("`@<')I;

RE: [uPATCH] make drivers/scsi/eata.c call pci_enable_device before rs. probing (241p11)

2001-01-31 Thread Ballabio_Dario
I tested your patch and it has no adverse effects on my development system. If there is a general consensus about the call order from the hot-plug/pci people, I'll include it in my next EATA driver revision. Cheers, -db -Original Message- From: Rasmus Andersen [mailto:[EMAIL PROTECTED]] S

chack_region removal patch for EATA and u14-34f

2001-01-25 Thread Ballabio_Dario
This patch applies to 2.4.0, 2.4.1-pre10 or 2.4.0-ac10. It upgrades both EATA and u14-34f scsi drivers to revision 6.03. The only fix is the check_region replacement. Cheers, -db begin 644 scsi_diff_2.4.0.diff M9&EF9B`M=2`M"TR+C0N,2UP"]D"!I;B!UPHK("`@("`@PH@("`@("`@ M<')I;G1K*"(E71E"P@=6YU#H@0V]

RE: [PATCH] drivers/scsi/u14-35f.c: check_region -> request_region (241p9)

2001-01-24 Thread Ballabio_Dario
Why do you try to introduce bugs in a piece of code which is not broken at all? If do check_region first, than if the probed address is a u14/34f board I do a request_region. Your code do request_region and if the following test fails, the region you requested is not released. Cheers, ***