Re: [PATCH] uas: Add missing le16_to_cpu calls to asm1051 / asm1053 usb-id check

2014-09-11 Thread Bjørn Mork
Hans de Goede hdego...@redhat.com writes: --- a/drivers/usb/storage/uas-detect.h +++ b/drivers/usb/storage/uas-detect.h @@ -73,8 +73,8 @@ static int uas_use_uas_driver(struct usb_interface *intf, * broken on the ASM1051, use the number of streams to differentiate. * New

Re: [PATCH] megaraid_sas: fix memory leak if SGL has zero length entries

2013-06-29 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user supplied length before passing it to dma_alloc_coherent()) introduced a memory leak. Memory allocated for entries following zero length SGL entries will not be freed. Reference: http://bugs.debian.org

Re: [PATCH 4/7][SCSI] mpt3sas: Infinite loops can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned

2013-06-28 Thread Bjørn Mork
Sreekanth Reddy sreekanth.re...@lsi.com writes: Infinite loop can occur if IOCStatus is not equal to MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions _scsih_search_responding_sas_devices, _scsih_search_responding_raid_devices and _scsih_search_responding_expanders

Re: [PATCH 1/1] Create megaraid ioctl device node

2013-05-06 Thread Bjørn Mork
Patrick Monnerat patrick.monne...@datasphere.ch writes: From: Patrick Monnerat p...@datasphere.ch Create ioctl device node for megaraid_sas driver. Let this node be managed by udev. Fix a typo. Or maybe just simplify it all and use a misc device instead? See how this is done in e.g.

Re: [PATCH] mpt2sas: prevent double free on error path

2013-01-23 Thread Bjørn Mork
Jörn Engel jo...@logfs.org writes: diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index c6bdc92..43b3a98 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c @@ -570,6 +570,18 @@

Re: [PATCH -next] [SCSI] mpt3sas: remove unused variables

2012-12-17 Thread Bjørn Mork
sreekanth.re...@lsi.com writes: diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index ac9dbc2..61a1a45 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -2754,13 +2754,11 @@

[PATCH] megaraid_sas: fix memory leak if SGL has zero length entries

2012-11-21 Thread Bjørn Mork
Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/scsi/megaraid/megaraid_sas_base.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index d2c5366..12b6be4 100644 --- a/drivers/scsi

Re: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

2012-09-29 Thread Bjørn Mork
sreekanth.re...@lsi.com writes: This patch contains MPI API headers This patch is part 1 of MPI API headers. Signed-off-by: Sreekanth Reddy sreekanth.re...@lsi.com Reviewed-by: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com --- diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h