[PATCH] qedf: Send the driver state to MFW.

From: Saurav Kashyap Need to notify firmware when driver is loaded and unloaded. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf

Re: [RFC PATCH] qedf: qedf_dcbx_no_wait can be static

o_wait, qedf_dcbx_no_wait, bool, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(dcbx_no_wait, " Do not wait for DCBX convergence to start " > "sending FIP VLAN requests on link up (Default: off)."); > Acked-by: Chad Dupuis

[PATCH 20/21] qedf: Update copyright for 2018.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_fcoe_fw_funcs.h | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.h | 2 +- drivers/scsi/qedf/qedf.h | 2 +- drivers/scsi/qedf/qedf_attr.c

[PATCH 18/21] qedf: Set the UNLOADING flag when removing a vport.

80 RBP: 9a43567d3950 R8: 0c15 R9: 9a3fb09b9880 R10: 9a434fa0e3e8 R11: 9a43567d35ce R12: R13: 9a434f695280 R14: 9a43aa359c80 R15: 9a3fb9e005c0 ORIG_RAX: CS: 0010 SS: 0018 Signed-off-by: Chad Dupuis --

[PATCH 21/21] qedf: Update version number to 8.33.16.20.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 4a19e6f6d843..9455faacd5de 100644 --- a/drivers/scsi/qedf/qedf_version.h +++ b/drivers

[PATCH 17/21] qedf: Add additional checks when restarting an rport due to ABTS timeout.

connection before issuing an ABTS. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 589414f06376..f669df03f37d 100644 --- a/drivers/scsi/qedf

[PATCH 19/21] qedf: Add more defensive checks for concurrent error conditions.

the whole host if the rport is already uploaded or in the process of relogin - Check to state for an fcport before initiating a middle path ELS request Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_els.c | 13 +++-- drivers/scsi/qedf/qedf_io.c | 33

[PATCH 14/21] qedf: Improve firmware debug dump handling.

Get all firmware debug data instead of just a grc dump. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 2 ++ drivers/scsi/qedf/qedf_dbg.c | 2 +- drivers/scsi/qedf/qedf_main.c | 13 - 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 10/21] qedf: Return request as DID_NO_CONNECT if MSI-X is not enabled.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 94d6455c9ddc..78cbd126c7e5 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -931,6

[PATCH 16/21] qedf: If qed fails to enable MSI-X fail PCI probe.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 0150f2e4e75c..31fc64b23566 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf

[PATCH 15/21] qedf: Honor default_prio module parameter even if DCBX does not converge.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3e9befcbd5ba..0150f2e4e75c 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi

[PATCH 06/21] qedf: Sanity check FCoE/FIP priority value to make sure it's between 0 and 7.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 8dcacc5b5f60..1a58f4a9cdf9 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c

[PATCH 00/21] qedf: Update driver to 8.33.16.20.

Hi Martin, Please add these patches to your tree for the next kernel merge window at your convenience. Thanks, Chad Chad Dupuis (20): qedf: Synchronize rport restarts when multiple ELS commands time out. qedf: Increase the number of default FIP VLAN request retries to 60. qedf: Add

[PATCH 03/21] qedf: Add missing skb frees in error path.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 1 + drivers/scsi/qedf/qedf_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index 773558fc0697..aef199c12fb4 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b

[PATCH 13/21] qedf: Remove setting DCBX pending during soft context reset.

change is to remove disabling DCBx flag from soft reset. Signed-off-by: Saurav Kashyap Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 866989ccd66e..be29c8d155c2 100644

[PATCH 02/21] qedf: Increase the number of default FIP VLAN request retries to 60.

Some configurations need more than 30 seconds to respond to a FIP VLAN request so increase the default to 60 seconds. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi

[PATCH 04/21] qedf: Fix VLAN display when printing sent FIP frames.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index aef199c12fb4..c6b984efa5e8 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/drivers/scsi/qedf

[PATCH 05/21] qedf: Add check for offload before flushing I/Os for target.

+0x74/0x80 [ 343.972193] [] entry_SYSCALL_64_fastpath+0x12/0x6d [ 343.975285] DWARF2 unwinder stuck at entry_SYSCALL_64_fastpath+0x12/0x6d Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi

[PATCH 01/21] qedf: Synchronize rport restarts when multiple ELS commands time out.

] [] ? __internal_add_timer+0xab/0x130 [17501.850555] [] ? dequeue_task_fair+0x41e/0x660 [17501.851528] [] fc_rport_work+0xf4/0x6c0 [libfc] [17501.852490] [] process_one_work+0x17a/0x440 [17501.853446] [] worker_thread+0x126/0x3c0 Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 1 + drivers

[PATCH 09/21] qedf: Release RRQ reference correctly when RRQ command times out.

: Flushing ELS request xid=0x96a refcount=2. The fix is to call kref_put on the rrq_req in case of timeout as the timeout handler will call rrq_compl directly vs. a normal completion where it is call from els_compl. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_els.c | 8 1 file

[PATCH 11/21] qedf: Check if link is alraedy up when receiving a link up event from qed.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 64491ae60059..866989ccd66e 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c

[PATCH 12/21] qedf: Add task id to kref_get_unless_zero() debug messages when flushing requests.

Helps to corroborate which requests we can't get reference on and if it's real bug or not. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_

[PATCH 08/21] qedf: Honor priority from DCBX FCoE App tag.

FCoE priority we get in the driver's DCBX handler Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 52 +++ 2 files changed, 39 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/qedf/qed

[PATCH 07/21] qedf: Add dcbx_not_wait module parameter so we won't wait for DCBX convergence to start discovery.

This module parameter is to work around cases where we do not receive the DCBX handler notification from qed but discovery is still possible if we send out a FIP VLAN request irregardless of the DCBX state. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 11 +-- 1 file

Re: [PATCH 6/6] scsi: qedf: use correct strncpy() size

d Bergmann > --- > drivers/scsi/qedf/qedf_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reasonable security precaution. Acked-by: Chad Dupuis

Re: [PATCH 4/6] scsi: qedf: fix LTO-enabled build

ff-by: Arnd Bergmann > --- > drivers/scsi/qedf/qedf_dbg.h | 17 ++--- > drivers/scsi/qedf/qedf_debugfs.c | 6 +++--- > drivers/scsi/qedf/qedf_main.c| 8 +++- > 3 files changed, 16 insertions(+), 15 deletions(-) > Thanks. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

*qedf = lport_priv(lport); > struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device)); > struct fc_rport_libfc_priv *rp = rport->dd_data; > - struct qedf_rport *fcport = rport->dd_data; > + struct qedf_rport *fcport; > struct qedf_ioreq *io_req; > int rc = 0; > int rval; > Acked-by: Chad Dupuis

[PATCH] bnx2fc: Fix check in SCSI completion handler when reqeust has already timed out.

to the ownership of the SCSI layer. This can cause unpredictable results. Solution is to add in the missing return. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc

Re: [PATCH -next] scsi: qedf: Fix error return code in __qedf_probe()

tions(+) > Yeah, we should be returning -ENOMEM in those cases. Acked-by: Chad Dupuis

Re: [RESEND PATCH 1/2] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

- > drivers/scsi/bnx2fc/bnx2fc_hwi.c | 60 > +--- > drivers/scsi/bnx2fc/bnx2fc_tgt.c | 51 +++--- > 2 files changed, 47 insertions(+), 64 deletions(-) > Sorry, didn't realize I needed to ack the resend. Acked-by: Chad Dupuis

Re: [PATCH 7/9] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

; goto mem_alloc_failure; > } > > - memset(tgt->confq_pbl, 0, tgt->confq_pbl_size); > num_pages = tgt->confq_mem_size / CNIC_PAGE_SIZE; > page = tgt->confq_dma; > pbl = (u32 *)tgt->confq_pbl; > @@ -792,15 +787,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > /* Allocate and map ConnDB */ > tgt->conn_db_mem_size = sizeof(struct fcoe_conn_db); > > - tgt->conn_db = dma_alloc_coherent(&hba->pcidev->dev, > - tgt->conn_db_mem_size, > - &tgt->conn_db_dma, GFP_KERNEL); > + tgt->conn_db = dma_zalloc_coherent(&hba->pcidev->dev, > +tgt->conn_db_mem_size, > +&tgt->conn_db_dma, GFP_KERNEL); > if (!tgt->conn_db) { > printk(KERN_ERR PFX "unable to allocate conn_db %d\n", > tgt->conn_db_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->conn_db, 0, tgt->conn_db_mem_size); > > > /* Allocate and map LCQ */ > @@ -808,15 +802,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > tgt->lcq_mem_size = (tgt->lcq_mem_size + (CNIC_PAGE_SIZE - 1)) & >CNIC_PAGE_MASK; > > - tgt->lcq = dma_alloc_coherent(&hba->pcidev->dev, tgt->lcq_mem_size, > - &tgt->lcq_dma, GFP_KERNEL); > + tgt->lcq = dma_zalloc_coherent(&hba->pcidev->dev, tgt->lcq_mem_size, > +&tgt->lcq_dma, GFP_KERNEL); > > if (!tgt->lcq) { > printk(KERN_ERR PFX "unable to allocate lcq %d\n", > tgt->lcq_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->lcq, 0, tgt->lcq_mem_size); > > tgt->conn_db->rq_prod = 0x8000; > > Conversion looks sane. Acked-by: Chad Dupuis

[PATCH] bnx2fc: Fix hung task messages when a cleanup response is not received during abort.

x90 [183373.131509] [] ? kthread_create_on_node+0x140/0x140 Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_io.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c

Re: [PATCH 1/1] scsi: bnx: use setup_timer

(BNX2FC_FLAG_DESTROY_CMPL, > The title of the patch should be fixed up since the driver is 'bnx2fc'. But besides that nit the patch looks good. Acked-by: Chad Dupuis

Re: [PATCH] scsi_transport_fc: set scsi_target_id upon rescan

> Otherwise the port will never be scanned. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_transport_fc.c | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) > Verified that port is scanned after applying this patch. Tested-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Fix a potential NULL pointer dereference

out_put; > } > > /* Copy frame header from firmware into fp */ > @@ -884,9 +885,10 @@ static void qedf_rec_compl(struct qedf_els_cb_arg > *cb_arg) > > out_free_frame: > fc_frame_free(fp); > -out_free: > +out_put: > /* Put reference for original command since REC completed */ > kref_put(&orig_io_req->refcount, qedf_release_cmd); > +out_free: > kfree(cb_arg); > } > > Thanks for the catch. Acked-by: Chad Dupuis

[PATCH 6/6] qedf: Update driver version to 8.20.5.0.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 6fa442061c32..397b3b8ee51a 100644 --- a/drivers/scsi/qedf/qedf_version.h +++ b

[PATCH 5/6] qedf: Fix up modinfo parameter name for 'debug' in modinfo output.

Because we were passing 'qedf_debug' instead of 'debug' to the MODULE_PARM_DESC() macro, modinfo listed the parameter name as 'qedf_debug' instead of it's proper name 'debug'. Correct the parameter name. Signed-off-by: Chad Dupuis --- drivers/sc

[PATCH 4/6] qedf: Covert single-threaded workqueues to regular workqueues.

There is no ordering required for the various workqueues the driver uses so they can be converted to regular workqueues. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b

[PATCH 3/6] qedf: Corrent VLAN tag insertion in fallback VLAN case.

sed the module parameter and is not hardcoded to 1002 (though 1002 is the default). Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 1 - drivers/scsi/qedf/qedf_fip.c | 18 +++--- drivers/scsi/qedf/qedf_main.c | 12 3 files changed, 15 insertions(+), 16 deletions(

[PATCH 1/6] qedf: Set WWNN and WWPN based on values from qed.

If dev_info.wwpn and dev_info.wwnn are set by qed use these values to set the WWNs of the port. Otherwise fall back to the old method using fcoe_wwn_from_mac(). Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions

[PATCH 0/6] Update qedf to version 8.20.5.0.

From: "Chad Dupuis" Hi Martin, Please apply the following patches at your earliest convenience. Thanks, Chad Chad Dupuis (6): qedf: Set WWNN and WWPN based on values from qed. qedf: Use granted MAC from the FCF for the FCoE source address if it is available. qedf: Corren

[PATCH 2/6] qedf: Use granted MAC from the FCF for the FCoE source address if it is available.

affic, offload traffic and setting the data_src_address libfcoe uses for FIP keep alive messages. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 1 - drivers/scsi/qedf/qedf_fip.c | 17 - drivers/scsi/qedf/qedf_main.c | 59 +-- 3

Re: [PATCH v2] scsi: qedf: Limit number of CQs

CQs.. > > Fixes: 3c5da9427802 ("qed: Share additional information with qedf") > Signed-off-by: Thomas Bogendoerfer > --- > > Changes in v2: > - integrated suggested change from Chad Dupuis > > drivers/scsi/qedf/qedf.h | 3 ++- > drivers/scsi/qedf/qe

Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code

++- > drivers/scsi/bnx2i/bnx2i_init.c | 64 --- > include/linux/cpuhotplug.h|2 - > 4 files changed, 53 insertions(+), 126 deletions(-) > We tested the series and everything was fine. Ack to the series. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Limit number of CQs

On Thu, 13 Jul 2017, 12:19pm, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > FCOE offloading on qedf devices fails with: > > [qed_sp_fcoe_func_start:150(sp-0-3b:00.02)]Cannot satisfy CQ amount. CQs >requested 8, CQs available 6. Aborting function start > [qed_fcoe_s

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

On Fri, 7 Jul 2017, 9:14am, Sebastian Andrzej Siewior wrote: > On 2017-06-29 15:57:56 [+0200], Johannes Thumshirn wrote: > > So here we are again, > > Tested-by: Johannes Thumshirn > > > > FCoE will follow as soon as my setup can speak FCoE again. > > So it all looks good, doesn't it? Chad ne

Re: [PATCH][V2] scsi: qedf: fix spelling mistake: "offlading" -> "offloading"

ince since spp type isn't FCP\n"); > + "Not offloading since spp type isn't FCP\n"); > break; > } > if (!(rdata->ids.roles & FC_RPORT_ROLE_FCP_TARGET)) { > Thanks. Acked-by: Chad Dupuis

Re: [PATCH 19/28] qedf: drop bus reset handler

g_reset: reset (for value=0x102) may not be available Given this I don't have an objection to this patch. Tested-by: Chad Dupuis

Re: [PATCH 19/28] qedf: drop bus reset handler

On Wed, 28 Jun 2017, 9:58am, Christoph Hellwig wrote: > On Wed, Jun 28, 2017 at 10:25:07AM +0200, Hannes Reinecke wrote: > > qedf has a host reset handler, but as the bus reset handler is > > a stub always returning SUCCESS the host reset is never invoked. > > So drop the bus reset handler. > >

Re: [PATCH 0/3] scsi: qedf: Fix a return value + some cleanups

ons(+), 25 deletions(-) > > All are sensible small improvements. Ack the series. series-acked-by: Chad Dupuis

Re: [PATCH 00/15] qedf: Update driver to version 8.18.22.0.

On Wed, 24 May 2017, 3:12pm, Martin K. Petersen wrote: > > Chad, > > > Please apply the following patches to the scsi tree at your earliest > > convenience. > > Please address Bart's comments and resubmit. > > Thanks! > > Sure, will submit a V2 that addresses Bart's comments.

Re: [PATCH] bnx2fc: fix race condition in bnx2fc_get_host_stats()

nx2fc_fcoe.c | 10 -- > 2 files changed, 9 insertions(+), 2 deletions(-) > Thanks Maurizio. Acked-by: Chad Dupuis

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On Wed, 17 May 2017, 11:01am, Sebastian Andrzej Siewior wrote: > On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > > Ok, I believe I've found the issue here. The machine that the test has > > performed on had many more possible CPUs than active CPUs. We calculate >

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On Tue, 9 May 2017, 11:18am, James Bottomley wrote: > On Tue, 2017-05-09 at 10:17 -0400, Chad Dupuis wrote: > > On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > > > > > > > Sebastian, > > > > > > > Martin, do you see

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > Sebastian, > > > Martin, do you see any chance to get this merged? Chad replied to the > > list that he is going to test it on 2017-04-10, didn't respond to the > > ping 10 days later. The series stalled last time in the same way. > >

Re: [PATCH] scsi: qedf: Avoid reading past end of buffer

lthough this patch looks fine to me, isn't strlcpy() preferred over > > strncpy()? > > strlcpy doesn't zero-pad, so I think strncpy is preferred here, > otherwise we may risk leaving portions of the destination buffer > filled with uninitialized data, maybe leaking kernel memory contents. > > -Kees > I'd agree with strncpy so we zero out the rest of the buffer. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: properly update arguments position in function call

ST_SEQ | FC_FC_END_SEQ | > FC_FC_SEQ_INIT, 0); > > Thanks. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Cleanup the type of io_log->op

op; /* SCSI CDB */ > uint8_t lba[4]; > unsigned int bufflen; /* SCSI buffer length */ > unsigned int sg_count; /* Number of SG elements */ > Makes sense. Acked-by: Chad Dupuis

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 2:36pm, Randy Dunlap wrote: > On 05/03/17 11:29, Chad Dupuis wrote: > > > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > > >> > >> Hello everybody, > >> > >> While looking into Coverity ID 1402011 I r

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402011 I ran into the following piece of code > at drivers/scsi/qedf/qedf_io.c:2057: > > /* Fill FC header */ > fc_hdr = &(tm_req->req_fc_hdr); > sid = fcport->sid; > did = fcport->r

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

On Mon, 10 Apr 2017, 5:12pm -, Sebastian Andrzej Siewior wrote: > This is a repost to get the patches applied against v4.11-rc6. mkp's scsi > for-next tree can be merged with no conflicts. > > The last repost [0] was not merged and stalled after Martin pinged Chad > [1]. He didn't even reply

Re: [PATCH] scsi: libfc: directly call ELS request handlers

e a bit more obvious. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/libfc/fc_lport.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > A reasonable refactoring. Reviewed-by: Chad Dupuis

Re: [PATCH] qedf: fix wrong le16 conversion

t_st_ctx->read_only.task_type = task_params->task_type; > SET_FIELD(t_st_ctx->read_write.flags, > FCOE_TSTORM_FCOE_TASK_ST_CTX_READ_WRITE_EXP_FIRST_FRAME, 1); > - t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID); > + t_st_ctx->read_write.rx_id = cpu_to_le16(FCOE_RX_ID); > > /* Init Ustorm */ > u_ag_ctx = &ctx->ustorm_ag_context; > Arnd, thanks for fixing this up. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Use vsprintf extension %pad

qedf->bdq_pbl, &qedf->bdq_pbl_dma); > > /* > * Populate BDQ PBL with physical and virtual address of individual > Looks good. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches

csi/qedf/qedf_io.c | 4 ++-- > 3 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_dbg.h b/drivers/scsi/qedf/qedf_dbg.h Thanks. Acked-by: Chad Dupuis

Re: [PATCH] qedf: fixup compilation warning about atomic_t usage

gic FastLinQ offload FCoE driver > framework.) > Cc: Chad Dupuis > Cc: Nilesh Javali > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/qedf/qedf_io.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

Firmware ELS request/response handling > > - FIP request/response handled by the driver itself > > > > Signed-off-by: Nilesh Javali > > Signed-off-by: Manish Rangankar > > Signed-off-by: Saurav Kashyap > > Signed-off-by: Arun Easi > >

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

On Mon, 30 Jan 2017, 10:34am -, Hannes Reinecke wrote: > On 01/25/2017 09:33 PM, Dupuis, Chad wrote: > > +static int qedf_request_msix_irq(struct qedf_ctx *qedf) > > +{ > > + int i, rc, cpu; > > + > > + cpu = cpumask_first(cpu_online_mask); > > + for (i = 0; i < qedf->num_queues; i++)

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

Firmware ELS request/response handling > > - FIP request/response handled by the driver itself > > > > Signed-off-by: Nilesh Javali > > Signed-off-by: Manish Rangankar > > Signed-off-by: Saurav Kashyap > > Signed-off-by: Arun Easi > > Signed-off-by:

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

I forgot to add netdev-next to the subject line. Is a repost needed here? On Mon, 16 Jan 2017, 7:53pm -, Dupuis, Chad wrote: > From: Arun Easi > > This adds the backbone required for the various HW initalizations > which are necessary for the FCoE driver (qedf) for QLogic FastLinQ > 4

Re: [Open-FCoE] [PATCH RFC 5/5] qedf: Add FIP request handling

> > > > Signed-off-by: Nilesh Javali > > Signed-off-by: Manish Rangankar > > Signed-off-by: Saurav Kashyap > > Signed-off-by: Chad Dupuis > > --- > > drivers/scsi/qedf/qedf_fip.c | 267 > > +++ > &

Re: [Open-FCoE] [PATCH RFC 3/5] qedf: Add offloaded I/O request functions.

- ABTS requests > > - Cleanup requests > > - Task management requests > > > > It also contains: > > > > - I/O request initialization > > - Firmware completion handling > > > > Signed-off-by: Nilesh Javali > > Signed-off-by: Manish

Re: [Open-FCoE] [PATCH RFC 2/5] qedf: Add QLogic FastLinQ offload FCoE driver framework.

- Debugfs and log level infrastructure > > - Link handling > > - Firmware interface structures > > - QED core module initialization > > - Light L2 interface callbacks > > > > Signed-off-by: Nilesh Javali > > Signed-off-by: Manish Rangankar

Re: [PATCH 13/20] libfc: Remove fc_rport_init()

644 > --- a/include/scsi/libfc.h > +++ b/include/scsi/libfc.h > @@ -978,7 +978,6 @@ static inline bool fc_fcp_is_read(const struct fc_fcp_pkt > *fsp) > /* > * REMOTE PORT LAYER > */ > -int fc_rport_init(struct fc_lport *); > void fc_rport_terminate_io(struct fc_rpo

Re: [PATCH 10/20] libfc: Replace ->rport_logoff callback with function call

changed, 18 insertions(+), 28 deletions(-) > Straightforward conversion. Reviewed-by: Chad Dupuis -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/20] libfc callback cleanup

On Tue, 18 Oct 2016, 8:01am -, Hannes Reinecke wrote: > Hi all, > > it has been bugging me for a while that libfc has tons of callbacks > in an attempt to abstract things away. But as it turned out > no-one ever used those, rendering them quite pointless. > As I got some time to kill on the

Re: [PATCH 0/2] libfc/fcoe Fixes

On Thu, 29 Sep 2016, 8:06am -, Hannes Reinecke wrote: > Hi Chad, > > On 09/28/2016 07:30 PM, Chad Dupuis wrote: > > > > During testing we fixed a deadlock we found in libfc while logging off from > > the > > fabric if an ELS command was still out

[PATCH 0/2] libfc/fcoe Fixes

earliest convenience. Thanks, Chad Chad Dupuis (2): fcoe: Harden CVL handling when we have not logged into the fabric. libfc: Do not take rdata->rp_mutex when processing a -FC_EX_CLOSED ELS response. drivers/scsi/fcoe/fcoe_ctlr.c | 35 --- drivers/scsi/li

[PATCH 1/2] fcoe: Harden CVL handling when we have not logged into the fabric.

but we have not logged in yet, then reset everything and go back to solicitation. Signed-off-by: Chad Dupuis --- drivers/scsi/fcoe/fcoe_ctlr.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/f

[PATCH 2/2] libfc: Do not take rdata->rp_mutex when processing a -FC_EX_CLOSED ELS response.

SED response. Signed-off-by: Chad Dupuis --- drivers/scsi/libfc/fc_rport.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 93f5961..6f19c12 100644 --- a/drivers/scsi/libfc/fc_rpor

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On Fri, 9 Sep 2016, 11:28am -, Martin K. Petersen wrote: > > "Johannes" == Johannes Thumshirn writes: > > >> On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior > wrote: > >> The driver creates its own per-CPU threads which are updated based on > >> CPU hotplug events. I

Re: [PATCH] bnx2fc: Simplify code

held. >*/ > mutex_lock(&bnx2fc_dev_lock); > - list_splice(&adapter_list, &to_be_deleted); > - INIT_LIST_HEAD(&adapter_list); > + list_splice_init(&adapter_list, &to_be_deleted); > adapter_count = 0; > mutex_unlock(&bnx2fc_dev_lock); &

Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible

-git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c > index 8f24d60..f501095 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_io.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c > @@ -1079,7 +1079,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) > return bnx2fc_initiat

Re: [RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges

ed, 23 insertions(+), 4 deletions(-) > > Hannes, thanks for posting this. I've been working witih a customer of ours and have successfully tested this patch set. Reviewed-by: Chad Dupuis Tested-by: Chad Dupuis -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 01/22] libfc: Revisit kref handling

rivers/scsi/libfc/fc_rport.c > @@ -44,6 +44,17 @@ > * path this potential over-use of the mutex is acceptable. > */ > <-- snip --> Yes, this took quite a few iterations to get right but your rules make sense. I've tested with this patch and it successfully passed. T

Re: [PATCH] scsi: bnx2i: convert to kworker

On Fri, 12 Aug 2016, 9:24pm -, Martin K. Petersen wrote: > > "Sebastian" == Sebastian Andrzej Siewior writes: > > Sebastian> On 2016-07-04 19:40:37 [+0200], To linux-scsi@vger.kernel.org > wrote: > >> The driver creates its own per-CPU threads which are updated based on > >> CPU hotplu

Re: [PATCH] bnx2fc: replace printk() with BNX2FC_IO_DBG()

rintk(KERN_ERR PFX "fcp_rsp_code = %d\n", > + BNX2FC_IO_DBG(io_req, "fcp_rsp_code = %d\n", > io_req->fcp_rsp_code); > } > -- > Maurizio Lombardi Make sense to move this to a debug level. A

[PATCH v2 5/5] bnx2fc: Update version number to 2.10.3.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 106788f..fdd4eb4 100644 --- a/drivers/scsi/bnx2fc/bnx2fc.h +++ b/drivers/scsi/bnx2fc/bnx2fc.h @@ -65,7

[PATCH v2 4/5] bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer.

ediscover the device. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_io.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index ac8fb2a..25a1e19 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/dri

[PATCH v2 1/5] bnx2fc: Add driver tunables.

From: Joe Carnuccio Per customer request, add the following driver tunables: o devloss_tmo o max_luns o queue_depth o tm_timeout tm_timeout is set per scsi_host in /sys/class/scsi_host/hostX/tm_timeout. Signed-off-by: Joe Carnuccio Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc

[PATCH v2 2/5] bnx2fc: Print when we send a fip keep alive.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index b0305b0..365101a 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers

[PATCH v2 0/5] bnx2fc: Update driver to version 2.10.3.

Hi James, Martin, Please apply the patch series for the next merge window at your earliest convenience. V2 changes: - Made netdev device name print pr_info instead of pr_err. - Made TMF timeout settable via sysfs node instead of modparam. Thanks, Chad Chad Dupuis (4): bnx2fc: Print when we

[PATCH v2 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 365101a..a188199 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

On Tue, 5 Apr 2016, Bastien Philbert wrote: This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert --- drivers

Re: [PATCH 1/5] bnx2fc: Add driver tunables.

On Fri, 1 Apr 2016, James Bottomley wrote: On Fri, 2016-04-01 at 10:06 -0400, Chad Dupuis wrote: On Fri, 1 Apr 2016, Johannes Thumshirn wrote: On 2016-04-01 15:10, Chad Dupuis wrote: From: Joe Carnuccio Per customer request, add the following driver tunables: o devloss_tmo o max_luns o

Re: [PATCH 3/5] bnx2fc: Print netdev device name when FCoE is successfully initialized.

On Fri, 1 Apr 2016, Johannes Thumshirn wrote: On 2016-04-01 15:10, Chad Dupuis wrote: Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index d95eee6

Re: [PATCH 1/5] bnx2fc: Add driver tunables.

On Fri, 1 Apr 2016, Johannes Thumshirn wrote: On 2016-04-01 15:10, Chad Dupuis wrote: From: Joe Carnuccio Per customer request, add the following driver tunables: o devloss_tmo o max_luns o queue_depth o tm_timeout Signed-off-by: Joe Carnuccio Signed-off-by: Chad Dupuis --- drivers

[PATCH 1/5] bnx2fc: Add driver tunables.

From: Joe Carnuccio Per customer request, add the following driver tunables: o devloss_tmo o max_luns o queue_depth o tm_timeout Signed-off-by: Joe Carnuccio Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 38 +- drivers/scsi/bnx2fc

[PATCH 5/5] bnx2fc: Update version number to 2.10.3.

Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h index 499e369..9ce361a 100644 --- a/drivers/scsi/bnx2fc/bnx2fc.h +++ b/drivers/scsi/bnx2fc/bnx2fc.h @@ -65,7

[PATCH 4/5] bnx2fc: Check sc_cmd device and host pointer before returning the command to the mid-layer.

ediscover the device. Signed-off-by: Chad Dupuis --- drivers/scsi/bnx2fc/bnx2fc_io.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 0f60e22..33e519d 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/dri

  1   2   3   >