Re: [PATCH v2 2/2] scsi: ufs: Use freq table with devfreq

2018-05-07 Thread Chanwoo Choi
freq); > + dev_pm_opp_remove(hba->dev, clki->max_freq); > +} > + > static void __ufshcd_suspend_clkscaling(struct ufs_hba *hba) > { > unsigned long flags; > @@ -6966,6 +6998,7 @@ static void ufshcd_hba_exit(struct ufs_hba *hba) > if (hba->devfreq) > ufshcd_suspend_clkscaling(hba); > destroy_workqueue(hba->clk_scaling.workq); > + ufshcd_devfreq_remove(hba); > } > ufshcd_setup_clocks(hba, false); > ufshcd_setup_hba_vreg(hba, false); > For using OPP entries for devfreq: Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2 1/2] scsi: ufs: Extract devfreq registration

2018-05-07 Thread Chanwoo Choi
dev_err(hba->dev, "Unable to register > with devfreq %d\n", > - ret); > + ret = ufshcd_devfreq_init(hba); > + if (ret) > goto out; > - } > } > hba->clk_scaling.is_allowed = true; > } > Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 1/3] PM / devfreq: Actually support providing freq_table

2018-04-24 Thread Chanwoo Choi
Hi, On 2018년 04월 24일 14:29, Bjorn Andersson wrote: > On Mon 23 Apr 19:48 PDT 2018, Chanwoo Choi wrote: > >> Hi, >> >> On 2018??? 04??? 24??? 09:20, Bjorn Andersson wrote: >>> The code in devfreq_add_device() handles the case where a freq_table is >>> p

Re: [PATCH 1/3] PM / devfreq: Actually support providing freq_table

2018-04-23 Thread Chanwoo Choi
struct dev_pm_opp *opp; > - unsigned long max_freq = ULONG_MAX; > - > - opp = dev_pm_opp_find_freq_floor(devfreq->dev.parent, _freq); > - if (IS_ERR(opp)) > - max_freq = 0; > - else > - dev_pm_opp_put(opp); > + struct devfreq_dev_profile *profile = devfreq->profile; > > - return max_freq; > + return profile->freq_table[profile->max_state - 1]; > } ditto. > > /** > -- Best Regards, Chanwoo Choi Samsung Electronics

[PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Chanwoo Choi
, const char *governor_name, void *data); Cc: Vinayak Holikatti <vinholika...@gmail.com> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Ch

[PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Chanwoo Choi
, const char *governor_name, void *data); Cc: Vinayak Holikatti <vinholika...@gmail.com> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Ch

[PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-10-26 Thread Chanwoo Choi
, const char *governor_name, void *data); Cc: Vinayak Holikatti <vinholika...@gmail.com> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Ch

[PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-10-26 Thread Chanwoo Choi
, const char *governor_name, void *data); Cc: Vinayak Holikatti <vinholika...@gmail.com> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com> Cc: Martin K. Petersen <martin.peter...@oracle.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Ch