Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
page_to_gfn. More complex clean up > will come in follow-up patches. > > I think it may be possible to do further clean up in the x86 code to > ensure that helpers returning machine address (such as virt_address) is > not used by no auto-translated guests. I will let x86 xen expert d

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread David Vrabel
On 29/07/15 12:35, Julien Grall wrote: > Hi Wei, > > On 29/07/15 11:13, Wei Liu wrote: >> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: >> [...] >>> diff --git a/drivers/net/xen-netback/netback.c >>> b/drivers/net/xen-netback/netback.c >>> index 7d50711..3b7b7c3 100644 >>> --- a/d

Re: [Xen-devel] [PATCH v3 0/9] Use correctly the Xen memory terminologies

2015-08-11 Thread David Vrabel
On 07/08/15 17:34, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/xen/mm.h [1] for Linux xen code. Applied to for-linus-4.3, thanks. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

Re: [PATCH V3 2/4] Introduce xen-scsifront module

2014-08-04 Thread David Vrabel
te(dev, XenbusStateConnected); > + break; > + } > +} I would like to see this state machine in common code but I'm not going to insist on it since this is a existing driver. Xen related parts: Acked-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 3/4] Introduce XEN scsiback module

2014-08-04 Thread David Vrabel
n (usually Dom0) which is > owner of the physical device. This allows e.g. to use SCSI tape drives in a > XEN domU. Xen related parts Acked-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.ke

Re: [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-22 Thread David Vrabel
On 18/08/14 10:31, jgr...@suse.com wrote: > - add support for larger SG-lists by putting them in an own granted page As a reminder, this can't be acked until this protocol change has been applied to Xen copy of this header. David -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [Xen-devel] [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-26 Thread David Vrabel
On 23/08/14 01:40, Konrad Rzeszutek Wilk wrote: > On Fri, Aug 22, 2014 at 02:21:55PM -0700, Nicholas A. Bellinger wrote: >> >> >> For the XEN scsiback parts as a new target fabric driver, feel free to >> add my: >> >> Reviewed-by: Nicholas Bellinger >> >> So I assume this will be merged for v3.18

Re: [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread David Vrabel
On 18/08/14 10:31, jgr...@suse.com wrote: > From: Juergen Gross > > Add myself as maintainer for the Xen pvSCSI stuff. > > Signed-off-by: Juergen Gross > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index aefa948..360f86f 10064

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread David Vrabel
On 26/08/14 17:37, James Bottomley wrote: > On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote: >> On 08/26/2014 04:14 PM, David Vrabel wrote: >>> On 18/08/14 10:31, jgr...@suse.com wrote: >>>> From: Juergen Gross >>>> >>>> Add myself as

Re: [Xen-devel] [PATCH V6 0/5] Add XEN pvSCSI support

2014-09-01 Thread David Vrabel
On 28/08/14 05:44, Juergen Gross wrote: > This series adds XEN pvSCSI support. With pvSCSI it is possible to use > physical > SCSI devices from a XEN domain. Applied to devel/for-linus-3.18. Thanks. Your lines in your descriptions were too long for the default git log format. I fixed this up b

Re: [Xen-devel] [patch] xen-scsifront: use GFP_ATOMIC under spin_lock

2014-09-08 Thread David Vrabel
On 08/09/14 12:15, Dan Carpenter wrote: > This function is only called with a spin_lock held and IRQs disabled. > The allocation is not allowed to sleep and NOIO is not sufficient, it > has to be ATOMIC. Applied this and the scsiback one to devel/for-linus-3.18. Thanks. David -- To unsubscribe f

[PATCH] xen-scsifront: don't deadlock if the ring becomes full

2014-09-11 Thread David Vrabel
scsifront_action_handler() will deadlock on host->host_lock, if the ring is full and it has to wait for entries to become available. Signed-off-by: David Vrabel --- This was found with sparse. I've not tested it. --- drivers/scsi/xen-scsifront.c |3 ++- 1 file changed, 2 insertio

Re: [Xen-devel] [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-26 Thread David Vrabel
On 26/09/14 17:36, Chen Gang wrote: > When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > internally, so need not return any status value, then use 'void' instead > of 'int' for xenbus_switch_state() and __xenbus_switch_state(). > > Also need be sure that all callers which check

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-29 Thread David Vrabel
On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote: > On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > > Only on the first depth, not on the subsequent ones (as in if > the first xenbus_switch_fail fails, it won't try

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-29 Thread David Vrabel
On 29/09/14 16:40, Konrad Rzeszutek Wilk wrote: > On Mon, Sep 29, 2014 at 03:17:10PM +0100, David Vrabel wrote: >> On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote: >>> On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: >>>> When xenbus_switch_state() fails, it

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread David Vrabel
On 26/09/14 17:36, Chen Gang wrote: > When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > internally, so need not return any status value, then use 'void' instead > of 'int' for xenbus_switch_state() and __xenbus_switch_state(). > > Also need be sure that all callers which check

Re: [Xen-devel] [PATCH] xen-scsiback: some modifications about code comment

2015-02-19 Thread David Vrabel
On 09/02/15 07:08, Juergen Gross wrote: > On 02/07/2015 04:31 AM, Rudy Zhang wrote: >> From: Tao Chen >> >> Signed-off-by: Tao Chen > > Are some white space fixes in comments really worth a patch? No. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread David Vrabel
On 03/03/15 08:37, Tao Chen wrote: > Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, > it makes the code easier to read. You need to #define pr_fmt(fmt) to add a prefix like this. > struct ids_tuple v; /* translate from */ > - struct scsiback_tpg *tpg;

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread David Vrabel
On 04/03/15 18:32, Tao Chen wrote: > Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr > sentences and DPRINTK. > Also fixed up some comments just as eliminate redundant white spaces and > format the code. > These will make the code easier to read. I have already said you ne

Re: [Xen-devel] [PATCH v4] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-16 Thread David Vrabel
On 10/03/15 20:49, Tao Chen wrote: > Add the {xen-pvscsi: } prefix in pr_fmt and remove DPRINTK, then > replace all DPRINTK with pr_debug. > > Also fixed up some comments just as eliminate redundant whitespace > and format the code. > > These will make the code easier to read. Applied to devel/f

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread David Vrabel
On 29/11/16 11:19, Juergen Gross wrote: > On 29/11/16 12:14, Jan Beulich wrote: > On 29.11.16 at 11:50, wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >>> vscsifrnt_info *info

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread David Vrabel
On 11/07/16 10:33, Juergen Gross wrote: > On 11/07/16 04:51, Bin Wu wrote: >> During scsi command queueing, if mapping data fails, we need to >> reclaim the failed request. Otherwise, the garbage request will >> be pushed into the ring for the backend to work. > > Well spotted. There is another in

Re: [Xen-devel] [PATCH 2/4] Introduce xen-scsifront module

2014-06-30 Thread David Vrabel
On 27/06/14 15:34, jgr...@suse.com wrote: > > +/* .resume = scsifront_resume, */ Following on from the recent discussion on migration with front/backends I thought I'd review how this new driver does it. Is there an expectation that a VM with a PV scsi device cannot be restored

Re: [Xen-devel] [PATCH V2 1/4] Add XEN pvSCSI protocol description

2014-07-28 Thread David Vrabel
On 25/07/14 12:37, jgr...@suse.com wrote: > From: Juergen Gross > > Add the definition of pvSCSI protocol used between the pvSCSI frontend in a > XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). > > This header was originally provided by Fujitsu for XEN based on Linux 2.6.1