On Mon, 2014-08-25 at 15:15 -0400, Chad Dupuis wrote:
>
> On Fri, 22 Aug 2014, Eddie Wai wrote:
>
> > On Fri, 2014-08-22 at 20:12 +0200, Maurizio Lombardi wrote:
> >> Hi Chad,
> >>
> >> On 08/22/2014 02:08 PM, Chad Dupuis wrote:
> >>> Eddie,
On Fri, 2014-07-25 at 10:12 +0200, Maurizio Lombardi wrote:
> Hi Eddie,
>
> just want to add you to the CC list.
>
> Some days ago the bnx2fc's maintainer email address has been updated,
> this should be the new one: qlogic-storage-upstr...@qlogic.com
>
> I tried to send this patch to the new ad
scsi_sg_count(sc)) {
> > + dma_unmap_sg(&hba->pcidev->dev, scsi_sglist(sc),
> > + scsi_sg_count(sc), sc->sc_data_direction);
> > io_req->bd_tbl->bd_valid = 0;
> > }
> > }
> >
> >
On Mon, 2014-08-04 at 10:20 +0200, Maurizio Lombardi wrote:
> In the bnx2fc_map_sg() function, the original behaviour is to
> allocate the DMA memory by directly calling dma_map_sg()
> instead of using scsi_dma_map().
>
> In contrast, bnx2fc_unmap_sg_list() calls scsi_dma_unmap().
>
> The problem
On Wed, 2014-06-25 at 16:26 +0200, Maurizio Lombardi wrote:
> Hi,
>
> On 06/25/2014 04:04 PM, Rickard Strandqvist wrote:
> > A struct member variable is set to different values without having used in
> > between.
> >
> > This was found using a static code analysis program called cppcheck
> >
>
arr_sz, GFP_KERNEL);
> if (!cmgr->free_list_lock) {
> printk(KERN_ERR PFX "failed to alloc free_list_lock\n");
> + kfree(cmgr->free_list);
> + cmgr->free_list = NULL;
> goto m
d", event);
> return;
> }
>
Thanks for fixing this, Shirish. It makes sense to suppress the
unwanted netevent messages.
The patch looks good to me, but we should really get the current bnx2fc
maintainer from Qlogic to ACK this.
Acked-by: Eddie Wai
--
To unsub
On Tue, 2014-06-03 at 10:54 -0400, Neil Horman wrote:
> On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote:
> > On Sat, May 31, 2014 at 05:13:11AM +0000, Eddie Wai wrote:
> > >
> > >
> > > On May 30, 2014, at 7:48 PM, "Neil Horman" wrote
On May 30, 2014, at 7:48 PM, "Neil Horman" wrote:
> On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote:
>> Thanks for fixing this. The patch generally looks good, but I do have a
>> few comments.
>>
>> On Fri, 2014-05-30 at 11:01 -0400, Neil Horman
Thanks for fixing this. The patch generally looks good, but I do have a
few comments.
On Fri, 2014-05-30 at 11:01 -0400, Neil Horman wrote:
> Recently had this warning reported:
>
> [ 290.489047] Call Trace:
> [ 290.489053] [] dump_stack+0x19/0x1b
> [ 290.489055] [] __might_sleep+0x179/0x23
FYI, this was part of the boot_nic sysfs patch which would allow iscsid
to sync_session with info from the iBFT for iSCSI BFS via offload.
This looks good to me.
Acked-by: Eddie Wai
On Mon, 2014-05-19 at 07:32 -0400, vikas.chaudh...@qlogic.com wrote:
> From: Tej Parkash
>
> Sign
The patchset looks good. Thanks.
Acked-by: Eddie Wai
On Tue, 2014-04-01 at 13:58 +0200, Maurizio Lombardi wrote:
> PATCH 1/3 removes a unused variable from the bnx2fc_free_hash_table()
> function,
>
> PATCH 2/3 fixes a memory leak and some NULL pointer derefer
On Sat, 2014-03-08 at 00:21 +0100, Maurizio Lombardi wrote:
> Hi Eddie,
>
> On Fri, Mar 07, 2014 at 11:21:45AM -0800, Eddie Wai wrote:
> > Hello Maurizio,
> >
> > Thanks for looking into this. The patch looks good, but I would like to
> > extend it with the fol
Hello Maurizio,
Thanks for looking into this. The patch looks good, but I would like to
extend it with the following allocation failure portion to completely
remove the memory leak. Please incorporate this into your next
submission.
Thanks,
Eddie
@@ -2020,7 +2026,7 @@ static int bnx2fc_allocat
Looks good. Thanks.
Acked-by: Eddie Wai
On Fri, 2014-03-07 at 15:37 +0100, Maurizio Lombardi wrote:
> hash_table_size is not used by the bnx2fc_free_hash_table() function.
>
> Signed-off-by: Maurizio Lombardi
> ---
> drivers/scsi/bnx2fc/bnx2fc_hwi.c | 3 ---
> 1 file ch
Hello Dan,
Thanks for bringing this to our attention. We'll fix it upon our next
patchset submission.
Thanks,
Eddie
On Thu, 2014-02-13 at 12:52 +0300, Dan Carpenter wrote:
> Hello Bhanu Gollapudi,
>
> The patch 853e2bd2103a: "[SCSI] bnx2fc: Broadcom FCoE offload driver"
> from Feb 4, 2011, lea
Hello,
I would like to attend LSF/MM 2014 to participate in the discussions
about the proposed SCSI error handling and the impending scsi-mq changes
from the LLDD perspective.
Eddie
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@v
Old version: 2.4.1
New version: 2.4.2
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc.h |2 +-
drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
index 2e984e3
SCSI retry delay upon SAM_STAT_BUSY/_SET_FULL was not being handled
in bnx2fc. This patch adds such handling by returning TARGET_BUSY
to the SCSI ML for the corresponding LUN until the retry timer expires.
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc.h |1 +
drivers/scsi
] [] ? rescuer_thread+0x3e0/0x3e0
[4.123791] [] kthread+0xc0/0xd0
[4.123794] [] ? kthread_create_on_node+0x110/0x110
[4.123798] [] ret_from_fork+0x7c/0xb0
[4.123801] [] ? kthread_create_on_node+0x110/0x110
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c |6
Tomas,
I have already took this up to James yesterday and he said he will be fixing
it over the weekend.
Thanks,
Eddie
On Oct 18, 2013, at 6:49 AM, "Tomas Henzl" wrote:
> On 09/26/2013 07:01 AM, Eddie Wai wrote:
>> [v2] - removed the interface->enabled flag setti
ove_driver+0x8e/0x110
kernel: [] driver_unregister+0x62/0xa0
kernel: [] pci_unregister_driver+0x44/0xb0
kernel: [] bnx2x_cleanup+0x18/0x73 [bnx2x]
kernel: [] sys_delete_module+0x194/0x260
kernel: [] ? audit_syscall_entry+0x1d7/0x200
kernel: [] system_call_fastpath+0x16/0x1b
Signed-off-by: Eddie
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc.h |2 +-
drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
index 08b22a9..6991027 100644
--- a/drivers/scsi
#x27;t continue)
Note that there is no call to scsi_done for this SCSI_CMD cmpletion
in this path.
The patch changes the path of execution to call scsi_done immediately
instead of instantiating the RRQ.
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc_io.c |6 ++
1 files changed, 6 i
+0x18/0x73 [bnx2x]
kernel: [] sys_delete_module+0x194/0x260
kernel: [] ? audit_syscall_entry+0x1d7/0x200
kernel: [] system_call_fastpath+0x16/0x1b
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 60 +++-
1 files changed, 45 insertions(+), 15 deletions(-)
diff -
Signed-off-by: Eddie Wai
---
MAINTAINERS |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e5e2518..26bc416 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1825,7 +1825,7 @@ S:Supported
F: drivers/net/wireless/brcm80211
ort to align the upstream
and the out-of-tree releases of bnx2fc.
Comments are welcome. Thanks.
Eddie
Eddie Wai (4):
BNX2FC: Fixed a SCSI CMD cmpl race condition between ABTS and
CLEANUP
BNX2FC: hung task timeout warning observed when rmmod bnx2x with
active FCoE targets
BNX2FC:
Old version: 2.7.2.2
New version: 2.7.6.2
Signed-off-by: Eddie Wai
---
drivers/scsi/bnx2i/57xx_iscsi_constants.h |2 +-
drivers/scsi/bnx2i/57xx_iscsi_hsi.h |2 +-
drivers/scsi/bnx2i/bnx2i.h|2 +-
drivers/scsi/bnx2i/bnx2i_hwi.c|2 +-
drivers/scsi
Signed-off-by: Eddie Wai
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 50105f9..e297cb0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1816,6 +1816,12 @@ L: linux-scsi@vger.kernel.org
S: Supported
F
:
boot_root - holds the name of the /sys/firmware/ibft or iscsi_rootN
boot_nic - holds the ethernetN name
boot_target - holds the targetN name
Signed-off-by: Eddie Wai
---
drivers/scsi/libiscsi.c | 18 ++
drivers/scsi/scsi_transport_iscsi.c | 12
include
boot_nic - holds the ethernetN name
boot_target - holds the targetN name
Signed-off-by: Eddie Wai
---
drivers/scsi/libiscsi.c | 18 ++
drivers/scsi/scsi_transport_iscsi.c | 12
include/scsi/iscsi_if.h |4
include/scsi/libiscsi.h
queue and the DMA code. It would
be an easy alternative to simply prevent the shost->dma_boundary from
being set to DMA_BIT_MASK(64), but it seems more correct to fix the
amd_iommu code itself to detect and handle this max 64-bit mask condition.
Please let me know your comments.
Thanks,
Eddie
Hello James,
I'm re-sending this patch fix by Tomas as it hasn't made it upstream yet
in any of the trees.
Thanks,
Eddie
On Tue, 2012-07-03 at 10:08 +0200, Tomas Henzl wrote:
> The intention in bnx2i_send_fw_iscsi_init_msg was to zero out
> only the lower 32bits, but instead the whole mask64 is
This is the kernel part of the modification to extract the net params
from the ibft sysfs to the iface struct used for the connection
request upon sync_session in the open-iscsi util.
Signed-off-by: Eddie Wai
---
drivers/scsi/libiscsi.c |6 ++
drivers/scsi
Removed the individual PCI DEVICE ID checking inside bnx2i. The device
type can easily be read from the corresponding cnic->flags. This will
free bnx2i from having to get updated for every new device ID that gets
added.
Signed-off-by: Eddie Wai
Acked-by: Michael Chan
---
drivers/scsi/bn
ff-by: Eddie Wai
Cc: sta...@kernel.org
---
drivers/scsi/bnx2i/bnx2i_hwi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 86a12b4..3878e62 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/
36 matches
Mail list logo
