Re: [PATCH target-pending] iscsi-target: make sure to wake up sleeping login worker

2018-01-19 Thread Eric Dumazet
On Fri, 2018-01-19 at 14:36 +0100, Florian Westphal wrote: > Mike Christie reports: > Starting in 4.14 iscsi logins will fail around 50% of the time. > > Problem appears to be that iscsi_target_sk_data_ready() callback may > return without doing anything in case it finds the login work queue > i

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Eric Dumazet
> Signed-off-by: Hannes Reinecke > --- > drivers/scsi/sg.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Eric Dumazet Thanks !

Re: [PATCH] scsi: qla2xxx: Fix an integer overflow in sysfs code

2017-08-30 Thread Eric Dumazet
On Wed, Aug 30, 2017 at 6:12 AM, Greg KH wrote: > On Wed, Aug 30, 2017 at 03:21:07PM +0300, Dan Carpenter wrote: >> The value of "size" comes from the user. When we add "start + size" >> it could lead to an integer overflow bug. >> >> It means we vmalloc() a lot more memory than we had intended.

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-06 Thread Eric Dumazet
On Tue, 2016-12-06 at 15:10 +0800, Zhouyi Zhou wrote: > kmalloc_reserve may fail to allocate memory inside skb_linearize, > which means skb_linearize's return value should not be ignored. > Following patch correct the uses of skb_linearize. > > Compiled in x86_64 > > Signed-off-by: Zhouyi Zhou

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 11:33 -0700, James Bottomley wrote: > On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote: > > Yeah it's easiest if I just apply this to net-next, which I've just done, > > thanks Eric. > > Fine with me. There's no point creating cross tree hassle for a simple > include p

[PATCH net-next] qla4xxx: add a missing include

2015-05-26 Thread Eric Dumazet
From: Eric Dumazet vmalloc.h used to be included from include/net/inet_hashtables.h but it is no longer the case. Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()") Reported-by: kbuild test robot Signed-off-by: Eric Dumazet --- Given its broken in David net-next