Re: status of drivers/scsi/scsi_tgt_lib.c

2014-01-27 Thread FUJITA Tomonori
On Sun, 26 Jan 2014 23:50:38 -0800 Christoph Hellwig wrote: >> > Do you know if either SRP or ibmvscsi are used regularly these days? >> > Does tgtd userspace still support this interface? >> >> It doesn't. I think that ibm pseries switched to virtual fc driver >> from virtual srp long ago. Only

Re: status of drivers/scsi/scsi_tgt_lib.c

2014-01-24 Thread FUJITA Tomonori
Hey, On Fri, 24 Jan 2014 05:15:25 -0800 Christoph Hellwig wrote: > Do you know if either SRP or ibmvscsi are used regularly these days? > Does tgtd userspace still support this interface? It doesn't. I think that ibm pseries switched to virtual fc driver from virtual srp long ago. Only very old

Re: [patch] [SCSI] bnx2fc: zero out sense buffer properly

2012-08-18 Thread FUJITA Tomonori
On Sat, 18 Aug 2012 11:46:37 +0300 Dan Carpenter wrote: > ->sense_buffer used to be an array but it changed to pointer in > de25deb180 "[SCSI] use dynamically allocated sense buffer". This call > to memset() needs to be updated as well. > > Signed-off-by: Dan Carpenter > > diff --git a/driver

Re: [PATCH 2/2] ps3rom: Simplify fill_from_dev_buffer()

2008-02-25 Thread FUJITA Tomonori
On Mon, 25 Feb 2008 14:24:31 +0100 (CET) Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Subject: [PATCH] ps3rom: Simplify fill_from_dev_buffer() > > As we no longer need to calculate the data length of the whole scatterlist, > we can abort the loop earlier and coalesce req_len and act_len into o

[PATCH] ps3rom: fix wrong resid calculation bug

2008-02-24 Thread FUJITA Tomonori
sg driver rounds up the length in struct scatterlist to be a multiple of 512 in some conditions. So LLDs can't use the data length in a sg list to calculate residual. Instead, the length in struct scsi_cmnd should be used. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Geert U

[PATCH] scsi_debug: fix wrong resid calculation bug

2008-02-24 Thread FUJITA Tomonori
sg driver rounds up the length in struct scatterlist to be a multiple of 512 in some conditions. So LLDs can't use the data length in a sg list to calculate residual. Instead, the length in struct scsi_cmnd should be used. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Doug

[PATCH] aacraid: READ_CAPACITY_16 shouldn't trust allocation length in cdb

2008-02-24 Thread FUJITA Tomonori
response length that the driver expects, it clears the data buffer in the sg list to zero but it doesn't need to do. Just setting resid is fine. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Mark Salyzyn <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> --

RE: [PATCH] ips: sg chaining support to the path to non I/O commands

2008-02-22 Thread FUJITA Tomonori
On Tue, 19 Feb 2008 04:39:00 -0800 "Salyzyn, Mark" <[EMAIL PROTECTED]> wrote: > ACK Thanks! > Other RAID drivers (eg: aacraid) makes the assumption that commands > in these paths (INQUIRY, READ CAPACITY, MODE SENSE etc spoofing) are > single scatter gather elements and have yet to be bitten. I

[PATCH 1/2] stex: stex_direct_copy shouldn't call dma_map_sg

2008-02-22 Thread FUJITA Tomonori
nce this code path doesn't involve dma transfers. This patch removes stex_direct_copy and simply calls stex_internal_copy with the actual number of sg entries. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Ed Lin <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTE

[PATCH 2/2] stex: stex_internal_copy should be called with sg_count in struct st_ccb

2008-02-22 Thread FUJITA Tomonori
l length. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Ed Lin <[EMAIL PROTECTED]> Cc: James Bottomley <[EMAIL PROTECTED]> --- drivers/scsi/stex.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c ind

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
On Tue, 19 Feb 2008 10:06:39 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-19 at 17:02 +0900, FUJITA Tomonori wrote: > > ips did scsi_add_host(sh, NULL) so scsi_dma_map uses > > shost_gendev.parent that isn't initialized properly, then the kern

Re: SCSI RAM driver

2008-02-19 Thread FUJITA Tomonori
On Tue, 19 Feb 2008 06:31:20 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Tue, Feb 19, 2008 at 10:14:53PM +0900, FUJITA Tomonori wrote: > > I see that two drivers have very different objectives but if we add > > use_thread option to scsi_debug (we can do e

Re: SCSI RAM driver

2008-02-19 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 23:36:59 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > This is the first release of a driver we've been using internally at Intel > for a few weeks which is as low-latency as possible. It's designed to > let us find latency issues elsewhere in the storage stack (eg file

[PATCH] ips: sg chaining support to the path to non I/O commands

2008-02-19 Thread FUJITA Tomonori
Here is another ips patch, but not a bug fix. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] ips: sg chaining support to the path to non I/O commands I overlooked ips_scmd_buf_write and ips_scmd_buf_read when I converted ips to use the data buffer accessors. ips is unlikely

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
On Mon, 18 Feb 2008 19:48:49 -0800 "Tim Pepper" <[EMAIL PROTECTED]> wrote: > On Feb 18, 2008 4:11 PM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > Can you please help me just once more? 2.6.25-rc2 fixed this bug in a > > bit different way by chance. Ple

[PATCH] ips: fix data buffer accessors conversion bug

2008-02-19 Thread FUJITA Tomonori
There is one more bug in ips. I think that this needs to go to scsi-rc-fixes, 2.6.24-stable, and 2.6.23-stable though we might rarely hit this bug. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 16:03:47 +0900 Subject: [PATCH] ips: fix data buffer accessors conversi

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
is commit (not sending a patch that was not committed upstream)? On Mon, 18 Feb 2008 22:32:46 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Sun, 17 Feb 2008 15:37:02 -0800 > Tim Pepper <[EMAIL PROTECTED]> wrote: > > > On Mon 19 Feb at 07:31:56 +0900 [EMAIL PROTECTED]

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-18 Thread FUJITA Tomonori
On Mon, 18 Feb 2008 15:30:58 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Mon 18 Feb at 22:32:46 +0900 [EMAIL PROTECTED] said: > > > > diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c > > index 05bb6ea..39cdd68 100644 > > --- a/drivers/scsi/ips.c > > +++ b/drivers/scsi/ips.c > > @@ -6906,

Re: [PATCH] bsg: bidi bio map failure fix

2008-02-18 Thread FUJITA Tomonori
On Mon, 18 Feb 2008 09:09:07 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-18 at 15:46 +0100, Jens Axboe wrote: > > Seems symmetric to me now, either we fail and everything is cleaned up, > > or return success. What remains? > > My main symmetry complaint was the API: The ma

Re: [PATCH] bsg: bidi bio map failure fix

2008-02-18 Thread FUJITA Tomonori
On Mon, 18 Feb 2008 13:55:08 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Feb 12 2008, James Bottomley wrote: > > On Tue, 2008-02-12 at 15:40 -0500, Pete Wyckoff wrote: > > > If blk_rq_map_user requires more than one bio, and fails mapping > > > somewhere after the first bio, it will retu

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-18 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 15:37:02 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Mon 19 Feb at 07:31:56 +0900 [EMAIL PROTECTED] said: > > > > Can you apply the 0001 and 0002 against 2.6.24 and see how it works? > > If it works well, then please apply the 0001, 0002 and 0003. > > Fujita-san, > > I'

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 13:15:40 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Sat 16 Feb at 09:41:48 +0900 [EMAIL PROTECTED] said: > > > > Do you mean that you applied only the following two patches against > > 2.6.24, and then it doesn't work? > > > > 0001-ips-revert-the-changes-for-the-data-bu

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 09:02:14 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sun, 2008-02-17 at 23:52 +0900, FUJITA Tomonori wrote: > > On Sun, 17 Feb 2008 07:28:48 -0700 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > > > On Sun, Feb

Re: [PATCH] scsi_debug: disable clustering

2008-02-17 Thread FUJITA Tomonori
On Sun, 17 Feb 2008 07:28:48 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Sun, Feb 17, 2008 at 08:18:11AM -0600, James Bottomley wrote: > > No, he means that kmap_atomic can only map a page of data. This makes > > single page only sg list entries and input assumption into this loop. > > w

[PATCH] ps3rom: disable clustering

2008-02-17 Thread FUJITA Tomonori
ps3rom does: scsi_for_each_sg(cmd, sgpnt, scsi_sg_count(cmd), k) { kaddr = kmap_atomic(sg_page(sgpnt), KM_IRQ0); We cannot do something like that with the clustering enabled (or we can use scsi_kmap_atomic_sg). Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Cc: Geert Uytter

[PATCH] scsi_debug: disable clustering

2008-02-16 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] scsi_debug: disable clustering scsi_debug does at several places: for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) { kaddr = (unsigned char *) kmap_atomic(sg_page(sg), KM_USER0); We cannot do so

[PATCH] qla2xxx: fix compilation compile

2008-02-15 Thread FUJITA Tomonori
scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_fce_show': scsi/qla2xxx/qla_dfs.c:26: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'uint64_t' Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- dri

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-15 Thread FUJITA Tomonori
On Fri, 15 Feb 2008 14:50:57 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Sat 16 Feb at 01:09:43 +0900 [EMAIL PROTECTED] said: > > > > The first one is just reverting the data buffer accessors > > conversion. It would be nice if we could just revert it but we > > can't. These changes are nece

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-15 Thread FUJITA Tomonori
On Thu, 14 Feb 2008 17:16:36 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Fri 15 Feb at 09:13:16 +0900 [EMAIL PROTECTED] said: > > > > Thanks. So we surely have a bug in the non-breakup part. > > > > I've just found one bug. Can you try this patch against 2.6.24? > > Tested and unfortunatel

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-14 Thread FUJITA Tomonori
On Thu, 14 Feb 2008 15:55:49 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > On Thu 14 Feb at 20:48:38 +0900 [EMAIL PROTECTED] said: > > > > I have a slight doubt on the breakup code though I'm not sure you hit > > the code. Reverting only the breakup part works? The patch is against > > 2.6.24. >

Re: [PATCH] bsg: bidi bio map failure fix

2008-02-14 Thread FUJITA Tomonori
ferp; > ret = blk_rq_map_user(q, next_rq, dxferp, hdr->din_xfer_len); > - if (ret) > + if (ret) { > + next_rq->bio = NULL; /* do not unmap twice */ > goto out; > + } > } > > if

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-14 Thread FUJITA Tomonori
On Wed, 13 Feb 2008 13:43:24 -0800 Tim Pepper <[EMAIL PROTECTED]> wrote: > We recently upgraded a production x86_64 machine with serveraid > cards to 2.6.24 and noted that /proc/scsi/scsi showed garbage for our > serveraid service processors. sg_inq also returned garbage from the > service proces

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread FUJITA Tomonori
driver and the corresponding ULD. > > OK, the advansys fix came in. I've added it to the patch. > > James > > > > >From f983323fea178352ed3b69c70561a13825a3ce59 Mon Sep 17 00:00:00 2001 > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Date: Fri,

Re: [PATCH] advansys: fix overrun_buf aligned bug

2008-02-07 Thread FUJITA Tomonori
On Thu, 07 Feb 2008 19:01:55 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-02-08 at 09:50 +0900, FUJITA Tomonori wrote: > > struct asc_dvc_var needs overrun buffer to be placed on an 8 byte > > boundary. advansys defines struct asc_dvc_var: >

[PATCH] advansys: fix overrun_buf aligned bug

2008-02-07 Thread FUJITA Tomonori
removes overrun_buf static array and use kzalloc. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index ccef891..3c2d688 100644 ---

Re: Latest git oopses during boot

2008-02-07 Thread FUJITA Tomonori
On Thu, 7 Feb 2008 23:24:00 +0100 "Harald Arnesen" <[EMAIL PROTECTED]> wrote: > On 2/7/08, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > > > On Thu, 7 Feb 2008, Harald Arnesen wrote: > > > > > > I'll try applying the patch to a freshly downloaded git-tree. > > > > Ok, good. > > > > > Shall I t

Re: Latest git oopses during boot

2008-02-07 Thread FUJITA Tomonori
ks. I uploaded the oops picture to > > http://userweb.kernel.org/~akpm/oops.jpg > > > > > Cc to the Matthew Wilcox added. > > > > mm... looks like all Matthew's changes were in 2.6.23. And 2.6.23 worked > > OK, yes? > > Both 2.6.23 and 2.6.24 are

Re: [Bugme-new] [Bug 9901] New: kernel panic in stex modules (?)

2008-02-06 Thread FUJITA Tomonori
. > > > Sorry, but I can't save crash log, so I'll provide screen "shot": > > > http://img238.imageshack.us/my.php?image=p2030030ki1.jpg > > > > > > Steps to reproduce: > > > Boot, start FTP-server, load RAID with heavy input, in some h

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 18:09:15 +0100 Matteo Tescione <[EMAIL PROTECTED]> wrote: > On 5-02-2008 14:38, "FUJITA Tomonori" <[EMAIL PROTECTED]> wrote: > > > On Tue, 05 Feb 2008 08:14:01 +0100 > > Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: > >

Re: new scsi sense handling

2008-02-05 Thread FUJITA Tomonori
On Tue, 5 Feb 2008 11:43:58 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > --- On Tue, 2/5/08, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Mon, 4 Feb 2008 18:39:22 -0800 (PST) > > Luben Tuikov <[EMAIL PROTECTED]> wrote: > > > > &

Re: [PATCH 21/24][RFC] scsi_tgt: use of sense accessors

2008-02-05 Thread FUJITA Tomonori
On Tue, 5 Feb 2008 11:21:33 -0500 Pete Wyckoff <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote on Mon, 04 Feb 2008 19:53 +0200: > > FIXME: I need help with this driver (Pete?) > > I used scsi_sense() in a none const way. But since > > scsi_tgt is the ULD here, it can just access it'

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 17:07:07 +0100 Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori schrieb: > > On Tue, 05 Feb 2008 08:14:01 +0100 > > Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: > > > >> James Bottomley schrieb: > >> > >

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Mon, 4 Feb 2008 20:07:01 -0600 "Chris Weiss" <[EMAIL PROTECTED]> wrote: > On Feb 4, 2008 11:30 AM, Douglas Gilbert <[EMAIL PROTECTED]> wrote: > > Alan Cox wrote: > > >> better. So for example, I personally suspect that ATA-over-ethernet is > > >> way > > >> better than some crazy SCSI-over-TCP

Re: new scsi sense handling

2008-02-05 Thread FUJITA Tomonori
On Mon, 4 Feb 2008 18:39:22 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > --- On Mon, 2/4/08, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > There are 3 usages of sense handling in drivers > > > > 1. sense is available in driver internal structure and is > > mem-copied to upper level > > 2.

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 05:43:10 +0100 Matteo Tescione <[EMAIL PROTECTED]> wrote: > Hi all, > And sorry for intrusion, i am not a developer but i work everyday with iscsi > and i found it fantastic. > Altough Aoe, Fcoe and so on could be better, we have to look in real world > implementations what is

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: > James Bottomley schrieb: > > > These are both features being independently worked on, are they not? > > Even if they weren't, the combination of the size of SCST in kernel plus > > the problem of having to find a m

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread FUJITA Tomonori
On Wed, 30 Jan 2008 14:10:47 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > On Jan 30, 2008 11:56 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Wed, 30 Jan 2008 09:38:04 +0100 > > "Bart Van Assche" <[EMAIL PROTECTED]> wrote

Re: Integration of SCST in the mainstream Linux kernel

2008-01-30 Thread FUJITA Tomonori
On Wed, 30 Jan 2008 09:38:04 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > On Jan 30, 2008 12:32 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > > iSER has parameters to limit the maximum size of RDMA (it needs to > > repeat RDMA with a poo

Re: Integration of SCST in the mainstream Linux kernel

2008-01-29 Thread FUJITA Tomonori
On Tue, 29 Jan 2008 13:31:52 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > > . . STGT read SCST read.STGT read > SCST read. > > . . performance performance . performance > performance . > > .

Re: [PATCH] zfcp: fix sense_buffer access bug

2008-01-28 Thread FUJITA Tomonori
On Mon, 28 Jan 2008 08:46:25 +0100 Christof Schmitt <[EMAIL PROTECTED]> wrote: > On Sun, Jan 27, 2008 at 12:41:50PM +0900, FUJITA Tomonori wrote: > > The commit de25deb18016f66dcdede165d07654559bb332bc changed > > scsi_cmnd.sense_buffer from a static array to a dynamically

[PATCH] zfcp: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers

[PATCH] ncr53c8xx: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can't access to sense_buffer in '&cmd->sense_buffer' way. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/s

aic79xx: fix sense_buffer access bug

2008-01-26 Thread FUJITA Tomonori
Ah, I overlooked more LLDs... = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] aic79xx: fix sense_buffer access bug The commit de25deb18016f66dcdede165d07654559bb332bc changed scsi_cmnd.sense_buffer from a static array to a dynamically allocated buffer. We can'

[PATCH] hptiop: fix sense_buffer

2008-01-26 Thread FUJITA Tomonori
Sorry, there was another place that I overlooked in the sense buffer conversion. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] hptiop: fix sense_buffer access bug Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/hptiop.c |2 +- 1 files changed,

[PATCH] aic79xx: fix warnings with CONFIG_PM disabled

2008-01-26 Thread FUJITA Tomonori
xx_pci_driver struct, removes some forward declarations, and adds some ifdef CONFIG_PM. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic79xx.h |5 +++- drivers/scsi/aic7xxx/aic79xx_core.c|2 + drivers/scsi/aic7xx

[PATCH] aic7xxx: fix warnings with CONFIG_PM disabled

2008-01-26 Thread FUJITA Tomonori
xx_pci_driver struct, removes some forward declarations, and adds some ifdef CONFIG_PM. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx/aic7xxx.h |4 +++ drivers/scsi/aic7xxx/aic7xxx_core.c|3 +- drivers/scsi/aic7xx

Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
On Sat, 26 Jan 2008 11:22:47 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Fri, 25 Jan 2008 20:05:55 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > > This is against the scsi-bi

Re: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
On Fri, 25 Jan 2008 20:05:55 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > This is against the scsi-bidi tree. > > > > We need to use the cmd_type of a leading request for scsi_init_sgtable > >

[PATCH] use the cmd_type of a leading request for scsi_init_sgtable

2008-01-25 Thread FUJITA Tomonori
rchive.com/linux-scsi@vger.kernel.org/msg12669.html = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable We need to use the cmd_type of a leading request for scsi_init_sgtable to set up scsi_data_buffer:length of its bidi reque

[PATCH 1/2] destroy scsi_bidi_sdb_cache in scsi_exit_queue

2008-01-25 Thread FUJITA Tomonori
This patchset is against the scsi-bidi tree. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH 1/2] destroy scsi_bidi_sdb_cache in scsi_exit_queue Needs to call kmem_cache_destroy for scsi_bidi_sdb_cache in scsi_exit_queue. Signed-off-by: FUJITA Tomonori <[EMAIL

[PATCH 2/2] handle scsi_init_queue failure properly

2008-01-25 Thread FUJITA Tomonori
scsi_init_queue is expected to clean up allocated things when it fails. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi

[PATCH 1/2] ch: fix device minor number management bug

2008-01-24 Thread FUJITA Tomonori
Oops, sorry, I sent the patches to linux-kernel... = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH 1/2] ch: fix device minor number management bug ch_probe uses the total number of ch devices as minor. ch_probe: ch->minor = ch_devcount; ... ch_devcount

[PATCH 2/2] ch: remove forward declarations

2008-01-24 Thread FUJITA Tomonori
This moves ch_template and changer_fops structs to the end of file and removes forward declarations. This also removes some trailing whitespace. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/ch.c | 120 - 1 files c

[PATCH] ch: handle class_device_create failure properly

2008-01-23 Thread FUJITA Tomonori
When class_device_create fails, ch_probe needs to fail too. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/ch.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c index cead0f5..765f2fc

[PATCH 1/3] scsi_debug: add get_data_transfer_info helper function

2008-01-22 Thread FUJITA Tomonori
This adds get_data_transfer_info helper function that get lha and sectors for READ_* and WRITE_* commands (and XDWRITEREAD_10 later). Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi_debug.c | 83 1 files chang

[PATCH 3/3] scsi_debug: add XDWRITEREAD_10 support

2008-01-22 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi_debug.c | 70 + include/scsi/scsi.h |1 + 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c

Re: [PATCH 0/3] update bidirectional series to sit on top of sg_table

2008-01-22 Thread FUJITA Tomonori
From: James Bottomley <[EMAIL PROTECTED]> Subject: [PATCH 0/3] update bidirectional series to sit on top of sg_table Date: Fri, 11 Jan 2008 21:09:00 -0600 > OK, I suppose in the scheme of things, it's my turn to bear some of the > pain. the SCSI bidirectional series rejects pretty badly with sg_t

[PATCH 2/3] scsi_debug: add bidi data transfer support

2008-01-22 Thread FUJITA Tomonori
This enables fill_from_dev_buffer and fetch_to_dev_buffer to handle bidi commands. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi_debug.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/scsi_debug.c b/d

Re: Performance of SCST versus STGT

2008-01-22 Thread FUJITA Tomonori
On Tue, 22 Jan 2008 14:33:13 +0300 Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > The big problem of stgt iSER is disk I/Os (move data between disk and > > page cache). We need a proper asynchronous I/O mechanism, however, > > Linux doesn&

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-21 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 21:37:41 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Mon, Jan 21, 2008 at 01:08:58PM +0900, FUJITA Tomonori wrote: > > On Sun, 20 Jan 2008 09:40:11 -0700 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > Longer-term, I want to all

Re: Performance of SCST versus STGT

2008-01-21 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 10:36:18 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > On Jan 18, 2008 1:08 PM, Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > > > > [ ... ] > > So, seems I understood your slides correctly: the more valuable data for > > our SCST SRP vs STGT iSER comparison should b

Re: [PATCH] remove use_sg_chaining

2008-01-20 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 21:54:21 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Sun, Jan 20 2008 at 21:24 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sun, 2008-01-20 at 21:18 +0200, Boaz Harrosh wrote: > >> On Tue, Jan 15 2008 at 19:52 +0200, James Bottomley <[EMAIL PROTECTED]> > >>

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 09:40:11 -0700 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Jan 16, 2008 at 01:32:17PM +0900, FUJITA Tomonori wrote: > > This removes static array sense_buffer in scsi_cmnd and uses > > dynamically allocated sense_buffer (with GFP_DMA). > >

Re: [PATCH v3] use dynamically allocated sense buffer

2008-01-20 Thread FUJITA Tomonori
On Sun, 20 Jan 2008 10:36:56 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Wed, 2008-01-16 at 13:32 +0900, FUJITA Tomonori wrote: > > This is the third version of: > > > > http://marc.info/?l=linux-scsi&m=120038907123706&w=2 > [...] > >

Re: [PATCH] firewire: fw-sbp2: prepare for s/g chaining

2008-01-17 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 21:10:50 +0100 (CET) Stefan Richter <[EMAIL PROTECTED]> wrote: > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > --- > > Replacement of patch "firewire: fw-sbp2: enable s/g chaining". > > It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk > to prevent co

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 09:58:11 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-01-17 at 18:13 +0900, FUJITA Tomonori wrote: > > On Wed, 16 Jan 2008 14:35:50 +0200 > > Benny Halevy <[EMAIL PROTECTED]> wrote: > > > > > On Jan. 1

[PATCH] atp870u: don't zero out sense_buffer in queuecommand

2008-01-17 Thread FUJITA Tomonori
LLDs don't need to zero out scsi_cmnd::sense_buffer in queuecommand since scsi-ml does. This is a preparation of the future changes to allocate the sense_buffer only when necessary. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/atp870u.c |1 - 1 files

Re: Performance of SCST versus STGT

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 12:48:28 +0300 Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > On Thu, 17 Jan 2008 10:27:08 +0100 > > "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > > > > > >>Hello, > >> >

Re: Performance of SCST versus STGT

2008-01-17 Thread FUJITA Tomonori
On Thu, 17 Jan 2008 10:27:08 +0100 "Bart Van Assche" <[EMAIL PROTECTED]> wrote: > Hello, > > I have performed a test to compare the performance of SCST and STGT. > Apparently the SCST target implementation performed far better than > the STGT target implementation. This makes me wonder whether th

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-17 Thread FUJITA Tomonori
On Wed, 16 Jan 2008 14:35:50 +0200 Benny Halevy <[EMAIL PROTECTED]> wrote: > On Jan. 15, 2008, 17:20 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote: > >> This is the second version of > >>

Re: INITIO scsi driver fails to work properly

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 09:16:06 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sun, 2008-01-13 at 14:28 +0200, Filippos Papadopoulos wrote: > > On 1/11/08, James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > > On Fri, 2008-01-11 at 18:44 +0200, Filippos Papadopoulos wrote: > > > > On Jan 1

[PATCH v3] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
are the previous results: scsi-misc (slub) | 486.9 MB/s IOPS 124652.9/s dynamic sense buf (slub) | 483.2 MB/s IOPS 123704.1/s I put the results and the kernel configuration: http://www.kernel.org/pub/linux/kernel/people/tomo/sense/ = From: FUJITA Tomonori <[EMAIL PROTECTED]> Su

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 17:44:14 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > If __scsi_put_command puts a command to shost->free_list, it doesn't > > free scmd->sense_buffer since it's the sense_buffer for the backup > > sense_buffer. If __scsi_put_command puts a command to > > shost->cmd_pool->

Re: [PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
On Tue, 15 Jan 2008 15:56:56 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > This is the second version of > > > > http://marc.info/?l=linux-scsi&m=119933628210006&w=2 >

[PATCH v2] use dynamically allocated sense buffer

2008-01-15 Thread FUJITA Tomonori
ard disk overheads). Here's the full results: http://www.kernel.org/pub/linux/kernel/people/tomo/sense/results.txt = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] use dynamically allocated sense buffer This removes static array sense_buffer in scsi_cmnd and uses dy

Re: panic in sg_add when class_device_create() fails

2008-01-14 Thread FUJITA Tomonori
On Mon, 14 Jan 2008 14:11:36 -0800 Michael Reed <[EMAIL PROTECTED]> wrote: > We're seeing an occasional panic in sg_add() when class_device_create() > fails. It's obvious in the code that it uses the pointer to sg_class_member > even though it's invalid. We do see the "class_device_create failed

[PATCH 2/2] sg: handle class_device_create failure properly

2008-01-14 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/sg.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 92b4367..527e2eb 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1430,11 +1

[PATCH 1/2] sg: set class_data after success

2008-01-14 Thread FUJITA Tomonori
If cdev_add fails in sg_add, sg_remove crashes since class_data is bogus. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/sg.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index f1871ea..92b4367 100644

[PATCH 2/2] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE

2008-01-12 Thread FUJITA Tomonori
y permission of Mark (I use min macro). o The previous version overlooked some sizeof sense_buffer lines in aacraid and qla4xxx. o I overlooked the ncr53c8xx compile warning. = From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH 2/2] replace sizeof sense_buffer with SCSI_SENSE_BUF

[PATCH 1/2] don't zero out sense_buffer in queuecommand

2008-01-12 Thread FUJITA Tomonori
r now because new APIs for them would be added later on. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/aic7xxx_old.c |1 - drivers/scsi/eata_pio.c |1 - drivers/scsi/ips.c |3 --- drivers/scsi/libsas/sas_scsi_host.c |1

[PATCH] libsas: fix sense_buffer overrun

2008-01-12 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas_scsi_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index b784089..828fed1 100644 --- a/drivers/scsi/

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread FUJITA Tomonori
On Thu, 10 Jan 2008 16:46:05 -0500 Pete Wyckoff <[EMAIL PROTECTED]> wrote: > Is there another async I/O mechanism? Userspace builds the CDBs, > just needs some way to drop them in SCSI ML. BSG is almost perfect > for this, but doesn't do iovec, leading to lots of memcpy. syslets? - To unsubscri

Re: Driver 'sd' needs updating

2008-01-10 Thread FUJITA Tomonori
CC'ed linux-scsi and James, On Thu, 10 Jan 2008 08:51:50 + Nick Warne <[EMAIL PROTECTED]> wrote: > > Hi everybody - Happy New Year to you all! > > OK, updated to git rc7 yesterday - I now see this in syslog: > >"Driver 'sd' needs updating - please use bus_type methods" > > The warning

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-08 Thread FUJITA Tomonori
On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote on Sat, 05 Jan 2008 14:01 +0900: > > From: Deepak Colluru <[EMAIL PROTECTED]> > > Subject: [PATCH] bsg : Add support for io vectors in bsg > > Date: Fri, 4 Jan 2008 21:47:34 +0530 (IST) > > > > > F

Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3

2008-01-08 Thread FUJITA Tomonori
CC'ed Jes, On Tue, 8 Jan 2008 14:15:53 +0300 Evgeniy Dushistov <[EMAIL PROTECTED]> wrote: > On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote: > > This is a bit of a rash of bug fixes. The qla1280 is actually a bug fix > > (in spite of the title---it's actually correcting an existi

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2008-01-07 Thread FUJITA Tomonori
On Mon, 07 Jan 2008 15:25:36 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Sun, 23 Dec 2007 13:09:05 +0200 > > Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > > >

[PATCH] fix scsi_setup_command_freelist failure path race

2008-01-07 Thread FUJITA Tomonori
Looks like that host_cmd_pool_mutex are necessary here. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/scsi.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index ebc0193..54ff611 100644 --- a/d

Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd

2008-01-06 Thread FUJITA Tomonori
On Sun, 23 Dec 2007 13:09:05 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly > > by some low level drivers (that typically happens with US

Re: [PATCH 2/2] use dynamically allocated sense buffer

2008-01-06 Thread FUJITA Tomonori
On Thu, 3 Jan 2008 13:56:37 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > This removes static array sense_buffer in scsi_cmnd and uses > dynamically allocated sense_buffer (with GFP_DMA). > > scsi_add_host allocates as many buffers as > scsi_host->can_queue. __s

RE: Open-FCoE on linux-scsi

2008-01-05 Thread FUJITA Tomonori
On Fri, 4 Jan 2008 14:07:28 -0800 "Dev, Vasu" <[EMAIL PROTECTED]> wrote: > > >> > >> _If_ there will indeed be dedicated FCoE HBAs in the future, the > >> following stack could exist in addition to the one above: > >> > >> - SCSI core, > >> scsi_transport_fc > >> - FCoE HBA driver(s) > >

  1   2   3   4   5   6   >