Re: [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

2017-10-06 Thread Herbert Xu
Allen Pais wrote: > Signed-off-by: Allen Pais Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me s

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-27 Thread Herbert Xu
On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote: > > > On 26/04/17 09:56 PM, Herbert Xu wrote: > > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > >> Very straightforward conversion to the new function in the caam driver > >> an

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-26 Thread Herbert Xu
On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe > Cc: Herbert Xu > Cc: "David S. Miller" > --- >

Re: [PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation

2013-05-13 Thread Herbert Xu
nsform for the x86_64 cpus that support it. > 3. Added generic crct10dif crypto transform. All applied. Thanks Tim. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line &q

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-29 Thread Herbert Xu
gt; code. This is only an issue when everything is built-in to the kernel. In that case we could make the crc implementations register at a point earlier than device_initcall, but no earlier than subsys_initcall since that's where cryptomgr sits. Cheers, -- Email: Herbert Xu Home Page: h

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-27 Thread Herbert Xu
ver, I think this is an overkill. Initialising it once should be enough. If someone really wanted to change things at run-time, they could always build this as a module and unload/reload it. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.a

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-26 Thread Herbert Xu
nditional like the crc32c case. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kerne

Re: [PATCH v2 1/4] Wrap crc_t10dif function all to use crypto transform framework

2013-04-25 Thread Herbert Xu
o the crypto framework. > > Signed-off-by: Tim Chen Please wrap the generic implementation as we do for crc32c. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread Herbert Xu
le list in order to add just a single block at the end. While with sg_ring we could just put the original list along with the new one in a new list. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gond

Re: [PATCH 1/3] SG: Move functions to lib/scatterlist.c and add sg chaining allocator helpers

2007-12-21 Thread Herbert Xu
#x27;s do it properly as Rusty has demonstrated so that we support back-chaining as well as frong-chaining. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [PATCH 0/5] sg_ring for scsi

2007-12-21 Thread Herbert Xu
sit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mess

Re: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-06-07 Thread Herbert Xu
ng free_pages(). Could you explain what is going to cause this page to be reused if it has a non-zero reference count? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org

Re: SG_IO with >4k buffer size to iscsi sg device causes "Bad page" panic

2007-05-09 Thread Herbert Xu
(resp); > + for( m = PAGE_SIZE; m < resSz; m += PAGE_SIZE ) > + { > + tmppage++; > + SetPageReserved(tmppage); > + } > + Why not just increase the page use count? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~