Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread Hiral Patel (hiralpat)
Hi James, Yes for this patch Narsimhulu Musini is the author of this patch. Thanks, Hiral On 9/6/13 10:35 AM, "James Bottomley" wrote: >On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote: >> Code to reset fc_host statistics. >> echo 1 > /sys/class/fc_host/hostX/statistics/reset_statistics cl

Re: [PATCH v2] fnic: BUG: sleeping function called from invalid context during probe

2013-07-26 Thread Hiral Patel (hiralpat)
On 7/23/13 1:04 PM, "Chris Leech" wrote: >I hit this during driver probe with the latest fnic updates (this trace >is from a backport into a distro kernel, but the issue is the same). > >> BUG: sleeping function called from invalid context at mm/slab.c:3113 >> in_atomic(): 0, irqs_disabled(): 1,

Re: [PATCH] fnic: use simple_open instead of fnic_trace_ctrl_open

2013-07-12 Thread Hiral Patel (hiralpat)
On 7/11/13 11:50 PM, "Camelia Groza" wrote: >This removes the open coded fnic_trace_ctrl_open() function >and replaces file operations references to the function >with simple_open() instead. > >Found using coccinelle. > >Signed-off-by: Camelia Groza >--- > drivers/scsi/fnic/fnic_debugfs.c |

Re: [patch] [SCSI] fnic: potential dead lock in fnic_is_abts_pending()

2013-06-04 Thread Hiral Patel (hiralpat)
On 5/30/13 12:50 AM, "Dan Carpenter" wrote: >There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is >false. > >Signed-off-by: Dan Carpenter >--- >Static analysis. I can't test this. > >diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c >index be99e75..a97e6e5 1

Re: [scsi:misc 102/104] drivers/scsi/fnic/fnic_fcs.c:381:31: sparse: cast to restricted __be16

2013-02-25 Thread Hiral Patel (hiralpat)
Hey James, I have fixed FIP Vlan discovery patch for sparse warnings and resubmitted 3 pending patches. The patches 1-7 got committed to misc branch already has the fix for sparse and other problems. Thanks, Hiral On 2/24/13 12:18 AM, "James Bottomley" wrote: >On Sat, 2013-02-23 at 03:07 +080

Re: [PATCH 08/10] fnic: FIP VLAN Discovery Feature Support

2013-02-22 Thread Hiral Patel (hiralpat)
Thanks James for the fix. -Hiral On 2/22/13 10:09 AM, "James Bottomley" wrote: >On Tue, 2013-02-12 at 17:01 -0800, Hiral Patel wrote: >> FIP VLAN discovery discovers the FCoE VLAN that will be used by all >>other FIP protocols >> as well as by the FCoE encapsulation for Fibre Channel payloads o

Re: [scsi:misc 61/65] drivers/scsi/fnic/fnic_scsi.c:441:3: warning: cast from pointer to integer of different size

2013-02-12 Thread Hiral Patel (hiralpat)
Hi James, I have fixed fnic patches 3-10 for sparse and smatch errors. Thanks, Hiral On 1/29/13 10:26 PM, "kbuild test robot" wrote: >tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc >head: 52cb5cbe9b8ed89db0f8c9eeec8410fcfb0887fd >commit: 6f3b5679f2af1ef3becbf7832d2b

Re: [scsi:for-next 23/27] drivers/scsi/fnic/fnic_scsi.c:1260 fnic_rport_exch_reset() error: we previously assumed 'sc->device' could be null (see line 1237)

2013-01-29 Thread Hiral Patel (hiralpat)
Hi Dan, I have fixed the new smatch warnings which was introduced by fnic update patches and resubmitted new patches. Thanks, Hiral On 12/17/12 5:49 AM, "Dan Carpenter" wrote: >[ It doesn't make sense to check for NULL, print an error and then > dereference the pointer. The normal Oops messa

linux-scsi@vger.kernel.org

2013-01-29 Thread Hiral Patel (hiralpat)
Hi James, Sorry, somehow I missed looking at kbuild emails. I have fixed sparse and smatch issues and resubmitted patches 3-10. Thanks, Hiral On 1/28/13 7:16 PM, "James Bottomley" wrote: >On Mon, 2012-12-17 at 21:50 +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/

Re: [PATCH 06/10] fnic: New debug flags and debug log messages

2012-12-19 Thread Hiral Patel (hiralpat)
Hi James, I agree with your comment. I missed on duplicate definition, as gcc didnĀ¹t give me error while compiling. I just resubmitted patch 06 after removing duplicate definition. Thanks, Hiral On 12/19/12 2:01 AM, "James Bottomley" wrote: >On Mon, 2012-12-17 at 15:29 -0800, Hiral Patel wrot

Re: [PATCH 05/10] fnic: fnic driver may hit BUG_ON on device reset

2012-12-17 Thread Hiral Patel (hiralpat)
Just submitted 05, 06, 07 and 08 fnic patches after verifying compilation of each patch independently. Thanks, Hiral On 12/17/12 3:24 AM, "James Bottomley" wrote: >On Mon, 2012-12-10 at 01:21 -0800, Hiral Patel wrote: >> The issue was observed when LUN Reset is issued through IOCTL or >>sg_rese

Re: [PATCH 9/9] fnic: FIP configuration mismatch between switch and adapter crashes driver

2012-12-10 Thread Hiral Patel (hiralpat)
Sorry This one is just same as [9/10], only difference is subject. By mistake I emailed it with others. Ignore this patch from the set. Thanks, Hiral On 12/10/12 1:38 AM, "James Bottomley" wrote: >On Mon, 2012-12-10 at 01:21 -0800, Hiral Patel wrote: >> If switch configured in FIP and kirkwood