李春 于2019年1月30日周三 上午7:08写道：
>
> # Description of problem:
> We loaded a disk from two network of storage node via iscsi, merged
> into a disk through multipath, and made a raid1 with local disk by
> mdadm.
> However, when the storage machine of iscsi disk rebooted, raid1 disk
> does not automatic
Christoph Hellwig 于2018年10月11日周四 下午9:38写道：
>
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Jack Wang
Thanks,
Jack
Hi,
We have ssd failure sometimes, and mpt3sas remove the devices
automatically, and readd again.
For example
[Tue Jul 31 13:46:58 2018] sd 11:0:4:0: device_block, handle(0x000d)
[Tue Jul 31 13:47:00 2018] sd 11:0:4:0: device_unblock and setting to
running, handle(0x000d)
[Tue Jul 31 13:47:00 201
> entry_SYSCALL_64_after_hwframe+0x49/0xbe
>
> See also
> https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg54525.html.
>
> Suggested-by: Eric W. Biederman
> Fixes: ac0ece9174ac ("scsi: use device_remove_file_self() instead of
> device_schedule_callback()")
> Signed-off-by: Bart Van Assche
> Cc: Eric W. Biederman
> Cc: Tejun Heo
> Cc: Hannes Reinecke
> Cc: Johannes Thumshirn
> Cc: Ingo Molnar
> Cc: Oleg Nesterov
> Cc:
Looks good to me!
Reviewed-by: Jack Wang
2018-03-19 18:44 GMT+01:00 James Bottomley
:
> On Mon, 2018-03-19 at 17:30 +0100, Jack Wang wrote:
>> >
>> >
>> > >
>> > > And I think either mpt2sas and/or mpt3sas HBAs (I don't have my
>> > > hardware
>> > > nearby) have
>
>> And I think either mpt2sas and/or mpt3sas HBAs (I don't have my hardware
>> nearby) have a SMP target hidden away somewhere. Perhaps someone from
>> LSI/Avago/Broadcom could supply more information about that.
Indeed, mpt3sas has internal enclosure some how.
snip from "sas3ircu 0 display" ou
2018-03-19 15:20 GMT+01:00 Douglas Gilbert :
> On 2018-03-19 11:40 AM, Jack Wang wrote:
>>
>> Hi list,
>>
>> Any one knows how can I locate a HDD directly attached to mpt3sas,
>> sas3ircu only supports LOCATE commd to locates driver installed in a
>> di
Hi list,
Any one knows how can I locate a HDD directly attached to mpt3sas,
sas3ircu only supports LOCATE commd to locates driver installed in a
disk enclosure, but not directly attached.
I know microsemi/PMCs supports SGPIO interface to locate drive eg:
Adp80xxapp sgpio 0 set 0 1
I searched in
2018-03-07 8:47 GMT+01:00 Jason Yan :
> When ata device doing EH, some commands still attached with tasks are not
> passed to libata when abort failed or recover failed, so libata did not
> handle these commands. After these commands done, sas task is freed, but
> ata qc is not freed. This will cau
2018-02-27 12:50 GMT+01:00 John Garry :
> On 27/02/2018 06:59, Jason Yan wrote:
>>
>> When ata device doing EH, some commands still attached with tasks are not
>> passed to libata when abort failed or recover failed, so libata did not
>> handle these commands. After these commands done, sas task is
From: Jack Wang
The check_events interface was added for check if device changes,
mainly for device is removable eg. CDROM
In sd_open, it checks if device is removable then check_disk_change.
when the device is not removable, we can simple succeeds the call
without send TUR.
Signed-off-by
+cc Viswas from micorsemi. maybe he can help.
2018-01-12 12:15 GMT+01:00 :
>
> Hello, we have a long standing issue for a couple of years with our SAS HBA.
>
> It happens no matter what distribution we use(Debian, CentOS, Ubuntu).
>
> When we bought this HBA we had already two 500GB Seagate SAS H
2017-11-17 18:01 GMT+01:00 Bart Van Assche :
> On Fri, 2017-11-17 at 16:14 +0100, Jack Wang wrote:
>> I suspect could be missing run queue or lost IO, IMHO it's unlikely
>> below disk probing fix the bug.
>
> If the system is still in this state or if you can reproduce th
2017-11-14 18:33 GMT+01:00 Bart Van Assche :
> On Tue, 2017-11-14 at 18:01 +0100, Jack Wang wrote:
>> I suspect we run into same bug you were trying to fix in this patch
>> set. we're running in v4.4.50
>>
>> I was trying to reproduce it, but no lucky yet, do y
2016-11-14 19:35 GMT+01:00 Bart Van Assche :
> On 11/12/2016 09:47 PM, James Bottomley wrote:
>>
>> On Fri, 2016-11-11 at 16:38 -0800, Bart Van Assche wrote:
>>>
>>> Hello James and Martin,
>>>
>>> This short patch series fixes a deadlock that I ran into for the
>>> first time several months ago bu
}
>
> @@ -353,3 +343,11 @@ void sas_unregister_ports(struct sas_ha_struct *sas_ha)
> sas_deform_port(sas_ha->sas_phy[i], 0);
>
> }
> +
> +const work_func_t sas_port_event_fns[PORT_NUM_EVENTS] = {
> + [PORTE_BYTES_DMAED] = sas_porte_bytes_dmaed,
> + [PORTE_BROADCAST_RCVD] = sas_porte_broadcast_rcvd,
> + [PORTE_LINK_RESET_ERR] = sas_porte_link_reset_err,
> + [PORTE_TIMER_EVENT] = sas_porte_timer_event,
> + [PORTE_HARD_RESET] = sas_porte_hard_reset,
> +};
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 99f32b5..c80321b 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -292,6 +292,7 @@ struct asd_sas_port {
> struct asd_sas_event {
> struct sas_work work;
> struct asd_sas_phy *phy;
> + int event;
> };
>
> static inline struct asd_sas_event *to_asd_sas_event(struct work_struct
> *work)
> @@ -301,17 +302,20 @@ static inline struct asd_sas_event
> *to_asd_sas_event(struct work_struct *work)
> return ev;
> }
>
> +static inline void INIT_SAS_EVENT(struct asd_sas_event *ev, void
> (*fn)(struct work_struct *),
> + struct asd_sas_phy *phy, int event)
> +{
> + INIT_SAS_WORK(&ev->work, fn);
> + ev->phy = phy;
> + ev->event = event;
> +}
> +
> +
> /* The phy pretty much is controlled by the LLDD.
> * The class only reads those fields.
> */
> struct asd_sas_phy {
> /* private: */
> - struct asd_sas_event port_events[PORT_NUM_EVENTS];
> - struct asd_sas_event phy_events[PHY_NUM_EVENTS];
> -
> - unsigned long port_events_pending;
> - unsigned long phy_events_pending;
> -
> int error;
> int suspended;
>
> --
> 2.5.0
>
Looks good, thanks!
Reviewed-by: Jack Wang
-git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 2fa0b13..08c1c32 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -679,6 +679,7 @@ extern int sas_bios_param(struct scsi_device *,
> sector_t capacity, int *hsc);
> extern struct scsi_transport_template *
> sas_domain_attach_transport(struct sas_domain_function_template *);
> +extern struct device_attribute dev_attr_phy_event_threshold;
>
> int sas_discover_root_expander(struct domain_device *);
>
> --
> 2.5.0
>
Looks good, thanks!
Reviewed-by: Jack Wang
icate
> domain unless we set the strict_wide_port to 1.
>
> Regards,
> Viswas G
Ok, understand now!
Acked-by: Jack Wang
Thanks!
>
>
>> -----Original Message-
>> From: Jack Wang [mailto:xjtu...@gmail.com]
>> Sent: Tuesday, August 29, 2017 4:55 PM
ion.
>
> Regards,
> Viswas G
Hi Viswas,
The spasti field is only for pm80xx, not for pm8001, I think it's
better to move sas_identify_frame_local to pm80xx_hwi.h.
Regards,
Jack
>
>> -Original Message-
>> From: Jack Wang [mailto:xjtu...@gmail.com]
>
atic void pm80xx_send_read_log(struct pm8001_hba_info
> *pm8001_ha,
> ccb->device = pm8001_ha_dev;
> ccb->ccb_tag = ccb_tag;
> ccb->task = task;
> + ccb->n_elem = 0;
> pm8001_ha_dev->id |= NCQ_READ_LOG_FLAG;
> pm8001_ha_dev->id |= NCQ_2ND_RLE_FLAG;
>
> --
> 2.12.3
>
Thanks.
Looks good to me!
Acked-by: Jack Wang
2015-01-30 7:06 GMT+01:00 Viswas G :
> Modified SATA abort handling with following steps:
> 1) Set device state as recovery.
> 2) Send phy reset.
> 3) Wait for reset completion.
> 4) After successful reset, abort all IO's to the device.
> 5) After aborting all IO's to device, set device state as op
; index 1ee2ec210065..d8e5d81e83f1 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.h
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.h
> @@ -1349,6 +1349,8 @@ typedef struct SASProtocolTimerConfig
> SASProtocolTimerConfig_t;
> #define MAIN_SAS_PHY_ATTR_TABLE_OFFSET 0x90 /* DWORD 0x24 */
> #define MAIN_PORT_RECOVERY_TIMER 0x94 /* DWORD 0x25 */
> #define MAIN_INT_REASSERTION_DELAY 0x98 /* DWORD 0x26 */
> +#define MAIN_MPI_ILA_RELEASE_TYPE 0xA4 /* DWORD 0x29 */
> +#define MAIN_MPI_INACTIVE_FW_VERSION 0XB0 /* DWORD 0x2C */
>
> /* Gereral Status Table offset - byte offset */
> #define GST_GSTLEN_MPIS_OFFSET 0x00
> --
> 2.12.3
>
Thanks, looks good to me.
Acked-by: Jack Wang
2015-01-30 7:06 GMT+01:00 Viswas G :
> Different SAS addresses are assigned for each set of phys.
>
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_init.c | 13 +
> drivers/scsi/pm8001/pm80xx_hwi.c | 3 +--
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --
2015-01-30 7:06 GMT+01:00 Viswas G :
> sas_identify structure defined by pm80xx doesn't have CRC field.
> So added a new sas_identify structure without CRC.
>
> Signed-off-by: Raj Dinesh
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_hwi.h | 2 +-
> drivers/scsi/pm8001/pm8001_sas.
8 << 8)
>
> /* phy_profile */
> --
> 2.12.3
>
Thanks Viswas, how did this happen, checked pm8001_hwi.h, it's right.
Anyway, looks good to me!
Acked-by: Jack Wang
From: Jack Wang
The email address is undeliverable for some time now,
so just remove it.
Signed-off-by: Jack Wang
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 12a528a..e3e61c5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9989,7 +9989,6
message even though vSES device has failed the command
> with illegal request error message and it has not returned any wrong
> diagnostic page.
>
> sdev_printk(KERN_ERR, sdev,
> "Wrong diagnostic page; asked for %d got %u\n",
> page_code, recv_page_code);
>
> Thanks,
> Sreekanth
Hi Sreekanth,
To me, we should fix ses module to check 00h List of Supported
Diagnostic Pages first before ask for 07h.
Add James in CC.
Cheers,
Jack Wang
2017-03-07 1:54 GMT+01:00 V :
> Hi,
>
> I am reaching out regarding a SCSI error handler issue, which we see
> in our lab systems.
>
> Environment: Ubuntu 4.4.0-31-generic
>
> Issue: Write IOs are getting stuck in our system randomly. All drives
> seen with the issue are all SATA drives.
> Root cau
e81a8fa 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.h
> +++ b/drivers/scsi/pm8001/pm8001_sas.h
> @@ -521,8 +521,6 @@ struct pm8001_hba_info {
> struct pm8001_device*devices;
> struct pm8001_ccb_info *ccb_info;
> #ifdef PM8001_USE_MSIX
> - struct msix_entry msix_entries[PM8001_MAX_MSIX_VEC];
> - /*for msi-x interrupt*/
> int number_of_intr;/*will be used in remove()*/
> #endif
> #ifdef PM8001_USE_TASKLET
>
Looks good, thanks!
Acked-by: Jack Wang
sk/queue/iosched/read_expire
> echo 1500 > /sys/block/$disk/queue/iosched/write_expire
> echo 1 > /sys/block/$disk/device/queue_depth;
> echo 300 > /sys/block/$disk/device/timeout;
> done
>
> I hope the performance impact of queue_depth = 1 is not to much
2017-01-26 10:51 GMT+01:00 Jelle de Jong :
> Hello everybody,
>
> I got a server that seemingly random gets kernel crashes, due to an
> escalation of events from most likely the mvsas based disk controller.
>
> The harddisk should be okay, I replaced a whole bunch to be sure, but the
> server does
e soon with all the buf fixes and performance
> tuning changes.
>
> Regards,
> Viswas G
>
> On Thu, Jul 7, 2016 at 10:04 PM, wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=121531
>>
>> --- Comment #14 from Jack Wang ---
>> The changes are huge, hard
s/scsi/pm8001/pm80xx_hwi.c:4554 mpi_set_phy_profile_req()
> error: uninitialized symbol 'tag'.
>
Thanks for reporting, attached patch should fix the warning.
From e30af801d9ee9979b2a7a2af815cb395c2255a09 Mon Sep 17 00:00:00 2001
From: Jack Wang
Date: Thu, 14 Apr 2016 14:38:57 +0200
Su
Fix it by remove scsi host first, this way scsi core will not send
commands down after detaching SAS transport.
This is a follow up fix for Benjamin's fix for pm80xx.
See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html
Signed-off-by: Jack Wang
---
drivers/scsi/mvsas/mv_init.c
Fix it by remove scsi host first, this way scsi core will not send
commands down after detaching SAS transport.
This is a follow up fix for Benjamin's fix for pm80xx.
See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html
Signed-off-by: Jack Wang
---
drivers/scsi/aic94xx/aic94xx_init.c
Fix it by remove scsi host first, this way scsi core will not send
commands down after detaching SAS transport.
This is a follow up fix for Benjamin's fix for pm80xx.
See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html
Signed-off-by: Jack Wang
---
drivers/scsi/isci/init.c |
2015-10-30 21:01 GMT+01:00 Benjamin Rood :
> Previously, when this module was unloaded via 'rmmod' with at least one
> drive attached, the SCSI error handler thread would become stuck in an
> infinite recovery loop and lockup the system, necessitating a reboot.
>
> Once the SAS layer is detached, t
t for non msi-x interrupt handler */
> - if ((!pdev->msix_cap) || (pm8001_ha->chip_id == chip_8001))
> + if ((!pdev->msix_cap || !pci_msi_enabled()) ||
> + (pm8001_ha->chip_id == chip_8001))
> tasklet_init(&pm8001_ha->tasklet[0], pm8001_tasklet,
> (unsigned long)&(pm8001_ha->irq_vector[0]));
> else
> --
> 2.4.3
>
Reviewed-by: Jack Wang
Thanks
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-10-30 15:53 GMT+01:00 Benjamin Rood :
> The documentation for the 8070 and 8072 SPCv chip explicitly states that
> a minimum of 500ms must elapse before issuing commands, otherwise the
> SPCv may not process them and the firmware may get into an unrecoverable
> state requiring a reboot. While
DOR_ID_ADAPTEC2 &&
> + pm8001_ha->pdev->subsystem_vendor !=
> + PCI_VENDOR_ID_ATTO &&
> pm8001_ha->pdev->subsystem_vendor != 0) {
> ibutton0 = pm8001_cr32(pm8001_ha, 0,
>
e_table *circularQ;
> +
> + memset(&payload, 0, sizeof(payload));
> +
> + rc = pm8001_tag_alloc(pm8001_ha, &tag);
> + if (rc)
> + PM8001_INIT_DBG(pm8001_ha, pm8001_printk("Invalid tag"));
> +
> + circularQ = &pm8001_ha->inbnd_q_tbl[0];
&
;> + payload.func_specific[0x010 + i];
>> } else
>> pm8001_ha->sas_addr[j] =
>> payload.func_specific[0x804 + i];
>>
> The indentation is a bit skewed here.
&g
> + { PCI_VENDOR_ID_ATTO, 0x8072,
> + PCI_VENDOR_ID_ATTO, 0x0082, 0, 0, chip_8072 },
> {} /* terminate list */
> };
>
> --
> 2.4.3
>
Reviewed-by: Jack Wang
Thanks
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-
) \
> + || (dev->device == 0X8070) \
> + || (dev->device == 0X8072))
>
> #define PM8001_NAME_LENGTH 32/* generic length of strings */
> extern struct list_head hba_list;
> --
> 2.4.3
>
Reviewed-by: Jack Wang
Thanks
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Jack Wang
Thanks
Jack
2015-10-30 15:53 GMT+01:00 Benjamin Rood :
> Previuosly, all PMC Sierra 80xx controllers are assumed to be a
> motherboard controller, except if the subsystem vendor ID was equal to
> PCI_VENDOR_ID_ADAPTEC. The driver then attempts to load PHY settin
erriding ts->stat
> to SAS_DEV_NO_RESPONSE.
>
> Signed-off-by: Johannes Thumshirn
Thanks, please feel free to add:
Acked-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 1 +
> drivers/scsi/pm8001/pm80xx_hwi.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git
Company has policy to use company email address, so update
my email address to company address.
Signed-off-by: Jack Wang
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a226416..c82f964 100644
--- a/MAINTAINERS
+++ b
+--
> drivers/scsi/pm8001/pm80xx_hwi.h |5 +-
> 6 files changed, 112 insertions(+), 36 deletions(-)
>
For the whole patchset:
Reviewed-by: Jack Wang
PS: company policy requests to use the email address of the company,
please cc me to above address next time, I will
Sorry for delay, I missed this patch.
Acked-by: Jack Wang
2015-02-12 7:34 GMT+01:00 Suresh Thiagarajan :
> Added the pm8006 controller id in pci table
>
> Signed-off-by: Suresh Thiagarajan
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_defs.h |3 ++-
>
2014-11-04 8:54 GMT+01:00 Christoph Hellwig :
> Now that we also get proper values in cmd->request->tag for untagged
> commands, there is no need to force tagged_supported to on in drivers
> that need host-wide tags.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/fnic/fnic_main.c
Cc pmchba maillist.
2014-09-25 18:20 GMT+02:00 :
> https://bugzilla.kernel.org/show_bug.cgi?id=85151
>
> --- Comment #6 from Jack Wang ---
> Ah, I forgot no bsg node if expander discover failed:(
> HBA SAS address is 0, does not matter.
>
> From my point, this bug clear
If it works, then I'm fine with this, thanks.
Please add my ack if needed:
Acked-by: Jack Wang
2014-07-31 14:53 GMT+02:00 Suresh Thiagarajan :
>
>
> On Wed, Jul 30, 2014 at 5:42 PM, James Bottomley
> wrote:
>> On Wed, 2014-07-30 at 17:37 +0530, Suresh Thiagarajan
Hi Alex,
Looks Ok for me.
Please feel free to add my:
Reviewed-by: Jack Wang
Thanks,
Jack
2014-07-26 10:33 GMT+02:00 Alexander Gordeev :
> On Wed, Jul 16, 2014 at 08:05:22PM +0200, Alexander Gordeev wrote:
>> As result of deprecation of MSI-X/MSI enablement functions
>> pci_en
38 ++---
> drivers/scsi/pm8001/pm8001_sas.h |2 +-
> drivers/scsi/pm8001/pm80xx_hwi.c | 48
> +++--
> 6 files changed, 125 insertions(+), 61 deletions(-)
>
The whole patch set looks good to me.
Thanks for resendin
Thanks Rickard,
>From my point of view, looks good, but I'd like to get review from Anand
(cc-ed).
Anand, could you share your opinion?
Regards,
Jack
On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in
> between.
>
>
Looks good, thanks Rickard.
Acked-by: Jack Wang
On 06/01/2014 03:13 PM, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
> Sign
Thanks Brad for testing and fixing.
Acked-by: Jack Wang
On 06/19/2014 05:13 PM, bradley.gr...@gmail.com wrote:
> From: Bradley Grove
>
> During hibernation, the HBA firmware may lose power and forget the device
> id info. This causes the HBA to reject IO upon resume. The fix
On 06/17/2014 01:15 PM, Maurizio Lombardi wrote:
> The pm8001_get_phy_settings_info() function does not check
> the kzalloc() return value and does not free the allocated memory.
>
> Signed-off-by: Maurizio Lombardi
Looks good, thanks
Acked-by: Jack Wang
> ---
> d
str += sprintf(str, "%c",
> *((u8 *)((u8 *)virt_addr+bios_index)));
> + kfree(payload.func_specific);
> return str - buf;
> }
> static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show,
> NULL);
>
Thanks, looks good.
dler_msix, flag,
> + intr_drvname[i], &(pm8001_ha->irq_vector[i]));
> + if (rc) {
> + for (j = 0; j < i; j++) {
> + free_irq(pm8001_ha->msix_entries[j].vector,
> &(pm8001_ha->irq_vec
free_irq(
> pm8001_ha->msix_entries[j].vector,
>
Thanks, looks fine.
Acked-by: Jack Wang
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
n Seba
> Signed-off-by: Oleg Nesterov
> Signed-off-by: Suresh Thiagarajan
> Signed-off-by: Viswas G
Looks good to me, thanks.
Acked-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 84
> ++
> drivers/scsi/pm8001
id doing it this way?
>
If you use global flags, you may change interrupt state depends on context.
> On Mon, Dec 23, 2013 at 8:45 AM, Suresh Thiagarajan
> wrote:
>>
>>
>> -Original Message-
>> From: Jack Wang [mailto:xjtu...@gmail.com]
>> Sent: Mo
On 12/23/2013 02:07 PM, Tomas Henzl wrote:
> On 12/18/2013 12:28 PM, Viswas G wrote:
>> From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 2001
>> From: Suresh Thiagarajan
>> Date: Mon, 16 Dec 2013 21:15:20 +0530
>> Subject: [PATCH] pm80xx: Spinlock fix
>>
>> spin_unlock was used in
ATTO pm8001 based HBAs.
> pm80xx: Enable BAR shift to avoid BIOS conflict with MPI space for
> ATTO pm8001 based HBAs.
>
> drivers/scsi/pm8001/pm8001_hwi.c | 6 +++---
> drivers/scsi/pm8001/pm8001_init.c | 10 +-
> 2 files changed, 8 insertions(+), 8 deletions
On 11/27/2013 06:40 AM, Viswas G wrote:
> We are resubmitting the following patches in the new patch set
>
> pm80xx : Removing redundant code snippets
> pm80xx : Fixed return value issue
>
> Please discard the previous patches we submitted for the same.
>
> [PATCH 5/6] pm80xx : Removing redunda
On 11/20/2013 08:22 AM, Viswas G wrote:
> pm8001_get_gsm_dump() was returning "1" in error case
> instead of negative error code.
>
> Signed-off-by: Viswas G
Looks good, thanks
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_hwi.c |8
>
On 11/20/2013 08:21 AM, Viswas G wrote:
> Removed redundant code snipptes in pm8001_hwi.c
> and pm8001_ctl.c
>
> Signed-off-by: Viswas G
Looks good, thanks
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 22 --
> drivers/scsi/pm800
ff-by: nikith.ganigarakop...@pmcs.com
Nice catch, Thanks
Reviewed-by: Jack Wang
PS: same about the signed-off chain.
> ---
> drivers/scsi/pm8001/pm8001_hwi.c |2 ++
> drivers/scsi/pm8001/pm8001_hwi.h |4
> drivers/scsi/pm8001/pm80xx_hwi.c |2 ++
> drivers/scsi/pm8001
SATA device delay is not enough.
> It will give crash for set device state command response and
> wait_for_completion is the best solution for this.
>
Nice catch,
Reviewed-by: Jack Wang
PS: the signed-off chain is not right, From author should come first
here Nikith. And please do not
ing complexity by
> using ioctl interface.
>
> Regards,
> Viswas G
>
>
> -Original Message-
> From: Jack Wang [mailto:xjtu...@gmail.com]
> Sent: Monday, November 04, 2013 4:00 PM
> To: Viswas G
> Cc: linux-scsi@vger.kernel.org; Sangeetha Gnanasekaran; Nik
fication: LSI
product identification: Virtual SMP Port
product revision level:
smp_read_gpio /dev/bsg/sas_host0
Read GPIO register response:
GPIO_CFG[0]:
version: 0
GPIO enable: 1
cfg register count: 2
gp register count: 1
supported drive count: 16
Regards,
Jack
> ---
Hi Viswas,
As ioctl interface is not welcome for new feature, that's why we removed
ioctl interface when pm8001 accepted into mainline.
I suggest you use bsg interface for this, see sas_host_smp.c for details.
Regards,
Jack
On 10/22/2013 02:20 PM, Viswas G wrote:
>
> Signed-off-by: Viswas G
>
ntrollers to configure their own settings.
I still think you'd better add a list for devices know to support phy
setting similar as IS_SPC12G, there are some devices in the driver
support list do not have default setting I suspect.
Jack
>
> -Original Message-
> From: Jack Wang
ilities,
> Inbound outbound queues dump.
> Non fatal dump in case of IO failures.
> Fatal dump in case of firmware failure.
>
> Signed-off-by: anandkumar.santha...@pmcs.com
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 129 +
>
On 09/26/2013 07:42 AM, Anand wrote:
> From 4715339743d45a6ef862bc0f5d5ec404b4667f94 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam
> Date: Wed, 18 Sep 2013 11:14:54 +0530
> Subject: [PATCH V2 09/10] pm80xx: 4G boundary fix.
>
> Signed-off-by: anandkumar.santha...@pmcs.com
>
Please give
On 09/26/2013 07:40 AM, Anand wrote:
> From 678d8085ace7c471dc140420c41dc4ad70300d60 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam
> Date: Wed, 18 Sep 2013 11:12:59 +0530
> Subject: [PATCH V2 08/10] pm80xx: Queue rotation logic for inbound and
> outbound queues.
>
> Signed-off-by: anand
anandkumar.santha...@pmcs.com
>
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_hwi.c |6 --
> drivers/scsi/pm8001/pm8001_sas.c |9 -
> 2 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c
>
On 09/26/2013 07:37 AM, Anand wrote:
> From 5ddec5ef3033b4fee08dcdc7ba8b434425453e9d Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam
> Date: Tue, 17 Sep 2013 16:47:21 +0530
> Subject: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device.
>
> Signed-off-by: anandkumar.santha...@pm
snip
> #ifdef PM8001_USE_MSIX
> /**
> * pm8001_setup_msix - enable MSI-X interrupt
> @@ -847,6 +872,9 @@ static int pm8001_pci_probe(struct pci_dev *pdev,
> }
>
> pm8001_init_sas_add(pm8001_ha);
> + /* phy setting support for motherboard controller */
> + if (pdev->subsyst
anandkumar.santha...@pmcs.com
>
As I know no all controller with BIOS support, but it's fine to have this.
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 34 ++
> drivers/scsi/pm8001/pm8001_ctl.h |2 ++
> 2 files changed, 36 i
ode in case of SMP request.
>
> Signed-off-by: anandkumar.santha...@pmcs.com
>
Reviewed-by: Jack Wang
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c |4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c
> b/dri
> IButton security feature support for motherboard controllers.
>
> Signed-off-by: anandkumar.santha...@pmcs.com
Reviewed-by: Jack Wang
>
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 22 +-
> 1 files changed, 21 insertions(+), 1 deletions(-)
>
> diff
safe to set 12g linkrate support also on 6g, if so, then :
Reviewed-by: Jack Wang
> /* SSC Disable and SAS Analog ST configuration */
> /**
> payload.ase_sh_lm_slr_phyid =
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h
> b/drivers/scsi/pm8001/pm80xx_hwi.h
&
On 09/21/2013 07:24 AM, KY Srinivasan wrote:
>
>
>> -Original Message-
>> From: Greg KH [mailto:gre...@linuxfoundation.org]
>> Sent: Friday, September 20, 2013 1:32 PM
>> To: KY Srinivasan
>> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
>> oher...@suse.com; jbottom...@p
On 09/18/2013 08:41 AM, Alireza Haghdoost wrote:
> Hi
>
> I am working on a high throughput and low latency application which
> does not tolerate block layer overhead to send IO request directly to
> fiber channel lower layer SCSI driver. I used to work with libaio but
> currently I am looking for
On 09/16/2013 05:58 PM, Anand wrote:
> From 3574b24db1a5472df9cef88010fabad7742351e5 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam
> Date: Tue, 3 Sep 2013 16:55:54 +0530
> Subject: [PATCH 4/5] pm80xx: Print SAS address of IO failed device, 4G
> boundary fix.
>
> Added queue rotation log
808, 0, 0, chip_8076 },
> + { PCI_VENDOR_ID_ADAPTEC2, 0x8077,
> + PCI_VENDOR_ID_ADAPTEC2, 0x0808, 0, 0, chip_8077 },
> + { PCI_VENDOR_ID_ADAPTEC2, 0x8074,
> + PCI_VENDOR_ID_ADAPTEC2, 0x0404, 0, 0, chip_8074 },
> {} /* terminate list */
> };
>
> @@ -1108
On 09/16/2013 05:53 PM, Anand wrote:
> From db345f70bef0b07655d887f2d0398faf666f4a48 Mon Sep 17 00:00:00 2001
> From: Anand Kumar Santhanam
> Date: Tue, 3 Sep 2013 15:21:29 +0530
> Subject: [PATCH 2/5] pm80xx: IButton feature support and Indirect SMP fix.
>
> IButton security feature support for
> Getting device busy data for sde 0(tstamp=20130912172055)...
Which give admin more hint about the situation.
Best regards,
Jack
>From cbca8a40fe3837789129e210365488d329d8a440 Mon Sep 17 00:00:00 2001
From: Jack Wang
Date: Thu, 12 Sep 2013 16:57:16 +0200
Subject: [PATCH] export device_b
On 07/31/2013 05:19 PM, Jack Wang wrote:
> On 07/26/2013 06:43 PM, Hans Verkuil wrote:
>> The IO command size is 128 bytes for these new controllers as opposed to 64
>> for the old 8001 controller.
>>
>> The Adaptec out-of-tree driver did this correctly. After comparing
mp;asd_ha->seq.pend_q_lock protection, you need to figure out your self.
PS: the aic94xx is out of maintain for some years as I see. You may need
to update to newer hardware.
Jack
>
>
> 19.08.2013 12:03, Jack Wang пишет:
>> On 08/16/2013 10:26 AM, Evgeny wrote:
>>> He
On 08/16/2013 10:26 AM, Evgeny wrote:
> Hello.
>
> I've been testing vanilla 3.4.45 (config attached), 3.4.56 kernels on
> centos 5.9 with Adaptec AIC-9410W SAS controller:
There's some fix in libsas about error handle , As I remember most of
patch finally merged in 3.7, could you try newer kern
.
>
> So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as
> that is the correct value for both old and new controllers.
>
> Signed-off-by: Hans Verkuil
> Cc: sta...@vger.kernel.org # for v3.10 and up
snip
Thanks Hans.
Looks good now.
Acked-by:
On 07/22/2013 03:43 PM, Douglas Gilbert wrote:
> On 13-07-22 04:26 AM, Hugh Chin wrote:
>> I'm developing SMP application by Python. I've ran it on Linux, it works
>> fine. But now I have to run it on Windows. Of course, it didn't work.
>>
>> So far I know that Windows seems doesn't have bsg driver
Hi Anand,
On 07/15/2013 02:37 PM, Anand Kumar Santhanam wrote:
> Hi Hans,
>
> Pls find responses inline.
>
> Regards
> Anand
>
> -Original Message-
> From: Jack Wang [mailto:xjtu...@gmail.com]
> Sent: Monday, July 15, 2013 2:24 PM
> To: Hans Ve
On 07/14/2013 10:25 AM, Hans Verkuil wrote:
> The IO command size is 128 bytes for these new controllers as opposed to 64
> for the old 8001 controller.
>
> The Adaptec out-of-tree driver did this correctly. After comparing the two
> this turned out to be the crucial difference.
Thanks Hans for th
Hi Hans,
On 07/14/2013 10:45 AM, Hans Verkuil wrote:
> Hi Anand,
>
> On 07/12/2013 03:14 PM, Anand Kumar Santhanam wrote:
>> Hans,
>>
>> I reviewed the code changes and I did not see major differences except
>> for the fact that in adaptec driver we have 64 interrupt handlers to
>> handle 64 MSI-X
On 07/02/2013 10:58 AM, Aaron Lu wrote:
> On 07/02/2013 03:11 PM, Kishore Babu Lukka wrote:
>> Adding Asha also.
>>
>> -Original Message-
>> From: Mahesh Rajashekhara
>> Sent: Monday, July 01, 2013 11:41 AM
>> To: jbottom...@parallels.com; linux-scsi@vger.kernel.org
>> Cc: Tony Ruiz; Achim
On 06/18/2013 10:23 AM, Yijing Wang wrote:
> Pci core has been saved pm cap register offset by pdev->pm_cap in
> pci_pm_init()
> in init path. So we can use pdev->pm_cap instead of using
> pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and
> simplified code.
>
I think Lindar alr
1 - 100 of 125 matches
Mail list logo
