Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

2018-02-12 Thread Jaegeuk Kim
On 02/12, Stanislav Nijnikov wrote: > > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Monday, February 12, 2018 3:08 AM > > To: Stanislav Nijnikov <stanislav.nijni...@wdc.com> > > Cc: linux-scsi@vger.kernel.

Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

2018-02-11 Thread Jaegeuk Kim
On 02/06, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS device descriptor > parameters. The group adds "device_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown > as hexadecimal numbers. The full

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

2018-02-11 Thread Jaegeuk Kim
On 02/06, Stanislav Nijnikov wrote: > This patch introduces attribute group to show existing sysfs entries. > > Signed-off-by: Stanislav Nijnikov > --- > drivers/scsi/ufs/Makefile| 3 +- > drivers/scsi/ufs/ufs-sysfs.c | 156 >

Re: [PATCH v3 1/9] ufs: sysfs: device descriptor

2018-01-02 Thread Jaegeuk Kim
On 01/02, Stanislav Nijnikov wrote: > > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Thursday, December 28, 2017 9:37 PM > > To: Stanislav Nijnikov <stanislav.nijni...@wdc.com> > > Cc: linux-scsi@vger.kernel.

Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

2017-12-28 Thread Jaegeuk Kim
oah-Hartman > > > Sent: Thursday, December 21, 2017 10:00 AM > > > To: Jaegeuk Kim <jaeg...@kernel.org> > > > Cc: linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org; Jaegeuk Kim > > > <jaeg...@google.com> > > > Subject: Re: [PATCH 2/2 v4

Re: [PATCH v3 9/9] ufs: sysfs: attributes

2017-12-28 Thread Jaegeuk Kim
On 12/28, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS attributes. The > group adds "attributes" folder under the UFS driver sysfs entry > (/sys/bus/platform/drivers/ufshcd/*). The attributes are shown > as hexadecimal numbers. The full information about the

Re: [PATCH v3 4/9] ufs: sysfs: health descriptor

2017-12-28 Thread Jaegeuk Kim
imal numbers. The full information about the parameters could be > found at UFS specifications 2.1. > > Signed-off-by: Stanislav Nijnikov <stanislav.nijni...@wdc.com> It needs to remove the above SOB. > > Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org&

Re: [PATCH v3 1/9] ufs: sysfs: device descriptor

2017-12-28 Thread Jaegeuk Kim
On 12/28, Stanislav Nijnikov wrote: > This patch introduces a sysfs group entry for the UFS device descriptor > parameters. The group adds "device_descriptor" folder under the UFS driver > sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown > as hexadecimal numbers. The full

Re: [PATCH 2/2 v4] scsi: ufs: introduce sysfs entries exposing UFS health info

2017-12-20 Thread Jaegeuk Kim
used 08h: 70% ~ 80% device life time used 09h: 80% ~ 90% device life time used 0Ah: 90% ~ 100% device life time used 0Bh: Exceeded its maximum estimated device life time Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Jaegeuk Kim <jaeg...@google.com> --- Cha

Re: [PATCH 1/2 v3] scsi: ufs: introduce static sysfs entries

2017-12-20 Thread Jaegeuk Kim
Hi Bart, On 12/20, Bart Van Assche wrote: > On Wed, 2017-12-20 at 11:16 -0800, Jaegeuk Kim wrote: > > From: Jaegeuk Kim <jaeg...@google.com> > > Hello Jaegeuk, > > For future patch series submissions, please include a cover letter that > explains > the purpo

Re: [PATCH 1/2] scsi: ufs: introduce static sysfs entries

2017-12-20 Thread Jaegeuk Kim
On 12/20, Greg KH wrote: > On Tue, Dec 19, 2017 at 12:02:53PM -0800, Jaegeuk Kim wrote: > > From: Jaegeuk Kim <jaeg...@google.com> > > > > This patch introduces attribute group to show existing sysfs entries. > > > > Cc: Greg KH <gre...@linuxfoundation

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

2017-12-20 Thread Jaegeuk Kim
On 12/20, gre...@linuxfoundation.org wrote: > On Tue, Dec 19, 2017 at 02:46:44PM -0800, Jaegeuk Kim wrote: > > >From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim <jaeg...@google.com> > > Date: Tue, 26 Sep 2017 20:53:48 -0700

[PATCH 2/2 v3] scsi: ufs: introduce sysfs entries exposing UFS health info

2017-12-20 Thread Jaegeuk Kim
From: Jaegeuk Kim <jaeg...@google.com> This patch adds a new sysfs group, namely health, via: /sys/devices/soc/X.ufshc/health/ This directory contains the below entries, each of which shows an 8-bytes hex number representing different meanings defined by JEDEC specfication. Users can

[PATCH 1/2 v3] scsi: ufs: introduce static sysfs entries

2017-12-20 Thread Jaegeuk Kim
From: Jaegeuk Kim <jaeg...@google.com> This patch introduces attribute group to show existing sysfs entries. Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Signed-off-by: Jaegeuk Kim <jaeg...@google.com> --- Change log from v1: - use ATTRIBUTE_GROUPS and sysfs_create_

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

2017-12-19 Thread Jaegeuk Kim
>From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim <jaeg...@google.com> Date: Tue, 26 Sep 2017 20:53:48 -0700 Subject: [PATCH 2/2] scsi: ufs: introduce sysfs entries exposing UFS health info This patch adds a new sysfs group, namely health, via:

Re: [PATCH 2/2 v2] scsi: ufs: use sysfs entry for health info

2017-12-19 Thread Jaegeuk Kim
On 12/19, Bart Van Assche wrote: > On Tue, 2017-12-19 at 12:02 -0800, Jaegeuk Kim wrote: > > This patch introduces sysfs entries to show the information. > > What information does "the information" refer to? > > Regarding the patch title: I think this patch

[PATCH 2/2] scsi: ufs: use sysfs entry for health info

2017-12-19 Thread Jaegeuk Kim
From: Jaegeuk Kim <jaeg...@google.com> This patch introduces sysfs entries to show the information. # cat /sys/devices/soc/1da4000.ufshc/health/eol # cat /sys/devices/soc/1da4000.ufshc/health/length # cat /sys/devices/soc/1da4000.ufshc/health/lifetimeA # cat /sys/devices/soc/1da4000

[PATCH 1/2] scsi: ufs: introduce static sysfs entries

2017-12-19 Thread Jaegeuk Kim
From: Jaegeuk Kim <jaeg...@google.com> This patch introduces attribute group to show existing sysfs entries. Cc: Greg KH <gre...@linuxfoundation.org> Signed-off-by: Jaegeuk Kim <jaeg...@google.com> --- drivers/scsi/ufs/ufshcd.c | 48 +++