Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread James Bottomley
On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: > > On 2016-04-06 10:24 AM, James Bottomley wrote: > > On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: > > > > > > On 2016-04-06 09:38 AM, James Bottomley wrote: > > > > On Wed, 2

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread James Bottomley
On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: > > On 2016-04-06 09:38 AM, James Bottomley wrote: > > On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: > > > > > > On 2016-04-06 03:48 AM, Julian Calaby wrote: > > > > Hi Bastien, &g

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread James Bottomley
On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: > > On 2016-04-06 03:48 AM, Julian Calaby wrote: > > Hi Bastien, > > > > On Wed, Apr 6, 2016 at 7:19 AM, Bastien Philbert > > wrote: > > > This fixes backwards locking in the function __csio_unreg_rnode > > > to > > > properly lock befor

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

2016-04-05 Thread James Bottomley
On Tue, 2016-04-05 at 13:50 -0400, Bastien Bastien Philbert wrote: > On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis > wrote: > > > > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > > > > > This fixes the locking around the call to bnx2fc_alloc_id to > > > comply > > > with the comments about thi

Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api

2016-04-04 Thread James Bottomley
On Sun, 2016-04-03 at 23:07 -0700, Ming Lin wrote: > On Mon, Mar 28, 2016 at 7:48 AM, Ming Lin wrote: > > On Thu, Mar 24, 2016 at 8:46 AM, James Bottomley > > wrote: > > > On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote: > > > > On Wed, Mar 23,

Re: [PATCH v3 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

2016-04-02 Thread James Bottomley
; scsi_target_destroy() indicating this target is going to be removed. > > Signed-off-by: Johannes Thumshirn > Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38 The code and ordering is fine with me, so you can add Reviewed-by: James Bottomley However, I'd really appreciate it if the d

Re: [PATCH 1/5] bnx2fc: Add driver tunables.

2016-04-01 Thread James Bottomley
On Fri, 2016-04-01 at 10:06 -0400, Chad Dupuis wrote: > On Fri, 1 Apr 2016, Johannes Thumshirn wrote: > > > On 2016-04-01 15:10, Chad Dupuis wrote: > > > From: Joe Carnuccio > > > > > > Per customer request, add the following driver tunables: > > > > > > o devloss_tmo > > > o max_luns > > > o q

Re: [PATCH] uas: Add a new NO_REPORT_LUNS quirk

2016-03-31 Thread James Bottomley
On Thu, 2016-03-31 at 17:03 +0200, Hans de Goede wrote: > Hi, > > On 31-03-16 16:48, James Bottomley wrote: > > On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote: > > > Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with > > > an usb-id of:

Re: [PATCH] uas: Add a new NO_REPORT_LUNS quirk

2016-03-31 Thread James Bottomley
On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote: > Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with > an usb-id of: 0bc2:331a, as these will fail to respond to a > REPORT_LUNS command. Actually, if we're sending them a report luns command, they must be reporting in at SCSI-

Re: [RESEND PATCH v2 0/2] Update SCSI target removal path

2016-03-30 Thread James Bottomley
On Wed, 2016-03-30 at 09:09 +0200, Johannes Thumshirn wrote: > [resend with linux-scsi@ in Cc, my apologies] > > This is a follow up to "scsi: Add intermediate STARGET_REMOVE state > to scsi_target_state". > > If anyone has an idea how to create a regression test suite for the > target removal

Re: [PATCH 0/2] scsi: remove orphaned modular code from non-modular drivers

2016-03-27 Thread James Bottomley
On Sun, 2016-03-27 at 13:00 -0400, Paul Gortmaker wrote: > In the ongoing audit/cleanup of non-modular code needlessly using > modular infrastructure, the SCSI subsystem fortunately only contains > two instances that I detected. Both are for legacy drivers that > predate the git epoch, so clear

[GIT PULL] final round of SCSI updates for the 4.5+ merge window

2016-03-26 Thread James Bottomley
The only new stuff which missed the first pull request is an update to the UFS driver. The rest is an assortment of bug fixes and minor tweaks which appeared recently (some are fixes for recent code and some are stuff spotted recently by the checkers or the new gcc-6 compiler [most of Arnd's stuff

Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api

2016-03-24 Thread James Bottomley
On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote: > On Wed, Mar 23, 2016 at 12:40 AM, Christoph Hellwig > wrote: > > On Tue, Mar 22, 2016 at 03:03:11PM -0700, Ming Lin wrote: > > > From: Ming Lin > > > > > > The fist 4 patches make the SG related > > > definitions/structs/functions > > > in SCS

Re: [PATCH] scsi: ufs: select CONFIG_NLS

2016-03-22 Thread James Bottomley
On Thu, 2016-03-17 at 13:29 +0100, Arnd Bergmann wrote: > A recent change to ufshcd introduced a call to utf16s_to_utf8s, > a function that is provided by the NLS module, so we get a link > error when that is not present: > > drivers/scsi/built-in.o: In function `ufshcd_read_string_desc': > :(.tex

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

2016-03-19 Thread James Bottomley
OK, like this? >From 7af7c428e7e04ddcc87fda12d6571e3dff8ae024 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Fri, 18 Mar 2016 15:35:45 -0700 Subject: scsi_transport_fc: introduce lightweight class for virtualization systems The FC transport class is very heavily tilted towards helpin

Re: [PATCH] uas: Limit qdepth at the scsi-host level

2016-03-19 Thread James Bottomley
On Sat, 2016-03-19 at 09:59 +0100, Hans de Goede wrote: > Commit 64d513ac31bd ("scsi: use host wide tags by default") causes > the scsi-core to queue more cmnds then we can handle on devices with > multiple LUNs, limit the qdepth at the scsi-host level instead of > per slave to fix this. Help me u

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

2016-03-19 Thread James Bottomley
On Wed, 2016-03-16 at 23:15 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Wednesday, March 16, 2016 4:08 PM > > To: Martin K. Petersen ; KY Srinivasan > >

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

2016-03-19 Thread James Bottomley
On Wed, 2016-03-16 at 18:34 -0400, Martin K. Petersen wrote: > > > > > > "KY" == KY Srinivasan writes: > > KY> How would I get the sysfs files under fc_host if I don't use the > FC > KY> transport. The customer scripts expect these sysfs files. > > Right, but I was interested in finding out why

[PATCH 2/2] storvsc_drv: make use of the lightweight FC transport class

2016-03-18 Thread James Bottomley
Signed-off-by: James Bottomley --- drivers/scsi/storvsc_drv.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3ddcabb..dcb7393 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-18 Thread James Bottomley
On Wed, 2016-03-16 at 14:05 +, Himanshu Madhani wrote: > > On 3/16/16, 5:59 AM, "Arnd Bergmann" wrote: > > > On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: > > > On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > > > > > &g

Re: [PATCH RFC 0/2] mempool based chained scatterlist alloc/free api api

2016-03-15 Thread James Bottomley
On Tue, 2016-03-15 at 15:39 -0700, Ming Lin wrote: > From: Ming Lin > > Hi list, > > This moves the mempool based chained scatterlist alloc/free code from > scsi_lib.c to lib/scatterlist.c. > > So other drivers(for example, the under development NVMe over fabric > drivers) can also use it. >

[GIT PULL] first round of SCSI updates for the 4.5+ merge window

2016-03-15 Thread James Bottomley
vate link statistics counters. Himanshu Madhani (3): qla2xxx: Update driver version to 8.07.00.33-k qla2xxx: Enable T10-DIF for ISP27XX qla2xxx: Allow fw to hold status before sending ABTS response. James Bottomley (1): MAINTAINERS: use new email address for James Bottomle

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

2016-03-15 Thread James Bottomley
On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: > The qlt_check_reserve_free_req() function produces an incorrect > warning when CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > drivers/scsi/qla2xxx/qla_target.c: In function > 'qlt_check_reserve_free_req': > drivers/scsi/qla2xxx/qla_target.c

Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-15 Thread James Bottomley
On Tue, 2016-03-15 at 14:27 +1100, Finn Thain wrote: > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > > > On 03/14/2016 05:27 AM, Finn Thain wrote: > > > This setting does not need to be conditional on Atari ST or TT. > > > > > > Without TCQ support, cmd_per_lun == 2 is probably reasonable... > >

MAINTAINERS: use new email address for James Bottomley

2016-03-14 Thread James Bottomley
The @odin.com one has been bouncing for a while now, so replace with new Employer email. Signed-off-by: James Bottomley --- diff --git a/MAINTAINERS b/MAINTAINERS index a7c4466..59f12c8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9644,7 +9644,7 @@ F:drivers/scsi/sg.c F: include

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread James Bottomley
On Wed, 2016-03-09 at 22:20 +0100, Helge Deller wrote: > On 09.03.2016 16:15, John David Anglin wrote: > > On 2016-03-09 9:43 AM, Ming Lei wrote: > > > > We've provided all the information you asked for, what's the > > > > next step > > > > > on this, or do we have to unwind the bio splitting code

Re: [BUG] "block: make generic_make_request handle arbitrarily sized bios" breaks boot on parisc-linux

2016-03-09 Thread James Bottomley
On Thu, 2016-02-25 at 11:38 +0800, Ming Lei wrote: > On Thu, Feb 25, 2016 at 7:28 AM, John David Anglin < > dave.ang...@bell.net> wrote: > > On 2016-02-24, at 4:36 PM, Helge Deller wrote: > > > > > Maybe Dave has more luck, otherwise I'll continue to try to get > > > some info. > > > > I tried yo

Re: [PATCH-v2 2/2] target/iblock: Use -EAGAIN/-ENOMEM to propigate SAM BUSY/TASK_SET_FULL

2016-03-07 Thread James Bottomley
On Mon, 2016-03-07 at 00:03 -0800, Nicholas A. Bellinger wrote: > On Mon, 2016-03-07 at 08:55 +0100, Christoph Hellwig wrote: > > On Sun, Mar 06, 2016 at 01:55:15PM -0800, Nicholas A. Bellinger > > So as-is this might be well intended but either useless or broken. > > -- > > No, it useful for ho

[GIT PULL] SCSI fixes for 4.5-rc6

2016-03-04 Thread James Bottomley
Two fairly simple fixes. One is a regression with ipr firmware loading caused by one of the trivial patches in the last merge window which failed to strip the \n from the file name string, so now the firmware loader no longer works leading to a lot of unhappy ipr users; fix by stripping the \n. T

Re: aicasm: fix kbuild for separated build directories

2016-03-02 Thread James Bottomley
On Wed, 2016-03-02 at 17:25 +0100, Michal Marek wrote: > On 2016-03-02 17:17, James Bottomley wrote: > > On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote: > > > On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote: > > > > I've recently been expe

Re: aicasm: fix kbuild for separated build directories

2016-03-02 Thread James Bottomley
On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote: > On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote: > > I've recently been experimenting with building in emulated > > architecture containers which allow me to build natively on my > > laptop a k

Re: small diff in reported GiB size of an SSD

2016-02-29 Thread James Bottomley
ocks: (240 GB/223 > GiB) > > sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/224 > > GiB) > commit 564b026fbd0d28e9f70fb3831293d2922bb7855b Author: James Bottomley Date: Wed Jan 20 14:58:29 2016 -0800 string_helpers: fix precision loss for some inputs James -

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-02-26 Thread James Bottomley
On Fri, 2016-02-26 at 23:22 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, February 26, 2016 2:25 PM > > To: KY Srinivasan ; linux-ke

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-02-26 Thread James Bottomley
On Fri, 2016-02-26 at 15:45 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 > 2796ec3c%7c72f988bf86f

Re: [PATCH] ipr: Fix regression when loading firmware

2016-02-26 Thread James Bottomley
On Fri, 2016-02-26 at 14:52 -0600, Brian King wrote: > On 02/25/2016 10:54 AM, Gabriel Krisman Bertazi wrote: > > Commit d63c7dd5bcb9 ("ipr: Fix out-of-bounds null overwrite") > > removed the > > end of line handling when storing the update_fw sysfs attribute. > > This > > changed the userpace AP

Re: [PATCH 2/2] sd: disable write same for SAT as per the comment

2016-02-26 Thread James Bottomley
On Sat, 2016-02-27 at 04:32 +0800, Tom Yan wrote: > Oh I made a mistake on this one then. > > Since I send it with another patch, should I resend that alone? Yes, that's fine. but you need to explain as part of the changelog why this condition needs inverting because your Subject just says "as pe

Re: [PATCH 2/2] sd: disable write same for SAT as per the comment

2016-02-26 Thread James Bottomley
On Sat, 2016-02-27 at 04:07 +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > Signed-off-by: Tom Yan > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 1179ec1..951 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -2786,7 +2786,7 @@ static void sd_read_write_sa

[GIT PULL] SCSI fixes for 4.5-rc4

2016-02-18 Thread James Bottomley
scsi-fixes The short changelog is: James Bottomley (1): scsi: fix soft lockup in scsi_remove_target() on module removal Todd Fujinaka (1): SCSI: Add Marvell configuration device to VPD blacklist And the diffstat: drivers/scsi/scsi_devinfo.c | 1 + drivers/scsi/scsi_sysfs.c | 6

Re: [PATCH] aic7xxx: Fix queue depth handling

2016-02-15 Thread James Bottomley
On Mon, 2016-02-15 at 18:53 +, Alan wrote: > We were setting the queue depth correctly, then setting it back to > two. If you hit this as a bisection point then please send me an > email as it would imply we've been hiding other bugs with this one. > > Signed-off-by: Alan Cox > --- > drive

aicasm: fix kbuild for separated build directories

2016-02-12 Thread James Bottomley
I've recently been experimenting with building in emulated architecture containers which allow me to build natively on my laptop a kernel for any architecture which qemu will emulate. To do this, I've been building into build/$(uname -m) and this caused the aicasm stuff to fail to build (using CON

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-02-12 Thread James Bottomley
On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > The scsi_transport_iscsi module already uses the ida_simple > routines for managing the target ID, if requested to do > so. This change replaces an ever-increasing atomic integer > that tracks the session ID itself with the ida_simple > family

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread James Bottomley
On Fri, 2016-02-12 at 08:51 -0800, Tyrel Datwyler wrote: > On 02/12/2016 08:43 AM, James Bottomley wrote: > > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: > > > Add defines for mad version and mad os_type, and replace the > > > magic > > > numbe

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread James Bottomley
On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: > Add defines for mad version and mad os_type, and replace the magic > numbers in set_adapter_info() accordingly. > > Signed-off-by: Tyrel Datwyler > --- Is there some reason you didn't carry the review tag over from this: http://mid.gman

[GIT PULL] SCSI fixes for 4.5-rc3

2016-02-11 Thread James Bottomley
A set of seven fixes. Two regressions in the new hisi_sas arm driver, a blacklist entry for the marvell console which was causing a reset cascade without it, a race fix in the WRITE_SAME/DISCARD routines, a retry fix for the rdac driver, without which, it would prematurely return EIO and a couple

[PATCH] scsi: fix soft lockup in scsi_remove_target() on module removal

2016-02-10 Thread James Bottomley
bastian Herbszt Tested-by: Sebastian Herbszt Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38 Cc: sta...@vger.kernel.org Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 4f18a85..00bc721 100644 --- a/drivers/scsi/scsi_sysfs.c +++

Re: [PATCH] Separate target visibility from reaped state information

2016-02-10 Thread James Bottomley
On Wed, 2016-02-10 at 15:05 +0100, Johannes Thumshirn wrote: > On Wed, Feb 03, 2016 at 11:38:16PM +0100, Sebastian Herbszt wrote: > > James Bottomley wrote: > > > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > > > > On 01/19/16 17:03, James Bottomley wr

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-09 Thread James Bottomley
On Tue, 2016-02-09 at 13:50 +0100, Christoph Hellwig wrote: > Jens, > > do you want a 'default y' patch or just a better description? I'd be > happy to send either one. Since it only appears to be SUSE and they've now been told, better description is fine. James -- To unsubscribe from this li

Re: T10 adds locally assigned UUID designation descriptor

2016-02-08 Thread James Bottomley
On Mon, 2016-02-08 at 12:33 -0500, Douglas Gilbert wrote: > Recently, in draft spc5r08, T10 added a locally assigned RFC 4122 > UUID *** designation descriptor. That descriptor can now be > returned for VPD page 0x83 (device identification) amongst others. > It can be used anywhere SCSI needs a uni

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread James Bottomley
On Mon, 2016-02-08 at 08:32 +0100, Hannes Reinecke wrote: > On 02/08/2016 12:07 AM, James Bottomley wrote: > > On Sun, 2016-02-07 at 15:28 -0700, Jens Axboe wrote: > > > On 02/07/2016 09:04 AM, James Bottomley wrote: > > > > On Sun, 2016-02-07 at 10:22

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread James Bottomley
On Sun, 2016-02-07 at 15:28 -0700, Jens Axboe wrote: > On 02/07/2016 09:04 AM, James Bottomley wrote: > > On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: > > > Keith said it should be on by default, and I promised him to > > > change > > > it once

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-07 Thread James Bottomley
On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: > Keith said it should be on by default, and I promised him to change > it once we run into problems, which I guess this counts as. > > But just curious: what distro are you using? Upstream systemd > explicitly rejected using scsi_id fo

complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-06 Thread James Bottomley
The reason is fairly obvious: the default for the new option BLK_DEV_NVME_SCSI is N and all the distribution kernels (and me when testing) take the default options (I checked in the OBS kernel builds and this is true). The net result is that scsi_id from udev no longer works on nvme disks and tha

Re: [PATCH] Separate target visibility from reaped state information

2016-02-03 Thread James Bottomley
On Wed, 2016-02-03 at 23:38 +0100, Sebastian Herbszt wrote: > James Bottomley wrote: > > On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > > > On 01/19/16 17:03, James Bottomley wrote: > > > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote: >

Re: [PATCH] Separate target visibility from reaped state information

2016-02-03 Thread James Bottomley
On Wed, 2016-02-03 at 18:17 +0100, Christoph Hellwig wrote: > On Mon, Feb 01, 2016 at 08:11:29PM -0500, Martin K. Petersen wrote: > > I am concerned about queuing something as a stable fix if it is > > just > > masking a fundamental underlying problem. > > It's not masking a fundamental problem.

Re: [PATCH] Separate target visibility from reaped state information

2016-02-02 Thread James Bottomley
On Tue, 2016-02-02 at 17:17 -0800, Bart Van Assche wrote: > On 02/02/2016 04:43 PM, James Bottomley wrote: > > On Tue, 2016-02-02 at 10:29 -0800, Bart Van Assche wrote: > > > On 02/02/2016 03:46 AM, James Bottomley wrote: > > > > diff --git a/drivers/scsi/scsi_

Re: [PATCH] Separate target visibility from reaped state information

2016-02-02 Thread James Bottomley
On Tue, 2016-02-02 at 10:29 -0800, Bart Van Assche wrote: > On 02/02/2016 03:46 AM, James Bottomley wrote: > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > > index 4f18a85..00bc721 100644 > > --- a/drivers/scsi/scsi_sysfs.c > > +++

Re: [PATCH] Separate target visibility from reaped state information

2016-02-02 Thread James Bottomley
On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > On 01/19/16 17:03, James Bottomley wrote: > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote: > > > > > > > > "Bart" == Bart Van Assche > > > > > > > > wri

Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread James Bottomley
On Mon, 2016-02-01 at 15:42 +0530, Jitendra Bhivare wrote: > mcc_cq_lock spin_lock is used only in beiscsi_process_mcc which is > called > only when all interrupts are disabled from mgmt_epfw_cleanup during > unloading of driver. There is no other context where there can be > contention for the pro

Re: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-01-29 Thread James Bottomley
erence to > > > `fc_release_transport' > > With this commit, the storvsc driver depends on FC atttributes. Make > this > dependency explicit. > > Signed-off-by: K. Y. Srinivasan > Reported-by: Fengguang Wu > --- > V2: Fixed the dependency based on

[GIT PULL] SCSI fixes for 4.5-rc1

2016-01-29 Thread James Bottomley
Four fixes: one to try to fix our repeated intermittent crashes in suspend/resume, one to correct a regression in the optimal I/O size reporting and a couple for randconfig build failures in the hisi_sas driver. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-01-28 Thread James Bottomley
On Thu, 2016-01-28 at 19:07 +, KY Srinivasan wrote: > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Thursday, January 28, 2016 7:56 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.

Re: [Lsf-pc] [LSF/MM TOPIC] LIO/SCST Merger

2016-01-28 Thread James Bottomley
On Thu, 2016-01-28 at 18:24 +0200, Sagi Grimberg wrote: > > I'm going to downvote this topic just like last year with my PC hat > > on as I think it's a) not relevant or usefully discussable at LSF > > and b) framed the wrong way. > > I'm not sure LSF is the right platform, but I gotta say that

Re: [PATCH] storvsc: use small sg_tablesize on x86

2016-01-28 Thread James Bottomley
On Thu, 2016-01-28 at 07:48 +0100, Olaf Hering wrote: > On Wed, Jan 27, James Bottomley wrote: > > > It's not really architecture independent, is it? Just use the bit > > width config. > > Again: which one? This driver is not for mips|powerpc|score|sh. zgrep

Re: [Lsf-pc] [LSF/MM TOPIC] NVMe target support

2016-01-28 Thread James Bottomley
On Thu, 2016-01-28 at 07:16 -0800, Bart Van Assche wrote: > On 01/27/16 20:41, Nicholas A. Bellinger wrote: > > [ ... ] > > The folks for such a discussion would include: > > > > Christoph Hellwig, Hannes Reinecke, Dave Minturn, Sagi > > Grimberg, > > Ming Lin, Roland Dreier and Mike Chris

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 23:29 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 > 2796ec3c%7c72f988bf86f

Re: [PATCH] storvsc: use small sg_tablesize on x86

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 23:09 +, KY Srinivasan wrote: > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Monday, January 25, 2016 12:35 AM > > To: James Bottomley > > Cc: KY Srinivasan ; Haiyang Zhang > > ; lin

Re: [Bug 111381] mvsas 0.8.16 on Marvell 88SE9485 reports timeouts on load

2016-01-27 Thread James Bottomley
On Thu, 2016-01-28 at 00:37 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=111381 > > --- Comment #2 from Gabriel A. Devenyi --- > After a check and reseat of all cables, now getting this in dmesg: > [ 4386.920825] sd 3:0:4:0: [sdn] tag#0 FAILED Re

Re: [Bug 111381] New: mvsas 0.8.16 on Marvell 88SE9485 reports timeouts on load

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 21:56 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=111381 > > Bug ID: 111381 >Summary: mvsas 0.8.16 on Marvell 88SE9485 reports timeouts > on > load >Product: SCSI Drive

Re: [Lsf-pc] [LSF/MM TOPIC] LIO/SCST Merger

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 10:19 -0800, Bart Van Assche wrote: > On 01/27/2016 10:08 AM, James Bottomley wrote: > > On Wed, 2016-01-27 at 09:54 -0800, Bart Van Assche wrote: > > > Last year, during the 2015 LSF/MM summit, it has been decided > > > that > > > the LI

Re: [Lsf-pc] [LSF/MM TOPIC] LIO/SCST Merger

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 09:54 -0800, Bart Van Assche wrote: > Last year, during the 2015 LSF/MM summit, it has been decided that > the LIO/SCST merger project should proceed by sending the > functionality upstream that is present in SCST but not yet in LIO. > This will help to reduce the workload

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-27 Thread James Bottomley
On Wed, 2016-01-27 at 17:14 +0100, Tomas Henzl wrote: > On 27.1.2016 06:44, Sathya Prakash wrote: > > There is no fusion based network card and resources exists today in > > Avago(LSI) to test this patch so we prefer to leave it as is. We > > would > > like to prevent any new changes on MPT (FC/SCS

[GIT PULL] final round of SCSI updates for the 4.4+ merge window

2016-01-22 Thread James Bottomley
This is mostly stuff which missed the first pull request because it needed to incubate longer. It's mainly made up of the ncr 5380 rework but also has a few assorted bug fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The short changelog

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread James Bottomley
On Wed, 2016-01-20 at 11:40 -0500, Martin K. Petersen wrote: > > > > > > "James" == James Bottomley < > > > > > > james.bottom...@hansenpartnership.com> writes: > > James> We should mark the commit causing the problems, which went &

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread James Bottomley
On Wed, 2016-01-20 at 11:01 -0500, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes > to > block layer sectors. > > Signed-off-by: Martin K. Petersen > Reported-by: Christian Bornt

Re: [PATCH v2, RESEND] Separate target visibility from reaped state information

2016-01-06 Thread James Bottomley
On Wed, 2016-01-06 at 09:24 +0100, Bart Van Assche wrote: > Instead of representing the states "visible in sysfs" and > "has been removed from the target list" by a single state > variable, use two variables to represent this information. > > This patch avoids that SCSI device removal can trigger

Re: [LKP] [lkp] [ses] 3417c1b5cb: WARNING: CPU: 2 PID: 2013 at fs/xfs/xfs_file.c:772 xfs_file_dio_aio_write+0x2a2/0x320()

2015-12-28 Thread James Bottomley
On Mon, 2015-12-28 at 16:04 +0800, Huang, Ying wrote: > James Bottomley writes: > > > [cc to linux-scsi added] > > On Mon, 2015-12-28 at 09:43 +0800, kernel test robot wrote: > > > FYI, we noticed the below changes on > > > > > > https://git.kernel.o

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

2015-12-28 Thread James Bottomley
On Sun, 2015-12-27 at 21:30 +0100, Wilfried Weissmann wrote: > Am 27.12.15 um 20:42 schrieb James Bottomley: > > On Sun, 2015-12-27 at 20:21 +0100, Wilfried Weissmann wrote: > > > add SGPIO support to Marvell 94xx > > > > How do you actually use this? It doesn

Re: [lkp] [ses] 3417c1b5cb: WARNING: CPU: 2 PID: 2013 at fs/xfs/xfs_file.c:772 xfs_file_dio_aio_write+0x2a2/0x320()

2015-12-27 Thread James Bottomley
[cc to linux-scsi added] On Mon, 2015-12-28 at 09:43 +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ma > ster > commit 3417c1b5cb1fdc10261dbed42b05cc93166a78fd ("ses: Fix problems > with simple enclosure

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

2015-12-27 Thread James Bottomley
On Sun, 2015-12-27 at 20:21 +0100, Wilfried Weissmann wrote: > add SGPIO support to Marvell 94xx How do you actually use this? It doesn't seem to be plumbed into the standard GPIO subsystem and there appears to be no user accessible interface for it either (nor is it used internally). There does

Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

2015-12-22 Thread James Bottomley
On Wed, 2015-12-23 at 11:56 +1100, Finn Thain wrote: > On Tue, 22 Dec 2015, Joe Perches wrote: > > > On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote: > > > This patch is just the result of two substitutions. The first > removes > > > any tabs and spaces at the end of the line. The second repl

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-21 Thread James Bottomley
On Sat, 2015-12-19 at 02:28 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, December 18, 2015 8:48 AM > > To: KY Srinivasan ; Hannes Rein

[GIT PULL] SCSI fixes for 4.4-rc5

2015-12-18 Thread James Bottomley
/scsi.git scsi-fixes The short changelog is: James Bottomley (2): ses: fix additional element traversal bug ses: Fix problems with simple enclosures Ken Xue (1): Revert "SCSI: Fix NULL pointer dereference in runtime PM" With the diffstat: drivers/scsi/scsi_pm

Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-18 Thread James Bottomley
On Fri, 2015-12-18 at 09:49 +0100, Hannes Reinecke wrote: > What I would like to see is a clear separation here: > - Disable FC disk handling if FC attributes are not configured > - Add a module parameter allowing to disable FC attributes even if > they are compiled in. Remember: this is a virtual

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-18 Thread James Bottomley
On Fri, 2015-12-18 at 16:20 +, KY Srinivasan wrote: > > > -Original Message- > > From: Hannes Reinecke [mailto:h...@suse.de] > > Sent: Friday, December 18, 2015 12:52 AM > > To: KY Srinivasan ; gre...@linuxfoundation.org; > > linux- > > ker...@vger.kernel.org; de...@linuxdriverproject.

[PATCH] ses: fix additional element traversal bug

2015-12-11 Thread James Bottomley
...@vger.kernel.org Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index 1736935..53ef1cb 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -561,7 +561,15 @@ static void ses_enclosure_data_process(struct enclosure_device *edev

Re: [Bug 108771] scsi: ses: kasan: ses_enclosure_data_process use after free on boot SAS2X28

2015-12-09 Thread James Bottomley
On Wed, 2015-12-09 at 15:35 +0300, Pavel Tikhomirov wrote: > > On 12/08/2015 07:16 PM, James Bottomley wrote: > > On Mon, 2015-12-07 at 14:01 +, bugzilla-dae...@bugzilla.kernel.org > > wrote: > >> https://bugzilla.kernel.org/show_bug.cgi?id=108771 > >

[PATCH v2 3/3] ses: fix discovery of SATA devices in SAS enclosures

2015-12-09 Thread James Bottomley
never matches. Instead of doing this, for SAS attached devices, match by the direct endpoint address instead. Signed-off-by: James Bottomley diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 5f692ae..2a1d20e 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -194,6 +

Re: [PATCH 3/3] ses: fix discovery of SATA devices in SAS enclosures

2015-12-09 Thread James Bottomley
On Thu, 2015-12-10 at 04:38 +0800, kbuild test robot wrote: > Hi James, > > [auto build test ERROR on v4.4-rc4] > [cannot apply to scsi/for-next next-20151209] > > url: > https://github.com/0day-ci/linux/commits/James-Bottomley/Fix-the-problem-of-SATA-devices-within-SA

[PATCH 3/3] ses: fix discovery of SATA devices in SAS enclosures

2015-12-09 Thread James Bottomley
never matches. Instead of doing this, for SAS attached devices, match by the direct endpoint address instead. Signed-off-by: James Bottomley --- drivers/scsi/ses.c | 22 -- 1 files changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/ses.c b/drivers/scsi/

[PATCH 2/3] scsi_transport_sas: add function to get SAS endpoint address

2015-12-09 Thread James Bottomley
For a device known to be SAS connected, this will return the endpoint address. This is useful for getting the SAS address of SATA devices. Signed-off-by: James Bottomley --- drivers/scsi/scsi_transport_sas.c | 14 ++ include/scsi/scsi_transport_sas.h |1 + 2 files changed, 15

[PATCH 1/3] scsi_transport_sas: add is_sas_attached() function

2015-12-09 Thread James Bottomley
(sdev)) { ... } which would be compiled out (and thus eliminate the symbols) if SAS is not configured. Signed-off-by: James Bottomley --- drivers/scsi/scsi_transport_sas.c | 16 include/scsi/scsi_transport_sas.h |9 + 2 files changed, 25 insertions(+), 0

[PATCH 0/3] Fix the problem of SATA devices within SAS enclosures

2015-12-09 Thread James Bottomley
with SAS. If anyone ever gets around to doing FC enclosures, they should probably be done in the same way. James --- James Bottomley (3): scsi_transport_sas: add is_sas_attached() function scsi_transport_sas: add function to get SAS endpoint address ses: fix discovery of SATA devices in SAS

Re: [PATCH] ses: Fix problems with simple enclosures

2015-12-09 Thread James Bottomley
On Wed, 2015-12-09 at 18:07 +0100, Tomas Henzl wrote: > On 8.12.2015 18:00, James Bottomley wrote: > > Simple enclosure implementations (mostly USB) are allowed to return only > > page 8 to every diagnostic query. That really confuses our > > implementation because we ass

[PATCH] ses: Fix problems with simple enclosures

2015-12-08 Thread James Bottomley
starting to see more USB enclosures. Reported-by: Andrea Gelmini Cc: sta...@vger.kernel.org Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index dcb0d76..7d9cec5 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -84,6 +84,7

Re: [Bug 108771] scsi: ses: kasan: ses_enclosure_data_process use after free on boot SAS2X28

2015-12-08 Thread James Bottomley
On Mon, 2015-12-07 at 14:01 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=108771 > > --- Comment #1 from Pavel Tikhomirov --- > Aditional info about enclosue(from that node, but older 3.10 based kernel): > > [root@p9 crash]# modprobe sg > [root@p

[GIT PULL] SCSI fixes for 4.4-rc3

2015-12-05 Thread James Bottomley
ev_release() qla2xxx: Fix rwlock recursion Dan Carpenter (2): hpsa: logical vs bitwise AND typo mvsas: don't allow negative timeouts Douglas Gilbert (1): scsi_debug: fix prevent_allow+verify regressions James Bottomley (1): mpt3sas: fix Kconfig dependency problem f

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

2015-12-04 Thread James Bottomley
On Fri, 2015-12-04 at 23:58 +, Verma, Vishal L wrote: > On Fri, 2015-12-04 at 15:30 -0800, James Bottomley wrote: > [...] > > > + * We return > > > + * 0 if there are no known bad blocks in the range > > > + * 1 if there are known bad block which are all a

Re: [PATCH v2 2/3] block: Add badblock management for gendisks

2015-12-04 Thread James Bottomley
On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > NVDIMM devices, which can behave more like DRAM rather than block > devices, may develop bad cache lines, or 'poison'. A block device > exposed by the pmem driver can then consume poison via a read (or > write), and cause a machine check. On

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

2015-12-04 Thread James Bottomley
On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > Take the core badblocks implementation from md, and make it generally > available. This follows the same style as kernel implementations of > linked lists, rb-trees etc, where you can have a structure that can be > embedded anywhere, and acce

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

2015-12-04 Thread James Bottomley
On Fri, 2015-12-04 at 11:58 -0500, Ewan Milne wrote: > On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > > sg_map -i > > > > > > in your system, you should see something with an

<    1   2   3   4   5   6   7   8   9   10   >