Re: [Patch] scsi_error: should not get sense for timeout IO in scsi error handler

2015-08-26 Thread James Bottomley
On Fri, 2015-07-31 at 17:52 +0800, jiang.bi...@zte.com.cn wrote: > scsi_error: should not get sense for timeout IO in scsi error handler > > When an IO timeout occurs, the IO will be aborted in > scsi_abort_command() and SCSI_EH_ABORT_SCHEDULED will be set. Because > of that, the SCSI_EH_CANCEL_CM

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-08-26 Thread James Bottomley
On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote: > > > > + /* this should never happen */ > > > + if (WARN_ON(!cmnd)) > > > + return SCSI_MLQUEUE_HOST_BUSY; > > > > > > - if (NULL == cmnd || NULL == devip) { > > > - pr_warn("called with NULL cmnd or devip pointer\n"); > > >

Re: IO failures with SMR drives at latest kernel versions

2015-08-26 Thread James Bottomley
On Wed, 2015-08-26 at 08:40 +0200, Hannes Reinecke wrote: > On 08/26/2015 06:53 AM, Anatol Pomozov wrote: > > Hi > > > > On Sun, Aug 23, 2015 at 11:15 PM, Hannes Reinecke wrote: > >>> I looked at this commit and it actually adds SMR support to SCSI > >>> layer. Reverting ATA_DEV_ZAC means going b

Re: [PATCH v3 10/10] qla2xxx: Avoid that sparse complains about context imbalances

2015-08-26 Thread James Bottomley
On Thu, 2015-07-09 at 07:25 -0700, Bart Van Assche wrote: > Surround conditional locking statements with "#ifndef __CHECKER__" / > "#endif" to hide these for the sparse static source code analysis > tool. Thanks! I know I whine alot about checkpatch but having drivers sparse clean like this one n

Re: [PATCH v3 05/10] qla2xxx: Remove __constant_ prefix

2015-08-26 Thread James Bottomley
On Thu, 2015-07-09 at 07:24 -0700, Bart Van Assche wrote: > Whether htonl() or __constant_htonl() is used, if the argument > is a constant the conversion happens at compile time. Hence leave > out the __constant_ prefix for this and other endianness > conversion functions. This improves source code

Re: [PATCH v3 3/3] megaraid_sas : fix whitespace errors

2015-08-26 Thread James Bottomley
On Tue, 2015-07-07 at 15:52 -0500, Bjorn Helgaas wrote: > Fix whitespace and indentation errors. No code change. checkpatch says you missed one: ERROR: space required after that ',' (ctx:VxV) #860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457: + if (sscanf(buf,"%u",&megasas_dbg_lvl

Re: [PATCH] aic94xx: Skip reading user settings if flash is not found

2015-08-26 Thread James Bottomley
On Mon, 2015-07-06 at 13:07 +0200, Hannes Reinecke wrote: > If no user settings are found it's pointless trying to > read them from flash. So skip that step. > This also fixes a compilation warning about uninitialized variables in > aic94xx. > > Signed-off-by: Hannes Reinecke This patch looks fi

Re: [PATCH 1/3] hpsa: convert show method snprintf usage to scnprintf

2015-08-26 Thread James Bottomley
On Wed, 2015-07-01 at 03:45 +, Seymour, Shane M wrote: > Changed all show method snprintf usage to scnprintf per > Documentation/filesystems/sysfs.txt. > > Signed-off-by: Shane Seymour There's been no ack on this one. However, there's no actual reason to prefer scnprintf over snprintf: the

[GIT PULL] SCSI fixes for 4.2-rc7

2015-08-23 Thread James Bottomley
A couple of major (hang and deadlock) fixes with fortunately fairly rare triggering conditions. The PM oops is only really triggered by people using enclosure services (rare) and the fnic driver is mostly used in enterprise environments. The patch is available here: git://git.kernel.org/pub/scm/

Re: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-08-17 Thread James Bottomley
On Mon, 2015-08-17 at 14:12 +, Mahesh Rajashekhara wrote: > Hi James, > > Please let me know the status of V6 patchset. Well, you altered it fairly significantly with the combination, so I need the original reviewers at least to glance over it and say their reviews stand. If you kept the rev

[GIT PULL] SCSI fixes for 4.2-rc6

2015-08-14 Thread James Bottomley
This patch consists of 2 libfc fixes causing rare crashes, one iscsi one causing a potential hang on shutdown, an I/O blocksize issue which caused a regression and a memory leak in scsi-mq. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The sh

Re: [PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

2015-08-13 Thread James Bottomley
On Thu, 2015-08-13 at 17:07 -0700, K. Y. Srinivasan wrote: > From: Dexuan Cui > > This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: Which tree is this in? upstream linus is giving me bad object on that id. > Drivers: hv: vmbus: Further improve CPU affiliation logic > > W

Re: [PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-08-12 Thread James Bottomley
On Fri, 2015-07-10 at 14:18 +0800, linux wrote: > Hi, > >We found that the updated hptiop driver (version v1.10.0) was not embedded > into kernel 4.2 RC1, is there something wrong with the submitted patch or > when would the patch be accepted? > >If there is any question, please do no

Re: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-08-12 Thread James Bottomley
> On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > > From: Rajinikanth Pandurangan > > > > Description: > > In MSIx mode, we need at least 2 vectors. > > > > Changes from V4: > > Newly created for V5 based on review comment. > > > > Signed-off-by: Rajinikanth Pandura

Re: [PATCH] libiscsi: Fix host busy blocking during connection teardown

2015-08-12 Thread James Bottomley
On Wed, 2015-08-12 at 10:10 -0700, Chris Leech wrote: > Bump. > > We've done some testing, and this does prevent a deadlock that can be > triggered with a session logout while other sessions on the same HBA > are under high IO load. I'd be nice to see this merged. so now it needs a tag for stabl

Re: [Patch] scsi_ioctl: support persistent reserve commands for non-root user.

2015-08-03 Thread James Bottomley
On Tue, 2015-08-04 at 09:11 +0800, jiang.bi...@zte.com.cn wrote: > scsi_ioctl: support persistent reserve commands through ioctl for > non-root user. > > Scsi persistent reserve commands need to be used for non-root user in > many scenarios. > EPERM error will be returned by sg_io() when PERSISTEN

Re: [PATCH 1/6] libata: Do not retry commands with valid autosense

2015-08-03 Thread James Bottomley
On Mon, 2015-08-03 at 11:55 -0400, Tejun Heo wrote: > Hello, James. > > On Mon, Aug 03, 2015 at 08:42:43AM -0700, James Bottomley wrote: > > I'd think it would be the same reason as all modern transports: it's > > faster and allows processing of sense data in-band.

Re: [PATCH 1/6] libata: Do not retry commands with valid autosense

2015-08-03 Thread James Bottomley
On Mon, 2015-08-03 at 11:18 -0400, Tejun Heo wrote: > Adding a bit. > > On Mon, Aug 03, 2015 at 11:04:28AM -0400, Tejun Heo wrote: > > Ugh... so this is from NCQ autosense thing. Now ATA devices reports > > sense data too which trumps AC_ERR_DEV so libata EH decides to retry > > even when the dev

Re: [PATCH 0/6] ZAC host-aware device support

2015-08-03 Thread James Bottomley
On Mon, 2015-08-03 at 09:24 +0200, Hannes Reinecke wrote: > On 08/02/2015 06:11 PM, James Bottomley wrote: > > On Fri, 2015-07-31 at 15:02 +0200, Hannes Reinecke wrote: > >> Hi all, > >> > >> here is a patchset for adding ZAC host-aware device support to libata.

[GIT PULL] SCSI fixes for 4.2-rc4

2015-08-02 Thread James Bottomley
A set of three fixes for the ipr driver and one fairly major one for memory leaks in the mq path of SCSI. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Brian King (3): ipr: Fix invalid array indexing for HRRQ

Re: [PATCH 0/6] ZAC host-aware device support

2015-08-02 Thread James Bottomley
On Fri, 2015-07-31 at 15:02 +0200, Hannes Reinecke wrote: > Hi all, > > here is a patchset for adding ZAC host-aware device support to libata. > Main bits are translations for ZBC IN and ZBC OUT; others are the > required plumbing like generating the correct VPD pages. > James, do you require a se

Re: [PATCH][SCSI] hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer

2015-07-30 Thread James Bottomley
On Wed, 2015-06-24 at 11:41 +0800, linux wrote: > Support HighPoint RR36xx HBAs which are based on Marvell Frey. > Support SAS tape and SAS media changer. > > Signed-off-by: HighPoint Linux Team > > drivers/scsi/hptiop.c | 104 > +++ >

Re: kernel BUG at drivers/scsi/scsi_lib.c:1101! observed during md5sum for one file on (RAID4->RAID0) device

2015-07-30 Thread James Bottomley
On Thu, 2015-07-30 at 05:03 -0400, Yi Zhang wrote: > Hi SCSI/RAID maintainer > > During raid test with 4.2.0-rc3, I observed below kernel BUG, pls check below > info for the test log/environment/test steps. > > Log: > [ 306.741662] md: bind > [ 306.750865] md: bind > [ 306.753993] md: bind >

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 10:55 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley > wrote: > > On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > >> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > >> wrote: > >> > On We

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > wrote: > > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > >> I don't have a libsas environment handy, I worked with Praveen to > >> validate t

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: > On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley > wrote: > > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > >> On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley > >> wrote: > >

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-27 Thread James Bottomley
On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: > On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley > wrote: > > > >> } > >> > >> void sas_device_set_phy(struct domain_device *dev, struct sas_port *port) > >> diff --git a/drivers/sc

Re: [PATCH 0/9] qla2xxx: Patches for scsi "misc" branch.

2015-07-24 Thread James Bottomley
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote: > Hi Himanshu & Co, > > (Adding target-devel CC') > > On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote: > > Hi James, > > > > Please apply the following patches to the scsi tree at your earliest > > convenience for inclusio

Re: [for 4.1 PATCH resend] libsas: fix "sysfs group not found" warnings at port teardown time

2015-07-22 Thread James Bottomley
On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote: > Praveen reports: > > After some debugging this is what I have found > > sas_phye_loss_of_signal gets triggered on phy_event from mvsas > sas_phye_loss_of_signal calls sas_deform_port > sas_deform_port posts a DI

[GIT PULL] SCSI fixes for 4.2-rc2

2015-07-19 Thread James Bottomley
Two fairly simple fixes: one is a change that causes us to have a very low queue depth leading to performance issues and the other is a null deref occasionally in tapes thanks to use after put. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes Th

Re: [PATCH] dm-mpath: always return reservation conflict

2015-07-15 Thread James Bottomley
On Wed, 2015-07-15 at 13:52 +0200, Hannes Reinecke wrote: > On 07/15/2015 01:35 PM, James Bottomley wrote: > > On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote: > >> If dm-mpath encounters an reservation conflict it should not > >> fail the path (as communica

Re: [PATCH] dm-mpath: always return reservation conflict

2015-07-15 Thread James Bottomley
On Wed, 2015-07-15 at 13:23 +0200, Hannes Reinecke wrote: > If dm-mpath encounters an reservation conflict it should not > fail the path (as communication with the target is not affected) > but should rather retry on another path. > However, in doing so we might be inducing a ping-pong between > pa

Re: [PATCH 09/11] qla2xxx: Added interface to send ELS commands from driver.

2015-07-07 Thread James Bottomley
On Fri, 2015-07-03 at 09:14 -0700, Christoph Hellwig wrote: > Why is this a binary attribute? Needs an interface specific in > Documentation/ABI/ to start with, and a Ccto stable seems very > aggressive. Right, adding an interface isn't a bug fix. Can you separate this into patches which are ess

Re: [PATCHv2] sd: retry READ CAPACITY for ALUA state transition

2015-07-06 Thread James Bottomley
On Mon, 2015-07-06 at 08:13 -0700, Bart Van Assche wrote: > On 07/06/2015 04:12 AM, Hannes Reinecke wrote: > > During ALUA state transitions the device might return > > a sense code 02/04/0a (Logical unit not accessible, asymmetric > > access state transition). As this is a transient error > > we s

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-26 Thread James Bottomley
On Fri, 2015-06-26 at 11:43 +0200, Stefan Richter wrote: > On Jun 22 James Bottomley wrote: > > On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > Obviously, for a disk with a writeback cache that can'

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:59 -0500, Timothy Pearson wrote: > On 06/23/2015 12:56 PM, James Bottomley wrote: > > On Tue, 2015-06-23 at 12:47 -0500, Timothy Pearson wrote: > >> On 06/23/2015 12:45 PM, James Bottomley wrote: > >>> On Tue, 2015-06-23 at 12:33 -0500, Timot

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:47 -0500, Timothy Pearson wrote: > On 06/23/2015 12:45 PM, James Bottomley wrote: > > On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: > >> On 06/23/2015 08:35 AM, James Bottomley wrote: > >>> On Tue, 2015-06-23 at 18:06 +0530, Sr

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 12:33 -0500, Timothy Pearson wrote: > On 06/23/2015 08:35 AM, James Bottomley wrote: > > On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: > >> Hi, > >> > >> Upstream contributor should not add copyright to this driver code.

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

2015-06-23 Thread James Bottomley
On Tue, 2015-06-23 at 18:06 +0530, Sreekanth Reddy wrote: > Hi, > > Upstream contributor should not add copyright to this driver code. I can't agree with that as a general rule: it depends on the significance of the contribution. The somewhat ill defined standard for this is the contribution mus

[GIT PULL v2] SCSI updates for the 4.1+ merge window

2015-06-22 Thread James Bottomley
arrier buffer advansys: use DMA-API for mapping sense buffer advansys: use shared host tag map for command lookup advansys: use host_reset James Bottomley (2): ips: remove pointless #warning scsi_scan: fix queue depth initialisation problem James Smart (24):

Re: [GIT PULL] SCSI updates for the 4.0+ merge window

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 14:31 -0700, James Bottomley wrote: > This is the usual grab bag of driver updates (lpfc, hpsa, megaraid_sas, > cxgbi, be2iscsi) plus an assortment of minor updates. There are also > two new drivers: the Cisco snic and the IBM cxlflash; the advansys > dri

[GIT PULL] SCSI updates for the 4.0+ merge window

2015-06-22 Thread James Bottomley
advansys: use 'bool' instead of 'int' advansys: Use dma_pool for sg elements advansys: Use DMA-API for mapping request blocks advansys: Use DMA-API for carrier buffer advansys: use DMA-API for mapping sense buffer advansys: use shared host tag

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 13:48 -0400, Alan Stern wrote: > On Mon, 22 Jun 2015, James Bottomley wrote: > > > On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > > > On Mon, 22 Jun 2015, James Bottomley wrote: > > > > > > > I'm not sure I entir

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote: > On Mon, 22 Jun 2015, James Bottomley wrote: > > > I'm not sure I entirely like this: we are back again treating data > > corruption problems silently. > > > > However, I also believe treating a

Re: [PATCH] USB: storage: add "no SYNCHRONIZE CACHE" quirk

2015-06-22 Thread James Bottomley
On Mon, 2015-06-22 at 10:55 -0400, Alan Stern wrote: > Some USB mass-storage devices claim to have a write-back cache but > don't support the SYNCHRONIZE CACHE command, which means there is no > way to tell these devices to flush their caches out to permanent > storage. Unfortunately, there is not

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread James Bottomley
On Wed, 2015-06-17 at 14:21 +, Dov Levenglick wrote: > Hi James, > Rob raises a point that we don't agree with. On the other hand, we are not > capable of convincing him in the validity of our approach - we are at an > impasse. > I would like to point out that our approach was reviewed by Paul

Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-15 Thread James Bottomley
On Mon, 2015-06-15 at 16:26 +0530, Sreekanth Reddy wrote: > On Sat, Jun 13, 2015 at 2:33 AM, Joe Lawrence > wrote: > > On 06/12/2015 05:42 AM, Sreekanth Reddy wrote: > > ... > >> +#if defined(alloc_ordered_workqueue) > >> + ioc->firmware_event_thread = alloc_ordered_workqueue( > >> +

Re: [PATCH v7 8/9] snic:Add event tracing to capture IO events.

2015-06-13 Thread James Bottomley
On Fri, 2015-05-29 at 01:04 -0700, Narsimhulu Musini wrote: > +#define SNIC_TRC(_hno, _tag, d1, d2, d3, d4, d5) \ > + do {\ > + if (unlikely(snic_log_level & 0x2)) \ > + SNIC_DBG("SnicTrace: %s %2u %2u %llx %llx

Re: [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data

2015-06-13 Thread James Bottomley
On Fri, 2015-05-29 at 01:04 -0700, Narsimhulu Musini wrote: > +static const struct file_operations snic_stats_fops __read_mostly = { > + .owner = THIS_MODULE, > + .open = snic_stats_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > +}; C

Re: [PATCH v6] cxlflash: Base support for IBM CXL Flash Adapter

2015-06-13 Thread James Bottomley
On Tue, 2015-06-09 at 17:15 -0500, Matthew R. Ochs wrote: > SCSI device driver to support filesystem access on the IBM CXL Flash adapter. > > Supported-by: Stephen Bates > Reviewed-by: Michael Neuling > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > --- > drivers/scsi/Kconfi

Re: [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-06-11 Thread James Bottomley
On Thu, 2015-06-11 at 08:32 -0400, Josh Boyer wrote: > On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar wrote: > > The driver is missing calls to pci_dma_mapping_error() after > > performing the DMA mapping, which caused DMA-API warning to > > show up in dmesg's output. Though that happens only when

Re: [PATCH] scsi: Avoid potential infinite eh_timeout_handler() loop

2015-06-04 Thread James Bottomley
On Thu, 2015-06-04 at 11:40 -0700, Rajat Jain wrote: > Each cmd timeout should result in scmd->retries++. Currently it happens > just only before a command is requeued back. However, if the LLD > eh_timed_out() handler asks to reset timer back again, then also it should > be incremented because eff

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread James Bottomley
On Wed, 2015-06-03 at 15:12 -0700, Nicholas A. Bellinger wrote: > On Wed, 2015-06-03 at 13:00 -0700, James Bottomley wrote: > > On Wed, 2015-06-03 at 18:16 +1000, Stephen Rothwell wrote: > > > Hi Nicholas, > > > > > > After merging the target-updates tr

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread James Bottomley
On Wed, 2015-06-03 at 18:16 +1000, Stephen Rothwell wrote: > Hi Nicholas, > > After merging the target-updates tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/target/target_core_fabric_lib.c: In function > 'target_get_pr_transport_id_len': > drivers/target/ta

Re: Patch "sd: Disable support for 256 byte/sector disks" has been added to the 4.0-stable tree

2015-06-03 Thread James Bottomley
On Wed, 2015-06-03 at 13:37 +, James Bottomley wrote: > On Wed, 2015-06-03 at 11:29 +0200, Jiri Slaby wrote: > > On 06/03/2015, 08:35 AM, gre...@linuxfoundation.org wrote: > > > From 74856fbf441929918c49ff262ace9835048e4e6a Mon Sep 17 00:00:00 2001 > > > From: Mark

Re: Patch "sd: Disable support for 256 byte/sector disks" has been added to the 4.0-stable tree

2015-06-03 Thread James Bottomley
gt; > So disable support for it. > > > > Signed-off-by: Mark Hounschell > > Signed-off-by: Hannes Reinecke > > Signed-off-by: James Bottomley > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/scsi/sd.c | 19 +-- > &

Re: [PATCH 2/9] [SCSI] aacraid: Add Power Management support

2015-06-01 Thread James Bottomley
On Mon, 2015-06-01 at 21:16 +, Rajinikanth Pandurangan wrote: > -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, June 01, 2015 8:15 AM > To: Rajinikanth Pandurangan > Cc: linux-scsi@vger.kernel.org; aacr...@pmc-si

Re: [PATCH v9] st: implement tape statistics

2015-06-01 Thread James Bottomley
On Mon, 2015-06-01 at 06:43 +, Seymour, Shane M wrote: > +#if (BITS_PER_LONG == 64) > +#define PRId64 "ld" > +#else > +#define PRId64 "lld" > +#endif I know this is the windows recommended way to do this, but lets not pollute the kernel with it because the kernel accepts %lld everywhere for 64

Re: [PATCH 2/9] [SCSI] aacraid: Add Power Management support

2015-06-01 Thread James Bottomley
On Wed, 2015-05-13 at 17:12 -0700, rajinikanth.panduran...@pmcs.com wrote: > diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c > index 9eec027..be30e43 100644 > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -1317,6 +1317,149 @@ static int aac_pr

Re: [PATCH 2/3] megaraid_sas: use dev_printk when possible

2015-05-31 Thread James Bottomley
On Tue, 2015-04-28 at 18:14 -0500, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages more useful. I got the first one, but this one needs refreshing. 2&3 have the same commit message, so they should be one patch, I think. Thanks, James -- To unsubscribe from this list: se

Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-05-28 Thread James Bottomley
In general, patch is much better: it passes all the static checker tests for byte width and endianness issues. However On Wed, 2015-05-27 at 00:19 -0700, Narsimhulu Musini wrote: > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 9c92f41..8baab3f 100644 > --- a/drivers/scsi/Kconfi

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread James Bottomley
On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote: > From: Eric Dumazet > Date: Tue, 26 May 2015 21:43:44 -0700 > > > From: Eric Dumazet > > > > vmalloc.h used to be included from include/net/inet_hashtables.h > > but it is no longer the case. > > > > Fixes: 095dc8e0c368 ("tcp: fix/cleanup

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-26 Thread James Bottomley
On Tue, 2015-05-26 at 09:30 -0400, James Smart wrote: > Sebastian, > > Re: more than 1 space between a type declaration and a variable name - I > do not believe that's a hard requirement. It fully passes checkpatch. > Yes, consistent style use (aligning all variable names at same offset, > or a

Re: [PATCH] be2iscsi change of ownership from Emulex to Avago Technologies recently. We like to get the following updates in: changed "Emulex" to "Avago Technologies", changed email addresses fro

2015-05-25 Thread James Bottomley
On Thu, 2015-05-14 at 23:16 -0700, Minh Tran wrote: > Signed-off-by: Minh Tran > Signed-off-by: Jayamohan Kallickal > --- > MAINTAINERS | 6 -- > drivers/scsi/be2iscsi/be.h | 6 +++--- > drivers/scsi/be2iscsi/be_cmds.c | 6 +++--- > drivers/scsi/be2iscsi/be_cmd

[GIT PULL] SCSI fixes for 4.1-rc4

2015-05-23 Thread James Bottomley
This is a set of five fixes: Two MAINTAINER email updates (urgent because the non-avagotech emails will start bouncing) an lpfc big endian oops fix, a 256 byte sector hang fix (to eliminate 256 byte sectors) and a storvsc fix which could cause test unit ready failures on bringup. The patch is ava

Re: [PATCH] [RESEND] SCSI: ips: remove pointless #warning

2015-05-19 Thread James Bottomley
On Tue, 2015-05-19 at 15:56 +0200, Arnd Bergmann wrote: > On Tuesday 19 May 2015 06:52:52 James Bottomley wrote: > > On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: > > > The ips driver contains > > > > > > #warning "This driver ha

Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread James Bottomley
On Wed, 2015-05-13 at 15:31 +0200, Arnd Bergmann wrote: > On Wednesday 13 May 2015 08:23:41 Brian King wrote: > > On 05/13/2015 03:10 AM, Arnd Bergmann wrote: > > > On Tuesday 12 May 2015 18:24:43 Brian King wrote: > > >> > > >> Commit 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c broke 64 bit DMA for

Re: [PATCH] scatterlist: enable sg chaining for all architectures

2015-04-28 Thread James Bottomley
On Wed, 2015-04-29 at 09:34 +0900, Akinobu Mita wrote: > 2015-04-29 7:16 GMT+09:00 James Bottomley > : > > On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote: > >> On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita > >> wrote: > >> > >> >

Re: [PATCH] scatterlist: enable sg chaining for all architectures

2015-04-28 Thread James Bottomley
On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote: > On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita > wrote: > > > Some architectures enable sg chaining option while others do not. > > > > The requirement to enable sg chaining is that pages must be aligned > > at a 32-bit boundary in orde

[PATCH] scsi_scan: fix queue depth initialisation problem

2015-04-28 Thread James Bottomley
From: James Bottomley Date: Sun, 26 Apr 2015 11:52:46 -0700 Subject: [PATCH] scsi_scan: fix queue depth initialisation problem Currently we blindly use the value of cmd_per_lun as the initial setting for queue_depth. This fails miserably (hangs the system) if it is zero, which is the default

Re: [PATCH] sd: always retry READ CAPACITY for ALUA state transition

2015-04-28 Thread James Bottomley
On Mon, 2015-04-27 at 11:35 +0200, Hannes Reinecke wrote: > During ALUA state transitions the device might return > a sense code 02/04/0a (Logical unit not accessible, asymmetric > access state transition). As this is a transient error > we should just retry the READ CAPACITY call until > the state

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-28 Thread James Bottomley
On Mon, 2015-04-27 at 09:02 +0200, Hannes Reinecke wrote: > On 04/26/2015 08:52 PM, James Bottomley wrote: > > On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: > >> On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: > >>> Ancient, and pretty much obsolete

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread James Bottomley
On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: > On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: > > Ancient, and pretty much obsolete by now. > > > > Signed-off-by: Hannes Reinecke > > --- > > drivers/scsi/advansys.c | 18 -- > > 1 file changed, 18 deletions(-) > >

Re: [PATCH 1/3] block: Return error in rescan_partitions if revalidating disk failed

2015-04-21 Thread James Bottomley
On Tue, 2015-03-24 at 18:16 +0800, Fam Zheng wrote: > If the disk can't read capacity, we should return an error. I'm not sure I buy this: you need to justify why. For instance removable media return an error in revalidate that causes the medium not present flag to be set ... do we really want to

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-20 Thread James Bottomley
On Fri, 2015-04-17 at 16:40 -0600, Jens Axboe wrote: > On 04/17/2015 04:20 PM, James Bottomley wrote: > > On Fri, 2015-04-17 at 16:07 -0600, Jens Axboe wrote: > >> On 04/17/2015 03:57 PM, James Bottomley wrote: > >>> On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wro

Re: [PATCH RESEND 13/18] megaraid_sas : add endianess conversions for all ones

2015-04-20 Thread James Bottomley
On Mon, 2015-04-20 at 18:04 +0530, sumit.sax...@avagotech.com wrote: > Add noop conversions for all ones to make sparse happy. > > Signed-off-by: Christoph Hellwig This isn't the right way to resend someone else's patch: it needs a From: Christoph Hellwig At the top and a signed off by you a

[GIT PULL] SCSI fixes for the 4.0+ merge window

2015-04-19 Thread James Bottomley
ect MSI-X queues and that now triggers a WARN_ON(). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The Short Changelog is Christoph Hellwig (1): megaraid_sas: use raw_smp_processor_id() Hannes Reinecke (1): am53c974: Fix crash du

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 16:07 -0600, Jens Axboe wrote: > On 04/17/2015 03:57 PM, James Bottomley wrote: > > On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: > >> On 04/17/2015 03:46 PM, James Bottomley wrote: > >>> On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wro

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 15:47 -0600, Jens Axboe wrote: > On 04/17/2015 03:46 PM, James Bottomley wrote: > > On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: > >> On 04/17/2015 03:42 PM, James Bottomley wrote: > >>>> @@ -662,32 +662,14 @@ void scsi_fin

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 15:44 -0600, Jens Axboe wrote: > On 04/17/2015 03:42 PM, James Bottomley wrote: > >> @@ -662,32 +662,14 @@ void scsi_finish_command(struct scsi_cmnd *cmd) > >>*/ > >> int scsi_change_queue_depth(struct scsi_device *sdev, int depth) > &

Re: [PATCH, RFC] scsi: use host wide tags by default

2015-04-17 Thread James Bottomley
On Fri, 2015-04-17 at 22:11 +0200, Christoph Hellwig wrote: > diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c > index 82abfce..941a424 100644 > --- a/drivers/scsi/53c700.c > +++ b/drivers/scsi/53c700.c > @@ -325,7 +325,6 @@ NCR_700_detect(struct scsi_host_template *tpnt, > tpnt->sl

[GIT PULL] SCSI updates for the 4.0+ merge window

2015-04-16 Thread James Bottomley
ings reported by static checker. James Bottomley (2): change SCSI Maintainer email sd, mmc, virtio_blk, string_helpers: fix block size units James Smart (21): lpfc: Update version to 10.5.0.0 for upstream patch set lpfc: Update copyright to 2015 lpfc: Fix for lun disc

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-16 Thread James Bottomley
On Thu, 2015-04-16 at 10:26 -0700, Adam Talbot wrote: > Wow, I forgot how long it takes to compile a full kernel. Glad I ran > Gentoo for a few years and knew how to compile and apply patches. I > will admit I had to dust off some mental cobwebs. > > Pre-patched 4.0.0 kernel tree: Oops, as expect

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-15 Thread James Bottomley
On Tue, 2015-04-14 at 14:41 -0700, Adam Talbot wrote: > Removing the sas expander and attaching the SATA drives directly works > just fine. I had to limp along with the drives direct attached for a > while, while debugging. Well, that narrows it down. It looks like there's a longstanding bug in m

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-14 Thread James Bottomley
On Tue, 2015-04-14 at 14:03 -0700, Adam Talbot wrote: > To make a very long debugging story short, I think there is an issues/bug > with the mvsas driver. It works, with older kernels, and breaks on > newer kernels. > > My Debian Jessie system was running great on a 3.18 kernel. Changed > cases t

Re: Has anyone seen this?

2015-04-14 Thread James Bottomley
On Tue, 2015-04-14 at 19:52 +0300, Sagi Grimberg wrote: > When I set up a DIX enabled device for the first time (say > scsi_debug) it all works, but when I remove it > and set it up again I get the below crash: > > Reproducer: > $modprobe scsi_debug dif=1 dix=1 > $modprobe -r scsi_debug > $modprob

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 10:06 -0400, Joe Lawrence wrote: > On 04/12/2015 08:54 PM, James Bottomley wrote: > > On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: > >> On 12/30/2014 09:07 AM, Joe Lawrence wrote: > >>> A colleague noticed that the mpt2 and mp

Re: [scsi:misc 14/106] drivers/scsi/storvsc_drv.c:1658 storvsc_queuecommand() warn: curly braces intended?

2015-04-13 Thread James Bottomley
On Mon, 2015-04-13 at 14:56 +0300, Dan Carpenter wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc > head: 0351b8f81392c6d036e5c8f73ceff68726e9 > commit: be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 [14/106] scsi: storvsc: Set > the tablesize based on the informat

Re: [PATCH 0/2] mpt2sas,mpt3sas - PCI master abort fixups

2015-04-12 Thread James Bottomley
On Sun, 2015-04-12 at 20:11 -0400, Joe Lawrence wrote: > On 12/30/2014 09:07 AM, Joe Lawrence wrote: > > A colleague noticed that the mpt2 and mpt3sas drivers do not correctly > > check the PCI master abort pattern in _base_wait_for_doorbell_ack. This > > pattern should be checked *prior* to any v

[GIT PULL] SCSI fixes for 4.0-rc7

2015-04-10 Thread James Bottomley
-fixes The short changelog is: Bart Van Assche (1): Defer processing of REQ_PREEMPT requests for blocked devices James Bottomley (1): enclosure: fix WARN_ON removing an adapter in multi-path devices John Soni Jose (1): be2iscsi: Fix kernel panic when device initialization fails

Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver

2015-04-09 Thread James Bottomley
On Thu, 2015-03-26 at 11:23 -0500, Brian King wrote: > From: Wen Xiong > > This patch implements raw mode support for AF DASD in ipr driver > which allows for tools to send commands directly to physical > devices which are members of RAID arrays when enabled in the firmware. > > Signed-off-by: W

Re: smp_processor_id warning in megasas driver on 3.19.3

2015-04-08 Thread James Bottomley
On Wed, 2015-04-08 at 11:26 -0700, Andy Lutomirski wrote: > On Wed, Apr 8, 2015 at 11:17 AM, James Bottomley > wrote: > > On Wed, 2015-04-08 at 10:59 -0700, Andy Lutomirski wrote: > >> This is a regression somewhere between 3.15 and 3.19.3. Let me know > >> if mor

Re: smp_processor_id warning in megasas driver on 3.19.3

2015-04-08 Thread James Bottomley
On Wed, 2015-04-08 at 10:59 -0700, Andy Lutomirski wrote: > This is a regression somewhere between 3.15 and 3.19.3. Let me know > if more diagnostics would be helpful. It's not a regression. Likely someone turned on additional warnings. So the problem is that the warning is incorrect: the use of

Re: [PATCH V2 0/7] scsi: storvsc: Miscellaneous enhancements and fixes

2015-04-08 Thread James Bottomley
On Fri, 2015-03-27 at 00:26 -0700, K. Y. Srinivasan wrote: > This patch-set addresses perf issues discovered on the Azure storage stack. > These patches also fix a couple of bugs. > > As in the first version of this patch-set, some of the patches are simply a > resend. > I have bumped up the vers

Re: [PATCHv2] libsas: Fixup transport protocol definition in sas_get_ata_info()

2015-04-07 Thread James Bottomley
On Tue, 2015-04-07 at 17:45 +0200, Christoph Hellwig wrote: > On Tue, Apr 07, 2015 at 10:49:07AM +0200, Hannes Reinecke wrote: > > 'tproto' specifies the transport protocol, not the device type. > > So use the correct definitions here. > > > > Signed-off-by: Hannes Reinecke > > This looks correc

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-04-01 Thread James Bottomley
On Thu, 2015-04-02 at 16:39 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: > > > Ben, this is legal by design. It was specifically designed for the > > aic79xx SCSI card, but can be used for a variety of other reasons. The &g

[PATCH] change SCSI Maintainer email

2015-04-01 Thread James Bottomley
We've recently suffered a rebranding and the Service Provider half of Parallels has become Odin. This means my email has changed so update the MAINTAINERS file (and tidy up the pointers to our git trees to be correct). Signed-off-by: James Bottomley --- diff --git a/MAINTAINERS b/MAINTA

Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci_ids.h directly

2015-03-29 Thread James Bottomley
On Sun, 2015-03-29 at 16:36 +0200, Michael S. Tsirkin wrote: > On Sun, Mar 29, 2015 at 05:03:36PM +0300, James Bottomley wrote: > > On Sun, 2015-03-29 at 15:42 +0200, Michael S. Tsirkin wrote: > > > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > > > use th

Re: [PATCH 61/86] scsi/qla1280: use uapi/linux/pci_ids.h directly

2015-03-29 Thread James Bottomley
On Sun, 2015-03-29 at 15:42 +0200, Michael S. Tsirkin wrote: > Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, > use the new header directly so we can drop > the wrapper in include/linux/pci_ids.h. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/scsi/qla1280.c | 2 +- > 1 file c

Re: [PATCH v7 2/3] scsi: ufs: add debugfs for ufs

2015-03-27 Thread James Bottomley
On Thu, 2015-03-12 at 17:54 +0200, Gilad Broner wrote: > From: Lee Susman > > Adding debugfs capability for ufshcd. This patch fails to build as a module because you aren't building corectly: ERROR: "ufsdbg_add_debugfs" [drivers/scsi/ufs/ufshcd.ko] undefined! ERROR: "ufsdbg_remove_debugfs" [dri

<    3   4   5   6   7   8   9   10   11   12   >