Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

>>> On 29.11.16 at 12:19, <jgr...@suse.com> wrote: > On 29/11/16 12:14, Jan Beulich wrote: >>>>> On 29.11.16 at 11:50, <jgr...@suse.com> wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

>>> On 29.11.16 at 11:50, wrote: > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct > vscsifrnt_info *info) > > ring_req = RING_GET_REQUEST(&(info->ring),

[PATCH] xen-scsiback: prefer xenbus_write() over xenbus_printf() where possible

... as being the simpler variant. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-prefer-xenbus_write/drivers/xen/xen-scsi

[PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

Only a positive return value indicates success. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- drivers/scsi/xen-scsifront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xen-scsifront.c +++ 4.7-rc6-xenbus_scanf/drivers/sc

[PATCH] xen-scsiback: correct return value checks on xenbus_scanf()

Only a positive return value indicates success. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsi

Re: [Xen-devel] [PATCH V3 1/4] Add XEN pvSCSI protocol description

On 04.08.14 at 10:27, jgr...@suse.com wrote: +/* Requests from the frontend to the backend */ + +/* + * Request a SCSI operation specified via a CDB in vscsiif_request.cmnd. + * The target is specified via channel, id and lun. + */ +#define VSCSIIF_ACT_SCSI_CDB 1 + +/* + *

Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

On 30.06.14 at 13:18, jgr...@suse.com wrote: On 06/30/2014 01:02 PM, Jan Beulich wrote: On 27.06.14 at 19:11, konrad.w...@oracle.com wrote: On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: +/* + * Maximum scatter/gather segments per request. + * + * Considering balance

[PATCH] fix buffer leak after scsi: saner replacements for -proc_info()

That patch failed to set proc_scsi_fops' .release method. Signed-off-by: Jan Beulich jbeul...@suse.com --- drivers/scsi/scsi_proc.c |1 + 1 file changed, 1 insertion(+) --- 3.10-rc3/drivers/scsi/scsi_proc.c +++ 3.10-rc3-scsi-proc-leak/drivers/scsi/scsi_proc.c @@ -84,6 +84,7 @@ static int