Re: [PATCH 1/6] virtio: wrap find_vqs

On 2017年03月30日 22:32, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off

Re: [PATCH 1/6] virtio: wrap find_vqs

On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by: Michael S. Tsirkin --- A quick glance and it looks ok, but what the benefit of this series,

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

. Tsirkin <m...@redhat.com> --- It seems that there should be a better way to do it, but this works too. Reviewed-by: Jason Wang <jasow...@redhat.com> drivers/block/Makefile | 1 + drivers/char/Makefile | 1 + drivers/char/hw_random/Makefile | 2 ++ drivers/gp

Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

On 12/17/2013 11:09 AM, Rusty Russell wrote: Jason Wang jasow...@redhat.com writes: On 10/28/2013 04:01 PM, Asias He wrote: vqs are freed in virtscsi_freeze but the hotcpu_notifier is not unregistered. We will have a use-after-free usage when the notifier callback is called after

[PATCH V2] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

affinity when doing cpu hotplug) Cc: sta...@vger.kernel.org Signed-off-by: Asias He asias.he...@gmail.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com --- Changes from V1: - Add Fixes line - CC stable --- drivers/scsi/virtio_scsi.c | 15 ++- 1

Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

On 10/28/2013 04:01 PM, Asias He wrote: vqs are freed in virtscsi_freeze but the hotcpu_notifier is not unregistered. We will have a use-after-free usage when the notifier callback is called after virtscsi_freeze. Signed-off-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 15

Re: [PATCH] virtio-scsi: Fix hotcpu_notifier use-after-free with virtscsi_freeze

; + + err = register_hotcpu_notifier(vscsi-nb); + if (err) + vdev-config-del_vqs(vdev); - return virtscsi_init(vdev, vscsi); + return err; } #endif Acked-by: Jason Wang jasow...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH 1/5] virtio-ring: move queue_index to vring_virtqueue

On 08/28/2012 07:54 PM, Paolo Bonzini wrote: From: Jason Wangjasow...@redhat.com Instead of storing the queue index in transport-specific virtio structs, this patch moves them to vring_virtqueue and introduces an helper to get the value. This lets drivers simplify their management and tracing

mpt2sas: disk name is out of order with expander

Here is our configuration OS: ubuntu 10.4( kernel 2.6.32) HBA: H200 driver: mpt2sas We'd like to map the disk name with enclosure slot. That is to say, we would like to sda - slot 0, sdb - slto 1, sdc- slot 2 ...; With the ubuntu included mpt2sas driver, the disk name is out of order. We use