Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread Konrad Rzeszutek Wilk
On Tue, Apr 18, 2017 at 09:42:20AM -0600, Logan Gunthorpe wrote: > > > On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote: > > Interesting that you didn't CC any of the maintainers. Could you > > do that in the future please? > > Please read the cover lette

Re: [PATCH 17/25] blk-mq: remove the error argument to blk_mq_complete_request

2017-04-18 Thread Konrad Rzeszutek Wilk
error argument to > > blk_mq_complete_request. > > > > Signed-off-by: Christoph Hellwig > > For blkfront: > > Acked-by: Roger Pau Monné > And also Reviewed-by: Konrad Rzeszutek Wilk

Re: [PATCH 16/25] xen-blkfront: don't use req->errors

2017-04-18 Thread Konrad Rzeszutek Wilk
n the driver > > should be moving more of the completion processing into .complete, but > > this is the minimal change to move forward for now. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Roger Pau Monné > Reviewed-by: Konrad Rzeszutek Wilk Thanks!

Re: kill req->errors

2017-04-18 Thread Konrad Rzeszutek Wilk
On Fri, Apr 07, 2017 at 09:11:24AM +0200, Christoph Hellwig wrote: > On Thu, Apr 06, 2017 at 04:00:24PM -0400, Konrad Rzeszutek Wilk wrote: > > You wouldn't have a git tree to easily test it? Thanks. > > git://git.infradead.org/users/hch/block.git request-errors &g

Re: [PATCH 16/22] xen-blkfront: Make use of the new sg_map helper function

2017-04-18 Thread Konrad Rzeszutek Wilk
On Tue, Apr 18, 2017 at 02:13:59PM +, David Laight wrote: > From: Logan Gunthorpe > > Sent: 13 April 2017 23:05 > > Straightforward conversion to the new helper, except due to > > the lack of error path, we have to warn if unmapable memory > > is ever present in the sgl. Interesting that you d

Re: kill req->errors

2017-04-06 Thread Konrad Rzeszutek Wilk
On Thu, Apr 06, 2017 at 05:39:19PM +0200, Christoph Hellwig wrote: > Currently the request structure has an errors field that is used in > various different ways. The oldest drivers use it as an error count, > blk-mq and the generic timeout code assume that it holds a Linux > errno for block compl

Re: [PATCH] ibft: Expose iBFT acpi header via sysfs

2016-04-01 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 09:49:26PM -0400, David Bond wrote: > > Some ethernet adapter vendors are supplying products which support optional > (payed license) features. On some adapters this includes a hardware iscsi > initiator. The same adapters in a normal (no extra licenses) mode of > operatio

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

2016-02-29 Thread Konrad Rzeszutek Wilk
On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote: > On 02/25/2016 12:15 PM, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The iBFT table only specifies a prefix length, not a netmask. >> And the netmask is pretty much pointless for IPv6. >> So introduce a new attribute 'prefix-len' and dis

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-29 Thread Konrad Rzeszutek Wilk
On Mon, Sep 29, 2014 at 03:17:10PM +0100, David Vrabel wrote: > On 29/09/14 15:02, Konrad Rzeszutek Wilk wrote: > > On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: > >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > > > > Only

Re: [Xen-devel] [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-29 Thread Konrad Rzeszutek Wilk
On Fri, Sep 26, 2014 at 07:07:19PM +0100, David Vrabel wrote: > On 26/09/14 17:36, Chen Gang wrote: > > When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > > internally, so need not return any status value, then use 'void' instead > > of 'int' for xenbus_switch_state() and __xenb

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-29 Thread Konrad Rzeszutek Wilk
On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: > When xenbus_switch_state() fails, it will call xenbus_switch_fatal() Only on the first depth, not on the subsequent ones (as in if the first xenbus_switch_fail fails, it won't try to call xenbus_switch_state again and again). > internal

Re: [Xen-devel] [PATCH V5 0/5] Add XEN pvSCSI support

2014-08-22 Thread Konrad Rzeszutek Wilk
On Fri, Aug 22, 2014 at 02:21:55PM -0700, Nicholas A. Bellinger wrote: > Hi Juergen & Co, > > On Mon, 2014-08-18 at 11:31 +0200, jgr...@suse.com wrote: > > This series adds XEN pvSCSI support. With pvSCSI it is possible to use > > physical > > SCSI devices from a XEN domain. > > > > The support

Re: [Xen-devel] [PATCH V5 3/5] Introduce xen-scsifront module

2014-08-22 Thread Konrad Rzeszutek Wilk
> --- /dev/null > +++ b/drivers/scsi/xen-scsifront.c > @@ -0,0 +1,1017 @@ > +/* > + * Xen SCSI frontend driver > + * > + * Copyright (c) 2008, FUJITSU Limited > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-21 Thread Konrad Rzeszutek Wilk
On Wed, Aug 20, 2014 at 04:01:57PM +0200, Juergen Gross wrote: > On 08/20/2014 03:25 PM, Konrad Rzeszutek Wilk wrote: > >On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: > >>From: Juergen Gross > >> > >>Add the definition of pvSCSI protocol u

Re: How to get the number of VFs assigned to the guests in XEN

2014-08-20 Thread Konrad Rzeszutek Wilk
On Wed, Aug 20, 2014 at 04:33:29PM +0530, Sreekanth Reddy wrote: > HI, > > > > For SRIOV support, currently in the KVM environment, mpt3sas driver can use > the API pci_vfs_assigned() to know the number of VFs that are currently > assigned to the running VMs. So that during the PF driver unload

Re: [Xen-devel] [PATCH V5 1/5] xen/events: support threaded irqs for interdomain event channels

2014-08-20 Thread Konrad Rzeszutek Wilk
gt; /* error */ > ret = request_threaded_irq(...); > > Signed-off-by: Juergen Gross > Acked-by: David Vrabel Acked-by: Konrad Rzeszutek Wilk > --- > drivers/xen/events/events_base.c | 5 +++-- > include/xen/events.h | 2 ++ > 2 files changed, 5 inse

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: > From: Juergen Gross > > Add the definition of pvSCSI protocol used between the pvSCSI frontend in a > XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). > > This header was originally provided by Fujitsu for X

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-20 Thread Konrad Rzeszutek Wilk
On Mon, Aug 18, 2014 at 11:31:50AM +0200, jgr...@suse.com wrote: > From: Juergen Gross > > Add myself as maintainer for the Xen pvSCSI stuff. > > Signed-off-by: Juergen Gross Acked-by: Konrad Rzeszutek Wilk > --- > MAINTAINERS | 8 > 1 file changed, 8 inser

Re: [PATCH V2 0/4] Add XEN pvSCSI support

2014-07-25 Thread Konrad Rzeszutek Wilk
On Fri, Jul 25, 2014 at 01:37:29PM +0200, jgr...@suse.com wrote: > This series adds XEN pvSCSI support. With pvSCSI it is possible to use > physical > SCSI devices from a XEN domain. > > The support consists of a backend in the privileged Domain-0 doing the real > I/O and a frontend in the unpriv

Re: [Xen-devel] [PATCH 4/4] add xen pvscsi maintainer

2014-06-27 Thread Konrad Rzeszutek Wilk
On Fri, Jun 27, 2014 at 04:34:36PM +0200, jgr...@suse.com wrote: > From: Juergen Gross > > Add myself as maintainer for the Xen pvSCSI stuff. Woot! Acked-by: Konrad Rzeszutek Wilk > > Signed-off-by: Juergen Gross > --- > MAINTAINERS | 7 +++ > 1 file changed, 7

Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

2014-06-27 Thread Konrad Rzeszutek Wilk
On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: > From: Juergen Gross > > Add the definition of pvSCSI protocol used between the pvSCSI frontend in a > XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). > > This header was originally provided by Fujitsu for X

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-13 Thread Konrad Rzeszutek Wilk
On Wed, May 07, 2014 at 02:01:48PM -0500, Mike Christie wrote: > On 05/07/2014 04:00 AM, vikas.chaudh...@qlogic.com wrote: > > From: Vikas Chaudhary > > > > Broadcom iscsi offload firmware uses a non standard ibft sign of "BIFT". > > This patch modifies the ibft search code to search for "BIFT" a

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-09 Thread Konrad Rzeszutek Wilk
:49:59PM -0500, Mike Christie wrote: > >>>> On 05/07/2014 02:21 PM, Konrad Rzeszutek Wilk wrote: > >>>>> On Wed, May 07, 2014 at 07:12:31PM +, James Bottomley wrote: > >>>>>> On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wi

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-07 Thread Konrad Rzeszutek Wilk
On Wed, May 07, 2014 at 07:12:31PM +, James Bottomley wrote: > On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, May 07, 2014 at 05:00:20AM -0400, vikas.chaudh...@qlogic.com wrote: > > > From: Vikas Chaudhary > > > > > > Broadc

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-07 Thread Konrad Rzeszutek Wilk
On Wed, May 07, 2014 at 05:00:20AM -0400, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > Broadcom iscsi offload firmware uses a non standard ibft sign of "BIFT". Why? If it uses the standard iBFT format why does it use a non-standard signature? > This patch modifies the ibft sear

Re: "swiotlb buffer is full" with 3.13-rc1+ but not 3.4.

2013-12-03 Thread Konrad Rzeszutek Wilk
On Sat, Nov 30, 2013 at 03:48:44PM -0500, James Bottomley wrote: > On Sat, 2013-11-30 at 13:56 -0500, Konrad Rzeszutek Wilk wrote: > > My theory is that the SWIOTLB is not full - it is just that the request > > is for a compound page that is more than 512kB. Please note that >