[PATCH v5 1/2] ibmvscsi: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v5 2/2] ibmvscsi: set max_lun to 32

As defined in 4.6.9 of SAM-4, the encoding of LUN is on 5 bits (max_lun=32) and the current value is only 8. Set max_lun to IBMVSCSI_MAX_LUN (32). Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +- drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + 2 files changed, 2 insertions

[PATCH v5 0/2] ibmvscsi parameter cleanup

i/ibmvscsi/ibmvscsi.c:2298:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64 {aka long long unsigned int}' [-Wformat=] "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n", Laurent Vivier (2): ibmvscsi: display

Re: [PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

On 09/11/2015 16:07, James Bottomley wrote: > On Mon, 2015-11-09 at 15:47 +0100, Laurent Vivier wrote: >> The value of the parameter is never re-read by the driver, >> so a new value is ignored. Let know the user he >> can't modify it by removing writable attribut

Re: [PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

On 09/11/2015 15:50, Hannes Reinecke wrote: > On 11/09/2015 03:47 PM, Laurent Vivier wrote: >> This patch allows to define the maximum LUN numbers. >> As defined in 4.6.9 of SAM-4, the encoding of LUN is >> on 5 bits (max_lun=32) and the current value is only 8. >>

[PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH v4 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

This patch allows to define the maximum LUN numbers. As defined in 4.6.9 of SAM-4, the encoding of LUN is on 5 bits (max_lun=32) and the current value is only 8. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + 2 files

[PATCH v4 0/3] ibmvscsi parameter cleanup

4 has type 'u64 {aka long long unsigned int}' [-Wformat=] "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n", Laurent Vivier (3): ibmvscsi: make parameters max_id and max_channel read-only ibmvscsi: display default value for max_id, max_lun and max_channel.

Re: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

On 09/11/2015 15:04, Hannes Reinecke wrote: > On 11/09/2015 02:53 PM, Laurent Vivier wrote: >> QEMU allows until 32 LUNs. >> >> Signed-off-by: Laurent Vivier >> --- >> drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - >> drivers/scsi/ibmvscsi/ibmvscsi.h

[PATCH v3 1/3] ibmvscsi: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH v3 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 04de287

[PATCH v3 0/3] ibmvscsi parameter cleanup

"Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n", Laurent Vivier (3): ibmvscsi: make parameters max_id and max_channel read-only ibmvscsi: display default value for max_id, max_lun and max_channel. ibmvscsi: Allow to configure maximum LUN drivers/scsi/ibmvscsi/ibmvsc

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

On 05/11/2015 00:06, Brian King wrote: > On 11/04/2015 07:02 AM, Hannes Reinecke wrote: >> On 11/04/2015 12:46 PM, Laurent Vivier wrote: >>> >>> >>> On 04/11/2015 12:16, Hannes Reinecke wrote: >>>> On 11/04/2015 11:20 AM, Laurent Vivier wrote: >

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

On 04/11/2015 12:16, Hannes Reinecke wrote: > On 11/04/2015 11:20 AM, Laurent Vivier wrote: >> QEMU allows until 32 LUNs. >> >> Signed-off-by: Laurent Vivier >> --- >> drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - >> 1 file changed, 4 insertions(+), 1 dele

Re: [PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

On 04/11/2015 11:20, Laurent Vivier wrote: > QEMU allows until 32 LUNs. > > Signed-off-by: Laurent Vivier I forget the: Reviewed-by: Brian King Acked-by: Tyrel Datwyler > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v2 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier Reviewed-by: Brian King Acked-by: Tyrel Datwyler --- v2: fix format of max_lun (u64): use %llu drivers/scsi/ibm

[PATCH v2 1/3] ibmvscsi: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier Reviewed-by: Brian King Acked-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1

[PATCH v2 3/3] ibmvscsi: Allow to configure maximum LUN

QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 04de287..4480d3e 100644 --- a/drivers/scsi/ibmvscsi

[PATCH v2 0/3] ibmvscsi parameter cleanup

ximum LUN: %d Maximum Channel: %d\n", ^ Laurent Vivier (3): ibmvscsi: make parameters max_id and max_channel read-only ibmvscsi: display default value for max_id, max_lun and max_channel. ibmvscsi: Allow to configure maximum LUN drivers/scsi/ibmvscsi/ibmvscsi.c | 17 - 1 fil

[PATCH 1/3] ibmvscsi: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier Reviewed-by: Brian King Acked-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1

[PATCH 3/3] ibmvscsi: Allow to configure maximum LUN

QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier Reviewed-by: Brian King Acked-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index

[PATCH 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier Reviewed-by: Brian King Acked-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file chang

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

Ping ? On 13/10/2015 23:23, Laurent Vivier wrote: > James, > > this series has been reviewed and ack'ed, > as SCSI maintainer, could you take it ? > > Laurent > > On 10/09/2015 11:23, Laurent Vivier wrote: >> The value of the parameter is never re-read

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

James, this series has been reviewed and ack'ed, as SCSI maintainer, could you take it ? Laurent On 10/09/2015 11:23, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it b

Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN

Ping ? On 10/09/2015 11:23, Laurent Vivier wrote: > QEMU allows until 32 LUNs. > > Signed-off-by: Laurent Vivier > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c &

Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.

Ping ? On 10/09/2015 11:23, Laurent Vivier wrote: > As devices with values greater than that are silently ignored, > this gives some hints to the sys admin to know why he doesn't see > his devices... > > Signed-off-by: Laurent Vivier > --- > drivers/scsi/ibmvscsi/ib

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

Ping ? On 10/09/2015 11:23, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier > --- > I resend this pa

[PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.

As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH 3/3] ibmvsci: Allow to configure maximum LUN

QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index f9d7ec4..e5478b0 100644 --- a/drivers/scsi/ibmvscsi

[PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- I resend this patch as James was not cc'ed. drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file

[PATCH] ibmvsci: make parameters max_id and max_channel read-only

The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --