Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-08 Thread Luc Van Oostenryck
On Tue, May 08, 2018 at 01:21:56AM -0400, Martin K. Petersen wrote: > > Luc, > > > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > > which is a typedef for an enum type, but the implementation in this > > driver returns an 'int'. > > You forgot to update the function

[PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-04-24 Thread Luc Van Oostenryck
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> --- d

Re: [PATCH v3 1/6] ilog2: create truly constant version for sparse

2018-04-18 Thread Luc Van Oostenryck
xpression like this: > > #define SIZE (1<<10) > static int foo[ilog2(SIZE)]; > > sparse 0.5.2 doesn't warn about that either. It emits "error: bad > integer constant expression" only if ilog2 is used in an array sparse supports VLAs at syntaxic level but not much more. Anything needing directly or indirectly the array size will give this error. -- Luc Van Oostenryck