Re: [PATCH 1/1] cciss: bug fix to prevent cciss from loading in kdump crash kernel

2013-05-03 Thread Mike Miller (OS Dev)
On Fri, 2013-05-03 at 11:02 -0700, James Bottomley wrote: > On Tue, 2013-04-23 at 12:25 -0500, Mike Miller wrote: > > PATCH 1/1 > > > > By default the cciss driver supports all "older" HP Smart Array controllers > > and hpsa supports all controllers starting with the G6 family. There are > > modul

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-18 Thread Mike Miller (OS Dev)
On Wed, 2013-04-17 at 15:02 -0700, Andrew Morton wrote: > On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > > > Patch 1/1 > > > > If hpsa is selected as the Smart Array driver cciss may try to load in the > > kdump kernel. When this happens kdump fails and a core file cannot be > > create

Re: [Patch 1/1] cciss: bug fix, prevent cciss from loading in kdump kernel

2013-04-18 Thread Mike Miller (OS Dev)
On Tue, 2013-04-16 at 15:00 -0700, Andrew Morton wrote: > On Mon, 15 Apr 2013 12:59:06 -0500 Mike Miller wrote: > > > Patch 1/1 > > > > If hpsa is selected as the Smart Array driver cciss may try to load in the > > kdump kernel. When this happens kdump fails and a core file cannot be > > create

[PATCH 1/1] cciss: fix error reporting for SG_IO

2007-08-14 Thread Mike Miller (OS Dev)
Patch 1/1 Steve has been trying to send this out but it doesn't seem to be getting anywhere. Please review this patch for accuracy. There's a couple of things not clear to us. Thanks, mikem We found a problem with th

[PATCH 1/1] cciss: add new controller support for P700m

2007-06-19 Thread Mike Miller (OS Dev)
PATCH 1/1 This patch adds support for the Smart Array P700m SAS controller. This new controller will ship Fall 2008. Please consider this for inclusion. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> diff --git a/dr

Re: [PATCH] cciss: Fix pci_driver.shutdown while device is still active

2007-05-17 Thread MIke Miller (OS Dev)
On Mon, 2007-05-14 at 17:53 +, Gerald Britton wrote: > Fix an Oops in the cciss driver caused by system shutdown while a filesystem > on a cciss device is still active. The cciss_remove_one function only > properly removes the device if the device has been cleanly released by its > users, whic

[PATCH 1/1] cciss: kconfig patch to make cciss dependent on scsi for SG_IO ioctl

2007-04-12 Thread Mike Miller (OS Dev)
PATCH 1/1 This kconfig patch makes cciss dependent on scsi for the new SG_IO ioctl we just added. If cciss is built into the kernel it makes sures that scsi is also statically linked. If scsi is a module then cciss will also be built as a module. Please consider this for inclusion. Signed-off-b

[PATCH 3/3] cciss: set rq->errors more correctly in driver

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 3/3 Set rq->errors more correctly in cciss driver. Previously we had set it synonymously with the meaning of the last parameter of end_that_last_request and complete_buffers (the "uptodate" parameter) and had gotten away with it for all this time because nobody ever looked at rq->errors. S

[PATCH 2/3] cciss: add SG_IO ioctl to cciss

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 2/3 For all of you that think cciss should be a scsi driver here is the patch that you have been waiting for all these years. This patch actually adds the SG_IO ioctl to cciss. The primary purpose is for clustering and high-availibilty. But now anyone can exploit this ioctl in any manner the

[PATCH 1/3] cciss: reformat error handling

2007-04-10 Thread Mike Miller (OS Dev)
PATCH 1/3 This patch reformats some error handling code to reduce line lengths a bit. It accompanies the SG_IO patch which is 2/3 of this set. Please consider this for inclusion. Signed-off-by: Stephen M. Cameron <[EMAIL PROTECTED]> Signed-off-by: Mike Miller <[EMAIL PROTECTED]> --- linux-2.6.

[PATCH 1/1] cciss: add init of drv->cylinders back to cciss_geometry_inquiry

2007-04-04 Thread Mike Miller (OS Dev)
PATCH 1/1 This patch adds initialization of drv->cylinders back into the failing case in cciss_geometry_inquiry. I inadvertently removed it in one my 2TB updates. Please consider this for inclusion. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> --

Re: [Patch 2/2] cciss: add struct pci_driver shutdown support (replaces reboot notifier)

2007-03-05 Thread Mike Miller (OS Dev)
On Tue, Feb 27, 2007 at 12:26:34PM -0800, Andrew Morton wrote: > > On Fri, 23 Feb 2007 14:42:39 -0600 "Mike Miller (OS Dev)" <[EMAIL > > PROTECTED]> wrote: > > This patch supercedes yesterdays cciss-shutdown patch. The primary > > difference is >

Re: [Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier)

2007-02-23 Thread Mike Miller (OS Dev)
On Fri, Feb 23, 2007 at 01:32:36PM -0800, Greg KH wrote: > On Fri, Feb 23, 2007 at 02:42:39PM -0600, Mike Miller (OS Dev) wrote: > > Patch 2/2 > > > > This patch supercedes yesterdays cciss-shutdown patch. The primary > > difference is > > removing __devexit

[Patch 1/2] cciss: fix for 2TB support (again)

2007-02-23 Thread Mike Miller (OS Dev)
Patch 1/2 This patch changes the constant 0x to 0xULL to prevent sign extension. Previously: This patch changes the way we determine if a logical volume is larger than 2TB. The original test looked for a total_size of 0. Originally we added 1 to the total_size. That would make

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-23 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 04:06:41PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 16:02 -0600, Mike Miller (OS Dev) wrote: > > Will this patch for my patch work for now? > > Yes, I think that should be fine ... it's only a theoretical worry; at > the moment secto

[Patch 2/2] cciss: supercedes add shutdown support (replaces reboot notifier)

2007-02-23 Thread Mike Miller (OS Dev)
Patch 2/2 This patch supercedes yesterdays cciss-shutdown patch. The primary difference is removing __devexit from cciss_remove_one. Instead of create another function I'd rather use the code that was intended to perform the cleanup and cache flush. I've tested as a loadable module and statically

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:55:01PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote: > > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > > > .remove = __devexit_p(cciss_remove_one), >

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 03:41:24PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 13:24 -0800, Andrew Morton wrote: > > > On Thu, 22 Feb 2007 10:51:23 -0600 "Mike Miller (OS Dev)" <[EMAIL > > > PROTECTED]> wrote: > > > On Wed, Feb 21,

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
On Thu, Feb 22, 2007 at 09:45:02PM +, Christoph Hellwig wrote: > On Thu, Feb 22, 2007 at 03:38:45PM -0600, Mike Miller (OS Dev) wrote: > > Patch 2/2 > > > > This adds support for struct pci_driver shutdown and negates the previous > > NAK'ed > > reboot_

[Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread Mike Miller (OS Dev)
Patch 2/2 This adds support for struct pci_driver shutdown and negates the previous NAK'ed reboot_notifier patch. It's much easier, wish I had know about this before. Thanks to Christoph for pointing this out. Signed-off-by: Mike Miller <[EMAIL PROTECTED]> ---

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote: > > > > + if (total_size == 0x) { > > I seem to remember having already questioned this. total_size is sector_t, > which > can be either 32-bit or 64-bit. Are you sure that comparison works as > intended in both cases? >

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread Mike Miller (OS Dev)
On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote: > On Wed, 21 Feb 2007 15:10:39 -0600 "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> > wrote: > > > Patch 1/2 > > > > This patch changes the way we determine if a logical volume is larger than

[Patch 2/2] cciss: add reboot notifier support to driver

2007-02-21 Thread Mike Miller (OS Dev)
Patch 2/2 This patch adds reboot_notifier support to cciss. Changes in firmware make this patch essential. Without this patch there may be valid data left in the controller's battery backed write cache (BBWC) on shutdown. We found out the hard way that the kernel does not call our cleanup routi

[Patch 1/2] cciss: fix for 2TB support

2007-02-21 Thread Mike Miller (OS Dev)
Patch 1/2 This patch changes the way we determine if a logical volume is larger than 2TB. The original test looked for a total_size of 0. Originally we added 1 to the total_size. That would make our read_capacity return size 0 for >2TB lv's. We assumed that we could not have a lv size of 0 so i

[PATCH 2/2] cciss: fix XFER_READ/XFER_WRITE in do_cciss_request

2006-12-15 Thread Mike Miller (OS Dev)
Patch 2 of 2 This patch fixes a stupid bug. Sometime during the 2tb enhancement I ended up replacing the macros XFER_READ and XFER_WRITE with h->cciss_read and h->cciss_write respectively. It seemed to work somehow at least on x86_64 and ia64. I don't know how. But people started complaining about

[PATCH 1/2] cciss: set default raid level when reading geometry fails

2006-12-15 Thread Mike Miller (OS Dev)
PATCH 1 of 2 This patch sets a default raid level on a volume that either does not support reading the geometry or reports an invalid geometry for whatever reason. We were always setting some values for heads and sectors but never set a raid level. This caused lots of problems on some buggy firmwa

[PATCH 2/2] cciss: remove calls to pci_disable_device

2006-12-12 Thread Mike Miller (OS Dev)
PATCH 2/2 This patch removes calls to pci_disable_device except in fail_all_cmds. The pci_disable_device function does something nasty to Smart Array controllers that pci_enable_device does not undo. So if the driver is unloaded it cannot be reloaded. Also, customers can disable any pci device

[PATCH 1/2] cciss: map out more memory for config table

2006-12-12 Thread Mike Miller (OS Dev)
PATCH 1/2 This patch maps out more memory for our config table. It's required to reach offset 0x214 to disable DMA on the P600. I'm not sure how I lost this hunk. Please consider this for inclusion. Thanks, mikem Signed-off-by: Mike Miller <[EMAIL PROTECTED]> drivers/block/cciss.c |2 +-

Re: [PATCH 9/12] repost: cciss: add busy_configuring flag

2006-12-12 Thread Mike Miller (OS Dev)
On Mon, Nov 06, 2006 at 09:32:00PM +0100, Jens Axboe wrote: > On Mon, Nov 06 2006, Mike Miller (OS Dev) wrote: > > PATCH 9 of 12 > > > > This patch adds a check for busy_configuring to prevent starting a queue > > on a drive that may be in the midst of updating,