Acked-by: Manoj N. Kumar
On 8/9/2016 6:40 PM, Matthew R. Ochs wrote:
The adapter file descriptor was previously cached within the kernel
for a given context in order to support performing a close on behalf
of an application. This is no longer needed as applications are now
required to perform
Acked-by: Manoj N. Kumar
On 8/9/2016 6:40 PM, Matthew R. Ochs wrote:
Update the block library link in the API documentation.
Signed-off-by: Matthew R. Ochs
---
Documentation/powerpc/cxlflash.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/powerpc/cxlfla
Acked-by: Manoj N. Kumar
On 8/9/2016 6:39 PM, Matthew R. Ochs wrote:
Caching the adapter file descriptor and performing a close on behalf
of an application is a poor design. This is due to the fact that once
a file descriptor in installed, it is free to be altered without the
knowledge of the
Acked-by: Manoj N. Kumar
On 8/9/2016 6:39 PM, Matthew R. Ochs wrote:
Currently, context user references are tracked via the list of LUNs
that have attached to the context. While convenient, this is not
intuitive without a deep study of the code and is inconsistent with
the existing reference tr
Acked-by: Manoj N. Kumar
On 8/9/2016 6:39 PM, Matthew R. Ochs wrote:
The context removal routine requires access to the owning adapter
structure to reset the context within the AFU as part of the tear
down sequence. In order to support kref adoption, the owning adapter
must be accessible from t
Acked-by: Manoj N. Kumar
On 8/9/2016 6:39 PM, Matthew R. Ochs wrote:
Context information structures are protected by a mutex that is held
when accessing/manipulating the context. When the code that manages
these structures was authored, a decision was made to include taking
the mutex as part of
On 6/15/2016 6:49 PM, Uma Krishnan wrote:
Some CXL Flash cards need notification of device shutdown
in order to flush pending I/Os.
A PCI notification hook for shutdown has been added where
the driver notifies the card and returns. When the device
is removed in the PCI remove path, notification
On 6/15/2016 6:49 PM, Uma Krishnan wrote:
Device dependent flags are needed to support functions that are
specific to a particular device.
Acked-by: Manoj N. Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 3/14/2016 2:42 PM, James Bottomley wrote:
The @odin.com one has been bouncing for a while now, so replace with
new Employer email.
Signed-off-by: James Bottomley
---
diff --git a/MAINTAINERS b/MAINTAINERS
index a7c4466..59f12c8 100644
--- a
Hannes:
Thanks for correcting the last argument.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 3/14/2016 4:43 AM, Hannes Reinecke wrote:
There is no way to detect the scsi_target_id for any given SAS
remote port, so add a new sysfs attribute 'scsi_target_id'.
Signed-off-by: Hanne
uot;0x%016llx\n",
unsigned long long);
sas_rphy_simple_attr(identify.phy_identifier, phy_identifier, "%d\n", u8);
+sas_rphy_simple_attr(scsi_target_id, scsi_target_id, "%d\n", u8);
Hannes:
Shouldn't the last argument be u32?
- Manoj Kumar
--
To unsubscri
int rel_port = -1, group_id;
struct alua_port_group *pg, *old_pg = NULL;
- bool pg_updated;
+ bool pg_updated = false;
unsigned long flags;
Reviewed-by: Manoj Kumar
---
Manoj Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
Fred:
Thanks for submitting this. Including linux-scsi.
Acked-by: Manoj N. Kumar
- Manoj
On 3/4/2016 5:26 AM, Frederic Barrat wrote:
To read the adapter VPD, drivers can't rely on pci config APIs, as it
wouldn't work on powerVM. cxl introduced a new kernel API especially
for this, so start
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8
drivers
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are
off by one. They are currently defined as 0x06 and 0x07 respetively.
These values are defined in PAPR correctly as 0x05 and 0x06. This
Tyrel:
Thanks for incorporating the suggestions.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80
Yeah, I can see how that is confusing. Since, all three possible valid
crq message types have the first bit set I think this was originally a
cute hack to grab anything that was likely valid. Then in
ibmvscsi_handle_crq() we explicitly match the full header value in a
switch statement logging anyt
On 2/3/2016 5:28 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80), a valid initialization entry (0xC0),
and a transport event (0xFF). Define these values as enums
On 12/14/2015 3:06 PM, Uma Krishnan wrote:
Having a date for the driver requires it to be updated quite
often. Removing the date which is not necessary. Also made
use of the existing symbol to print the driver name.
Signed-off-by: Uma Krishnan
---
Acked-by: Manoj N. Kumar
--
To unsubscribe
On 12/13/2015 9:47 PM, Andrew Donnellan wrote:
On 11/12/15 09:54, Uma Krishnan wrote:
From: Manoj Kumar
This drop enables a future card with a device id
of 0x0600 to be recognized by the cxlflash driver.
No card specific programming has been added. These
card specific changes will be staged
ailure.
Signed-off-by: Matthew R. Ochs
Acked-by: Manoj Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hannes:
A very valid point. Thanks for your suggestion.
Will look at resolving the issue in blk-mq.
Regards,
- Manoj
On 11/11/2015 1:28 AM, Hannes Reinecke wrote:
Shouldn't we rather fixup blk-mq to properly support SG_NONE?
Silently converting SG_NONE (=0) to 1 has a fair chance of breaking
n
Oops while testing blk_mq over the new cxlflash driver.
[ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5]
[ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0
[ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0
[ 2960.817314] Call Trace:
[ 2960.817320] __blk_mq_run_hw_queue+0x2bc/0x4c0
Don:
Thanks for not redefining HPSA_PERF_ERROR_BITS.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 11/4/2015 3:50 PM, Don Brace wrote:
This function is no longer used.
Reviewed-by: Tomas Henzl
Reviewed-by: Hannes Reinecke
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 11
n a future update.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 11/3/2015 12:26 PM, Gabriel Krisman Bertazi wrote:
According to the IPR specification, Inhibit Underlength Checking bit
must be disabled when issuing commands to vsets. Enabling it in this
case might cause SCSI commands to fail with
Tim:
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 10/30/2015 1:22 PM, tim.gard...@canonical.com wrote:
From: Tim Gardner
drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied
to the
the same section of code.
---
Manoj Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/28/2015 5:04 PM, Don Brace wrote:
Check for NULLs.
- int devtype;
+ unsigned int devtype;
Don:
Unrelated to the NULL argument check. Would have been preferable in a
distinct patch.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
--
To unsubscribe from this list: send the line
Don: See comment below.
- Manoj Kumar
On 10/28/2015 5:04 PM, Don Brace wrote:
This function is no longer used.
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
+#define HPSA_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIFT) - 1)
HPSA_PERF_ERROR_BITS seems to be only used in the fu
Oops while testing blk_mq over the new cxlflash driver.
[ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5]
[ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0
[ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0
[ 2960.817314] Call Trace:
[ 2960.817320] __blk_mq_run_hw_queue+0x2bc/0x4c0
Acked-by: Manoj Kumar
On 10/21/2015 3:16 PM, Matthew R. Ochs wrote:
Contexts may be skipped over for cleanup in situations where contention
for the adapter's table-list mutex is experienced in the presence of a
signal during the execution of the release handler.
--
To unsubscribe from
Acked-by: Manoj Kumar
On 10/21/2015 3:16 PM, Matthew R. Ochs wrote:
When running with lock instrumentation (e.g. lockdep), some of the
instrumentation can become disabled at probe time for a cxlflash
adapter. This is due to a missing lock registration for the tmf_slock.
The fix is to call
Acked-by: Manoj Kumar
On 10/21/2015 3:16 PM, Matthew R. Ochs wrote:
The port selection mask of a LUN can be corrupted when the manage LUN
ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu
Acked-by: Manoj Kumar
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Geliang:
Thanks for catching this.
- Manoj
Acked-by: Manoj Kumar
On 9/30/2015 9:55 PM, Geliang Tang wrote:
IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it.
Signed-off-by: Geliang Tang
---
drivers/scsi/cxlflash/superpipe.c | 4 ++--
1 file changed, 2 insertions(+), 2
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 9/22/2015 7:32 AM, Dan Carpenter wrote:
The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we go one
step beyond the end of the cfg->ctx_tbl[] array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/cx
James:
Wondering whether there is anything else you were expecting from us
before pulling this patch series in.
Regards,
- Manoj Kumar
On 8/13/2015 9:47 PM, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
A device state is added to track 3 possible states of the
Mikey:
Thanks for pointing this out. The patch for 2/3 should address this
issue.
Regards,
- Manoj Kumar
On 8/13/2015 8:08 PM, Michael Neuling wrote:
On Thu, 2015-08-13 at 18:43 -0500, Manoj Kumar wrote:
Mikey:
Thanks for your review. See comment inline below.
- Manoj Kumar
On 8/13/2015
Mikey:
Thanks for your review. See comment inline below.
- Manoj Kumar
On 8/13/2015 7:03 AM, Michael Neuling wrote:
Thanks for integrating my suggestions. create_context() has the same
freeing bug as 2/3 but if you fix that I'm happy if you add my
reviewed by:
Reviewed-by: Michael Ne
Mikey:
Good catch. Will resolve this in the v6 patch.
Thanks,
- Manoj
On 8/13/2015 5:53 AM, Michael Neuling wrote:
+
+ ctxi = kzalloc(sizeof(*ctxi), GFP_KERNEL);
+ lli = kzalloc((MAX_RHT_PER_CONTEXT * sizeof(*lli)), GFP_KERNEL);
+ if (unlikely(!ctxi || !lli)) {
+
Mikey:
Comments inline below.
- Manoj Kumar
On 8/11/2015 10:24 PM, Michael Neuling wrote:
The ioctls have a standard header structure, with version etc. that are
sanity checked before we get here. The other fields are sanity checked
where they are used, i.e. in get_context().
That was my
Ben:
Comments inline below.
On 8/11/2015 12:29 AM, Benjamin Herrenschmidt wrote:
So in a similar vein to the previous review, I am missing a lot of
context here but a few things did spring to me eyes:
Thanks for your review.
+ list_for_each_entry_safe(lli, temp, &cfg->lluns, list)
Mikey: Thanks for your review. Comments inline below.
On 8/11/2015 5:54 AM, Michael Neuling wrote:
I'm not keen on the numerous pr_err() in here. I think it'll make the driver
chatty especially with a badly behaving userspace.
Will look at all the pr_err() and limit them to errors that are
Brian: Thanks for your review. See comments inline, below.
- Manoj Kumar
On 8/6/2015 3:46 PM, Brian King wrote:
* cxlflash_queuecommand() - sends a mid-layer request
* @host: SCSI host associated with device.
* @scp: SCSI command to send.
@@ -512,6 +535,13 @@ static int
Wendy:
Thanks for your review. Comment inline below.
- Manoj Kumar
On 7/29/2015 5:12 PM, wenxi...@linux.vnet.ibm.com wrote:
+
+cfg->eeh_active = EEH_STATE_NONE;
+wake_up_all(&cfg->eeh_waitq);
+}
+
Do you need host->lock in these EEH callback functions?
These ar
Wendy:
Thanks for taking the time to review this patch. Comments inline below.
- Manoj Kumar
On 7/29/2015 5:13 PM, wenxi...@linux.vnet.ibm.com wrote:
+/* Update the free_curr_idx */
+if (bit_pos == 63)
+lun_info->free_curr_idx = bit_word + 1;
Predefined Macros for 63 and
On 6/9/2015 6:29 AM, Brian King wrote:
Pulled out going to sleep in the queuecommand path.
udelay doesn't sleep, its a busy wait, so you can still use it in queuecommand,
just don't spend too much time, and its probably better to udelay then to
just re-read in a tight loop.
Thanks for the cl
Brian:
Thanks for the quick review. Comments below.
- Manoj
On 6/8/2015 5:56 PM, Brian King wrote:
+retry:
+ newval = atomic64_dec_if_positive(&afu->room);
+ if (!newval) {
+ do {
+ room = readq_be(&afu->host_map->cmd_room);
+
On 6/8/2015 12:54 PM, Brian King wrote:
+
+ rcr = send_tmf(afu, scp, TMF_LUN_RESET);
+ if (unlikely(rcr))
+ rc = FAILED;
Do you need to wait for all commands to the LUN to be returned before returning
from
here? You could put a simple loop here, polling until there a
Brian:
Thank you for your review. Comments are inline.
- Manoj
On 6/8/2015 12:54 PM, Brian King wrote:
Looking pretty good. A few more comments.
Thanks,
Brian
+ spin_lock_irqsave(&cfg->tmf_waitq.lock, lock_flags);
+ if (cfg->tmf_active)
+ wait_event_interruptible_
Brian:
Thanks for your review. Responses are inline below.
- Manoj Kumar
On 6/4/2015 9:38 AM, Brian King wrote:
+
+ write_lock(&cfg->tmf_lock);
What is this lock protecting? The only thing it seems to be accomplishing is
making sure one thread isn't sending a TMF and an
51 matches
Mail list logo
