[PATCH v5 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-08-10 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer <mma...@broadcom.com> Acked-by: Nicholas Bellinger <n...@linux-iscsi.org> --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 inse

[PATCH v5 0/7] lib: string: add functions to case-convert strings

2016-08-10 Thread Markus Mayer
patch, since that code is OS independent and can't rely on a Linux library function (see [3]) - Added two new patches replacing strtoupper() implementations [1] https://lkml.org/lkml/2016/6/30/727 [2] https://lkml.org/lkml/2016/7/10/4 [3] https://lkml.org/lkml/2016/7/1/9 Markus Mayer (7): lib:

[PATCH v5 1/7] lib: string: add functions to case-convert strings

2016-08-10 Thread Markus Mayer
take a single string argument and modify the passed-in string. strlcpytoupper() and strlcpytolower() return the number of characters copied or -E2BIG if the destination string was truncated. Like strlcpy(), and unlike strncpy(), the functions guarantee NULL termination of the destination string. S

[PATCH v4 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-22 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer <mma...@broadcom.com> Acked-by: Nicholas Bellinger <n...@linux-iscsi.org> --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 inse

[PATCH v4 1/7] lib: string: add functions to case-convert strings

2016-07-22 Thread Markus Mayer
take a single string argument and modify the passed-in string. strlcpytoupper() and strlcpytolower() return the number of characters copied or -E2BIG if the destination string was truncated. Like strlcpy(), and unlike strncpy(), the functions guarantee NULL termination of the destination string. S

[PATCH v4 0/7] lib: string: add functions to case-convert strings

2016-07-22 Thread Markus Mayer
/lkml/2016/7/10/4 [3] https://lkml.org/lkml/2016/7/1/9 Markus Mayer (7): lib: string: add functions to case-convert strings drm/nouveau/core: make use of new strlcpytolower() function ACPI / device_sysfs: make use of new strtolower() function staging: speakup: replace spk_strlwr() with st

Re: [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-20 Thread Markus Mayer
On 20 July 2016 at 14:17, Nicholas A. Bellinger <n...@linux-iscsi.org> wrote: > On Wed, 2016-07-20 at 14:16 -0700, Nicholas A. Bellinger wrote: >> On Fri, 2016-07-08 at 15:43 -0700, Markus Mayer wrote: >> > After introducing generic strtolower(), iscsi_initiatorname_tol

Re: [PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-20 Thread Markus Mayer
On Wed, Jul 13, 2016 at 03:52:38PM -0700, Markus Mayer wrote: > On Sat, Jul 09, 2016 at 09:11:05PM -0700, Markus Mayer wrote: >> On 9 July 2016 at 20:13, Chris Metcalf <cmetc...@mellanox.com> wrote: >>> On 7/8/2016 6:43 PM, Markus Mayer wrote: >>>> >>>

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-13 Thread Markus Mayer
On 13 July 2016 at 15:53, Luis de Bethencourt wrote: > > Hi Markus, > > Thank you very much for the thorough testing and solution searching. > > Earlier today I sent a patch that removes dynamic_debug.h from > include/linux/kernel.h, since it isn't really needed. Sorry

Re: [PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-13 Thread Markus Mayer
On Sat, Jul 09, 2016 at 09:11:05PM -0700, Markus Mayer wrote: > On 9 July 2016 at 20:13, Chris Metcalf <cmetc...@mellanox.com> wrote: > > On 7/8/2016 6:43 PM, Markus Mayer wrote: > >> > >> This series introduces a family of generic string case conversion > >

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-13 Thread Markus Mayer
On 13 July 2016 at 10:19, Luis de Bethencourt <lui...@osg.samsung.com> wrote: > On 11/07/16 23:46, Markus Mayer wrote: > > Hi Markus, > > Amazing. I see this happening as well, but I know it shouldn't. > > The reason the #ifndef guards in headers are there is pr

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-11 Thread Markus Mayer
On 9 July 2016 at 08:30, Markus Mayer <markus.ma...@broadcom.com> wrote: > On 9 July 2016 at 05:04, Luis de Bethencourt <lui...@osg.samsung.com> wrote: >> On 08/07/16 23:43, Markus Mayer wrote: >>> Add a collection of generic functions to convert strings

Re: [PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-09 Thread Markus Mayer
On 9 July 2016 at 20:13, Chris Metcalf <cmetc...@mellanox.com> wrote: > On 7/8/2016 6:43 PM, Markus Mayer wrote: >> >> This series introduces a family of generic string case conversion >> functions. This kind of functionality is needed in several places in >> the k

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-09 Thread Markus Mayer
On 9 July 2016 at 05:04, Luis de Bethencourt <lui...@osg.samsung.com> wrote: > On 08/07/16 23:43, Markus Mayer wrote: >> Add a collection of generic functions to convert strings to lowercase >> or uppercase. >> >> Changing the case of a string (with o

[PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
ctions take a single string argument and modify the passed-in string. Like strlcpy(), and unlike strncpy(), the functions guarantee NULL termination of the destination string. Signed-off-by: Markus Mayer <mma...@broadcom.com> --- include/linux/string.h | 40

[PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-08 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer <mma...@broadcom.com> --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target

[PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
s [1] https://lkml.org/lkml/2016/6/30/727 [2] https://lkml.org/lkml/2016/7/1/9 Markus Mayer (7): lib: string: add functions to case-convert strings drm/nouveau/core: make use of new strlcpytolower() function ACPI / device_sysfs: make use of new strtolower() function staging: spea

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
On 7 July 2016 at 17:19, Rasmus Villemoes <li...@rasmusvillemoes.dk> wrote: > On Tue, Jul 05 2016, Markus Mayer <mma...@broadcom.com> wrote: > >> +/** >> + * strncpytoupper - Copy a length-limited string and convert to uppercase. >> + * @dst: The buffer to store

Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Markus Mayer
On 5 July 2016 at 15:56, Joe Perches <j...@perches.com> wrote: > On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: >> On 5 July 2016 at 15:14, Joe Perches <j...@perches.com> wrote: >> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> > >

Re: [PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Markus Mayer
On 5 July 2016 at 15:14, Joe Perches <j...@perches.com> wrote: > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> This series introduces a family of generic string case conversion >> functions. This kind of functionality is needed in several places in >> the k

[PATCH v2 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-05 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer <mma...@broadcom.com> --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target

[PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Markus Mayer
ctions take a single string argument and modify the passed-in string. All functions return a pointer to the terminating '\0' character in the modified string ("dst" or "s", respectively). Signed-off-by: Markus Mayer <mma...@bro

[PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Markus Mayer
ew patches replacing strtoupper() implementations [1] https://lkml.org/lkml/2016/6/30/727 [2] https://lkml.org/lkml/2016/7/1/9 Markus Mayer (7): lib: string: add functions str[n]cpytolower()/str[n]cpytoupper() drm/nouveau/core: make use of new strncpytolower() function ACPI / device_sysfs: make

Re: [PATCH 1/6] lib: string: add function strtolower()

2016-07-04 Thread Markus Mayer
On 1 July 2016 at 14:08, Rasmus Villemoes wrote: > A few suggestions: > > - Make the function take separate src and dst parameters, making it explicitly > allowed to pass the same value (but not other kinds of overlap, of > course). That way one can avoid

Re: [PATCH 1/6] lib: string: add function strtolower()

2016-07-01 Thread Markus Mayer
On 1 July 2016 at 03:52, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Fri, 01 Jul 2016, Markus Mayer <mma...@broadcom.com> wrote: >> Add a function called strtolower() to convert strings to lower case >> in-place, overwriting the original string. >>

[PATCH 1/6] lib: string: add function strtolower()

2016-06-30 Thread Markus Mayer
Add a function called strtolower() to convert strings to lower case in-place, overwriting the original string. This seems to be a recurring requirement in the kernel that is currently being solved by several duplicated implementations doing the same thing. Signed-off-by: Markus Mayer <

[PATCH 6/6] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-06-30 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer <mma...@broadcom.com> --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target

[PATCH 0/6] lib: string: add function strtolower()

2016-06-30 Thread Markus Mayer
f required hardware. This series is based on v4.7-rc5. Markus Mayer (6): lib: string: add function strtolower() drm/nouveau/core: make use of new strtolower() function ACPICA: make use of new strtolower() function ACPI / device_sysfs: make use of new strtolower() function staging: speaku