Re: Debugging scsi abort handling ?

2014-08-28 Thread Martin Peschke
On Thu, 2014-08-28 at 14:04 +0200, Hannes Reinecke wrote: > On 08/25/2014 01:15 PM, Paolo Bonzini wrote: > > - abort the command, and then the driver should never call the > > ->scsi_done callback for the Scsi_Cmnd*. > > > In practice we rely on the latter behaviour; when ->scsi_done is > called w

Re: [PATCH 6/7] scsi: Use Scsi_Host as argument for eh_host_reset_handler

2014-06-27 Thread Martin Peschke
On Fri, 2014-06-27 at 13:04 +0200, Hannes Reinecke wrote: > On 06/27/2014 12:47 PM, Steffen Maier wrote: > > On 06/27/2014 08:27 AM, Hannes Reinecke wrote: > >> Issuing a host reset should not rely on any commands. > >> So use Scsi_Host as argument for eh_host_reset_handler. > >> > >> Signed-off-by

Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-29 Thread Martin Peschke
On Sat, 2013-07-27 at 02:07 +0900, Akinobu Mita wrote: > 2013/7/26 Martin Peschke : > > On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote: > >> With module parameter num_parts > 0, partition table is built on the > >> ramdisk storage when loading the drive

Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-25 Thread Martin Peschke
gt;nr_sects = cpu_to_le32(end_sec - start_sec + 1); > pp->sys_ind = 0x83; /* plain Linux partition */ > } > } I have posted the same fix several times, e.g. http://marc.info/?l=linux-scsi&m=137051617907423&w=2 Good luck! Acked-by: Martin Peschke -

[PATCH RESEND] scsi_debug: Fix endianess in partition table

2013-06-06 Thread Martin Peschke
sda: p1 start 536870912 is beyond EOD, truncated For verification 'xxd -l 512 /dev/sda' has been used to make sure that this fix makes scsi_debug generated partition tables on s390x look like the ones generated on my laptop. Signed-off-by: Martin Peschke Reviewed-by: Steffen Maier

How to fix this sleep-inside-lock problem?

2013-06-05 Thread Martin Peschke
Hi, I would like to ask for advice, prior to submitting a patch for our lldd zfcp, or alternatively for common code. Someone reported this warning and function call stack: BUG: sleeping function called from invalid context at kernel/workqueue.c:2752 in_atomic(): 1, irqs_disabled(): 1, pid: 360,

PATCH] scsi_debug: Fix endianess in partition table

2013-04-26 Thread Martin Peschke
native capacity sda: p1 start 536870912 is beyond EOD, truncated For verification 'xxd -l 512 /dev/sda' has been used to make sure that this fix makes scsi_debug generated partition tables on s390x look like the ones generated on my laptop. Signed-off-by: Martin Peschke Reviewed-b

Re: [GIT PULL] Final round of SCSI updates for the 3.8+ merge window

2013-03-07 Thread Martin Peschke
James, any outlook for this one? [PATCH] scsi_debug: Fix endianess in partition table Thanks, Martin On Fri, 2013-03-01 at 09:19 +, James Bottomley wrote: > This is an assorted set of stragglers into the merge window with driver > updates for qla2xxx, megaraid_sas, storvsc and ufs. It also

[PATCH] scsi_debug: Fix endianess in partition table

2013-02-15 Thread Martin Peschke
sda: p1 start 536870912 is beyond EOD, truncated For verification 'xxd -l 512 /dev/sda' has been used to make sure that this fix makes scsi_debug generated partition tables on s390x look like the ones generated on my laptop. Signed-off-by: Martin Peschke Reviewed-by: Steffen Maier

Re: [PATCH] scsi_debug: Fix endianess in partition table

2013-02-13 Thread Martin Peschke
On Tue, 2013-02-12 at 09:45 -0500, Douglas Gilbert wrote: > However since SCSI is big endian and you are introducing > some "le" code then a line or so of explanation (comments) > in your revised patch might be helpful. I would argue that the definition of struct partition itself should be suffici

Re: [PATCH] scsi_debug: Fix endianess in partition table

2013-02-12 Thread Martin Peschke
On Mon, 2013-02-11 at 18:34 +0100, Martin Peschke wrote: > Both start_sect and nr_sects in struct partition are __le32 and > require cpu_to_le32() on assignment. Steffen Maier has pointed me at: block/partitions/msdos.c: return (sector_t)get_unaligned_le32(&p->start_sect);

[PATCH] scsi_debug: Fix endianess in partition table

2013-02-11 Thread Martin Peschke
p. Signed-off-by: Martin Peschke Reviewed-by: Steffen Maier --- drivers/scsi/scsi_debug.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -2662,8 +2662,8 @@ static void __init sdebug_buil

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-11 Thread Martin Peschke
Hello Hannes, > fc_eh_it_nexus_loss_handler() is invoked as the > eh_target_reset_handler() callback and the > eh_bus_reset_handler() is removed. lpfc_target_reset_handler(), which is replaced by your patch, used to issue a TARGET_RESET task management function over FCP in the eh_target_reset_han

[Patch 2/2] zfcp: fix cleanup of dismissed error recovery actions

2007-11-15 Thread Martin Peschke
ons go to the tail of the ready list; the erp thread picks actions to be processed from the ready list's head. Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> Acked-by: Swen Schillig <[EMAIL PROTECTED]> --- drivers/s390/scsi/zfcp_erp.c | 14 ++ 1 files changed

[Patch 1/2] zfcp: fix dismissal of error recovery actions

2007-11-15 Thread Martin Peschke
this. It is important to kick the erp thread only for actions in the running list, though, as an imbalance of wakeup signals would confuse the erp thread otherwise. Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> Acked-by: Swen Schillig <[EMAIL PROTECTED]> --- drivers/s390/scs

[Patch 0/2] zfcp: bug fixes for error recovery

2007-11-15 Thread Martin Peschke
has been requested. We have verified both patches running our error injection tests. Patches are against 2.6.24-rc2-git5. Please apply. [Patch 1/2] zfcp: fix dismissal of error recovery actions [Patch 2/2] zfcp: fix cleanup of dismissed error recovery actions Signed-off-by: Martin Peschke <[EM

Re: [PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-07 Thread Martin Peschke
I am afraid this patch can't be applied as it is. The problem is that the code doesn't take into account that older adapters do not provide the data which your patch tries to extract. There is a feature flag for that in the hardware specification. So the right response to Heiko's complaint abo

Re: [PATCH, RFC] SCSI cleanups for 2.5

2001-01-18 Thread Martin Peschke
- this command is used by some SCSI initiators > and most multipathing drivers to determine whether the same LU has been > accessed through different paths. > > You can find more details in SPC-2 (or SPC-3). I am aware of these drafts or standards. But I can't find VPID. I know

Re: [PATCH, RFC] SCSI cleanups for 2.5

2001-01-16 Thread Martin Peschke
On Thu, 11 Jan 2001, Jeremy Higdon wrote: > On Jan 11, 12:44pm, Martin Peschke wrote: > > > > On Wed, 10 Jan 2001, Prasenjit Sarkar wrote: > > > > > > > > > > > I am aware of the 64-bit LUN specification, but can you clarify what you > &g

Re: [PATCH, RFC] SCSI cleanups for 2.5

2001-01-11 Thread Martin Peschke
On Wed, 10 Jan 2001, Prasenjit Sarkar wrote: > > > > I am aware of the 64-bit LUN specification, but can you clarify what you > meant by 'id'? SCSI ID > If you meant the WWN-type identifier in FCP, Seems, that FCP-2 [ftp://ftp.t10.org/t10/drafts/fcp2/fcp2r04.pdf] maps FCP term "address i

Re: [PATCH, RFC] SCSI cleanups for 2.5

2001-01-10 Thread Martin Peschke
be changed to proc-fs, I think), the predefined order of alternate paths, missing load balancing ... - Fix host enumeration regarding naming of SCSI devices in devfs' name space to something more reconfiguration proof (scheme following physical addresses, like subsequent bus, id, lun) -alternately to previous approach: enhance scsihosts parameter from scsihosts=,,,driver to scsihosts=(,),,() This would allow to specify the order of hosts within the scope of a single HBA driver. Currently it depends on the order of detection and registration of HBAs at module or kernel initialization. But, what is about hosts being unavailable at this time sometimes and becoming operational later? If HBA drivers would pass an unique identifier for each detected host (let's assume unique_id) additionally to scsi_register, then the mid layer could match this against identifiers known from the scsihosts parameter and put the host into the predefined position. Regards Martin Peschke - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED]