[PATCH] csiostor: Retain default adapter configuration in absence of config file.

2013-05-16 Thread Naresh Kumar Inna
- Retain firmware defined configuration settings in the absence of user-provided configuration by eliminating the global RSS and the PF/VF capabilities mailbox commands. - Remove S_IRUGO from sysfs parameters that don't have 'show' functionality. Signed-off-by: Naresh Kumar Inna nar

Re: [patch -next] csiostor: off by one error

2013-03-25 Thread Naresh Kumar Inna
[CSIO_LNE_MAX_EVENT]; /* State m/c events */ uint32_tn_rnode_alloc; /* rnode allocated */ uint32_tn_rnode_free; /* rnode freed */ Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH -next] [SCSI] csiostor: fix error return code in csio_hw_init()

2013-03-15 Thread Naresh Kumar Inna
Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] [SCSI] csiostor: remove unused variable in csio_process_fwevtq_entry()

2013-03-15 Thread Naresh Kumar Inna
{ csio_warn(hw, unexpected CPL %#x on FW event queue\n, op); CSIO_INC_STATS(hw, n_cpl_unexp); Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [SCSI] csiostor: Chelsio FCoE offload driver

2013-02-07 Thread Naresh Kumar Inna
On 2/6/2013 6:39 PM, Dan Carpenter wrote: Hopefully, you recieved an email about this last November, but this is a follow up because the bug is still there. I don't recollect getting that email. Thanks for reporting nevertheless. There are some patches lined up for supporting new features and

Re: [PATCH 10/15] drivers/scsi/csiostor/csio_lnode.c: adjust duplicate test

2013-01-22 Thread Naresh Kumar Inna
); + ln = csio_lnode_alloc(hw); spin_lock_irq(hw-lock); if (!ln) { csio_err(hw, -- Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] [SCSI] csiostor: Don't leak mem or fail to release firmware in csio_hw_flash_config()

2012-12-28 Thread Naresh Kumar Inna
*fw_cfg_param, char *path) strncpy(path, /lib/firmware/ CSIO_CF_FNAME, 64); } +leave: kfree(cfg_data); release_firmware(cf); - return ret; } Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list

Re: [PATCH -next] [SCSI] csiostor: convert to use simple_open()

2012-12-02 Thread Naresh Kumar Inna
On 12/2/2012 5:21 PM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH -next v2] [SCSI] csiostor: convert to use simple_open()

2012-12-02 Thread Naresh Kumar Inna
, + .open= simple_open, .read= csio_mem_read, .llseek = default_llseek, }; Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [patch] [SCSI] csiostor: remove unneeded memset()

2012-11-28 Thread Naresh Kumar Inna
be multiple of 4 bytes */ ae-len = htons(len); - memset(ae-value, 0, len - 4); memcpy(ae-value, val, len); *ptr += len; } Acked-by: Naresh Kumar Inna nar...@chelsio.com Thanks, Naresh. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH] csiostor: Fix sparse warnings.

2012-11-26 Thread Naresh Kumar Inna
Hi James, Could you please let me know when this patch would be pushed? Thanks, Naresh. On 11/20/2012 6:15 PM, Naresh Kumar Inna wrote: This patch fixes sparse warnings related to endian-ness, which were reported by the 0-day kernel build and testing tool. Signed-off-by: Naresh Kumar Inna

[PATCH] csiostor: Fix sparse warnings.

2012-11-19 Thread Naresh Kumar Inna
This patch fixes sparse warnings related to endian-ness, which were reported by the 0-day kernel build and testing tool. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_attr.c | 34 ++-- drivers/scsi/csiostor/csio_hw.c | 14 +++--- drivers

Re: [scsi:misc 36/36] drivers/scsi/csiostor/csio_attr.c:92:41: sparse: incorrect type in assignment (different base types)

2012-11-16 Thread Naresh Kumar Inna
On 11/15/2012 11:59 PM, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 0779fa137a73170b6c796fdb476f1455ba67b9aa commit: 0779fa137a73170b6c796fdb476f1455ba67b9aa [36/36] [SCSI] csiostor: Chelsio FCoE offload driver sparse

[v6 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-11-15 Thread Naresh Kumar Inna
PATCH 7/8]: Interrupt handling and fast path I/O functionality. [v6 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes. Naresh Kumar Inna (8): cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates). csiostor: Chelsio FCoE offload driver submission (headers part

[v6 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-11-15 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 +++--- drivers/net

[v6 PATCH 2/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-11-15 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[v6 PATCH 3/8] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-11-15 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h

Re: [v6 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-11-02 Thread Naresh Kumar Inna
Hi James, Could you please let me know where we are with the review of this driver? Thanks, Naresh. On 10/25/2012 3:20 PM, Naresh Kumar Inna wrote: This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel. This driver currently supports FCoE offload

[v6 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-10-24 Thread Naresh Kumar Inna
PATCH 7/8]: Interrupt handling and fast path I/O functionality. [v6 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes. Naresh Kumar Inna (8): cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates). csiostor: Chelsio FCoE offload driver submission (headers part

[v6 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-10-24 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |8 ++-- drivers/net

[v6 PATCH 2/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-10-24 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[v6 PATCH 3/8] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-10-24 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h

Re: [V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-10-23 Thread Naresh Kumar Inna
Hi James, I hope now is a good time to resume the review of this driver. I will send out v6 version of the driver shortly, which has some bug fixes and other cleanup. Thanks, Naresh. On 10/8/2012 3:55 PM, James Bottomley wrote: On Mon, 2012-10-08 at 15:37 +0530, Naresh Kumar Inna wrote

Re: [V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-10-08 Thread Naresh Kumar Inna
Hi James, Please let me know if you are expecting any more changes to this driver to resume its review. I have addressed all review comments as of the last series of patches (below). Thanks, Naresh. On 9/24/2012 10:47 PM, Naresh Kumar Inna wrote: This is the initial submission of the Chelsio

[V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-24 Thread Naresh Kumar Inna
PATCH 6/8]: Local and remote port state tracking functionality. [V5 PATCH 7/8]: Interrupt handling and fast path I/O functionality. [V5 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes. Naresh Kumar Inna (8): cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header

[V5 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-09-24 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net

[V5 PATCH 2/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-24 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[V5 PATCH 3/8] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-09-24 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h

Re: [V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-18 Thread Naresh Kumar Inna
On 9/18/2012 2:06 PM, James Bottomley wrote: On Tue, 2012-09-18 at 09:54, Naresh Kumar Inna wrote: Hi James, Could you please consider merging version V4 of the driver patches, if you think they are in good shape now? Well, definitely not yet; you seem to have missed the memo on readq

Re: [V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-17 Thread Naresh Kumar Inna
Hi James, Could you please consider merging version V4 of the driver patches, if you think they are in good shape now? Thanks, Naresh. On 9/12/2012 10:48 PM, Naresh Kumar Inna wrote: This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-12 Thread Naresh Kumar Inna
On 9/12/2012 11:17 AM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Wed, 12 Sep 2012 11:05:22 +0530 On 9/11/2012 11:03 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:07 +0530 This patch contains minor fixes to make

[V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-12 Thread Naresh Kumar Inna
path I/O functionality. [V4 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes. Naresh Kumar Inna (8): cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates). csiostor: Chelsio FCoE offload driver submission (headers part 1). csiostor: Chelsio FCoE offload

[V4 PATCH 2/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-12 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[V4 PATCH 3/8] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-09-12 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h

[V4 PATCH 1/8] cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header updates).

2012-09-12 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4/cxgb4vf source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-12 Thread Naresh Kumar Inna
On 9/12/2012 10:22 PM, Andi Kleen wrote: Naresh Kumar Inna nar...@chelsio.com writes: OK, I think I should be able to arrange the patch set to fulfill that requirement. I was under the impression it was fine for new drivers to split patches in this fashion, since they go as a single commit

[V3 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission

2012-09-11 Thread Naresh Kumar Inna
part 1. [V3 PATCH 7/9]: Header files part 2. [V3 PATCH 8/9]: Updates to header files shared between cxgb4, cxgb4vf and csiostor. [V3 PATCH 9/9]: Header file compatibility fixes to cxgb4vf. Naresh Kumar Inna (9): csiostor: Chelsio FCoE offload driver submission (sources part 1

[V3 PATCH 7/9] csiostor: Chelsio FCoE offload driver submission (headers part 2).

2012-09-11 Thread Naresh Kumar Inna
This patch contains the second set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_lnode.h | 255 ++ drivers/scsi/csiostor/csio_mb.h| 278 +++ drivers/scsi/csiostor/csio_rnode.h

[V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread Naresh Kumar Inna
This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff

[V3 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates).

2012-09-11 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4 source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net/ethernet

Re: [V3 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-11 Thread Naresh Kumar Inna
On 9/11/2012 11:03 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:07 +0530 This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar

Re: [V3 PATCH 5/9] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-09-11 Thread Naresh Kumar Inna
On 9/11/2012 11:05 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Tue, 11 Sep 2012 20:09:03 +0530 +#include linux/moduleparam.h This header include is not necessary. I will remove it, thanks. -- To unsubscribe from this list: send the line unsubscribe linux

[V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[V2 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-05 Thread Naresh Kumar Inna
This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff

[V2 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission

2012-09-05 Thread Naresh Kumar Inna
compatibility fixes to cxgb4vf. Naresh Kumar Inna (9): csiostor: Chelsio FCoE offload driver submission (sources part 1). csiostor: Chelsio FCoE offload driver submission (sources part 2). csiostor: Chelsio FCoE offload driver submission (sources part 3). csiostor: Chelsio FCoE offload driver

[V2 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates).

2012-09-05 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4 source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net/ethernet

Re: [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 9:53 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:54 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +/* FCoE Adapter types its description */ +static struct csio_adap_desc csio_fcoe_adapters[] = { Tables like this should be const. Thanks for reviewing. I

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:01 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) This is similar to existing round_up() in kernel.h could you use that? I will replace

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 9:59 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation and the Work Request module functionality. Driver initialization includes module entry

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:03 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +#define CSIO_ASSERT(cond) \ +do

Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-03 Thread Naresh Kumar Inna
On 8/26/2012 12:38 AM, Naresh Kumar Inna wrote: On 8/25/2012 12:40 AM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Sat, 25 Aug 2012 00:34:35 +0530 Thanks for reviewing. Is your comment with respect to any particular module parameter[s] in this driver or all of them

Re: [PATCH 5/8] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-08-29 Thread Naresh Kumar Inna
On 8/26/2012 12:13 AM, Nicholas A. Bellinger wrote: On Sun, 2012-08-26 at 00:06 +0530, Naresh Kumar Inna wrote: On 8/25/2012 2:26 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote: On 8/24/2012 1:18 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24

Re: [PATCH 6/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-08-25 Thread Naresh Kumar Inna
On 8/25/2012 2:47 AM, Nicholas A. Bellinger wrote: On Sat, 2012-08-25 at 00:06 +0530, Naresh Kumar Inna wrote: On 8/24/2012 1:28 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote: This patch contains the first set of the header files for csiostor

Re: [PATCH 5/8] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-08-25 Thread Naresh Kumar Inna
On 8/25/2012 2:26 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote: On 8/24/2012 1:18 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote: This patch contains code to implement the interrupt handling

Re: [PATCH 6/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-08-25 Thread Naresh Kumar Inna
On 8/26/2012 12:10 AM, Nicholas A. Bellinger wrote: On Sat, 2012-08-25 at 23:39 +0530, Naresh Kumar Inna wrote: On 8/25/2012 2:47 AM, Nicholas A. Bellinger wrote: On Sat, 2012-08-25 at 00:06 +0530, Naresh Kumar Inna wrote: On 8/24/2012 1:28 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24

Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-08-25 Thread Naresh Kumar Inna
On 8/25/2012 12:40 AM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Sat, 25 Aug 2012 00:34:35 +0530 Thanks for reviewing. Is your comment with respect to any particular module parameter[s] in this driver or all of them? All of them. So are module parameters

Re: [PATCH 5/8] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-08-24 Thread Naresh Kumar Inna
On 8/24/2012 1:18 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote: This patch contains code to implement the interrupt handling and the fast path I/O functionality. The interrupt handling includes allocation of MSIX vectors, registering

Re: [PATCH 6/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-08-24 Thread Naresh Kumar Inna
On 8/24/2012 1:28 AM, Nicholas A. Bellinger wrote: On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote: This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_defs.h | 143

Re: [PATCH 6/8] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-08-24 Thread Naresh Kumar Inna
On 8/23/2012 11:45 PM, Love, Robert W wrote: On 8/23/2012 3:27 PM, Naresh Kumar Inna wrote: This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/scsi/csiostor/csio_defs.h | 143 ++ drivers

Re: [PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-08-24 Thread Naresh Kumar Inna
On 8/24/2012 10:34 PM, David Miller wrote: From: Naresh Kumar Inna nar...@chelsio.com Date: Fri, 24 Aug 2012 03:57:45 +0530 This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel. This driver currently supports FCoE offload functionality over

Re: [PATCH 5/8] csiostor: Chelsio FCoE offload driver submission (sources part 5).

2012-08-24 Thread Naresh Kumar Inna
On 8/24/2012 11:57 PM, Joe Perches wrote: On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote: Is there a TRUE/FALSE define in a standard header file? include/linux/stddef.h: enum { false = 0, true= 1 }; I see a lot of kernel code defining their own TRUE/FALSE

[PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-08-23 Thread Naresh Kumar Inna
. [PATCH 5/8]: Interrupt handling and fast path I/O functionality. [PATCH 6/8]: Header files part 1. [PATCH 7/8]: Header files part 2. [PATCH 8/8]: Updates to header files shared between cxgb4 and csiostor. Naresh Kumar Inna (8): csiostor: Chelsio FCoE offload driver submission (sources part 1

[PATCH 8/8] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates).

2012-08-23 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4, and the resulting changes to the cxgb4 files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +- drivers/net/ethernet/chelsio/cxgb4