Re: [PATCH] snic: switch to pci_irq_alloc_vectors

Hi Martin, Thanks for the changes. Looks good. Verified. Acked-by: Narsimhulu Musini Thanks simha On 07/02/17 5:47 am, "Martin K. Petersen" wrote: >> "Christoph" == Christoph Hellwig writes: > >Narsimhulu, > >Please test

Re: [PATCH] snic: Return error code on memory allocation failure

On 21/12/16 7:15 pm, "Burak Ok" wrote: >If a call to mempool_create_slab_pool() in snic_probe() returns NULL, >return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails >if >it cannot allocate memory. > >https://bugzilla.kernel.org/show_bug.cgi?id=189061 >

Re: [PATCH] snic: correctly check for array overrun on overly long version number

On 26/02/16 4:28 am, "Colin King" wrote: >From: Colin Ian King > >The snic version number is expected to be 4 decimals in the form like >a netmask string with each number stored in an element in array v. >However, there is an off-by-one check

Re: [PATCH 1/1] scsi/snic: fixing the error print

On 25/06/15 3:22 pm, Maninder Singh maninder...@samsung.com wrote: Currently SNIC_HOST_ERR is called in both cases whether snic_disc_start returns zero or non-zero. From the code it looks like it has to print only if snic_disc_start return non-zero value, So calling SNIC_HOST_ERR only for

Re: [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data

Hi James, Thanks for fixing the errors. the check patch that I used didn¹t list them as error, probably a lower version. Thank you very much for mentoring. Thanks Narsimhulu On 13/06/15 9:47 pm, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2015-05-29 at 01:04

Re: [PATCH v7 8/9] snic:Add event tracing to capture IO events.

Hi James, Thanks for fixing the errors. Thank you very much for mentoring and help. Thanks Narsimhulu On 13/06/15 9:50 pm, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2015-05-29 at 01:04 -0700, Narsimhulu Musini wrote: +#define SNIC_TRC(_hno, _tag, d1, d2, d3, d4,

Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Hi Johannes, Thank you for reviewing the patches. I will incorporate your comments in next patch submittal. On 28/05/15 7:12 pm, Johannes Thumshirn jthumsh...@suse.de wrote: On Thu, May 28, 2015 at 09:49:08AM +, Narsimhulu Musini (nmusini) wrote: Hi Boaz, Sure, I

Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Hi James, Thank you for reviewing the patches. Sure, I will incorporate your comments and suggestions in next patch submittal. On 28/05/15 7:25 pm, James Bottomley james.bottom...@hansenpartnership.com wrote: In general, patch is much better: it passes all the static checker tests for

Re: [PATCH v6 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Hi Boaz, Thank you for reviewing patch. Please find responses inline. On 27/05/15 2:47 pm, Boaz Harrosh b...@plexistor.com wrote: On 05/27/2015 10:19 AM, Narsimhulu Musini wrote: Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini

Re: [PATCH v4 4/9] snic:Add snic target discovery

Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 13/04/15 7:59 pm, Hannes Reinecke h...@suse.de wrote: On 04/13/2015 07:25 AM, Narsimhulu Musini (nmusini) wrote: Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 09/04/15 6

Re: [PATCH v4 4/9] snic:Add snic target discovery

Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 09/04/15 6:29 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_disc.h contains snic target structure definition.

Re: [PATCH v4 5/9] snic:add SCSI handling, AEN, and fwreset handling

Hi Hannes, Thank you for reviewing patches. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 09/04/15 6:46 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu

Re: [PATCH v4 6/9] snic:Add low level queuing interfaces

Hi Hannes, Thank you for reviewing patches. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 09/04/15 6:53 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, please find my comment at the bottom. On 04/09/2015 01:49 PM, Narsimhulu

Re: [PATCH v2 6/9] snic:Add low level queuing interfaces

Hi Hannes, Thank you for reviewing patches. Please find responses inline. On 07/04/15 12:08 pm, Hannes Reinecke h...@suse.de wrote: On 04/02/2015 10:13 AM, Narsimhulu Musini (nmusini) wrote: Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate

Re: [PATCH v3 1/9] snic: snic module infrastructure

Hi Christoph, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 02/04/15 2:51 pm, Christoph Hellwig h...@infradead.org wrote: +/* + * Usage of the scsi_cmnd scratchpad. + * These fields are locked by

Re: [PATCH v2 2/9] snic:Add interrupt, resource firmware interfaces

Hi Hannes, Thank you for reviewing patches. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 07/04/15 11:57 am, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, On 04/02/2015 09:48 AM, Narsimhulu Musini (nmusini) wrote: Hi Hannes

Re: [PATCH v2 3/9] snic:Add meta request, handling of meta requests.

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 25/03/15 4:02 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: snic_io.h contains

Re: [PATCH v2 5/9] snic:add SCSI handling, AEN, and fwreset handling

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 25/03/15 4:31 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: snic_scsi.c

Re: [PATCH v2 2/9] snic:Add interrupt, resource firmware interfaces

Hi Hannes, Thank you for reviewing patches. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 25/03/15 3:48 pm, Hannes Reinecke h...@suse.de wrote: On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: snic_fwint.h contains firmware

Re: [PATCH v2 6/9] snic:Add low level queuing interfaces

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 25/03/15 4:43 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: These files contain

Re: [PATCH v2 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 25/03/15 4:46 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, On 03/11/2015 06:01 PM, Narsimhulu Musini wrote: Kconfig for kbuild

Re: [PATCH 4/9] snic:Add snic target discovery

Hi Hannes, Thank you for reviewing the patch. Thanks Narsimhulu On 02/03/15 6:29 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and

Re: [PATCH 7/9] snic:Add sysfs entries to list stats and trace data

Hi Hannes, Thank you for reviewing the patch. Thanks Narsimhulu On 02/03/15 7:03 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup

Re: [PATCH 6/9] snic:Add low level queuing interfaces

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate your comments and suggestions in next patch submittal. On 02/03/15 7:02 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: These files contain low level

Re: [PATCH 5/9] snic:add SCSI handling, AEN, and fwreset handling

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 02/03/15 6:56 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, please find comments inline. On 02/10/2015 05:43 PM, Narsimhulu

Re: [PATCH 8/9] snic:Add event tracing to capture IO events.

Hi Hannes, Thank you for reviewing the patch. Please find responses inline. On 02/03/15 7:04 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing

Re: [PATCH 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

Hi Hannes, Thanks for reviewing the patch. Please find responses inline. I will incorporate the changes in next patch submittal. On 02/03/15 7:05 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: Kconfig for kbuild Makefile to build snic module

Re: [PATCH 1/9] snic: snic module infrastructure

Hi Hannes, Thank you for reviewing patches. Please find responses inline. I will incorporate the comments and suggestions in next patch submittal. On 02/03/15 6:09 pm, Hannes Reinecke h...@suse.de wrote: Hi Narsimhulu, please find comments inline. On 02/10/2015 05:43 PM, Narsimhulu Musini

Re: [PATCH 3/9] snic:Add meta request, handling of meta requests.

Hi Hannes, Thank you for reviewing the patch. On 02/03/15 6:26 pm, Hannes Reinecke h...@suse.de wrote: On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request

Re: [PATCH v2 1/9] snic: snic module infrastructure

Hi Julian Calby, Sure, thanks. Thanks Narsimhulu On 12/03/15 7:13 am, Julian Calaby julian.cal...@gmail.com wrote: Hi simha, On Thu, Mar 12, 2015 at 12:37 PM, Narsimhulu Musini (nmusini) nmus...@cisco.com wrote: Hi, Thanks for pointing the change log location. Do you suggest