Re: Observing Softlockup's while running heavy IOs

2016-09-12 Thread Neil Horman
On Mon, Sep 12, 2016 at 01:48:39PM +0530, Sreekanth Reddy wrote: > On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman <nhor...@tuxdriver.com> wrote: > > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: > >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman <n

Re: Observing Softlockup's while running heavy IOs

2016-09-08 Thread Neil Horman
On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: > On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman <nhor...@tuxdriver.com> wrote: > > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: > >> On Tue, Sep 6, 2016 at 8:36 PM, Neil Horman <n

Re: Observing Softlockup's while running heavy IOs

2016-09-07 Thread Neil Horman
On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: > On Tue, Sep 6, 2016 at 8:36 PM, Neil Horman <nhor...@tuxdriver.com> wrote: > > On Tue, Sep 06, 2016 at 04:52:37PM +0530, Sreekanth Reddy wrote: > >> On Fri, Sep 2, 2016 at 4:34 AM, Bart Van Assche > >

Re: Observing Softlockup's while running heavy IOs

2016-09-06 Thread Neil Horman
On Tue, Sep 06, 2016 at 04:52:37PM +0530, Sreekanth Reddy wrote: > On Fri, Sep 2, 2016 at 4:34 AM, Bart Van Assche > wrote: > > On 09/01/2016 03:31 AM, Sreekanth Reddy wrote: > >> > >> I reduced the ISR workload by one third in-order to reduce the time > >> that is

Re: [Open-FCoE] [PATCH] fcoe: fix reset of fip selection time.

2016-02-29 Thread Neil Horman
ive with sub FCOE_CTLR_START_DELAY > periodicity. > > Tested-by: Narendra K <narendr...@dell.com> > Acked-by: Neil Horman <nhor...@tuxdriver.com> > Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> > Acked-by: Vasu Dev <vasu@intel.com> > Signed-off-by: U

[PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-23 Thread Neil Horman
work_struct might be active when the housing fc_rport struct gets freed. Ensure that we cancel it prior to freeing the rport Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: James E.J. Bottomley jbottom...@parallels.com CC: Christoph Hellwig h...@infradead.org CC: linux-scsi@vger.kernel.org CC

[PATCH] bnx2fc: Improve stats update mechanism

2014-06-23 Thread Neil Horman
a per-cpu lookup, since we're certain not to get rescheduled. Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: James E.J. Bottomley jbottom...@parallels.com CC: Christoph Hellwig h...@infradead.org CC: linux-scsi@vger.kernel.org CC: Robert Love robert.w.l...@intel.com CC: Vasu Dev vasu

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-16 Thread Neil Horman
On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: debugfs caught this: WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0() ODEBUG: free active (active state 0) object type: work_struct hint: fc_scsi_scan_rport+0x0

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-10 Thread Neil Horman
On Tue, Jun 10, 2014 at 04:38:41AM -0700, Christoph Hellwig wrote: On Mon, Jun 09, 2014 at 03:16:37PM -0400, Neil Horman wrote: Given fcoe is quite mature now and its patches volume is very low, so getting its kernel patches directly to scsi subsystem should work fine and should be okay

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-09 Thread Neil Horman
On Mon, Jun 09, 2014 at 11:09:43AM -0700, Vasu Dev wrote: On Fri, 2014-06-06 at 16:54 -0400, Neil Horman wrote: On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: debugfs caught this: WARNING: at lib/debugobjects.c:260

Re: [Open-FCoE] [PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-06-06 Thread Neil Horman
On Mon, Jun 02, 2014 at 04:22:50PM -0700, Vasu Dev wrote: On Fri, 2014-05-30 at 10:59 -0400, Neil Horman wrote: debugfs caught this: WARNING: at lib/debugobjects.c:260 debug_print_object+0x83/0xa0() ODEBUG: free active (active state 0) object type: work_struct hint: fc_scsi_scan_rport+0x0

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-06-03 Thread Neil Horman
On Sat, May 31, 2014 at 08:37:57AM -0400, Neil Horman wrote: On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote: On May 30, 2014, at 7:48 PM, Neil Horman nhor...@tuxdriver.com wrote: On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote: Thanks for fixing

[PATCH] fc: ensure scan_work isn't active when freeing fc_rport

2014-05-30 Thread Neil Horman
work_struct might be active when the housing fc_rport struct gets freed. Ensure that we cancel it prior to freeing the rport Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: linux-scsi@vger.kernel.org CC: Robert Love robert.w.l...@intel.com CC: Vasu Dev vasu@intel.com --- drivers/scsi

[PATCH] bnx2fc: Improve stats update mechanism

2014-05-30 Thread Neil Horman
a per-cpu lookup, since we're certain not to get rescheduled. Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: linux-scsi@vger.kernel.org CC: Robert Love robert.w.l...@intel.com CC: Vasu Dev vasu@intel.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 16 1 file changed, 4

Re: [PATCH 4/8] libfc: Remove extra space in fc_exch_timer_cancel definition

2013-07-09 Thread Neil Horman
On Tue, Jul 09, 2013 at 12:47:26PM -0700, Robert Love wrote: Simply remove an extra space that violates coding style. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/libfc

Re: [PATCH 6/8] libfcoe: Fix meaningless log statement

2013-07-09 Thread Neil Horman
be logged if the code reaches this point. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/fcoe/fcoe_transport.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [PATCH 5/8] libfc: Differentiate echange timer cancellation debug statements

2013-07-09 Thread Neil Horman
...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/libfc/fc_exch.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index e98ea6a..5879929 100644

[PATCH] libcxgbi: supress warning when we request to much space from kmalloc

2013-04-23 Thread Neil Horman
-off-by: Neil Horman nhor...@tuxdriver.com Reported-by: Honggang LI ho...@redhat.com CC: James E.J. Bottomley jbottom...@parallels.com CC: linux-ker...@vger.kernel.org --- drivers/scsi/cxgbi/libcxgbi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/libcxgbi.h

Re: [PATCH v2] libfcoe: Save some memory and optimize name lookups

2012-12-17 Thread Neil Horman
as this patch makes them to be. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/fcoe/fcoe_sysfs.c | 44 +++- 1 file changed, 16 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/fcoe

Re: [Open-FCoE] [RFC PATCH v4 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

2012-10-10 Thread Neil Horman
Thanks, for the series Acked-by: Neil Horman nhor...@tuxdriver.com @Mark: Initial patch now optimizes enum-to-string memory usage and string retreival -- v3: This series applies to the v3.6 kernel. @Bart: Fixed bus_create_file - bus_attrs Removed sscanf with non

Re: Request for improved commit tracking between fcoe and scsi trees

2012-10-08 Thread Neil Horman
On Sun, Oct 07, 2012 at 11:59:29AM +0100, James Bottomley wrote: On Wed, 2012-10-03 at 15:23 -0400, Neil Horman wrote: James, Robert- I've been doing lots of backports of FCoE code to the RHEL tree these last few months, and I've noticed something fairly irritating, and I

Re: [Open-FCoE] [RFC PATCH v3 2/4] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

2012-10-08 Thread Neil Horman
On Fri, Oct 05, 2012 at 09:54:32AM -0700, Robert Love wrote: This patch does a few things. 1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces. These interfaces take an ifname and will either create an FCoE Controller or destroy an FCoE Controller depending on which file is

Re: [Open-FCoE] [PATCH] scsi_transport_fc: Add sysfs entry for HBA API management library

2012-10-04 Thread Neil Horman
On Thu, Oct 04, 2012 at 09:31:08PM +, Love, Robert W wrote: On 10/4/2012 12:08 AM, Hannes Reinecke wrote: On 10/03/2012 10:12 PM, Robert Love wrote: The user space HBA API vendor libraries need to know which HBA/CNAs hosts to manage. Currently, libhbalinux is used to manage a few