Re: [PATCH 3/3] scsi: nsp32: rename LED_* macros to EXT_PORT_LED_*

2019-07-29 Thread Pavel Machek
ros to EXT_PORT_LED_* in nsp32 driver. > > Cc: Frank Steiner > Cc: Jacek Anaszewski Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v2 0/2] sd: Rely on the driver core for asynchronous probing

2019-05-14 Thread Pavel Machek
Hi! > > This patch series makes the sd driver rely on the driver core for > > asynchronous probing. Although it's probably too late to submit this > > patch series to Linus during the v5.2 merge window, I want to make > > these patches available for review now. > > Applied to 5.3/scsi-queue (by h

Re: [PATCH 0/2] Revert the patches that rework sd probing

2019-04-29 Thread Pavel Machek
t this patch and > also a patch that depends on it. Thank you. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 16:40:11, David Woodhouse wrote: > On Mon, 2017-05-08 at 13:50 +0200, Boris Brezillon wrote: > > On Mon, 08 May 2017 11:13:10 +0100 > > David Woodhouse wrote: > > > > > > > > On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > > > > > > > > You're forgetting that the SSD

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 13:43:03, Tejun Heo wrote: > Hello, > > On Mon, May 08, 2017 at 06:43:22PM +0200, Pavel Machek wrote: > > What I was trying to point out was that storage people try to treat > > SSDs as HDDs... and SSDs are very different. Harddrives mostly survive > >

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 13:50:05, Boris Brezillon wrote: > On Mon, 08 May 2017 11:13:10 +0100 > David Woodhouse wrote: > > > On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > > > You're forgetting that the SSD itself (this thread is about SSDs) also has > > > a major software component which is

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
Hi! > > 'clean marker' is a good idea... empty pages have plenty of space. > > Well... you lose that space permanently. Although I suppose you could > do things differently and erase a block immediately prior to using it. > But in that case why ever write the cleanmarker? Just maintain a set of >

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 10:34:08, David Woodhouse wrote: > On Mon, 2017-05-08 at 11:28 +0200, Pavel Machek wrote: > > > > Are you sure you have it right in JFFS2? Do you journal block erases? > > Apparently, that was pretty much non-issue on older flashes. > > It isn&#x

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 08:21:34, David Woodhouse wrote: > On Sun, 2017-05-07 at 22:40 +0200, Pavel Machek wrote: > > > > NOTE: unclean SSD power-offs are dangerous and may brick the device in > > > > the worst case, or otherwise harm it (reduce longevity, damage flash >

Re: Race to power off harming SATA SSDs

2017-05-07 Thread Pavel Machek
Hi! > > However, *IN PRACTICE*, SATA STANDBY IMMEDIATE command completion > > [often?] only indicates that the device is now switching to the target > > power management state, not that it has reached the target state. Any > > further device status inquires would return that it is in STANDBY mode

Re: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-09-04 Thread Pavel Machek
On Sun 2016-09-04 11:35:33, Winkler, Tomas wrote: > > > On Thu, Sep 01, 2016 at 08:05:26PM +, Winkler, Tomas wrote: > > > > > > > > > > > On Sun, Aug 07, 2016 at 09:44:03AM +, Winkler, Tomas wrote: > > > > > > > > > > > > On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > > > > > > > The u

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
Hi! On Sun 2016-08-14 18:17:39, Tom Yan wrote: > On 14 August 2016 at 18:07, Tom Yan wrote: > > On 14 August 2016 at 18:01, Pavel Machek wrote: > >> > >> Since SATA support was merged, certainly since v2.4, and from way > >> before /dev/disk/by-id exist

Re: [PATCH v5 4/8] char: rpmb: provide a user space interface

2016-08-05 Thread Pavel Machek
On Mon 2016-07-18 23:27:49, Tomas Winkler wrote: > The user space API is achieved via two synchronous IOCTL. IOCTLs? > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is performed > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD where > the whole RPMB sequence includin

Re: [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-08-05 Thread Pavel Machek
Hi! > Few storage technologies such is EMMC, UFS, and NVMe support RPMB > hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer, but by a > set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and > PROGRAM_KEY. > Such a par

Re: [PATCH 2/8] char: rpmb: add sysfs-class ABI documentation

2016-04-24 Thread Pavel Machek
On Sun 2016-04-03 12:42:46, Tomas Winkler wrote: > Signed-off-by: Tomas Winkler > --- > Documentation/ABI/testing/sysfs-class-rpmb | 15 +++ > MAINTAINERS| 1 + > 2 files changed, 16 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-c

Re: sequential I/O on SSD disk varies from 20 to 300 MBytes/s every week

2015-02-25 Thread Pavel Machek
Hi! > During the testing period of about 5 months I have concluded: > > 1) There are 3 identical Fujitsu RX200 S6 test servers which all show the > same problem, but I also reproduced it on some Sun Fire and Dell server. > > 2) The problem happens with both HW RAID (MegaRAID SAS 2108) and when d

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-30 Thread Pavel Machek
On Mon 2014-09-22 13:23:54, Dmitry Torokhov wrote: > On Monday, September 22, 2014 09:49:06 PM Pavel Machek wrote: > > On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote: > > > On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote: > > > > Yes, but we mo

Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-22 Thread Pavel Machek
On Thu 2014-09-11 13:23:54, Dmitry Torokhov wrote: > On Thu, Sep 11, 2014 at 12:59:25PM -0700, James Bottomley wrote: > > > > On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote: > > > On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote: > > > > On Wed, 2014-09-10 at 07:41 +0900,

Re: [PATCH 1/15] block copy: initial XCOPY offload support

2014-08-04 Thread Pavel Machek
On Tue 2014-07-15 15:34:47, Mikulas Patocka wrote: > This is Martin Petersen's xcopy patch > (https://git.kernel.org/cgit/linux/kernel/git/mkp/linux.git/commit/?h=xcopy&id=0bdeed274e16b3038a851552188512071974eea8) > with some bug fixes, ported to the current kernel. > > This patch makes it possibl

Re: [PATCH] enclosure: add support for enclosure services

2008-02-19 Thread Pavel Machek
On Wed 2008-02-13 09:45:02, Kristen Carlson Accardi wrote: > On Tue, 12 Feb 2008 13:28:15 -0600 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: > > > I understand what you are trying to do - I guess I just doubt the > > > value y

Re: SCSI power management for AHCI

2008-01-19 Thread Pavel Machek
On Wed 2008-01-16 10:21:35, Alan Stern wrote: > On Tue, 15 Jan 2008, Pavel Machek wrote: > > > Hi! > > > > This is my first attempt at ahci autosuspend. It is _very_ hacky at > > this moment, I'll seriously need to clean it up. But it seems to work > > he

SCSI power management for AHCI

2008-01-15 Thread Pavel Machek
Hi! This is my first attempt at ahci autosuspend. It is _very_ hacky at this moment, I'll seriously need to clean it up. But it seems to work here. It includes Alan Stern's patches. I guess I could/should produce separate version. P

Re: [linux-pm] Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Pavel Machek
> > > When all the devices under a host are suspended, the LLD is informed > > > (via a new "autosuspend" method in the host template) so that it can > > > > That is most certainly a mistake. > > Why? > > > Is there a good reason to not modify > > to extend suspend() to take an extra argument

Small cleanups for scsi_host.h

2007-12-17 Thread Pavel Machek
Small cleanups in scsi_host.h. Few #defines make me wonder if their description is still up to date..? Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> --- commit f37d85c2619d02ca383962e588417b9eacae366d tree 4f2b2e93717c2f434e91ba32115a3801212e5e3d parent 9918d25acff9540d86ccd93f6e8e536f1c

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-20 Thread Pavel Machek
Hi! > I suppose I should just configure suspending to a file instead of a > swap partition, but I've just historically trusted suspend/resume to a > swap partition much more than to a file. Or maybe I should hack in a > sysctl to prevent any swapping even though the swap partition is > configured

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-20 Thread Pavel Machek
Hi! > > Would an oom-kill-someone-now sysrq be of help, I wonder? > > *shrug* It might. I was a letting it run hoping it would complete itself > when sysrq-f, IIRC. > it locked solid. (The keyboard LEDs weren't flashing, so I don't _think_ it > paniced. I was in X so I wouldn't have seen

Re: kdump detection in SCSI drivers

2007-10-02 Thread Pavel Machek
Hi! > How do we "know" when little memory is available? Kernel already scales its hash tables according to total RAM available, perhaps you can use similar mechanism? > Other suggestion which came about was to parse the kernel command line > and look for "elfcorehdr=". Is this ok? Is kernel comm

Re: kdump detection in SCSI drivers

2007-09-20 Thread Pavel Machek
> Hi, > > Is there a standard way for drivers (RAID) to detect if the current > kernel is running in kdump mode? We would like to adjust driver behavior > dynamically when kdump is active by scaling down resources. Perhaps you should be automatically using little resources when little memory is a

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-11 Thread Pavel Machek
Hi! > This patch will modify the scsi subsystem to allow > users to set a power management policy for the link. > > The scsi subsystem will create a new sysfs file for each > host in /sys/class/scsi_host called "link_power_management_policy". > This file can have 3 possible values: > > Value

Re: [PATCH 1/4] scsi: megaraid_sas -- add hibernation support

2007-07-04 Thread Pavel Machek
Hi! > The megaraid_sas driver doesn't support the hibernation, the > suspend/resume routine implemented to support the hibernation. > > Signed-off-by: Bo Yang <[EMAIL PROTECTED]> I'm glad to see first scsi driver to have hibernation support :-). Appart for whitespace, patch looks ok to me.

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! > >> I'm not sure about this. We need better PM framework to support > >> powersaving in other controllers and some ahcis don't save much > >> when only link power management is used, > > > > do you have data to support this? > > Yeah, it was some Lenovo notebook. Pavel is more familiar w

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! > >Yeah, it was some Lenovo notebook. Pavel is more > >familiar with the > >hardware. Pavel, what was the notebook which didn't > >save much power > >with standard SATA power save but needed port to be > >completely turned off? > > Pavel, if you have time, could you measure this with >

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Pavel Machek
Hi! > >> I'm not sure about this. We need better PM framework to support > >> powersaving in other controllers and some ahcis don't save much > >> when only link power management is used, > > > > do you have data to support this? > > Yeah, it was some Lenovo notebook. Pavel is more familiar w

Re: [GIT PATCH] scsi updates for 2.6.12-rc2

2005-04-15 Thread Pavel Machek
Hi! > > This is a small set of bugfixes for 2.6.12-rc2 ... you asked me to try > > git, so I did (I actually updated my bk backport script simply to export > > from a BK tree to a git tree). For the time being, I plan to keep the > > scsi changes in BK, but I'll export them for you to try merging

Re: [GIT PATCH] scsi updates for 2.6.12-rc2

2005-04-15 Thread Pavel Machek
Hi! > This is a small set of bugfixes for 2.6.12-rc2 ... you asked me to try > git, so I did (I actually updated my bk backport script simply to export > from a BK tree to a git tree). For the time being, I plan to keep the > scsi changes in BK, but I'll export them for you to try merging > > Th