ib_flush_fmr_pool() is called,
and other FMR users are not affected. Simply move used entries
from the clean list onto the dirty list before letting the
cleanup thread do its job.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/infiniband/core/fmr_pool.c | 17 ++
used FMR
entries also to be purged. During that process, another thread
can see that there are no free FMRs and fail, even though
there should always have been enough available.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/infiniband/core/fmr_pool.c | 21 ++
[EMAIL PROTECTED] wrote on Mon, 25 Feb 2008 15:02 -0800:
> Ugh.
[pw wrote:]
> > Looking at the FMR dirty list unmapping code in
> > ib_fmr_batch_release(), there is a section that pulls all the dirty
> > entries onto a list that it will later unmap and put back on the
> > free list.
>
> > But
[EMAIL PROTECTED] wrote on Mon, 18 Feb 2008 17:39 +0200:
> On Tue, Feb 12 2008 at 22:17 +0200, Pete Wyckoff <[EMAIL PROTECTED]> wrote:
> > From: Pete Wyckoff <[EMAIL PROTECTED]>
> > Subject: [PATCH] iscsi iser: varlen
> >
> > Handle variable-length CDB
: increase sg_tablesize
-- Pete
>From 255e73b67ec1458af18395981fddebdc958e8fe9 Mon Sep 17 00:00:00 2001
From: Pete Wyckoff <[EMAIL PROTECTED]>
Date: Thu, 14 Feb 2008 16:09:27 -0500
Subject: [PATCH] iscsi iser: remove DMA alignment restriction
iscsi_iser does not re
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:57 -0600:
> On Tue, 2008-02-12 at 16:46 -0500, Pete Wyckoff wrote:
> > [EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:10 -0600:
> > > On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote:
> > > > iscsi_iser does not have
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 15:10 -0600:
> On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote:
> > iscsi_iser does not have any hardware DMA restrictions. Add a
> > slave_configure function to remove any DMA alignment restriction,
> > allowing the
iser has no limit on max sectors. This lets iscsi iser support
large pass through commands just like iscsi TCP.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/d
Increase FMR limits from 512 kB to 1 MB. This matches the limit
used by SRP which also uses FMRs for memory mapping. Also
correct a bug where the sg_tablesize was 1 smaller than what was
allocated, by folding the "+ 1" used everywhere into the
definition of the constant.
Signed-of
: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c
b/drivers/infiniband/ulp/iser/iscsi_iser.c
index be1b9fb..1b272a6 100644
--- a/drivers/infi
These three patches remove various block device limits to
the iSER iSCSI transport. I guess in theory they should go
in via the IB tree, although ACKs from the iSCSI side would
be welcome.
The first two look quite similar to some TCP iSCSI patches
that Mike applied a while back:
d1d81c01f4bd
ng a mapcount bug via bad_page().
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index 3337125..bba7154 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -295,8 +295,10 @@
could use more testing. Note that this does
> rely on the 3 patches quoted above.
Similar, for varlen support to iSER. Probably apply this one before
the bidi one I just sent.
-- Pete
From: Pete Wyckoff <[EMAIL PROTECTED]>
Subject: [PATCH] iscsi iser: varlen
Hand
could use more testing. Note that this does
rely on the 3 patches quoted above.
-- Pete
From: Pete Wyckoff <[EMAIL PROTECTED]>
Support bidirectional SCSI commands in iSCSI iSER. The handling of
data buffers for each direction was already mostly separated. It was
necessary t
[EMAIL PROTECTED] wrote on Mon, 11 Feb 2008 18:05 +0200:
> You are most probably right I will investigate what happened. It looks
> like I went back to some old version right? or a merge fallout
> Thanks for reviewing.
>
> Please also test latest head-of-line code if possible + iscsi patches
> + l
[EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 22:29 +0200:
> iscsi bidi support at the generic libiscsi level
> - prepare the additional bidi_read rlength header.
> - access the right scsi_in() and/or scsi_out() side of things.
> also for resid.
> - Handle BIDI underflow overflow from tar
y_sense() because
> I did not want the extra copy. Pete will want to use a 260
> bytes buffer here.
>
> Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
> Need-help-from: Pete Wyckoff <[EMAIL PROTECTED]>
FYI, I never use scsi_tgt. Only just pure userspace on the target
[EMAIL PROTECTED] wrote on Wed, 30 Jan 2008 10:34 -0600:
> On Wed, 2008-01-30 at 09:38 +0100, Bart Van Assche wrote:
> > On Jan 30, 2008 12:32 AM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> > >
> > > iSER has parameters to limit the maximum size of RDMA (it needs to
> > > repeat RDMA with a poor
[EMAIL PROTECTED] wrote on Fri, 25 Jan 2008 20:05 -0600:
> On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote:
> > This is against the scsi-bidi tree.
> >
> > We need to use the cmd_type of a leading request for scsi_init_sgtable
> > to set up scsi_data_buffer:length of a bidi request proper
[EMAIL PROTECTED] wrote on Thu, 17 Jan 2008 19:05 +0900:
> On Thu, 17 Jan 2008 12:48:28 +0300
> Vladislav Bolkhovitin <[EMAIL PROTECTED]> wrote:
>
> > FUJITA Tomonori wrote:
> > > On Thu, 17 Jan 2008 10:27:08 +0100
> > > "Bart Van Assche" <[EMAIL PROTECTED]> wrote:
> > >
> > >
> > >>Hello,
> > >
[EMAIL PROTECTED] wrote on Fri, 11 Jan 2008 19:16 -0500:
> James Bottomley wrote:
>> On Thu, 2008-01-10 at 16:46 -0500, Pete Wyckoff wrote:
>>> [EMAIL PROTECTED] wrote on Thu, 10 Jan 2008 14:55 -0600:
>>>> On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote:
>&g
[EMAIL PROTECTED] wrote on Thu, 10 Jan 2008 14:55 -0600:
> On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote:
> > [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900:
> > > On Tue, 8 Jan 2008 17:09:18 -0500
> > > Pete Wyckoff <[EMAIL PROTECTED]> wrote:
&
[EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900:
> On Tue, 8 Jan 2008 17:09:18 -0500
> Pete Wyckoff <[EMAIL PROTECTED]> wrote:
> > I took another look at the compat approach, to see if it is feasible
> > to keep the compat handling somewhere else, w
[EMAIL PROTECTED] wrote on Sat, 05 Jan 2008 14:01 +0900:
> From: Deepak Colluru <[EMAIL PROTECTED]>
> Subject: [PATCH] bsg : Add support for io vectors in bsg
> Date: Fri, 4 Jan 2008 21:47:34 +0530 (IST)
>
> > From: Deepak Colluru <[EMAIL PROTECTED]>
> >
> > Add support for io vectors in bsg.
> >
[EMAIL PROTECTED] wrote on Tue, 01 Jan 2008 21:24 -0600:
>
> On Tue, 2008-01-01 at 18:10 -0800, Andrew Morton wrote:
> > On Tue, 1 Jan 2008 14:55:45 -0800 (PST) [EMAIL PROTECTED] wrote:
> >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9674
> > >
> > >Summary: Oops during rmmod'i
[EMAIL PROTECTED] wrote on Tue, 01 Jan 2008 10:27 -0600:
> On Tue, 2008-01-01 at 11:08 -0500, Pete Wyckoff wrote:
> > [EMAIL PROTECTED] wrote on Mon, 31 Dec 2007 16:43 -0600:
> > > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4
> > > bytes
0);
But they end up doing copies due to the way that queue_dma_alignment()
returns 511 in this case.
-- Pete
---
>From 90ee6d61ad71a024815eee2b416edb40c6b01256 Mon Sep 17 00:00:00 2001
From: Pete Wyckoff <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 10:23:02 -0500
Subjec
[Resend, date was in ancient history.]
From: Boaz Harrosh <[EMAIL PROTECTED]>
Once varlen cdbs are supported by the block and scsi-ml layers
we can apply this patch to support extended CDBs in iscsi.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Pete Wyc
[Resend, date was in ancient history.]
Accept variable length SCSI commands through BSG.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c | 34 +-
1 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
dditional bidi_read rlength header.
- access the right scsi_in() and/or scsi_out() side of things.
also for resid.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c | 14 ---
drivers/sc
Fixes for bsg to handle bidirectional commands. The next_rq part
of a bidi command must be marked REQ_TYPE_BLOCK_PC for scsi_init_sgtable.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/bsg.c b
Mark iscsi_tcp as being capable of bidirectional transfers. Perhaps
instead we could remove the check in bsg, as that is the only entry
to SCSI that bothers to check the flag.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c |7 +++
1 files chan
Accept variable length SCSI commands through BSG.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c | 34 +-
1 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index 8e181ab..0d9364d 100644
--- a/block
I spent the last couple of days rebasing my working set of kernel
patches from 2.6.22-rc5 to 2.6.24-rc6. I want to use the BSG
interface from userspace to submit variable-length bidirectional
SCSI commands to targets via iSCSI TCP.
Many thanks to all the work with scsi data accessors and iscsi th
From: Boaz Harrosh <[EMAIL PROTECTED]>
Once varlen cdbs are supported by the block and scsi-ml layers
we can apply this patch to support extended CDBs in iscsi.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
driver
Mark queue_flags that bidirectional is acceptable for iscsi_tcp, as
BSG will check to make sure this bit is set.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/iscsi_t
Accept variable length SCSI commands through BSG.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index eb0aaf4..c72b4f9 100644
--- a/block/bsg.c
+++ b
Set cmd_type on rq->next_rq to BLOCK_PC so that scsi_init_sgtable
knows to look at req->data_len rather than nr_sectors.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/bsg.c b/block
There are three patches here to enable using BSG to send SCSI
commands across iscsi TCP that are bidirectional and/or use
variable length CDBs. They sit on top of 2.6.23-rc2 plus Mike's
iscsi git plus the 12 core patches that Boaz has for bidirectional
support.
They apply to stock 2.6.23-rc2 but
We are releasing code to add support for iSCSI Extensions for RDMA
(iSER) to the existing STGT user space SCSI target. It uses
OpenFabrics libraries and kernel drivers to act as a SCSI target
over RDMA-capable devices. The code has been tested against
the existing Linux iSER initiator over Infini
[EMAIL PROTECTED] wrote on Sat, 09 Jun 2007 00:12 +0900:
> SCSI transport-level requests such as SAS management protocol (SMP)
> skip blk_verify_command().
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
> ---
> block/bsg.c | 27 +--
> include/linux/bsg.h
Fixes to common functions added with bsg so that they compile in
a kernel that has the bidi patches.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c|6 +++---
block/scsi_ioctl.c |6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/block
[EMAIL PROTECTED] wrote on Tue, 24 Apr 2007 13:27 -0400:
> Changes required to make bsg patches work on top of bidi patches. Adds
> capability to bsg to handle bidirectional commands and extended CDBs.
Oops. This is 2/2. Apply the "compile with bidi" one first.
-- Pete
-
To uns
Changes required to make bsg patches work on top of bidi patches. Adds
capability to bsg to handle bidirectional commands and extended CDBs.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c| 106 ++--
block/ll_rw
Use the status codes from the spec, not the shifted-by-one codes
that are marked deprecated in scsi.h This makes bsg v4 status
report the same value as sg v3 status too.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
Acked-by: Douglas Gilbert <[EMAIL PROTECTED]>
---
block/bsg.c
[EMAIL PROTECTED] wrote on Tue, 20 Mar 2007 03:22 +0900:
> From: Pete Wyckoff <[EMAIL PROTECTED]>
> Subject: [PATCH v2] bsg: iovec support with compat
> Date: Mon, 19 Mar 2007 14:07:27 -0400
>
> > Adding a new bsg_write_compat would be bad. There is lots of
> > pa
ion for user pointer
and length.
Perhaps later we might change blk_rq_map_user_iov to take
sg_v4_iovec and let sgv3 convert its sg_iovec into that.
-- Pete
Support vectored IO as in SGv3. The iovec structure uses explicit
sizes to avoid the need for compat conversion.
Signed-
s having to
build an sg_iovec just to call into the existing blk_rq_map_user_iov.
Comments?
-- Pete
Support vectored IO as in SGv3. This uses the standard struct sg_iovec
(same as struct iovec) and converts if necessary for CONFIG_COMPAT.
Signed-off-by: Pete Wyckoff <[EMAIL PRO
[EMAIL PROTECTED] wrote on Sat, 17 Mar 2007 18:13 -0500:
> Pete Wyckoff wrote:
> > [EMAIL PROTECTED] wrote on Wed, 14 Mar 2007 12:18 -0400:
> >> After reviewing this post by Pete Wyckoff:
> >> http://marc.theaimsgroup.com/?l=linux-scsi&m=117278879816029&w=2
>
[EMAIL PROTECTED] wrote on Wed, 14 Mar 2007 12:18 -0400:
> After reviewing this post by Pete Wyckoff:
> http://marc.theaimsgroup.com/?l=linux-scsi&m=117278879816029&w=2
>
> I decided to update my sg v4 interface document originally
> posted 20061106 which I will now ca
Some targets can return both valid data and sense information.
Always update the request data_len from the SCSI command residual.
Callers should interpret sense data to determine what parts of the
data are valid in case of a CHECK CONDITION status.
Signed-off-by: Pete Wyckoff <[EMAIL PROTEC
Support vectored IO as in SGv3. The iovec structure uses explicit
sizes to avoid the need for compat conversion.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
My application definitely can take advantage of scatter/gather IO,
which is supported in sgv3 but not in the bsg implementat
Add a slave_configure function to iSCSI TCP to remove any DMA
alignment restriction. This permits the use of direct IO from
arbitrary addresses.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c | 11 +++
1 files changed, 11 insertions(+), 0 del
Make queue_dma_alignment return 0 if it was specifically set to
0. Set it to the default 511 to keep the old behavior when it
was not explicitly set. This permits devices with no particular
alignment restrictions to use direct IO from arbitrary addresses.
Signed-off-by: Pete Wyckoff <[EM
Use the status codes from the standard, not the shifted-by-one codes
that are marked deprecated in scsi.h. This makes bsg v4 status
report the same value as sg v3 status too.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c |2 +-
1 files changed, 1 insertions(+), 1 del
ng "sda"
entry, e.g., in /sys/class/bsg.
Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]>
---
block/bsg.c | 16 +---
drivers/scsi/scsi_scan.c |6 ++
drivers/scsi/scsi_sysfs.c |1 +
3 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/
56 matches
Mail list logo
